[edk2-devel] [edk2-platforms][PATCH v3 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-25 Thread Prabin CA
Changes since V2: - Removed author's signed-off on the patches, which is owned by another author. Changes since V1: - Corrected memory map in the DSDT file. This patch series introduce support for RD-Fremont reference design platform. This platform includes 32 CPUs, but the fixed virtual

[edk2-devel] [edk2-platforms][PATCH v4 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-25 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v4 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-01-25 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++-

[edk2-devel] [edk2-platforms][PATCH v4 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-25 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v4 3/6] Platform/Sgi: Add a PCD to specify platform variant

2024-01-25 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v4 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-25 Thread Prabin CA
From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in

[edk2-devel] [edk2-platforms][PATCH v4 1/6] Platform/Sgi: remove +nofp gcc option flag

2024-01-25 Thread Prabin CA
From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow

[edk2-devel] [edk2-platforms][PATCH v4 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-01-25 Thread Prabin CA
Changes since V3: - Removed author's signed-off on the patches, which is owned by another author. Changes since V2: - Removed the patch which introduce fno-stack-protector in the build flag. Changes since V1: - Addressed comments from Sami This patch series introduces support for two reference

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Chang, Abner via groups.io
From: Abner Chang Initial version of edk2 Redfish feature of Redfish schema ComputerSystem_1_13_0. This driver handles ComputerSystem Boot properties but not all. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 53 ++

Re: [edk2-devel] [edk2-discuss] Multi-ISA Driver Compatibility Survey

2024-01-23 Thread Laszlo Ersek
On 1/22/24 20:04, Rebecca Cran wrote: > Originally posted at > https://twitter.com/UEFIForum/status/1745518769232077208 > > The Multi-ISA Driver Compatibility Survey is at > https://docs.google.com/forms/d/e/1FAIpQLScXjwaSBgLeqB1coEDxCPxho5JWF3AMqshOTJ2wd6Tf0He4LA/viewform > > From that page: >

Re: [edk2-devel] [edk2-platforms][PATCH V4 4/4] Silicon/ARM/NeoverseN1Soc: Consume N1SdpNtFwConfigPei supplied data

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V4 3/4] Platform/ARM/N1Sdp: Enable N1SdpNtFwConfigPei PEI module for N1Sdp

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V4 2/4] Platform/ARM/N1Sdp: Add N1SdpNtFwConfigPei PEI module

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V4 1/4] Silicon/ARM/NeoverseN1Soc: Extract NT_FW_CONFIG address passed by TF-A

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/ARM/N1Sdp: Route the Debug Serial Port to IOFPGA UART1

2024-01-19 Thread Himanshu Sharma
Link to V1: [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Modify IRQ ID of Debug UART and routing to IOFPGA UART1 (groups.io) ( https://edk2.groups.io/g/devel/message/98064?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Chimanshu%2C20%2C2%2C0%2C96088965 )

Re: [edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG

2024-01-19 Thread Sami Mujawar
Hi Sahil, On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote: > > v4: > - Fixed code review comments > - Split the patch into four patches Can you add git notes for the patches in the future, please? See

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: fix wrong parameter issue

2024-01-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Friday, January 19, 2024 2:23 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] >

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: fix wrong parameter issue

2024-01-18 Thread Nickle Wang via groups.io
Third parameter of AsciiStrToUnicodeStrS is the number of character in destination buffer, not the size in byte of destination buffer. This creates failure of converting ASCII string to Unicode string in Redfish application while getting Location field in HTTP header. Signed-off-by: Nickle Wang

[edk2-devel] [edk2-platforms PATCH v3 5/7] Silicon/Marvell: Driver to publish device tree

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds driver that can provide device tree to OS if user so wishes. PCD's are used to enable this, default is not to take this action. Signed-off-by: Narinder Dhillon --- .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 259 ++

[edk2-devel] [edk2-platforms PATCH v3 7/7] Silicon/Marvell: Odyssey project description files

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds Odyssey SoC project description and flash description files. Signed-off-by: Narinder Dhillon --- Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc| 219 ++ Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf| 304 +

[edk2-devel] [edk2-platforms PATCH v3 6/7] Silicon/Marvell: Command to dump device tree

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds an EDK2 shell command to dump configuration device tree. Signed-off-by: Narinder Dhillon --- .../Marvell/Applications/DumpFdt/DumpFdt.c| 344 ++ .../Marvell/Applications/DumpFdt/DumpFdt.inf | 52 +++

[edk2-devel] [edk2-platforms PATCH v3 4/7] Silicon/Marvell: Device tree driver

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds a device tree driver that is used to read board configuration information from a device tree. Signed-off-by: Narinder Dhillon --- .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++ .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43

[edk2-devel] [edk2-platforms PATCH v3 3/7] Silicon/Marvell: Odyssey watchdog driver

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds watchdog driver for Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++ .../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++ 2 files changed, 453 insertions(+) create mode 100644

[edk2-devel] [edk2-platforms PATCH v3 0/7] Silicon/Marvell/OdysseyPkg

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon New Marvell Odyssey SoC This patchset contains only the very basic elements needed to boot to EDK2 UiApp on Marvell Odyssey SoC - ARM BL31 firmware component copies EDK2 image into memory, so it is always executing from memory - There is a SMC library to get system

[edk2-devel] [edk2-platforms PATCH v3 1/7] Silicon/Marvell: New Marvell Odyssey processor

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds helper library to initialize Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../OdysseyLib/AArch64/ArmPlatformHelper.S| 97 .../Library/OdysseyLib/OdysseyLib.c | 79 ++ .../Library/OdysseyLib/OdysseyLib.inf

[edk2-devel] [edk2-platforms PATCH v3 2/7] Silicon/Marvell: Odyssey SmcLib

2024-01-17 Thread Narinder Dhillon
From: Narinder Dhillon This patch provides SMC call needed by Odyssey to determine size of available memory. Signed-off-by: Narinder Dhillon --- Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 +++ Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 +++

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-16 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Got it and thanks. I will fix the typo, put your RB then merge this patch. Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, January 16, 2024 2:20 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE:

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Nickle Wang via groups.io
> I didn't choose ReadOnly is because at BIOS perspective as a provider, we > still > update the read only property defined in schema such as BootOptions. Thus I > thought to use ReadOnly is not quite accurate. How do you think? I see. Thanks for your explanation. Please fix the typos and keep

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Tuesday, January 16, 2024 11:18 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: > Function to remove

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Nickle Wang via groups.io
I found typos. Please see below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: >

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishFeatureUtilityLib: Add two helper functions

2024-01-15 Thread Nickle Wang via groups.io
Please see my comments below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 2/3] >

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define json_object_del

2024-01-15 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define >

Re: [edk2-devel] [edk2-platforms PATCH v2 4/8] Silicon/Marvell: Odyssey watchdog driver

2024-01-15 Thread Narinder Dhillon
alcerak > Subject: [EXT] Re: [edk2-devel] [edk2-platforms PATCH v2 4/8] > Silicon/Marvell: Odyssey watchdog driver > > External Email > > -- > +marcin.s.woj...@gmail.com > > Hi Narinder > > cz

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-15 Thread PierreGondois
Hello Prabin, Except for patches 1,3,4 where I had a remark/question, for all other patches: Reviewed-by: Pierre Gondois Also, I could not directly apply the patches you sent on the latest master branch. Indeed, the serie is on top of other patches on the branch you shared:

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-01-15 Thread PierreGondois
Hello Prabin, On 1/12/24 16:47, Prabin CA via groups.io wrote: Introducing a flag called PCIE_ENABLE, which can be set to TRUE or FALSE from the respective .dsc files to enable or disable the PCIe support. As not all reference design platforms have PCIe support enabled, this flag is introduced.

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-01-15 Thread PierreGondois
On 1/12/24 16:47, Prabin CA via groups.io wrote: From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system

Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

2024-01-12 Thread Narinder Dhillon
Hi Marcin, > -Original Message- > From: Marcin Wojtas > Sent: Friday, January 12, 2024 4:19 AM > To: devel@edk2.groups.io; Narinder Dhillon > Cc: quic_llind...@quicinc.com; marcin.s.woj...@gmail.com; Szymon Balcerak > > Subject: [EXT] Re: [edk2-devel] [edk2-p

[edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/ARM/N1Sdp: Route the Debug Serial Port to IOFPGA UART1

2024-01-12 Thread Himanshu Sharma
Update the RegisterBase and Clk for the Debug Serial Port (DBG2) to route it to the IOFPGA UART1 and make the SPCR and DBG2 Serial Ports exclusive. Signed-off-by: Himanshu Sharma --- Change-log: V2: - Reverse updating the IRQ ID for DBG2 UART. - Update the commit message.

[edk2-devel] [edk2-platforms][PATCH V2 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-01-12 Thread Prabin CA
Enable ACPI CPPC mechanism for RD-Fremont as defined by the ACPI specification. The implementation uses AMU registers accessible as Fixed-feature Hardware (FFixedHW) for monitoring the performance. Non-secure SCMI fastchannels are used to communicate with LCP to set the desired performance.

[edk2-devel] [edk2-platforms][PATCH V2 7/8] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-01-12 Thread Prabin CA
RD-Fremont platform supports two LPI states, LPI1 (Standby WFI) and LPI3 (Power-down). The cluster supports LPI2 (Power-down) state. The LPI implementation also supports combined power state for core and cluster. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH V2 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-01-12 Thread Prabin CA
Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a 16 core platform with Poseidon CPU. Each of the CPUs include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache. The platform also includes system level cache of 32MB and 8GB of RAM. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH V2 5/8] Platform/Sgi: Add initial support for RD-Fremont platform

2024-01-12 Thread Prabin CA
The RD-Fremont fixed virtual platform simulates 16 CPUs and 8GB of RAM. Add initial support for this platform by adding the required platform build configuration files. This platform has considerable differences in its memory map compared to its predecessors. So add a corresponding memory map file

[edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-01-12 Thread Prabin CA
From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system and so the FVP simulates 16 clusters. In preparation

[edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-01-12 Thread Prabin CA
Introducing a flag called PCIE_ENABLE, which can be set to TRUE or FALSE from the respective .dsc files to enable or disable the PCIe support. As not all reference design platforms have PCIe support enabled, this flag is introduced. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH V2 2/8] Platform/Sgi: Refactor system memory base and size definitions

2024-01-12 Thread Prabin CA
In preparation of adding the next generation of reference design platform that have different memory map, refactor the PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the common PCD definitions file into the various platform generation specific memory map PCD definitions file.

[edk2-devel] [edk2-platforms][PATCH V2 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-01-12 Thread Prabin CA
From: Vivek Gautam On RD-N2 and previous generation platforms, the base address was within 32-bit region. However, on upcoming platforms, the SMMUv3 base address is beyond 32-bit address region. So, update the datatype of SMMUv3 base PCD. Signed-off-by: Vivek Gautam Signed-off-by: Prabin CA

[edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-12 Thread Prabin CA
Changes since V1: - Corrected memory map in the DSDT file. This patch series introduce support for RD-Fremont reference design platform. This platform includes 32 CPUs, but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system and so the

Re: [edk2-devel] [edk2-platforms PATCH v2 0/8] Silicon/Marvell/OdysseyPkg:

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > New Marvell Odyssey SoC > > This patchset contains only the very basic elements needed to boot to > EDK2 UiApp on Marvell Odyssey SoC > - ARM BL31 firmware component

[edk2-devel] [edk2-platforms][PATCH v3 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-12 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v3 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-01-12 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7

[edk2-devel] [edk2-platforms][PATCH v3 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-12 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v3 3/6] Platform/Sgi: Add a PCD to specify platform variant

2024-01-12 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-12 Thread Prabin CA
From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in

[edk2-devel] [edk2-platforms][PATCH v3 1/6] Platform/Sgi: remove +nofp gcc option flag

2024-01-12 Thread Prabin CA
From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow

[edk2-devel] [edk2-platforms][PATCH v3 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-01-12 Thread Prabin CA
Changes since V2: - Removed the patch which introduce fno-stack-protector in the build flag Changes since V1: - Addressed comments from Sami This patch series introduces support for two reference design platforms- RD-N2-Cfg3 and RD-V2. The RD-N2-Cfg3 FVP platform is a variant of RD-N2 platform

Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch adds an EDK2 shell command to dump board configuration > device tree. > > Signed-off-by: Narinder Dhillon > --- >

Re: [edk2-devel] [edk2-platforms PATCH v2 6/8] Silicon/Marvell: Device tree driver

2024-01-12 Thread Marcin Wojtas via groups.io
pt., 12 sty 2024 o 13:00 Marcin Wojtas napisał(a): > > +marcin.s.woj...@gmail.com > > Hi Narinder, > > czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > > > From: Narinder Dhillon > > > > This patch adds a device tree driver that is used to read board > > configuration information

Re: [edk2-devel] [edk2-platforms PATCH v2 6/8] Silicon/Marvell: Device tree driver

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch adds a device tree driver that is used to read board > configuration information from a device tree. > > Signed-off-by: Narinder Dhillon > --- >

Re: [edk2-devel] [edk2-platforms PATCH v2 5/8] Silicon/Marvell: RTC driver

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > Marvell Odyssey SoC does not have RTC on chip. This patch provides a > dummy RTC driver to generate architectural protocol and help boot > Odyssey SoC. > >

Re: [edk2-devel] [edk2-platforms PATCH v2 4/8] Silicon/Marvell: Odyssey watchdog driver

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch adds watchdog driver for Odyssey SoC. To make sure - isn't this watchdog IP compatible with the ARM generic watchdog (ArmPkg/Drivers/GenericWatchdogDxe/).

Re: [edk2-devel] [edk2-platforms PATCH v2 2/8] Silicon/Marvell: Odyssey ArmPlatformLib

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 napisał(a): > > From: Narinder Dhillon > > This patch adds ArmPlatformLib for Marvell Odyssey SoC. > > Signed-off-by: Narinder Dhillon > --- > .../AArch64/ArmPlatformHelper.S | 86 >

Re: [edk2-devel] [edk2-platforms PATCH v2 1/8] Silicon/Marvell: New Marvell Odyssey processor

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 napisał(a): > > From: Narinder Dhillon > > This patch creates ArmPlatformPkg for Odyssey SoC by overriding some of > the files in original ArmPlatformPkg. Differences from standard > ArmPlatformPkg are marked with "--- MRVL

Re: [edk2-devel] [edk2-platforms PATCH v2 3/8] Silicon/Marvell: Odyssey SmcLib

2024-01-12 Thread Marcin Wojtas via groups.io
+marcin.s.woj...@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > This patch provides SMC call needed by Odyssey to determine available > memory size. > > Signed-off-by: Narinder Dhillon > --- >

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishFeatureUtilityLib: Add two helper functions

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang - Add RedfishRemoveUnchangeableProperties () to remove unchangeable Redfish properties such as @OData.id. - Add DestoryRedfishCharArray () to free Redfish string array. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.inf

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Update RedfishCsCommon.c to add a function to remove Redfish unchangeable properties. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ConverterLib/include/RedfishCsCommon.h| 20 +++ .../ConverterLib/src/RedfishCsCommon.c| 55

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define json_object_del

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/PrivateInclude/jansson.h | 1 + 1 file changed, 1 insertion(+) diff --git a/RedfishClientPkg/PrivateInclude/jansson.h b/RedfishClientPkg/PrivateInclude/jansson.h index

[edk2-devel] [edk2-platforms][PATCH] RedfishPkg/JsonLib: Add JSON delete object function

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Add JSON delete object function to remove JSON object from the given JSON paylaod. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/Include/Library/JsonLib.h | 17 + RedfishPkg/Library/JsonLib/JsonLib.c | 24

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2024-01-09 Thread Yuwei Chen
ing ; Rebecca Cran > ; Zimmer, Vincent ; Leif > Lindholm ; Andrew Fish ; > Feng, Bob C ; Yang, Yuting2 > ; Hartung, Stephen ; > Kinney, Michael D > Subject: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python > VfrCompiler implementation > > There are several adv

Re: [edk2-devel] [edk2-redfish-client][PATCH V4] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-08 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Sunday, January 07, 2024 9:49 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL] [edk2-redfish-client][PATCH V4] RedfishClientPkg: Add ETag

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-08 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Chang, Abner Sent: Sunday, January 07, 2024 9:43 PM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Nickle Wang ; Mike Maslenkin Subject: RE: [EXTERNAL] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add ETag PCD

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use

Re: [edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/Sgi: Define RD-V2 platform id values

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu

Re: [edk2-devel] [edk2-platforms][PATCH v2 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/7] Platform/Sgi: Add a PCD to specify platform variant

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Platform/Sgi: remove +nofp gcc option flag

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/7] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds

2024-01-08 Thread levi.yun
Hi. Parabin On 05/01/2024 15:38, Prabin CA via groups.io wrote: Add the no-stack-protector compiler flag to allow StandaloneMM builds on both AArch64 and x86 host. Without this flag, the link stage fails with the following errors on multiple files when built with gcc (Ubuntu

[edk2-devel] [edk2-redfish-client][PATCH V4] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-07 Thread Chang, Abner via groups.io
From: Abner Chang Add PCD to disable ETag capability for the case Redfish service doesn't support ETag. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishClientPkg/RedfishClientPkg.dec | 3 + .../RedfishFeatureUtilityLib.inf

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks for catching that, Igor. Will send out V4 for this change. Abner > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, January 4, 2024 10:59 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Nickle Wang ; Mike Maslenkin > > Subject:

[edk2-devel] [edk2-platforms][PATCH v2 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-05 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/Sgi: Define RD-V2 platform id values

2024-01-05 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7

[edk2-devel] [edk2-platforms][PATCH v2 5/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-05 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v2 4/7] Platform/Sgi: Add a PCD to specify platform variant

2024-01-05 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v2 3/7] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-05 Thread Prabin CA
From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in

[edk2-devel] [edk2-platforms][PATCH v2 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds

2024-01-05 Thread Prabin CA
Add the no-stack-protector compiler flag to allow StandaloneMM builds on both AArch64 and x86 host. Without this flag, the link stage fails with the following errors on multiple files when built with gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0: undefined reference to `__stack_chk_guard' undefined

[edk2-devel] [edk2-platforms][PATCH v2 1/7] Platform/Sgi: remove +nofp gcc option flag

2024-01-05 Thread Prabin CA
From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow

[edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-01-05 Thread Prabin CA
Changes since V1: - Addressed comments from Sami This patch series introduces support for two reference design platforms- RD-N2-Cfg3 and RD-V2. The RD-N2-Cfg3 FVP platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. It is based on the Neoverse N2 CPUs and includes

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-05 Thread Mike Maslenkin
tion? > > Thanks > Abner > > > -Original Message- > > From: Mike Maslenkin > > Sent: Friday, January 5, 2024 8:20 AM > > To: devel@edk2.groups.io; Chang, Abner > > Cc: Nickle Wang ; Igor Kulchytskyy > > Subject: Re: [edk2-devel] [edk2-redfish-cl

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-05 Thread Chang, Abner via groups.io
or Kulchytskyy > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: > Add ETag PCD and revise Redfish ETag functions > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or respondin

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/7] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-01-05 Thread Sami Mujawar
Hi Prabin, There are 2 patches each in this series numbered 4/7, 5/7, 6/7 , 7/7. This is very confusing. [edk2-platforms][PATCH v1 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform [edk2-platforms][PATCH v1 7/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-04 Thread Mike Maslenkin
Looks good to me. But could it be possible to rephrase "ETAG is not supported on Redfish service." ? May be I misunderstand, but I assume "Redfish service" is a service at BMC side, while we are disabling ETAG functionality at Redfish client side. README.md says "Redfish service hosted by Board

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds

2024-01-04 Thread Rebecca Cran via groups.io
Wouldn't it be better to add the Stack Protector library (MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf) instead of disabling it? -- Rebecca Cran On 1/4/2024 11:49 AM, Prabin CA via groups.io wrote: Add the no-stack-protector compiler flag to allow StandaloneMM builds on both

[edk2-devel] [edk2-platforms][PATCH v1 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-04 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v1 7/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-04 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v1 6/7] Platform/Sgi: Define RD-V2 platform id values

2024-01-04 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7

[edk2-devel] [edk2-platforms][PATCH v1 6/7] Platform/Sgi: Add a PCD to specify platform variant

2024-01-04 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v1 5/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-04 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v1 5/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-04 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v1 4/7] Platform/Sgi: Add a PCD to specify platform variant

2024-01-04 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v1 4/7] Platform/Sgi: Define RD-V2 platform id values

2024-01-04 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7

<    1   2   3   4   5   6   7   8   9   10   >