Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-08 Thread Leif Lindholm
On Fri, Nov 5, 2021 at 7:37 PM Vitaly Cheptsov wrote: > > Hi Leif, > > I assume you mean the commit description, because the commit message is in the topic. A topic is not a commit message. The commit message is what comes after the topic. > I believe something like that would do: > >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-05 Thread Vitaly Cheptsov
t how to address this one issues without > adding those directives. > > Mike > >> -Original Message- >> From: Vitaly Cheptsov >> Sent: Friday, November 5, 2021 1:36 PM >> To: Kinney, Michael D >> Cc: Leif Lindholm ; devel@edk2.groups.io; Yao, Jiewen

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-05 Thread Michael D Kinney
-Original Message- > >> From: Leif Lindholm > >> Sent: Friday, November 5, 2021 12:28 PM > >> To: devel@edk2.groups.io; chept...@ispras.ru > >> Cc: Yao, Jiewen ; Dong, Eric ; > >> Kinney, Michael D > ; > >> Wang, Jian J ; Jeff Fan ;

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-05 Thread Vitaly Cheptsov
>> From: Leif Lindholm >> Sent: Friday, November 5, 2021 12:28 PM >> To: devel@edk2.groups.io; chept...@ispras.ru >> Cc: Yao, Jiewen ; Dong, Eric ; >> Kinney, Michael D ; >> Wang, Jian J ; Jeff Fan ; >> Mikhail Krichanov ; Marvin >> Häuser

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-05 Thread Michael D Kinney
chanov ; Marvin > Häuser > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by > aligning GDT buffer > > UefiCpuPkg maintainers - please respond. > > Meanwhile, Vitaly, could you please provide a commit message? > The BZ link is needed, but it's not a s

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-05 Thread Vitaly Cheptsov
Hi Leif, I assume you mean the commit description, because the commit message is in the topic. I believe something like that would do: CpuExceptionHandlerLib supplies misaligned GDT to the outer world (e.g. ArchSetupExceptionStack) when PcdCpuStackGuard is enabled. This happens because it uses

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-11-05 Thread Leif Lindholm
UefiCpuPkg maintainers - please respond. Meanwhile, Vitaly, could you please provide a commit message? The BZ link is needed, but it's not a substitute. / Leif On Mon, Sep 20, 2021 at 17:13:47 +0300, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3639 > > >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-10-24 Thread Vitaly Cheptsov
Hello, It has been over a month since the patch was sent. What is the state of the issue? Best regards, Vitaly > On 20 Sep 2021, at 19:15, vit9696 via [] wrote: > > Just to make it clear, this is an immediate solution that is good enough to > fix the bug. However, a more proper solution

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-09-20 Thread Vitaly Cheptsov via groups.io
Just to make it clear, this is an immediate solution that is good enough to fix the bug. However, a more proper solution would be to introduce the _Alignas ( https://en.cppreference.com/w/c/language/_Alignas ) concept to EDK II. I would suggest the following macro in Base.h: /** Enforce custom

[edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

2021-09-20 Thread Vitaly Cheptsov
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3639 Cc: Jiewen Yao Cc: Eric Dong Cc: Michael Kinney Cc: Jian J Wang Cc: Jeff Fan Cc: Mikhail Krichanov Cc: Marvin Häuser Signed-off-by: Vitaly Cheptsov --- .../Library/CpuExceptionHandlerLib/DxeException.c| 12