Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-14 Thread Laszlo Ersek
On 01/14/20 11:34, Vitaly Cheptsov via Groups.Io wrote: > - ConnectControllers > ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > > This one is more complex, as it supports explicitly connecting specified > controllers, however, for connecting all controllers it locates handles with >

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-14 Thread Vitaly Cheptsov via Groups.Io
your local version? >> >> >> Thanks, >> >> Ray >> >> >> From: devel@edk2.groups.io On Behalf Of Vitaly >> Cheptsov via Groups.Io >> Sent: Tuesday, January 14, 2020 4:47 AM >> To: Laszlo Ersek ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-14 Thread Vitaly Cheptsov via Groups.Io
ary 14, 2020 4:47 AM > To: Laszlo Ersek ; devel@edk2.groups.io; Ni, Ray > ; Gao, Zhichao > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles > without device paths > > Thanks all for your input, > > These explanations seem sufficient to us that it is n

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-13 Thread Ni, Ray
, Ray ; Gao, Zhichao Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths Thanks all for your input, These explanations seem sufficient to us that it is not a good idea to change the behaviour for everyone. Even so, we still need this to be configurable

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-13 Thread Vitaly Cheptsov via Groups.Io
Thanks all for your input, These explanations seem sufficient to us that it is not a good idea to change the behaviour for everyone. Even so, we still need this to be configurable in some way, as having to patch EDK II is impracticable. We believe there are three possible routes to approach

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-13 Thread Laszlo Ersek
On 01/13/20 12:56, Ni, Ray wrote: > We shouldn't assume that a DriverBindingStart() can only start on a handle > with device path installed. DevicePath protocol is just a special protocol. > It's possible that a bus driver starts on a host controller handle and > creates multiple children, each

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-13 Thread Ni, Ray
2020 5:20 PM > To: Gao, Zhichao > Cc: devel@edk2.groups.io; Ni, Ray > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles > without device paths > > Hi, > > ‘Freeze’ means it is hung up forever, and we believe it is caused by an > invalid memory acc

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-13 Thread Vitaly Cheptsov via Groups.Io
13, 2020 5:39 AM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without >> device paths >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2460 >> >> Doing this reduces the amount of needless wor

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-13 Thread Gao, Zhichao
ATCH 1/1] ShellPkg: Do not connect handles without > device paths > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2460 > > Doing this reduces the amount of needless work during device connection > and resolves issues with firmwares that freeze when connecting handles >

[edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

2020-01-12 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2460 Doing this reduces the amount of needless work during device connection and resolves issues with firmwares that freeze when connecting handles without device paths. Signed-off-by: Vitaly Cheptsov ---