Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported.

2023-09-11 Thread Linus Liu 
Hi Ard 
V3 patch has updated.
Please help to check it.
Thanks.

-Original Message-
From: Ard Biesheuvel  
Sent: Monday, September 11, 2023 9:14 PM
To: devel@edk2.groups.io; Liu, Linus 
Cc: Zhang, Qi1 ; Kumar, Rahul R ; 
Yao, Jiewen ; Chen, Tina ; Chen, 
Xiao X 
Subject: Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only 
available if encryption is supported.

On Thu, 7 Sept 2023 at 11:02, Linus Liu  wrote:
>
> From: Linus Liu 
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3004
>
> Cc: Qi Zhang
> Cc: Rahul Kumar 
> Cc: Jiewen Yao  
> Cc: Tina Chen   
> Cc: Xiao X Chen 

This patch is missing a signed-off-by line

> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c 
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> index e2e77cbc24..ba9fa66c60 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
>  // Secure erase is performed by generating a new encryption key
>  // this is only available if encryption is supported
>  //
> -AvalDiskActions->SecureErase = 1;
> +if (SupportedAttributes->MediaEncryption) {
> +  AvalDiskActions->SecureErase = 1;
> +} else {
> +  AvalDiskActions->SecureErase = 0;
> +}
>} else {
>  AvalDiskActions->PsidRevert  = 0;
>  AvalDiskActions->SecureErase = 0;
> --
> 2.39.2.windows.1
>
>
>
> 
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368
> Mute This Topic: https://groups.io/mt/101210886/1131722
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [a...@kernel.org]
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108513): https://edk2.groups.io/g/devel/message/108513
Mute This Topic: https://groups.io/mt/101210886/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


--- Begin Message ---
From: Linus Liu 

https://bugzilla.tianocore.org/show_bug.cgi?id=3004

Cc: Qi Zhang
Cc: Rahul Kumar 
Cc: Jiewen Yao  
Cc: Tina Chen   
Cc: Xiao X Chen 
Signed-off-by: Linus Liu 
---
 SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c 
b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
index e2e77cbc24..ba9fa66c60 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
@@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
 // Secure erase is performed by generating a new encryption key

 // this is only available if encryption is supported

 //

-AvalDiskActions->SecureErase = 1;

+if (SupportedAttributes->MediaEncryption) {

+  AvalDiskActions->SecureErase = 1;

+} else {

+  AvalDiskActions->SecureErase = 0;

+}

   } else {

 AvalDiskActions->PsidRevert  = 0;

 AvalDiskActions->SecureErase = 0;

--
2.39.2.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108511): https://edk2.groups.io/g/devel/message/108511
Mute This Topic: https://groups.io/mt/101307436/7575003
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [linus@intel.com]
-=-=-=-=-=-=


--- End Message ---

Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported.

2023-09-11 Thread Ard Biesheuvel 
On Thu, 7 Sept 2023 at 11:02, Linus Liu  wrote:
>
> From: Linus Liu 
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3004
>
> Cc: Qi Zhang
> Cc: Rahul Kumar 
> Cc: Jiewen Yao  
> Cc: Tina Chen   
> Cc: Xiao X Chen 

This patch is missing a signed-off-by line

> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c 
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> index e2e77cbc24..ba9fa66c60 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
>  // Secure erase is performed by generating a new encryption key
>  // this is only available if encryption is supported
>  //
> -AvalDiskActions->SecureErase = 1;
> +if (SupportedAttributes->MediaEncryption) {
> +  AvalDiskActions->SecureErase = 1;
> +} else {
> +  AvalDiskActions->SecureErase = 0;
> +}
>} else {
>  AvalDiskActions->PsidRevert  = 0;
>  AvalDiskActions->SecureErase = 0;
> --
> 2.39.2.windows.1
>
>
>
> 
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368
> Mute This Topic: https://groups.io/mt/101210886/1131722
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [a...@kernel.org]
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108486): https://edk2.groups.io/g/devel/message/108486
Mute This Topic: https://groups.io/mt/101210886/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported.

2023-09-11 Thread Yao, Jiewen 
Reviewed-by: Jiewen Yao 

> -Original Message-
> From: Liu, Linus 
> Sent: Thursday, September 7, 2023 5:02 PM
> To: devel@edk2.groups.io
> Cc: Liu, Linus ; Zhang, Qi1 ; Kumar,
> Rahul R ; Yao, Jiewen ; Chen,
> Tina ; Chen, Xiao X 
> Subject: [PATCH v2] Pyrite support - Secure erase is only available if 
> encryption is
> supported.
> 
> From: Linus Liu 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3004
> 
> Cc: Qi Zhang
> Cc: Rahul Kumar 
> Cc: Jiewen Yao  
> Cc: Tina Chen   
> Cc: Xiao X Chen 
> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> index e2e77cbc24..ba9fa66c60 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
>  // Secure erase is performed by generating a new encryption key
> 
>  // this is only available if encryption is supported
> 
>  //
> 
> -AvalDiskActions->SecureErase = 1;
> 
> +if (SupportedAttributes->MediaEncryption) {
> 
> +  AvalDiskActions->SecureErase = 1;
> 
> +} else {
> 
> +  AvalDiskActions->SecureErase = 0;
> 
> +}
> 
>} else {
> 
>  AvalDiskActions->PsidRevert  = 0;
> 
>  AvalDiskActions->SecureErase = 0;
> 
> --
> 2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108485): https://edk2.groups.io/g/devel/message/108485
Mute This Topic: https://groups.io/mt/101210886/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported.

2023-09-07 Thread Linus Liu 
From: Linus Liu 

https://bugzilla.tianocore.org/show_bug.cgi?id=3004

Cc: Qi Zhang
Cc: Rahul Kumar 
Cc: Jiewen Yao  
Cc: Tina Chen   
Cc: Xiao X Chen 
---
 SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c 
b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
index e2e77cbc24..ba9fa66c60 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
@@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
 // Secure erase is performed by generating a new encryption key
 // this is only available if encryption is supported
 //
-AvalDiskActions->SecureErase = 1;
+if (SupportedAttributes->MediaEncryption) {
+  AvalDiskActions->SecureErase = 1;
+} else {
+  AvalDiskActions->SecureErase = 0;
+}
   } else {
 AvalDiskActions->PsidRevert  = 0;
 AvalDiskActions->SecureErase = 0;
-- 
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368
Mute This Topic: https://groups.io/mt/101210886/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-