Re: 回复: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Abdul Lateef Attar via groups.io
.groups.io; gaolim...@byosoft.com.cn; 'Attar, AbdulLateef (Abdul Lateef)' *抄送:*Pierre Gondois ; 'Leif Lindholm' ; 'Andrew Fish' ; 'Michael Kinney' *主题:*Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node Hi Liming, >What’s your comme

Re: [edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

2024-05-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, May 8, 2024 4:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH]

回复: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread gaoliming via groups.io
; 'Attar, AbdulLateef (Abdul Lateef)' 抄送: Pierre Gondois ; 'Leif Lindholm' ; 'Andrew Fish' ; 'Michael Kinney' 主题: Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node Hi Liming, > What’s your comments for this patch? The pa

回复: [edk2-devel][edk2-stable202405] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread gaoliming via groups.io
Include more people for feedback. > -邮件原件- > 发件人: Hou, Wenxing > 发送时间: 2024年5月9日 17:35 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Li, Yi1 > > 抄送: Yao, Jiewen > 主题: RE: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls > > Hi Liming, > Thanks for your

Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Sami Mujawar
9 May 2024 at 11:18 To: "devel@edk2.groups.io" , "gaolim...@byosoft.com.cn" , "'Attar, AbdulLateef (Abdul Lateef)'" Cc: Pierre Gondois , 'Leif Lindholm' , 'Andrew Fish' , 'Michael Kinney' Subject: Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTabl

Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Sami Mujawar
)'" , "devel@edk2.groups.io" Cc: Pierre Gondois , Sami Mujawar , 'Leif Lindholm' , 'Andrew Fish' , 'Michael Kinney' Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node Resent from: Resent date: Thursday 9 Ma

回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

2024-05-09 Thread gaoliming via groups.io
Doug: Is there any functionality impact by these two CVE fixes? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Doug Flick via > groups.io > 发送时间: 2024年5月9日 13:56 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao > 主题: [edk2-devel] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and >

回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread gaoliming via groups.io
Sami and Pierre: What’s your comments for this patch? Is this a required bug fix or new feature? Thanks Liming 发件人: Attar, AbdulLateef (Abdul Lateef) 发送时间: 2024年5月9日 16:39 收件人: gaoliming ; devel@edk2.groups.io 抄送: 'Pierre Gondois' ; 'Sami Mujawar' 主题: Re: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Abdul Lateef Attar via groups.io
to generate ACPI tables based on this stable release. Thanks AbduL From: gaoliming Sent: Thursday, May 9, 2024 1:10 PM To: devel@edk2.groups.io ; Attar, AbdulLateef (Abdul Lateef) Cc: 'Pierre Gondois' ; 'Sami Mujawar' Subject: 回复: [edk2-devel] [edk2-stable202405

回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread gaoliming via groups.io
e Gondois > ; Sami Mujawar > 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > DynamicTablesPkg: Adds integer to the AML package node > > Adds an AmlAddIntegerToNamedPackage() API to generate AML code, > which adds an integer value to the package node. > > Cc: Pi

回复: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

2024-05-09 Thread gaoliming via groups.io
Reviewed-by: Liming Gao This is a security fix. So, I think it should catch this stable tag 202405 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Pakkirisamy > ShanmugavelX > 发送时间: 2024年5月6日 17:53 > 收件人: devel@edk2.groups.io > 抄送: Shanmugavel Pakkirisamy ; > Zhiguang Liu ;

[edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-08 Thread Abdul Lateef Attar via groups.io
Adds an AmlAddIntegerToNamedPackage() API to generate AML code, which adds an integer value to the package node. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 41 +++- .../Common/AmlLib/CodeGen/AmlCodeGen.c

[edk2-devel] [edk2-stable202405 RESEND PATCH v2 0/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-08 Thread Abdul Lateef Attar via groups.io
Please concider this patch for stable release. PR: https://github.com/tianocore/edk2/pull/5636 This patch adds integer to the AML package node. v2 delta : Addressed comments from Pierre Gondois Cc: Pierre Gondois Cc: Sami Mujawar Cc: Liming Gao Cc: Michael D Kinney Abdul Lateef Attar (1):

[edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
MpInfo2HobPei provides backwards compatibility between FSP binaries built with older versions of EDK II and the latest EDK II. Newer versions of CpuMpPei produce the gMpInformation2HobGuid. This HOB is required by newer implementations of the CPU DXE driver, however older versions of CpuMpPei do

[edk2-devel] [edk2-platforms] [PATCH v1 0/2] Intel/MinPlatform: Add MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
Newer versions of CpuMpPei produce the gMpInformation2HobGuid. This HOB is required by newer implementations of the CPU DXE driver, however older versions of CpuMpPei do not produce it. This can cause backwards compatibiliity issues if the FSP binary was built with an older version of EDK II and

[edk2-devel] [edk2-platforms] [PATCH v1 2/2] AlderlakeOpenBoardPkg: Include MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
Because Alder Lake FSP includes an older version of CpuMpPei MpInfo2HobPei is needed to boot with newer versions of EDK II. Accordingly, this change adds MpInfo2HobPei to FvPostMemory. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni Kasbekar Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong

[edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

2024-05-08 Thread Nickle Wang via groups.io
Upgrade Werkzeug to version 3.0.3 to address CVE-2024-34069 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- Tools/Redfish-Profile-Simulator/redfishProfileSimulator.py | 7 --- Tools/Redfish-Profile-Simulator/requirements.txt | 6 ++ 2

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-06 Thread G Edhaya Chandran
Hi Heinrich, The folder structure for edk2-test-rc2_202405 is created: https://members.uefi.org/wg/utwg/document/folder/128 With Warm Regards, Edhay > -Original Message- > From: Heinrich Schuchardt > Sent: Sunday, May 5, 2024 5:22 PM > To: G Edhaya Chandran > Cc:

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

2024-05-06 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Chang, Abner Sent: Thursday, May 02, 2024 11:49 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: rename

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-05 Thread Heinrich Schuchardt
On 5/4/24 01:47, G Edhaya Chandran wrote: Hi All,    A new release candidate is published after upstreaming Stuart's commits on build cleanup. _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_ The updates

[edk2-devel] [edk2-platforms PATCH v4 2/7] Silicon/Marvell: Odyssey SmcLib

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch provides SMC call needed by Odyssey to determine size of available memory. Signed-off-by: Narinder Dhillon --- Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 +++ Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 +++

[edk2-devel] [edk2-platforms PATCH v4 0/7] Silicon/Marvell/OdysseyPkg

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon New Marvell Odyssey SoC This patchset contains only the very basic elements needed to boot to EDK2 UiApp on Marvell Odyssey SoC - ARM BL31 firmware component copies EDK2 image into memory, so it is always executing from memory - There is a SMC library to get system

[edk2-devel] [edk2-platforms PATCH v4 7/7] Silicon/Marvell: Odyssey project description files

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds Odyssey SoC project description and flash description files. Signed-off-by: Narinder Dhillon --- Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc| 219 ++ Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf| 304 +

[edk2-devel] [edk2-platforms PATCH v4 1/7] Silicon/Marvell: New Marvell Odyssey processor

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds helper library to initialize Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../OdysseyLib/AArch64/ArmPlatformHelper.S| 97 .../Library/OdysseyLib/OdysseyLib.c | 79 ++ .../Library/OdysseyLib/OdysseyLib.inf

[edk2-devel] [edk2-platforms PATCH v4 4/7] Silicon/Marvell: Device tree driver

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds a device tree driver that is used to read board configuration information from a device tree. Signed-off-by: Narinder Dhillon --- .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++ .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43

[edk2-devel] [edk2-platforms PATCH v4 6/7] Silicon/Marvell: Command to dump device tree

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds an EDK2 shell command to dump configuration device tree. Signed-off-by: Narinder Dhillon --- .../Marvell/Applications/DumpFdt/DumpFdt.c| 344 ++ .../Marvell/Applications/DumpFdt/DumpFdt.inf | 52 +++

[edk2-devel] [edk2-platforms PATCH v4 3/7] Silicon/Marvell: Odyssey watchdog driver

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds watchdog driver for Odyssey SoC. Signed-off-by: Narinder Dhillon --- .../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++ .../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++ 2 files changed, 453 insertions(+) create mode 100644

[edk2-devel] [edk2-platforms PATCH v4 5/7] Silicon/Marvell: Driver to publish device tree

2024-05-04 Thread Narinder Dhillon
From: Narinder Dhillon This patch adds driver that can provide device tree to OS if user so wishes. PCD's are used to enable this, default is not to take this action. Signed-off-by: Narinder Dhillon --- .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 255 ++

[edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-03 Thread G Edhaya Chandran
Hi All, A new release candidate is published after upstreaming Stuart's commits on build cleanup. https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405 The updates since the old tag are the following commits in the patch series: [PATCH v2 0/4] TCG2 protocol clean up

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

2024-05-02 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Friday, May 3, 2024 9:57 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: rename

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

2024-05-02 Thread Nickle Wang via groups.io
Rename x-uefi-redfish to x-UEFI-redfish to match the format of UEFI configuration namespace prefix. RFC: https://edk2.groups.io/g/rfc/message/849 Signed-off-by: Jeff Brasen Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-05-02 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Jayaprakash, N > Sent: Wednesday, April 24, 2024 11:14 AM > To: devel@edk2.groups.io; Jayaprakash, N ; > Kinney, Michael D > Cc: Rebecca Cran > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] e

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

2024-04-30 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks for reviewing this, the change is merged. Abner From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, April 30, 2024 3:36 PM To: Chang, Abner ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: Remove the

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

2024-04-30 Thread Abdul Lateef Attar via groups.io
Reviewed-by: Abdul Lateef Attar On 29-04-2024 10:31, abner.ch...@amd.com wrote: From: Abner Chang BZ# 4695 Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../ManageabilityPkg/ManageabilityPkg.dsc | 72 ++- 1 file changed, 56 insertions(+), 16

[edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

2024-04-28 Thread Chang, Abner via groups.io
From: Abner Chang BZ# 4695 Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../ManageabilityPkg/ManageabilityPkg.dsc | 72 ++- 1 file changed, 56 insertions(+), 16 deletions(-) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-24 Thread Jayaprakash, N
, April 18, 2024 11:49 AM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Rebecca Cran Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs Thanks Mike. I shall make necessary changes and submit the PR again for re

[edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc : add rdmsr_ex and wrmsr_ex to read/write msr from specific cpus

2024-04-24 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746 The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr APIs supported in edk2 module. These extension APIs makes it possible to read / write MSRs from specific processors. This fills an important gap in reading / writing these

[edk2-devel] [edk2-libc Patch v2 0/1] add rdmsr_ex & wrmsr_ex functions to read/write msrs from specific cpu

2024-04-24 Thread Jayaprakash, N
This patch adds 2 new functions to read and write MSRs from specific CPUs. rdmsr_ex and wrmsr_ex are the 2 new functions added into edk2module to provide the read and write of CPU specific MSRs. Jayaprakash N (1): edk2-libc : add rdmsr_ex and wrmsr_ex to read/write msr from specific cpus

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-04-23 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Tuesday, April 23, 2024 3:09 PM > To: Igor Kulchytskyy ; Chang, Abner > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: > introduce

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-04-23 Thread Nickle Wang via groups.io
Hi Igor, Abner, Thanks for your review. Please allow me to answer your questions together. > 1. We suppose acquire the credential before we start to communicate with > Redfish. Will Redfish credential driver create another bootstrap account here > after provisioning? No, according to the

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-04-22 Thread Igor Kulchytskyy via groups.io
Hi Nickle and Abner, I also have the same question as Abner. Why do we need to delete those credentials? According to spec BMC should delete the bootstrap credentials automatically on host or service reset. Thank you, Igor -Original Message- From: Chang, Abner Sent: Sunday, April 21,

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-04-21 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, One comment and few questions, > -Original Message- > From: Nickle Wang > Sent: Thursday, April 18, 2024 8:28 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH]

Re: [edk2-devel] [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Friday, April 19, 2024 2:01 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available > in edk2module

Re: [edk2-devel] [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-19 Thread Jayaprakash, N
Thanks Mike as suggested made the logic simpler. Sent the updated v3 patch for review. Regards, JP -Original Message- From: Kinney, Michael D Sent: Friday, April 19, 2024 2:35 AM To: Jayaprakash, N ; devel@edk2.groups.io Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-libc

[edk2-devel] [edk2-libc Patch v3 0/1] wrmsr function is not working as expected

2024-04-19 Thread Jayaprakash, N
The wrmsr function always writes 0s to the higher 32 bits of the msr register. This PR fixes this issue reported through the BZ4745 Jayaprakash N (1): ek2-libc: wrmsr function available in edk2module is not working as expected .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c

[edk2-devel] [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-19 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745 This commit fixes the issue reported in the BZ4745. The wrmsr was always writing 0 to the higher 32 bits of the msr register. This was due to a logical flaw in the code, where the input variable of type unsigned int was left shitted by 32

Re: [edk2-devel] [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-18 Thread Michael D Kinney
The use of BitFieldOr64() is really only required when updating a portion of a 32-bit or 64-bit value that are not aligned on a 32-bit boundary and do not have a 32-bit aligned width. Since this use case is setting the lower 32-bits, simpler logic should be used. data = LShiftU64(vedx, 32) |

[edk2-devel] [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-18 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745 This commit fixes the issue reported in the BZ4745. The wrmsr was always writing 0 to the higher 32 bits of the msr register. This was due to a logical flaw in the code, where the input variable of type unsigned int was left shitted by 32

[edk2-devel] [edk2-libc Patch 2 0/1] wrmsr function is not working as expected.

2024-04-18 Thread Jayaprakash, N
The wrmsr function always writes 0s to the higher 32 bits of the msr register. This PR fixes the this issue reported through the BZ4745. Jayaprakash N (1): ek2-libc: wrmsr function available in edk2module is not working as expected .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-04-18 Thread Nickle Wang via groups.io
-Introduce RedfishBootstrapAccountDxe to delete bootstrap account from /redfish/v1/AccountService/Accounts after BIOS finished all Redfish jobs. The bootstrap account won't be available to other application. So deleting bootstrap account helps to release resource at BMC. - After bootstrap account

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-18 Thread Jayaprakash, N
Thanks Mike. I shall make necessary changes and submit the PR again for review. Regards, JP -Original Message- From: Kinney, Michael D Sent: Thursday, April 18, 2024 10:46 AM To: Jayaprakash, N ; devel@edk2.groups.io Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-devel

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-17 Thread Michael D Kinney
> Sent: Wednesday, April 17, 2024 8:16 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Rebecca Cran > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > & wrmsr_ex functions to read/write cpu specific msrs > > In the validation and debug scen

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-17 Thread Jayaprakash, N
Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs Hi JP, Is there a reason switch BSP is being used. That is not a common operation and is typically used if the current

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-17 Thread Michael D Kinney
> -Original Message- > From: Jayaprakash, N > Sent: Sunday, April 14, 2024 10:33 PM > To: devel@edk2.groups.io; Jayaprakash, N > Cc: Rebecca Cran ; Kinney, Michael D > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > & wrmsr_ex

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr function available in edk2module is not working as expected

2024-04-17 Thread Michael D Kinney
> -Original Message- > From: Jayaprakash, N > Sent: Tuesday, April 9, 2024 11:09 PM > To: devel@edk2.groups.io; Jayaprakash, N > Cc: Rebecca Cran ; Kinney, Michael D > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr > function available in e

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-14 Thread Jayaprakash, N
+ Rebecca and Mike, Would you be able to review this PR? Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Wednesday, April 10, 2024 11:49 AM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D Subject: [edk2-devel

回复: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx - mantis #2131

2024-04-14 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Qingyu > 发送时间: 2024年4月2日 11:56 > 收件人: devel@edk2.groups.io > 抄送: Dandan Bi ; Liming Gao > > 主题: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg: > Update the comments of ReadKeySt

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

2024-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ok, then you can just merge this patch set. thanks Abner > -Original Message- > From: Nickle Wang > Sent: Wednesday, April 10, 2024 4:17 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Igor Kulchytskyy ; Nick Ramirez > Subjec

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

2024-04-10 Thread Nickle Wang via groups.io
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Wednesday, April 10, 2024 9:43 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: Re: [edk2-devel] [edk2-redfish

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-10 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746 The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr APIs supported in edk2 module. These extension APIs makes it possible to read / write MSRs from specific processors and fills an existing gap in this area. Cc: Rebecca

[edk2-devel] [edk2-libc Patch 0/1] add rdmsr_ex & wrmsr_ex functions to read/write msrs from specific cpu

2024-04-10 Thread Jayaprakash, N
This patch adds 2 new functions to read and write msrs from specific CPUs. rdmsr_ex and wrmsr_ex are the 2 new functions added into edk2module to provide the read and write of CPU specific MSRs. Jayaprakash N (1): edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr function available in edk2module is not working as expected

2024-04-10 Thread Jayaprakash, N
Reviewed-by : Jayaprakash N -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Thursday, April 4, 2024 3:14 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/Features: release resources

2024-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, April 1, 2024 10:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH v2 2/2]

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

2024-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, I don't see the obvious coding error in this patch. However, I think we can remove HPE copyright from Redfish secure boot feature driver, as this is a new feature driver and HPE doesn't have contributions to these files, right? If so, then please

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/5] MdeModulePkg: Allow dynamic generation of HEST ACPI table

2024-04-08 Thread Dhaval Sharma
Hi, Is there any plan to upstream these HEST/ACPI patches? They seem to be arch agnostic. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117526): https://edk2.groups.io/g/devel/message/117526 Mute This Topic:

[edk2-devel] [edk2-libc Patch 0/1] wrmsr function is not working as expected.

2024-04-04 Thread Jayaprakash, N
The wrmsr function always writes 0s to the higher 32 bits of the msr register. This issue has been fixed by this PR. Jayaprakash N (1): edk2-libc: wrmsr function available in edk2module is not working as expected .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c| 2 +- 1

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr function available in edk2module is not working as expected

2024-04-04 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745 This commit fixes the issue reported in the BZ4745. The wrmsr function was always writing 0 to the higher 32 bits of the msr register. This was due to a logical flaw in the code, where the input variable of type unsigned int was left

Re: [edk2-devel] [edk2-platforms][PATCH v1 5/5] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 5/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/5] Platform/Sgi: Define RD-V2 platform id values

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 4/5] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 4/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/5] Platform/Sgi: Use PCD value for L2 cache size in PPTT table

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 2/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/5] Platform/Sgi: Add a new PCD for L2 cache size

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/5

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-04-03 Thread Prabin CA
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform Hi Prabin, To me the RD-V2 support appears to be incomplete (or the required information is not clear). Therefore, instead of stalling the entire series, I am going to drop patch 5

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform

2024-04-03 Thread Prabin CA
Thanks Sami, for your review I have addressed your review comments and incorporated the changes. Please find the link to new patch series https://edk2.groups.io/g/devel/message/117378 > -Original Message- > From: Sami Mujawar > Sent: Sunday, March 31, 2024 5:36 PM > To: Prabin CA ;

[edk2-devel] [edk2-platforms][PATCH v1 5/5] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-04-03 Thread Prabin CA
Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a 16 core platform with Poseidon CPU. Each of the CPUs include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache. The platform also includes system level cache of 32MB and 8GB of RAM. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v1 4/5] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-04-03 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v1 3/5] Platform/Sgi: Define RD-V2 platform id values

2024-04-03 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++-

[edk2-devel] [edk2-platforms][PATCH v1 2/5] Platform/Sgi: Use PCD value for L2 cache size in PPTT table

2024-04-03 Thread Prabin CA
The PcdL2CacheSize PCD specifies the size of L2 cache of the CPU. Use the size specified by this PCD in the PPTT table of the RD-N2 platform. The PLAT_L2_CACHE_SIZE build time parameter is used to set the size of the CPU's L2 cache and this allows changing the value of the L2 cache size depending

[edk2-devel] [edk2-platforms][PATCH v1 1/5] Platform/Sgi: Add a new PCD for L2 cache size

2024-04-03 Thread Prabin CA
A new PCD named PcdL2CacheSize is introduced to specify the size of the CPU's L2 cache. This PCD can be used in PPTT tables for a reference design platform. The default value of this PCD is set to 1MB but can be changed depending on the variant of the reference design platform. Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH v1 0/5] Platform/Sgi: Extend SMBIOS support for RD-V2 and RD-Fremont

2024-04-03 Thread Prabin CA
Each CPUs of RD-V2 has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. The system architecture of the RD-V2 platform is similar to the RD-N2 platform, except for the CPU and L2 cache size. So existing RD-N2 SMBIOS support is extended for RD-V2 platform to reuse

[edk2-devel] [edk2-platforms][PATCH V2] Platform/Loongson: Remove minimium memory size limitation

2024-04-02 Thread xianglai
From: Bibo Mao Temparory stack memory on PEI is hardcoded now, also minimium memory size 256M is hardcoded now. Here memory map table from fw cfg can be parsed. If there is memory map entry contains pei stack, it can be published as usable memory at PEI stage. Signed-off-by: Bibo Mao

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

2024-04-02 Thread Nickle Wang via groups.io
t; Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] > RedfishClientPkg/Features: Variable used before being initialized > > External email: Use caution opening links or attachments > > > [AMD Official Use Only - General] > > Hi Nickle, > Use Uri makes sense to me.

Re: [edk2-devel] [edk2-platforms V2 3/3] MinPlatformPkg: Sort ApicIdOrderTable by special rules

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms V2 3/3]

Re: [edk2-devel] [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType for all cores

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms V2 2/3]

Re: [edk2-devel] [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms V2 1/3]

Re: [edk2-devel] [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in MADT

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms V2]

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

2024-04-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, Use Uri makes sense to me. Thanks! Please go ahead to merge it. Reviewed-by: Abner Chang . > -Original Message- > From: Nickle Wang > Sent: Monday, April 1, 2024 10:38 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > >

Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool

2024-04-01 Thread Chiu, Chasel
Patch pushed: https://github.com/tianocore/edk2-platforms/commit/ce4b8e394077f7f10ace2c6e96767f676c000355 Thanks, Chasel > -Original Message- > From: Pabba, PhanindraX Babu > Sent: Wednesday, March 27, 2024 2:27 PM > To: devel@edk2.groups.io > Cc: Pabba, PhanindraX Babu ; Chiu,

[edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx - mantis #2131

2024-04-01 Thread Qingyu
Refer to Uefi spec 2.10 section 12.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Qingyu --- .../VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

2024-04-01 Thread Nickle Wang via groups.io
Private->Uri is initialized after calling SetRedfishSettingsObjectsUri() but it is used in SetRedfishSettingsObjectsUri function. Use input parameter "Uri" instead. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/Features: release resources

2024-04-01 Thread Nickle Wang via groups.io
-Release Etag and PendingSettingUri resources. -Update function header for GetHttpResponseEtag() and GetHttpResponseLocation(). Caller has to release returned memory buffer from these two functions. -Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez

[edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

2024-04-01 Thread Nickle Wang via groups.io
Introduce SecureBoot driver to support /redfish/v1/Systems/SYS/SecureBoot resource. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 2 + RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 +

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

2024-04-01 Thread Nickle Wang via groups.io
Thanks, Mike! I merged this pull request. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Wednesday, March 27, 2024 5:19 AM > To: Nickle Wang > Cc: Chang, Abner ; devel@edk2.groups.io; Igor > Kulchytskyy > Subject: Re: [edk2-redfish-client][RFC PATCH 0/3]

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-04-01 Thread Mike Maslenkin
54 PM > > To: Nickle Wang ; devel@edk2.groups.io; Mike > > Maslenkin > > Cc: Igor Kulchytskyy > > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] > > RedfishClientPkg: Set SettingsObject URI as the config language > > > > [AMD Official Use Only - Genera

Re: [edk2-devel] [edk2-platforms V2 3/3] MinPlatformPkg: Sort ApicIdOrderTable by special rules

2024-04-01 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Monday, April 1, 2024 14:04 To: devel@edk2.groups.io Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-platforms V2 3/3] MinPlatformPkg: Sort

Re: [edk2-devel] [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType for all cores

2024-04-01 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Monday, April 1, 2024 14:04 To: devel@edk2.groups.io Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType

Re: [edk2-devel] [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId

2024-04-01 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Monday, April 1, 2024 14:04 To: devel@edk2.groups.io Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the

Re: [edk2-devel] [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in MADT

2024-04-01 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Monday, April 1, 2024 13:59 To: devel@edk2.groups.io Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-platforms V2] MinPlatformPkg: Corret

[edk2-devel] [edk2-platforms V2 3/3] MinPlatformPkg: Sort ApicIdOrderTable by special rules

2024-04-01 Thread duntan
Sort ApicIdOrderTable by following special rules: 1. Make sure BSP is the first entry. 2. For APs, big core first, then small core. With this implementation, BIOS can present cores in order of relative performance in MADT. Linux OS would schedule cores by the order that they are presented in the

[edk2-devel] [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType for all cores

2024-04-01 Thread duntan
Add a new field CoreType in EFI_CPU_ID_ORDER_MAP and get CoreType for all cores. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Jason Lou Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 50

  1   2   3   4   5   6   7   8   9   10   >