Re: Patch: gw/urltrans.c

2010-09-01 Thread Nikos Balkanas
: Tuesday, August 31, 2010 12:23 PM Subject: Re: Patch: gw/urltrans.c Of course you can do the [Aa][Bb][Cc] trick! That was the reason while Alex and I told you that case sensitivity mattered and we were against your point about disabling it on the first place... While this method works fine, it's

Re: Patch: gw/urltrans.c

2010-09-01 Thread Alexander Malysh
: Monday, August 30, 2010 5:21 PM Subject: Re: Patch: gw/urltrans.c see inlined... Am 30.08.2010 um 16:06 schrieb Nikos Balkanas: Hi, Please see comments inlined. Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Nikos Balkanas nbalka...@gmail.com Cc

Re: Patch: gw/urltrans.c

2010-08-30 Thread Alexander Malysh
AM Subject: Re: Patch: gw/urltrans.c Case insensitivity is observed in the code. It just lacks in configuration. I changed patch to match documentation: 1) When given both keyword-regex and keyword, it will just prefer keyword-regex without complains (according to UG). 2) It will accept

Re: Patch: gw/urltrans.c

2010-08-30 Thread Nikos Balkanas
Hi, Please see comments inlined. Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Nikos Balkanas nbalka...@gmail.com Cc: devel@kannel.org Sent: Monday, August 30, 2010 12:08 PM Subject: Re: Patch: gw/urltrans.c Hi, why do you change explicit configuration

Re: Patch: gw/urltrans.c

2010-08-30 Thread Alexander Malysh
: Patch: gw/urltrans.c Hi, why do you change explicit configuration to something implicit? I don't understand. Please explain what is explicit and what is implicit. use have to decide what to use keyword or keyword-regex and both settings just not allowed and is error. Now it also

Re: Patch: gw/urltrans.c

2010-08-30 Thread Alejandro Guerrieri
:08 PM Subject: Re: Patch: gw/urltrans.c Hi, why do you change explicit configuration to something implicit? I don't understand. Please explain what is explicit and what is implicit. user have to decide whether to use keyword or keyword-regex and if both given it's error

Re: Patch: gw/urltrans.c

2010-08-30 Thread Milan P. Stanic
On Mon, 2010-08-30 at 17:06, Nikos Balkanas wrote: Please see comments inlined. Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Nikos Balkanas nbalka...@gmail.com Cc: devel@kannel.org Sent: Monday, August 30, 2010 12:08 PM Subject: Re: Patch: gw/urltrans.c

RE: Patch: gw/urltrans.c

2010-08-30 Thread Rene Kluwen
...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf Of Alejandro Guerrieri Sent: Monday, 30 August, 2010 16:31 To: Nikos Balkanas Cc: devel@kannel.org Subject: Re: Patch: gw/urltrans.c Commenting inline. Regards, Alex On 30/08/2010, at 16:06, Nikos Balkanas wrote: Hi, Please see comments

Re: Patch: gw/urltrans.c

2010-08-30 Thread Milan P. Stanic
On Mon, 2010-08-30 at 17:33, Rene Kluwen wrote: I agree here. Regexps are by default not case sensitive, unless the i-modifier is set. Isn't internal option setting an option? Like they do here: http://nl2.php.net/manual/en/regexp.reference.internal-options.php Example: (?i:foo) This

Re: Patch: gw/urltrans.c

2010-08-30 Thread Alejandro Guerrieri
Afaik, Kannel uses pcre for regexps. Not sure if it's possible to pass parameters as it is now, but seems like a possible course of action. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 30/08/2010, at 18:33, Milan P. Stanic wrote: On Mon, 2010-08-30 at 17:33, Rene Kluwen wrote:

Re: Patch: gw/urltrans.c

2010-08-30 Thread Milan P. Stanic
On Mon, 2010-08-30 at 18:36, Alejandro Guerrieri wrote: Afaik, Kannel uses pcre for regexps. Not sure if it's possible to pass parameters as it is now, but seems like a possible course of action. It is configure script option and is disabled by default. And it is not mentioned in userguide.

Re: Patch: gw/urltrans.c

2010-08-30 Thread Nikos Balkanas
All right. Here it is. Enjoy, Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Nikos Balkanas nbalka...@gmail.com Cc: devel@kannel.org Sent: Monday, August 30, 2010 5:21 PM Subject: Re: Patch: gw/urltrans.c see inlined... Am 30.08.2010 um 16:06 schrieb Nikos

Re: Patch: gw/urltrans.c

2010-08-26 Thread Alvaro Cornejo
case in the keyword-regex pattern will work as well. Please disregard. BR, Nikos - Original Message - From: Nikos Balkanas nbalka...@gmail.com To: devel@kannel.org Sent: Thursday, August 26, 2010 8:02 AM Subject: Patch: gw/urltrans.c Hi, Currently keyword-regex is configured

RE: Patch: gw/urltrans.c

2010-08-26 Thread Rene Kluwen
: Thursday, 26 August, 2010 15:44 To: Nikos Balkanas Cc: devel@kannel.org Subject: Re: Patch: gw/urltrans.c It should then be noted in the user guide. Otherwise we will continue receiving this questions over and over

Re: Patch: gw/urltrans.c

2010-08-26 Thread Nikos Balkanas
: devel@kannel.org Sent: Thursday, August 26, 2010 5:10 PM Subject: RE: Patch: gw/urltrans.c A lot of hand sets, nowadays automatically convert the first letter to uppercase whilst typing an sms message. So I think case-insensivity is not a bad thing? == Rene -Original Message- From: devel

RE: Patch: gw/urltrans.c

2010-08-26 Thread Rene Kluwen
Thanks. -Original Message- From: Nikos Balkanas [mailto:nbalka...@gmail.com] Sent: Friday, 27 August, 2010 00:30 To: devel@kannel.org Cc: Rene Kluwen; 'Alvaro Cornejo' Subject: Re: Patch: gw/urltrans.c Case insensitivity is observed in the code. It just lacks in configuration. I

Re: Patch: gw/urltrans.c

2010-08-26 Thread Nikos Balkanas
...@gmail.com Cc: devel@kannel.org Sent: Thursday, August 26, 2010 5:10 PM Subject: RE: Patch: gw/urltrans.c A lot of hand sets, nowadays automatically convert the first letter to uppercase whilst typing an sms message. So I think case-insensivity is not a bad thing? == Rene -Original Message- From

Patch: gw/urltrans.c

2010-08-25 Thread Nikos Balkanas
Hi, Currently keyword-regex is configured to only do exact case matches. This is in contrast to keyword matching, which is case incensitive. Additionaly, input string input string is converted to lower case for matching. This will cause all keyword-regex patterns with capital letters to fail.

Re: Patch: gw/urltrans.c

2010-08-25 Thread Nikos Balkanas
I don't know if this is really necessary. Just using lower case in the keyword-regex pattern will work as well. Please disregard. BR, Nikos - Original Message - From: Nikos Balkanas nbalka...@gmail.com To: devel@kannel.org Sent: Thursday, August 26, 2010 8:02 AM Subject: Patch: gw