[389-devel] Re: 300s delay when query cn=monitor

2021-07-15 Thread Thierry Bordaz
Hello, that is excellent news. The server was trying to read an operation for 5min then timeout (ioblock_timeout), I am a bit surprised it detected incoming event but nothing to read. Anyway in such situation the connection is locked and this  explains why cn=monitor was hanging. best

[389-devel] Re: 300s delay when query cn=monitor

2021-07-12 Thread Thierry Bordaz
Hi Erwin, I think the pstack is first step to diagnose what is going on. I suspected a timeout because of the long etime (250s) that is close to a 5min timeout (ioblock, ssl timeout,...) but ATM there is no strong evidence of this. timeout are not systematically reported in error logs as it

[389-devel] Re: 300s delay when query cn=monitor

2021-07-09 Thread Thierry Bordaz
Hi, I would suspect the dump of the opened connections status to be the RC of that delay. If the monitor thread can not acquire the connection lock, it will delay the request. So I would suspect a connection timeout (5min) to hang the monitoring thread, for example if a ldapclient is not

[389-devel] Re: Please have look at One-Time Password password policy

2021-03-26 Thread thierry bordaz
On 3/25/21 11:28 PM, William Brown wrote: On 25 Mar 2021, at 17:49, thierry bordaz wrote: On 3/25/21 3:20 AM, William Brown wrote: On 25 Mar 2021, at 12:00, Mark Reynolds wrote: On 3/24/21 8:32 PM, William Brown wrote: I think maybe it could be easy to visualise it. We have time

[389-devel] Re: Please have look at One-Time Password password policy

2021-03-25 Thread thierry bordaz
On 3/25/21 3:20 AM, William Brown wrote: On 25 Mar 2021, at 12:00, Mark Reynolds wrote: On 3/24/21 8:32 PM, William Brown wrote: I think maybe it could be easy to visualise it. We have time going from past to future like: past

[389-devel] Re: Please have look at One-Time Password password policy

2021-03-24 Thread thierry bordaz
On 3/24/21 12:16 AM, William Brown wrote: On 24 Mar 2021, at 02:12, thierry bordaz wrote: Hi William Thanks for you review. Some answers are inlined in the mail below. On 3/23/21 12:33 AM, William Brown wrote: Hey there, I think that you also need: pwdOTPValidFromTime This way

[389-devel] Re: Please have look at One-Time Password password policy

2021-03-23 Thread thierry bordaz
uld allow 'passwordMustChange' Hope that helps! Absolutely it helps a lot. Thanks ! thierry On 22 Mar 2021, at 21:30, thierry bordaz wrote: Hi, I wrote a small design [1] about OTP password policy that I would like to start implementing. Comments are welcome [1] https://www.port389.org/docs/3

[389-devel] Please have look at One-Time Password password policy

2021-03-22 Thread thierry bordaz
Hi, I wrote a small design [1] about OTP password policy that I would like to start implementing. Comments are welcome [1] https://www.port389.org/docs/389ds/design/otp-password-policy.html best regards thierry ___ 389-devel mailing list --

[389-devel] Re: Deref plugin entries == NULL #4525

2021-01-15 Thread thierry bordaz
:53 AM thierry bordaz <mailto:tbor...@redhat.com>> wrote: On 1/14/21 12:32 PM, Pierre Rogier wrote: Hi William, > It's a scenario we will need to fix via your BE work because of the MVCC transaction model that > LMDB will force us to adopt :) As I see thin

[389-devel] Re: Deref plugin entries == NULL #4525

2021-01-15 Thread thierry bordaz
On 1/14/21 12:32 PM, Pierre Rogier wrote: Hi William, > It's a scenario we will need to fix via your BE work because of the MVCC transaction model that > LMDB will force us to adopt :) As I see things in the early phases the lmdb read txn will probably only be managed at the db plugin

[389-devel] Re: Deref plugin entries == NULL #4525

2021-01-15 Thread thierry bordaz
On 1/13/21 1:44 AM, William Brown wrote: Hey there, https://github.com/389ds/389-ds-base/pull/4525/files I had a look and I can see a few possible contributing factors, but without a core and the exact state I can't be sure if this is correct. It's all just hypothetical from reading the

[389-devel] Re: Mapping tree rework

2020-10-20 Thread thierry bordaz
On 10/20/20 4:01 AM, William Brown wrote: In the first case we could easily mitigate the risk by testing and be fairly confident, in the second case the tests are too complex to achieve the same confidence and we should take this kind of risk only if there were a serious benefit to balance

[389-devel] Re: tests take minutes to start

2020-05-13 Thread thierry bordaz
On 5/13/20 9:15 AM, Viktor Ashirov wrote: On Wed, May 13, 2020 at 9:13 AM William Brown wrote: On 13 May 2020, at 17:01, Viktor Ashirov wrote: Hi, On Wed, May 13, 2020 at 8:31 AM William Brown wrote: Hi all, I noticed today that my tests now take minutes to start executing. It looks

[389-devel] Re: Please have a look at rewriters design

2020-04-01 Thread thierry bordaz
bipa in a lot of ways ... Anyway, that's why Thierry want's to have a symload in this case :) Best regards, Ludwig On 03/19/2020 01:09 AM, William Brown wrote: On 19 Mar 2020, at 04:08, thierry bordaz wrote: On 3/18/20 1:51 AM, William Brown wrote: On 18 Mar 2020, at 04:08, thierry borda

[389-devel] Re: Adding new syntaxes

2020-03-20 Thread thierry bordaz
Hi William, I only have a vague knowledge of syntaxes/MR. Each syntax is a plugin. Its init function registers for a given set of OIDs the matching rules (compare, order, substring) than handle that syntax (calls slapi_matchingrule_register). There is a special collation plugin that does the

[389-devel] Re: Please have a look at rewriters design

2020-03-18 Thread thierry bordaz
On 3/18/20 1:51 AM, William Brown wrote: On 18 Mar 2020, at 04:08, thierry bordaz wrote: Hi William, I updated the design according to our offline exchange Thanks Thierry, I appreciate the conversation and the updates to the document: it made clear there were extra details up in your

[389-devel] Re: Please have a look at rewriters design

2020-03-17 Thread thierry bordaz
Hi William, I updated the design according to our offline exchange regards thierry On 3/17/20 11:12 AM, thierry bordaz wrote: On 3/17/20 2:42 AM, William Brown wrote: On 17 Mar 2020, at 02:49, thierry bordaz wrote: Hi, As a follow up of the PR https://pagure.io/389-ds-base/pull

[389-devel] Re: Please have a look at rewriters design

2020-03-17 Thread thierry bordaz
On 3/17/20 2:42 AM, William Brown wrote: On 17 Mar 2020, at 02:49, thierry bordaz wrote: Hi, As a follow up of the PR https://pagure.io/389-ds-base/pull-request/50939, I wrote down a small design about rewriters (filter/computed_attr) plugin: http://www.port389.org/docs/389ds/design

[389-devel] Please have a look at rewriters design

2020-03-16 Thread thierry bordaz
Hi, As a follow up of the PR https://pagure.io/389-ds-base/pull-request/50939, I wrote down a small design about  rewriters (filter/computed_attr) plugin: http://www.port389.org/docs/389ds/design/search_rewriters.html Comments are welcome best regards thierry

[389-devel] Re: Thoughts on swapping to rfc2307bis.ldif by default

2020-03-03 Thread thierry bordaz
. This either during an import or if instances in the same replicated topology create incompatible entries. regards thierry Regards, Ludwig On 03/03/2020 10:17 AM, thierry bordaz wrote: On 3/3/20 4:12 AM, William Brown wrote: On 3 Mar 2020, at 11:18, William Brown wrote: On 3 Mar 2020, at 04

[389-devel] Re: Thoughts on swapping to rfc2307bis.ldif by default

2020-03-03 Thread thierry bordaz
On 3/3/20 4:12 AM, William Brown wrote: On 3 Mar 2020, at 11:18, William Brown wrote: On 3 Mar 2020, at 04:32, thierry bordaz wrote: On 3/2/20 7:24 AM, William Brown wrote: Hi all, As you may know, I'm currently working on a migration utility to help move from other ldap servers

[389-devel] Re: Thoughts on swapping to rfc2307bis.ldif by default

2020-03-03 Thread thierry bordaz
On 3/3/20 4:12 AM, William Brown wrote: On 3 Mar 2020, at 11:18, William Brown wrote: On 3 Mar 2020, at 04:32, thierry bordaz wrote: On 3/2/20 7:24 AM, William Brown wrote: Hi all, As you may know, I'm currently working on a migration utility to help move from other ldap servers

[389-devel] Re: Thoughts on swapping to rfc2307bis.ldif by default

2020-03-02 Thread thierry bordaz
On 3/2/20 7:24 AM, William Brown wrote: Hi all, As you may know, I'm currently working on a migration utility to help move from other ldap servers to 389-ds. Something that I have noticed in this process is that other servers default to rfc2307bis.ldif [0] by default. As part of the

[389-devel] Re: [PATCH] prevent slapd from hanging under unlikely circumstances

2020-02-05 Thread thierry bordaz
On 2/5/20 2:30 AM, William Brown wrote: On 5 Feb 2020, at 03:10, Ludwig Krispenz wrote: I think I can agree with 1-8, 9 is one solution to fix the problem you reported, but not yet validate that there are no other side effects, there are potential postop plugins which should NOT be

[389-devel] Re: System tap performance results,

2019-12-11 Thread thierry bordaz
On 12/11/19 1:21 AM, William Brown wrote: On 10 Dec 2019, at 19:15, thierry bordaz wrote: Hi William, Thanks for these very interesting results. It would help if you can provide the stap scripts to make sure what you are accounting the latency. Yes, I plan to put them into a PR soon

[389-devel] Re: System tap performance results,

2019-12-10 Thread thierry bordaz
Hi William, Thanks for these very interesting results. It would help if you can provide the stap scripts to make sure what you are accounting the latency. Also just to be sure is latency a synonym for response time ? Regarding the comparison (tail) 1client/16client. It looks to me that the

[389-devel] Re: Future of nunc-stans

2019-10-10 Thread thierry bordaz
On 10/9/19 11:55 AM, Ludwig Krispenz wrote: Hi William, I like your radical approach :-) In my opinion our connection code is getting to complicated by maintaining two different implementations in parallel -  not separated, but intermangled (and even more complicated by turbo mode). So I

[389-devel] Re: please review: Replication Status Message Improvements

2019-06-12 Thread thierry bordaz
regular_replication and init_replication status. On 6/12/19 6:17 PM, Mark Reynolds wrote: On 6/12/19 12:08 PM, thierry bordaz wrote: Hi Mark, Looking very good to me. For replication status there is either ldaprc or replrc. The message is self explaining if it is a LDAP or replication error. IMHO I

[389-devel] Re: please review: Replication Status Message Improvements

2019-06-12 Thread thierry bordaz
Hi Mark, Looking very good to me. For replication status there is either ldaprc or replrc. The message is self explaining if it is a LDAP or replication error. IMHO I think json could only contain 'repl_status' that can contain ldaprc or replrc. For init status, it exists ldaprc, connrc and

[389-devel] Re: Replication agreement status messages: JSON or text?

2019-06-12 Thread thierry bordaz
On 6/12/19 9:22 AM, Ludwig Krispenz wrote: Hi Mark, On 06/11/2019 08:15 PM, Mark Reynolds wrote: I am currently working on a revision of replication agreement status messages.  Previously we logged the status like so:     Error (%d) - message (sub-message) ... just to get it clear what

[389-devel] Re: On the command line tools ....

2019-05-27 Thread thierry bordaz
Hi William, I am not expert of CLI/UI so I would just comment as novice user. 389-ds 1.4, brings a brand new CLI/UI. To be less disruptive, the web UI reuse a lot the ideas of former java console. It allows fine tuning and shows some nasty internal details that in the future we may want to

[389-devel] Re: Advice on a memory issue

2019-05-16 Thread thierry bordaz
Hi William, |It looks to me that attr_syntax_create overwrite the allocated asi with one it allocates itself based on provided params. In short I think attr_syntax_creates allocates for you the syntaxinfo, you do not need to provide one. best regards thierry | On 5/16/19 8:17 AM, William

[389-devel] Re: Profiling discussion

2018-10-25 Thread thierry bordaz
On 10/11/2018 12:57 AM, William Brown wrote: On Wed, 2018-10-10 at 16:26 +0200, thierry bordaz wrote: Hi William, Thanks for starting this discussion. Your email raise several aspects (How, for whom,..) and I think a way to start would be to write down what we want. A need is from a given

[389-devel] Re: Nunc-stans status

2018-10-24 Thread thierry bordaz
On 10/21/2018 03:55 AM, William Brown wrote: Thanks for this write up Thierry, On 19 Oct 2018, at 17:15, thierry bordaz wrote: Hi, C10K is a scalability problem that a server can face when dealing with events of thousands of connections (i.e. clients) at the same time. Events can be new

[389-devel] Nunc-stans status

2018-10-19 Thread thierry bordaz
Hi, C10K is a scalability problem that a server can face when dealing with events of thousands of connections (i.e. clients) at the same time. Events can be new connections, new operations on the established connections, closure of connection (from client or server) For 389-ds, C10K problem

[389-devel] Re: Profiling discussion

2018-10-10 Thread thierry bordaz
Hi William, Thanks for starting this discussion. Your email raise several aspects (How, for whom,..) and I think a way to start would be to write down what we want. A need is from a given workload to determine where we are spending time as a way to determine where to invest. An other need is

[389-devel] please review: Ticket 48184 clean up and delete connections at shutdown

2018-05-18 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/48184 https://pagure.io/389-ds-base/pull-request/49701 A bit of history around that fix. An original fix was done for 48184 [1]. This fix introduced a regression [2] that we failed to fix fast enough and the fix was finally backout [3]. The current PR [4]

[389-devel] Re: lib389 usage cheatsheet

2018-05-09 Thread thierry bordaz
Hi Simon, Thanks Simon starting this thread :) Currently lib389 is mostly used by ldap devel/QE and seems realistic to become the admin library (for example used by freeipa or others) and component of 389 administrative tools. LDAP knowledge is a requirement for all of them. In

[389-devel] Re: Optional rust support review

2017-11-08 Thread thierry bordaz
Hi William, I see benefit to offer the support of modern language in 389-ds. Rust developer can be interested to improve 389-DS with missing functionality. Especially with the plugin-api we have the ability to support rust without change to the core server. If a rust plugin hit a

[389-devel] Please review 49312: SIGSEV when setting invalid changelog config value

2017-10-25 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49412 https://pagure.io/389-ds-base/issue/raw/files/3f00b1682d2a5815b4437ec3c7e03eb0eb84d30e113b9926343b62ba59a03283-0001-Ticket-49412-SIGSEV-when-setting-invalid-changelog-c.patch ___ 389-devel mailing list --

[389-devel] Please review 49386: Memberof should be ignore MODRDN when the pre/post entry are identical

2017-10-19 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49386 https://pagure.io/389-ds-base/issue/raw/files/05e1c4e50c1a24b304c37456a8e937475796e44cc16462c708d9042808a32301-0001-Ticket-49386-Memberof-should-be-ignore-MODRDN-when-t.patch ___ 389-devel mailing list --

[389-devel] Please review 49064: allow to enable MemberOf plugin in dedicated consumer

2017-10-17 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49064 https://pagure.io/389-ds-base/issue/raw/files/4a0d58fa9331e1c8180acb2f1b6b0928b4e66488e6a9faa3c0cb96e223557057-0001-Ticket-49064-RFE-allow-to-enable-MemberOf-plugin-in-.patch ___ 389-devel mailing list --

[389-devel] Re: Build failed in Jenkins: COMMIT_SANITY_TEST #72

2017-10-16 Thread thierry bordaz
Hi Mark, Thanks for the head up !! sorry for breaking the build. I have fixed it... crossing the fingers :) best regards thierry On 10/16/2017 02:51 PM, marey...@redhat.com wrote: See

[389-devel] Please review 48973: Indexing a ExactIA5Match attribute with a IgnoreIA5Match matching rule triggers a warning

2017-09-27 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/48973 https://pagure.io/389-ds-base/issue/raw/files/e9c88aa920e588d5fd279b2671c5824ae5366b2faf2cbf196eed4c73cc3058c4-0001-Ticket-48973-Indexing-a-ExactIA5Match-attribute-with.patch ___ 389-devel mailing list --

[389-devel] Please review 49332: Event queue is not working

2017-07-25 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49332 https://pagure.io/389-ds-base/issue/raw/files/9aa72873aa6ad8e0947ee8465514a6cb2157b4c9ac789cedaa2d592d5bcbb604-0001-Ticket-49332-Event-queue-is-not-working.patch ___ 389-devel mailing list --

[389-devel] Please review ticket 49291: slapi_search_internal_callback_pb may SIGSEV if related pblock has not operation set

2017-06-15 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49291 https://pagure.io/389-ds-base/issue/raw/7eae6cb7318f30a32fb9e89fcf199c90bed624eb6456900be365d09df669808c-0001-Ticket-49291-slapi_search_internal_callback_pb-may-S.patch ___ 389-devel mailing list --

[389-devel] Please review 49230: slapi_register_plugin creates config entry where it should not

2017-04-25 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49230 https://pagure.io/389-ds-base/issue/raw/files/daf059ca6b5791e50a37866387bccf0c21ae9a563f5326db08d06d31ca75e854-0001-Ticket-49230-slapi_register_plugin-creates-config-en.patch ___ 389-devel mailing list --

[389-devel] Please review 49184: Overflow in memberof

2017-04-13 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49184 https://pagure.io/389-ds-base/issue/raw/files/c8897365eb508b39a692e2eb224c49b88a8d8728d1b5e06e095e0f55ae2849e5-0002-Ticket-49184-Overflow-in-memberof.patch ___ 389-devel mailing list --

[389-devel] Please review 49209: Hang due to omitted replica lock release

2017-04-04 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49209 patch is: https://pagure.io/389-ds-base/issue/raw/files/8adf20a3bebb247024662ee92aa8783d99f85fd0183398822a856287a75fe7fd-0001-Ticket-49209-Hang-due-to-omitted-replica-lock-releas.patch ___ 389-devel mailing

[389-devel] Please review issue 49076: To debug DB_DEADLOCK condition, allow to reset DB_TXN_NOWAIT flag on txn_begin

2017-02-15 Thread thierry bordaz
https://pagure.io/389-ds-base/issue/49076 https://pagure.io/389-ds-base/issue/raw/files/a078dfacb0f0c623412d357dd6e29b1c9987845416dd3fd5d1721fa089dd00ba-0001-Ticket-49076-To-debug-DB_DEADLOCK-condition-allow-to.patch ___ 389-devel mailing list --

[389-devel] Please review 49031: Improve memberof with a cache of group parents

2017-01-03 Thread thierry bordaz
Hi, This is the second part of improvement of the memberof plugin. This second part improves memberof by adding a cache. The cache is build/clear per operation. During an update memberof values are recomputed on all impacted nodes (group or leaf). The cache contains ancestors of all groups.

[389-devel] Please review lib389 48984: support environment variable to define defaults.inf

2016-12-05 Thread thierry bordaz
While testing in a prefix install I found it useful: https://fedorahosted.org/389/attachment/ticket/48984/0003-Ticket-48984-support-of-environment-variable-for-def.patch ___ 389-devel mailing list -- 389-de...@lists.fedoraproject.org To unsubscribe

[389-devel] Please review: 48861 Memberof plugins can update several times the same entry to set the same values

2016-12-05 Thread thierry bordaz
This is a first patch improving memberof plugins when fixup is done over a graph with multiple paths to the same nodes. patch is https://fedorahosted.org/389/attachment/ticket/48861/0002-Ticket-48861-Memberof-plugins-can-update-several-tim.patch test suite (port of tet test suite):

[389-devel] Re: Please review design proposal for tickets 47986 and 48976

2016-10-12 Thread thierry bordaz
Hello, I would think of two options * If admin decides to switch to backend, it should not be prevented and the backend moves to 'backend' * periodic (hourly) checking (IMHO not configurable and always run), checking being the same mechanism as 'auto' o in-sync->backend o

[389-devel] Please review 48992: Total init may fail if the pushed schema is rejected

2016-09-23 Thread thierry bordaz
Thanks Noriko for your review. I updated the patch to give more explanation why the fix is in modify_schema_dse. I pick up LDAP_CONSTRAINT_VIOLATION in replacement of UNWILLING_TO_PERFORM but I have not strong opinion on appropriate value of that returned value. In the logic of that fix, it

[389-devel] Please review 48992: Total init may fail if the pushed schema is rejected

2016-09-22 Thread thierry bordaz
This bug exists in topology with mixed versions and with 1.2.11 supplier total/incremental update of 1.3.5 consumer https://fedorahosted.org/389/ticket/48992 https://fedorahosted.org/389/attachment/ticket/48992/0001-Ticket-48992-Total-init-may-fail-if-the-pushed-schem.patch

[389-devel] Please review 48956: ns-accountstatus.pl giving error even "No such object (32)" but still giving output "activated".

2016-08-17 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/48956/0002-Ticket-48956-ns-accountstatus.pl-showing-activated-u.patch https://fedorahosted.org/389/ticket/48956 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review 48906 (take 2): Allow nsslapd-db-locks to be configurable online

2016-07-11 Thread thierry bordaz
William, Mark, thanks for your review and sorry for missing basic hardening of this param... https://fedorahosted.org/389/ticket/48906 https://fedorahosted.org/389/attachment/ticket/48906/0003-Ticket-48906-Allow-nsslapd-db-locks-to-be-configurab.patch -- 389-devel mailing list

[389-devel] Please review 48906: Allow nsslapd-db-locks to be configurable online

2016-07-07 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/48906/0002-Ticket-48906-Allow-nsslapd-db-locks-to-be-configurab.patch https://fedorahosted.org/389/ticket/48906 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Re: Logging performance improvement

2016-07-07 Thread thierry bordaz
Hi William, This is looking a great idea. You are proposing to use liblfds to communicate with the log write. Do you think dbus would be an other option ? Would it help external mechanism to collect the DS logs ? thanks thierry On 07/01/2016 03:52 AM, William Brown wrote: Hi, I've been

[389-devel] Please review 48891 (2nd) : ns-slapd crashes during the shutdown after adding attribute with a matching rule

2016-06-23 Thread thierry bordaz
The previous fix was commited. It prevented a crash but is incomplete because of invalid access to freed buffer (https://fedorahosted.org/389/ticket/48891#comment:9). This is an additional part of the fix

[389-devel] Re: Please review: ticket #48766 Replication changelog can incorrectly skip over updates

2016-05-25 Thread thierry bordaz
On 05/25/2016 08:47 AM, Ludwig Krispenz wrote: On 05/24/2016 07:00 PM, thierry bordaz wrote: On 05/24/2016 05:24 PM, Ludwig Krispenz wrote: On 05/24/2016 04:20 PM, thierry bordaz wrote: Hi Ludwig, Thanks for your explanation. The design looks very good. I think it would be good to put

[389-devel] Please review (2nd): 48836 replication session fails because of permission denied

2016-05-18 Thread thierry bordaz
Thanks Ludwig and Noriko for the review. You are right replica_updatedn_list_ismember was the function to fix. https://fedorahosted.org/389/ticket/48836 https://fedorahosted.org/389/attachment/ticket/48836/0002-Ticket-48836-replication-session-fails-because-of-pe.patch -- 389-devel mailing

[389-devel] Please review: 48836 replication session fails because of permission denied

2016-05-17 Thread thierry bordaz
https://fedorahosted.org/389/ticket/48836 https://fedorahosted.org/389/attachment/ticket/48836/0001-Ticket-48836-replication-session-fails-because-of-pe.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review 48597 (take 2): Deadlock when rebuilding the group of authorized replication managers

2016-03-30 Thread thierry bordaz
Following Noriko's recommendations from first review https://fedorahosted.org/389/ticket/48597 https://fedorahosted.org/389/attachment/ticket/48597/0002-Ticket-48597-Deadlock-when-rebuilding-the-group-of-a.patch -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Please review 48497: extended search without MR indexed attribute prevents later indexing with that MR

2016-03-07 Thread thierry bordaz
ticket: https://fedorahosted.org/389/ticket/48497 patch: https://fedorahosted.org/389/attachment/ticket/48497/0001-ticket-48497-extended-search-without-MR-indexed-attr.patch CI test: https://fedorahosted.org/389/attachment/ticket/48497/ticket48497_test.py -- 389-devel mailing list

[389-devel] Please review 48746: Crash when indexing an attribute with a matching rule

2016-03-04 Thread thierry bordaz
Hello, This patches fixes two tickets as it is difficult to split the patch in two parts for each ticket. Patch is https://fedorahosted.org/389/attachment/ticket/48746/0002-Ticket-48746-Crash-when-indexing-an-attribute-with-a.patch One ticket is a crash:

[389-devel] Please review 48420: change severity of some messages related to "keep alive" entries

2016-03-01 Thread thierry bordaz
https://fedorahosted.org/389/ticket/48420 https://fedorahosted.org/389/attachment/ticket/48420/0001-Ticket-48420-change-severity-of-some-messages-relate.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review 48270: fail to index an attribute with a specific matching rule

2016-02-05 Thread thierry bordaz
https://fedorahosted.org/389/ticket/48270 https://fedorahosted.org/389/attachment/ticket/48270/0001-Ticket-48270-fail-to-index-an-attribute-with-a-speci.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review 48362: With exhausted range, part of DNA shared configuration is deleted after server restart

2015-12-08 Thread thierry bordaz
ticket: https://fedorahosted.org/389/ticket/48362 fix: https://fedorahosted.org/389/attachment/ticket/48362/0001-Ticket-48362-With-exhausted-range-part-of-DNA-shared.patch testcase: https://fedorahosted.org/389/attachment/ticket/48362/ticket48362_test.py -- 389-devel mailing list

Re: [389-devel] Please review ticket 47976: deadlock in mep delete post op

2015-11-04 Thread thierry bordaz
the real problem is not to set the txn in id2entry, which will then try to read a locked page. Ludwig On 11/03/2015 05:40 PM, thierry bordaz wrote: ticket https://fedorahosted.org/389/ticket/47976 fix https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock-in-mep-delete

[389-devel] Please review ticket 47976: deadlock in mep delete post op

2015-11-03 Thread thierry bordaz
ticket https://fedorahosted.org/389/ticket/47976 fix https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock-in-mep-delete-post-op.patch test case: https://fedorahosted.org/389/attachment/ticket/47976/0002-Ticket-47976-test-case.patch -- 389-devel mailing list

Re: [389-devel] DSAdmin tests and basic functionality in the lib389

2015-10-19 Thread thierry bordaz
On 10/19/2015 04:18 PM, Mark Reynolds wrote: On 10/19/2015 10:02 AM, Simon Pichugin wrote: Hi team, I am working now on the fixing lib389 broken tests: https://fedorahosted.org/389/ticket/48303 And it's time for dsadmin_* tests. Can anybody, please, tell me more about it? As I see, Mark and

[389-devel] Please review Ticket 47978: Deadlock between two MODs on the same entry between entry cache and backend lock

2015-10-16 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47978/0001-Ticket-47978-Deadlock-between-two-MODs-on-the-same-e.patch https://fedorahosted.org/389/ticket/47978 It exists a FreeIPA CI test that reproduce the hang (almost systematically): test_vault.py -- 389-devel mailing list

[389-devel] Please review ticket 48266 (3rd): Fractional replication evaluates several times the same CSN

2015-09-17 Thread thierry bordaz
Thank you Noriko and Simon for your careful reviews. I modified the fix: * create the subentry with 'cn' value 'repl keep alive ' * slapi_ch_free without cast * do the keep alive entry with '(&(objectclass=ldapsubentry)(cn=%s %d))', in previous fix I forgot '%d' I modified the test case

[389-devel] Please review ticket 48266 (4th): Fractional replication evaluates several times the same CSN

2015-09-17 Thread thierry bordaz
Thanks to Noriko who ran coverity tests the previous fix was invalid. Changing the call slapi_ch_free into slapi_ch_free_string. https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-4-Fractional-replication-evaluates-severa.patch -- 389-devel mailing list

[389-devel] Please review ticket 48266: Fractional replication evaluates several times the same CSN

2015-09-15 Thread thierry bordaz
Thank you so much Rich and Noriko for your feedbacks. I was late to take them into account and I am sorry for that delay. Here is the last patch and the associated test case. https://fedorahosted.org/389/ticket/48266

Re: [389-devel] [lib389] Deref control advice needed

2015-09-02 Thread thierry bordaz
On 08/27/2015 02:31 AM, Rich Megginson wrote: On 08/26/2015 03:28 AM, William Brown wrote: In relation to ticket 47757, I have started work on a deref control for Noriko. The idea is to get it working in lib389, then get it upstreamed into pyldap. At this point it's all done, except that the

[389-devel] please review: Ticket 48249 - sync_repl uuid may be invalid

2015-08-14 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/48249/0001-Ticket-48249-sync_repl-uuid-may-be-invalid.patch https://fedorahosted.org/389/ticket/48249 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review ticket 48127: Using RPM, allows non root user to create/remove DS instance

2015-03-13 Thread thierry bordaz
https://fedorahosted.org/389/ticket/48127 https://fedorahosted.org/389/attachment/ticket/48127/0001-Ticket-48127-Using-RPM-allows-non-root-user-to-creat.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review ticket 47936: Create a global lock to serialize write operations over several backends

2015-02-26 Thread thierry bordaz
Hello, This fix allows to protect several backends with a global lock during update operations. It is configurable and by default the global lock is not enabled. Under rare condition some plugin may lead to deadlocks. Global lock would be enabled to prevent those deadlocks

[389-devel] Please review ticket 47988: Schema learning mechanism, in replication, unable to extend an existing definition

2015-01-23 Thread thierry bordaz
Ticket https://fedorahosted.org/389/ticket/47988 Patch: https://fedorahosted.org/389/attachment/ticket/47988/0001-Ticket-47988-Schema-learning-mechanism-in-replicatio.patch Test case: https://fedorahosted.org/389/attachment/ticket/47988/0001-Ticket-47988-test-case.patch -- 389-devel mailing

[389-devel] Please review ticket 47828 (2nd): DNA scope: allow to exlude some subtrees

2014-12-17 Thread thierry bordaz
Hello , Taking into account Mark review (dnaExcludeScope:2.16.840.1.113730.3.1.2312) Bug: https://fedorahosted.org/389/ticket/47828 Fix: https://fedorahosted.org/389/attachment/ticket/47828/0002-Ticket-47828-DNA-scope-allow-to-exlude-some-subtrees.patch Test:

[389-devel] Please review ticket 47942 (3rd): DS hangs during online total update

2014-12-11 Thread thierry bordaz
Hello, The tickethttps://fedorahosted.org/389/ticket/47942 was already reviewed by Mark, Rich and pj101. The new patch is taking into account the following points: * incorrect indentation * Window/Pause configuration attribute are common to total and incremental

[389-devel] Please review for lib389 ticket 47691 (3rd): lib389 support for RPM builds of 389-ds

2014-11-24 Thread thierry bordaz
Hello, This fix allows to run 389-DS CI tests when 389-ds is deployed as a rpm. It takes into account previous reviews done by Rich (no use of 'sudo' or 'systemctl', use of 'nobody' user). It also checks that 127.0.0.1 is resolved as localhost.localdomain that is required by setup-ds.pl The

[389-devel] Please review for lib389 ticket 47691 (2nd): lib389 support for RPM builds of 389-ds

2014-11-12 Thread thierry bordaz
Hello, This fix allows to run 389-DS CI tests when 389-ds is deployed as a rpm. It takes into account previous remarks done by Rich (no use of 'sudo' or 'systemctl'). The tests can be launched either being 'root' ('cd ds/dirsrvtests/tickets; py.test ') or with sudo ('cn

[389-devel] Please review ticket 47553: MODDN aci should be disabled by default

2014-10-30 Thread thierry bordaz
Hello, To be backward compatible the processing of 'moddn' aci should be disabled by default. So 'add' permission will still allow to moddn an entry under the target subtree. New 'moddn' permission in aci will be supported (aci not rejected) but not enforced during moddn.

[389-devel] Please review ticket 47901: After total init, nsds5replicaLastInitStatus can report an erroneous error status (like 'Referral')

2014-10-30 Thread thierry bordaz
https://fedorahosted.org/389/ticket/47901 https://fedorahosted.org/389/attachment/ticket/47901/0001-Ticket-47901-After-total-init-nsds5replicaLastInitSt.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review ticket 47553: new MODRDN acis trigger double 'n' in getEffectiveRights

2014-10-16 Thread thierry bordaz
https://fedorahosted.org/389/ticket/47553 https://fedorahosted.org/389/attachment/ticket/47553/0001-Ticket-47553-Enhance-ACIs-to-have-more-control-over-.3.patch https://fedorahosted.org/389/attachment/ticket/47553/0002-Ticket-47553-test-case.patch -- 389-devel mailing list

Re: [389-devel] 389-DS plugin: need some help on the design

2014-09-25 Thread thierry bordaz
On 09/25/2014 04:32 AM, Rich Megginson wrote: On 09/24/2014 04:33 AM, thierry bordaz wrote: Hello, I was investigating the alternative/impacts of a new plugin and I would like to share some thoughts and check I did not miss something important. Here is the description

Re: [389-devel] Please review lib389: start/stop may hand indefinitely

2014-09-08 Thread thierry bordaz
On 09/05/2014 06:50 PM, Rich Megginson wrote: On 09/05/2014 10:32 AM, thierry bordaz wrote: On 09/05/2014 01:10 PM, thierry bordaz wrote: Detected with testcase 47838 that defines ciphers not recognized during SSL init. 47838 testcase makes the full test suite to hang. -- 389-devel mailing

[389-devel] Please review Ticket 47871: 389-ds-base-1.3.2.21-1.fc20 crashed over the weekend

2014-08-21 Thread thierry bordaz
Ticket https://fedorahosted.org/389/ticket/47871 Fix: https://fedorahosted.org/389/attachment/ticket/47871/0001-Ticket-47871-389-ds-base-1.3.2.21-1.fc20-crashed-ove.patch Test case:

[389-devel] Please review ticket 47797: DB deadlock when two threads (on separated backend) try to record changes in retroCL

2014-07-10 Thread thierry bordaz
https://fedorahosted.org/389/ticket/47797 https://fedorahosted.org/389/attachment/ticket/47797/0001-Ticket-47797-DB-deadlock-when-two-threads-on-separat.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (2nd) ticket 47823: RFE enforce attributes uniqueness over several subtrees

2014-07-08 Thread thierry bordaz
Ticket is https://fedorahosted.org/389/ticket/47823 Fix is https://fedorahosted.org/389/attachment/ticket/47823/0002-Ticket-47823-attribute-uniqueness-enforced-on-all-su.patch Taking into account Rich review: * use of (Slapi_DN *) rather that (char *) * slapi_ch_free_string rather than

[389-devel] please review ticket 47787: A replicated MOD fails (Unwilling to perform) if it targets a tombstone

2014-04-25 Thread thierry bordaz
Bug is: https://fedorahosted.org/389/ticket/47787 Fix is : https://fedorahosted.org/389/attachment/ticket/47787/0001-Ticket-47787-A-replicated-MOD-fails-Unwilling-to-per.patch Test case: https://fedorahosted.org/389/attachment/ticket/47787/0001-Ticket-47787-test-case.patch -- 389-devel

[389-devel] please review ticket 47721: Schema replication issue (follow up and cleanup)

2014-04-22 Thread thierry bordaz
Core fix for https://fedorahosted.org/389/ticket/47721 is already reviewed/pushed. Additional cleanup is following up with the fix and CI tests that are broken https://fedorahosted.org/389/attachment/ticket/47721/0001-Ticket-47721-Schema-Replication-Issue-follow-up-clea.patch -- 389-devel

[389-devel] please review ticket 47721: Schema replication issue

2014-04-08 Thread thierry bordaz
Design is http://directory.fedoraproject.org/wiki/Replication_of_custom_schema_(ticket_47721) Fix is https://fedorahosted.org/389/attachment/ticket/47721/0001-Ticket-47721-Schema-Replication-Issue.patch Test case is

[389-devel] Please review ticket 47553: Enhance ACIs to have more control over MODRDN operations

2014-03-17 Thread thierry bordaz
The design for this ticket is http://directory.fedoraproject.org/wiki/Access_control_on_trees_specified_in_MODDN_operation The fix is https://fedorahosted.org/389/attachment/ticket/47553/0001-Ticket-47553-Enhance-ACIs-to-have-more-control-over-.patch The test case is:

Re: [389-devel] Design review: Access control on entries specified in MODDN operation (ticket 47553)

2014-02-25 Thread thierry bordaz
On 02/24/2014 11:35 PM, Rich Megginson wrote: On 02/24/2014 02:47 PM, Noriko Hosoi wrote: Rich Megginson wrote: On 02/24/2014 09:00 AM, thierry bordaz wrote: Hello, IPA team filled this ticket https://fedorahosted.org/389/ticket/47553. It requires an ACI improvement so

[389-devel] 389-DS ACI improvement to control MODDN

2014-02-25 Thread thierry bordaz
Hello, Ticket https://fedorahosted.org/389/ticket/47553, is a 389-ds enhancement to allow a finer access control during a MODDN (new superior) operation. The use case being to allow/deny a bound user to move an entry from one specified part of the DIT to an other part. This

  1   2   >