Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-14 Thread Javier Martinez Canillas
On Thu, Jan 14, 2021 at 10:48 AM Chris Murphy wrote: > > > > On Thu, Jan 14, 2021, 2:24 AM Vitaly Zaitsev via devel > wrote: >> >> On 31.12.2020 13:36, Javier Martinez Canillas wrote: >> > I'll update the proposal based on the feedback. >> >> And what about users, who use Fedora with other

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-14 Thread Chris Murphy
On Thu, Jan 14, 2021, 2:24 AM Vitaly Zaitsev via devel < devel@lists.fedoraproject.org> wrote: > On 31.12.2020 13:36, Javier Martinez Canillas wrote: > > I'll update the proposal based on the feedback. > > And what about users, who use Fedora with other GNU/Linux distributions? > These

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-14 Thread Vitaly Zaitsev via devel
On 31.12.2020 13:36, Javier Martinez Canillas wrote: I'll update the proposal based on the feedback. And what about users, who use Fedora with other GNU/Linux distributions? These distributions can also switch to the same GRUB2 configuration. They will all start fighting for the same file.

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-14 Thread Chris Murphy
On Thu, Jan 14, 2021 at 12:35 AM Guido Aulisi wrote: > IMHO boot loaders should not write to filesystems, if this is needed to > hide the GRUB menu when boot is successful, then let's display it > always as it was one time. I don't think it we should follow Windows or > MacOS style here, the boot

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-13 Thread Guido Aulisi
Hi, Il giorno mer, 13/01/2021 alle 13.46 -0700, Chris Murphy ha scritto: > On Tue, Jan 12, 2021 at 8:48 PM Michel Alexandre Salim > wrote: ... snip > There are separate issues. > > grubenv is "OK" on ext4 and XFS. The issue is that none of the file > systems developers like anything other

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-13 Thread Chris Adams
Once upon a time, Chris Murphy said: > The issue with journaled file systems is that GRUB's file system > drivers have no ability to do journal replay. Therefore there is a > small risk the file system is rendered unbootable in a crash, because > the bootloader only sees the no-replay state of

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-13 Thread Chris Murphy
On Tue, Jan 12, 2021 at 10:06 PM Javier Martinez Canillas wrote: > > The thing is that implementing this proposal should be straightforward > and something that could be done for F34 but solving the grubenv issue > will require more time, since we first will need to agree with GRUB > upstream on

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-13 Thread Chris Murphy
On Tue, Jan 12, 2021 at 8:48 PM Michel Alexandre Salim wrote: > > Hi, > > > On Tue, 2021-01-12 at 19:56 +0100, Hans de Goede wrote: > > So I've read Neal's comment there and what he describes really > > is a special corner case, but yes it is possible for people to have > > created the special

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-12 Thread Javier Martinez Canillas
On Wed, Jan 13, 2021 at 4:48 AM Michel Alexandre Salim wrote: [snip] > > As discussed in detail here: > > https://pagure.io/fedora-workstation/issue/206 > > we really should be moving away from that. As discussed there Suse > > already has grub-patches to instead store the grubenv in an part of

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-12 Thread Javier Martinez Canillas
On Tue, Jan 12, 2021 at 8:24 PM Brian C. Lane wrote: [snip] > > > > The `$prefix` variable will be set to the device partition where > > `/boot/grub2/grub.cfg` is stored, using the partition filesystem's > > Universally Unique IDentifier (UUID). That way the correct GRUB > > configuration file

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-12 Thread Michel Alexandre Salim
Hi, On Tue, 2021-01-12 at 19:56 +0100, Hans de Goede wrote: > Hi, > > On 1/12/21 5:55 PM, Michel Alexandre Salim wrote: > > Hi, > > > > Thanks for the thorough reply, Hans! One question inline > > > > On Tue, 2021-01-05 at 12:31 +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 12/30/20

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-12 Thread Brian C. Lane
On Wed, Dec 30, 2020 at 02:53:00PM -0500, Ben Cotton wrote: [snip] > The proposal is to always store the `grub.cfg` and `grubenv` files in > the `/boot/grub2/` directory, making `/boot/efi/EFI/fedora/grub.cfg` > to only be a small configuration file that sets a different `$prefix` > variable and

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-12 Thread Hans de Goede
Hi, On 1/12/21 5:55 PM, Michel Alexandre Salim wrote: > Hi, > > Thanks for the thorough reply, Hans! One question inline > > On Tue, 2021-01-05 at 12:31 +0100, Hans de Goede wrote: >> Hi, >> >> On 12/30/20 11:52 PM, Neal Gompa wrote: >>> On Wed, Dec 30, 2020 at 5:48 PM Marius Schwarz < >>>

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-12 Thread Michel Alexandre Salim
Hi, Thanks for the thorough reply, Hans! One question inline On Tue, 2021-01-05 at 12:31 +0100, Hans de Goede wrote: > Hi, > > On 12/30/20 11:52 PM, Neal Gompa wrote: > > On Wed, Dec 30, 2020 at 5:48 PM Marius Schwarz < > > fedora...@cloud-foo.de> wrote: > > > > > > Am 30.12.20 um 22:14

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-05 Thread Gerd Hoffmann
On Thu, Dec 31, 2020 at 06:28:22PM +0800, Qiyu Yan wrote: > Vitaly Zaitsev via devel > 于2020年12月31日周四 下午6:12写道: > > > > On 30.12.2020 20:53, Ben Cotton wrote: > > > This change makes the GRUB configuration files layout to be consistent > > > across all the supported architectures. Currently EFI

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2021-01-05 Thread Hans de Goede
Hi, On 12/30/20 11:52 PM, Neal Gompa wrote: > On Wed, Dec 30, 2020 at 5:48 PM Marius Schwarz wrote: >> >> Am 30.12.20 um 22:14 schrieb Michel Alexandre Salim: >>> - a separate partition for storing GRUB config, no matter what >>> architecture, is probably the ideal solution >> Not always. In VMs

Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/UnifyGrubConfig == Summary == This change makes the GRUB configuration files layout to be consistent across all the supported architectures. Currently EFI is a special case since the GRUB configuration file and environment variables block are stored in the

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Javier Martinez Canillas
On Thu, Dec 31, 2020 at 12:54 PM Vitaly Zaitsev via devel wrote: > > On 31.12.2020 12:37, Peter Robinson wrote: > > Of course it could, who do you propose to do that work and support all > > the various options and code required? > It can be easily installed during Fedora installation by

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Javier Martinez Canillas
Hello Tomasz, On Thu, Dec 31, 2020 at 10:55 AM Tomasz Torcz wrote: [snip] > > I think either never fixing this, or never updating systems to the > > "new way" are both untenable. We saw with the BLS switch many users > > depend on doing in place upgrades. Many were pushing 4 or more years. > >

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Javier Martinez Canillas
Hello Chris, Thanks a lot for the comments. On Thu, Dec 31, 2020 at 1:02 AM Chris Murphy wrote: [snip] > > That problem was the result of quite old core.img in the MBR gap (or > BIOS Boot partition). As that change simultaneously depended on > shipping a new GRUB module without a way to

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Vitaly Zaitsev via devel
On 31.12.2020 12:37, Peter Robinson wrote: Of course it could, who do you propose to do that work and support all the various options and code required? It can be easily installed during Fedora installation by executing the following: 1. Make sure the ESP partition has more than 512 MB of

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Peter Robinson
On Thu, Dec 31, 2020 at 11:29 AM Vitaly Zaitsev via devel wrote: > > On 31.12.2020 11:50, Peter Robinson wrote: > > Because it doesn't support traditional BIOS boot, or the boot systems > > of POWER, Z-series and numerous other corner cases. Just look at the > > thread about BIOS support from a

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Vitaly Zaitsev via devel
On 31.12.2020 11:50, Peter Robinson wrote: Because it doesn't support traditional BIOS boot, or the boot systems of POWER, Z-series and numerous other corner cases. Just look at the thread about BIOS support from a few months ago to see how controversial even considering that was. If we then

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Peter Robinson
On Thu, Dec 31, 2020 at 10:10 AM Vitaly Zaitsev via devel wrote: > > On 30.12.2020 20:53, Ben Cotton wrote: > > This change makes the GRUB configuration files layout to be consistent > > across all the supported architectures. Currently EFI is a special > > case since the GRUB configuration file

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Vitaly Zaitsev via devel
On 31.12.2020 11:28, Qiyu Yan wrote: iirc systemd-boot don't support legacy BIOS system. Yes of course. Systemd-boot is not a bootloader. It is an EFIStub kernel manager with a simple menu. I've been using systemd-boot for over 1.5 years and it works great. It can only be enabled for

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Qiyu Yan
Vitaly Zaitsev via devel 于2020年12月31日周四 下午6:12写道: > > On 30.12.2020 20:53, Ben Cotton wrote: > > This change makes the GRUB configuration files layout to be consistent > > across all the supported architectures. Currently EFI is a special > > case since the GRUB configuration file and environment

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Vitaly Zaitsev via devel
On 30.12.2020 20:53, Ben Cotton wrote: The proposal is to always store the `grub.cfg` and `grubenv` files in the `/boot/grub2/` directory, making `/boot/efi/EFI/fedora/grub.cfg` to only be a small configuration file that sets a different `$prefix` variable and loads the configuration file stored

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Vitaly Zaitsev via devel
On 30.12.2020 20:53, Ben Cotton wrote: This change makes the GRUB configuration files layout to be consistent across all the supported architectures. Currently EFI is a special case since the GRUB configuration file and environment variables block are stored in the EFI System Partition (ESP)

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-31 Thread Tomasz Torcz
On Wed, Dec 30, 2020 at 05:08:03PM -0700, Chris Murphy wrote: > > Upgrades of customized configurations that deviate significantly from > > defaults aren't supported. It's best effort. We can't be blocking on > > people's customizations. > > > > I think we can come pretty close to atomically

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Chris Murphy
On Wed, Dec 30, 2020 at 5:01 PM Chris Murphy wrote: > > On Wed, Dec 30, 2020 at 2:09 PM Javier Martinez Canillas > wrote: > > > On Wed, Dec 30, 2020 at 9:22 PM Adam Williamson > > wrote: > > > > * We wouldn't have a "consistent configuration" across everybody, > > > really, because anyone who

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Chris Murphy
On Wed, Dec 30, 2020 at 2:09 PM Javier Martinez Canillas wrote: > On Wed, Dec 30, 2020 at 9:22 PM Adam Williamson > wrote: > > * We wouldn't have a "consistent configuration" across everybody, > > really, because anyone who upgraded from pre-F34 would still have the > > old config; every

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Neal Gompa
On Wed, Dec 30, 2020 at 5:48 PM Marius Schwarz wrote: > > Am 30.12.20 um 22:14 schrieb Michel Alexandre Salim: > > - a separate partition for storing GRUB config, no matter what > > architecture, is probably the ideal solution > Not always. In VMs you would reduce the amount of partitions to ease

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Marius Schwarz
Am 30.12.20 um 22:14 schrieb Michel Alexandre Salim: - a separate partition for storing GRUB config, no matter what architecture, is probably the ideal solution Not always. In VMs you would reduce the amount of partitions to ease up things. The main problem with Vms is, that you have LTS based

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Matthew Miller
On Wed, Dec 30, 2020 at 10:08:31PM +0100, Javier Martinez Canillas wrote: > That's why I went with the conservative approach of only do this for > new installs, to prevent breaking users configuration (or even worse, > their booting). Maybe a middle ground could be to provide a tool for > users to

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Michel Alexandre Salim
On Wed, 2020-12-30 at 12:21 -0800, Adam Williamson wrote: > On Wed, 2020-12-30 at 14:53 -0500, Ben Cotton wrote: > > == Benefit to Fedora == > > > > This change will not only simplify and make less confusing the GRUB > > configuration but also allow the following improvements: > > > > * To have

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Javier Martinez Canillas
Hello Adam, Thanks a lot for your feedback. On Wed, Dec 30, 2020 at 9:22 PM Adam Williamson wrote: > [snip] > > == Upgrade/compatibility impact == > > > > The changes will only be for new installations, existing systems will > > not be impacted and will continue using the grub.cfg and grubenv

Re: Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Adam Williamson
On Wed, 2020-12-30 at 14:53 -0500, Ben Cotton wrote: > == Benefit to Fedora == > > This change will not only simplify and make less confusing the GRUB > configuration but also allow the following improvements: > > * To have a consistent configuration across all the architectures using GRUB. > *

Fedora 34 Change: Unify the GRUB configuration files location across all supported architectures (System-Wide Change proposal)

2020-12-30 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/UnifyGrubConfig == Summary == This change makes the GRUB configuration files layout to be consistent across all the supported architectures. Currently EFI is a special case since the GRUB configuration file and environment variables block are stored in the