Re: Packages which needlessly use %defattr

2018-07-30 Thread Igor Gnatenko
On Mon, Jul 30, 2018 at 11:01 AM Miroslav Suchý wrote: > Dne 4.7.2018 v 12:18 Zbigniew Jędrzejewski-Szmek napsal(a): > > What about just doing a mass specfile update now? I think asking > > individual maintainers to fix their packages isn't worth their > > time. > > -1 > > I like the Jason

Re: Packages which needlessly use %defattr

2018-07-30 Thread Miroslav Suchý
Dne 4.7.2018 v 12:18 Zbigniew Jędrzejewski-Szmek napsal(a): > What about just doing a mass specfile update now? I think asking > individual maintainers to fix their packages isn't worth their > time. -1 I like the Jason attitude much more. It gives time to discuss it. To find false positives.

Re: Packages which needlessly use %defattr

2018-07-10 Thread Kevin Fenzi
On 07/10/2018 08:53 AM, Miro Hrončok wrote: > On 10.7.2018 17:45, Till Maas wrote: >> Hi, >> >> On Tue, Jul 10, 2018 at 10:36:08AM -0500, Jason L Tibbitts III wrote: >> >>> I haven't written any scripts which modify specfiles, only scripts which >>> find issues.  And in any case: >>> >>>

Re: Packages which needlessly use %defattr

2018-07-10 Thread Jason L Tibbitts III
In case it wasn't obvious from all of the commit messages, I did go ahead and remove many needless %defattr directives from a large number of packages a few hours ago. I used the output of the find-needless-defattr script from https://pagure.io/fedora-misc-package-utilities as a guide for which

Re: Packages which needlessly use %defattr

2018-07-10 Thread Miro Hrončok
On 10.7.2018 17:45, Till Maas wrote: Hi, On Tue, Jul 10, 2018 at 10:36:08AM -0500, Jason L Tibbitts III wrote: I haven't written any scripts which modify specfiles, only scripts which find issues. And in any case: https://fedoraproject.org/wiki/Mass_package_changes#Automated_cleanup

Re: Packages which needlessly use %defattr

2018-07-10 Thread Till Maas
Hi, On Tue, Jul 10, 2018 at 10:36:08AM -0500, Jason L Tibbitts III wrote: > I haven't written any scripts which modify specfiles, only scripts which > find issues. And in any case: > > https://fedoraproject.org/wiki/Mass_package_changes#Automated_cleanup > > Besides... this is git. And

Re: Packages which needlessly use %defattr

2018-07-10 Thread Jason L Tibbitts III
> "NK" == Nico Kadel-Garcia writes: NK> Would you please post, or post a link to, your updated filter NK> script? It remains at https://pagure.io/fedora-misc-package-utilities : https://pagure.io/fedora-misc-package-utilities/blob/master/f/find-needless-defattr I currently have no unpushed

Re: Packages which needlessly use %defattr

2018-07-10 Thread Nico Kadel-Garcia
On Mon, Jul 9, 2018 at 7:53 PM, Jason L Tibbitts III wrote: >> "KF" == Kevin Fenzi writes: > > KF> I agree. If this could be done before mass rebuild we can catch any > KF> issues/typos/mistakes in this with the mass rebuild. > > I've been away from computers for a bit, but I could certainly

Re: Packages which needlessly use %defattr

2018-07-09 Thread Jason L Tibbitts III
> "KF" == Kevin Fenzi writes: KF> I agree. If this could be done before mass rebuild we can catch any KF> issues/typos/mistakes in this with the mass rebuild. I've been away from computers for a bit, but I could certainly do this without too much effort. I just know that some people are

Re: Packages which needlessly use %defattr

2018-07-08 Thread Matthew Miller
On Mon, Jul 09, 2018 at 02:35:39AM +0200, Kevin Kofler wrote: > > "%defattr(-,root,root,-)" as the initial line in a %files section even > > though this has not been needed for well over a decade now. This > > construct even appears in new specfiles, perhaps because it appears in > > so many

Re: Packages which needlessly use %defattr

2018-07-08 Thread Nico Kadel-Garcia
On Wed, Jul 4, 2018 at 2:59 AM, Jonny Heggheim wrote: > Hi Nico. > > > On 07/04/2018 03:58 AM, Nico Kadel-Garcia wrote: >> Yeah, but since it's many thousands of packages, I think maybe you >> didn't have to send the whole list? > I like that he sent the whole list, then I can search for my

Re: Packages which needlessly use %defattr

2018-07-08 Thread Kevin Kofler
Jason L Tibbitts III wrote: > In a %files section of a specfile, the %defattr directive is used to set > the default file ownership and permissions. RPM has provided a sensible > default since version 4.4 (which predates FC6 and RHEL5), but very many > specfiles still include an initial %defattr

Re: Packages which needlessly use %defattr

2018-07-07 Thread Kevin Fenzi
On 07/04/2018 03:18 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jul 03, 2018 at 02:02:16PM -0500, Jason L Tibbitts III wrote: >> I ran the find-needless-defattr command from >> https://pagure.io/fedora-misc-package-utilities to find specfiles which >> include a non-default-changing %defattr

Re: Packages which needlessly use %defattr

2018-07-04 Thread Sergio Durigan Junior
On Wednesday, July 04 2018, Jonny Heggheim wrote: > On 07/04/2018 03:58 AM, Nico Kadel-Garcia wrote: >> Yeah, but since it's many thousands of packages, I think maybe you >> didn't have to send the whole list? > I like that he sent the whole list, then I can search for my username > and check if

Re: Packages which needlessly use %defattr

2018-07-04 Thread Todd Zullinger
Jan Kratochvil wrote: > On Wed, 04 Jul 2018 12:18:00 +0200, Zbigniew Jędrzejewski-Szmek wrote: >> What about just doing a mass specfile update now? I think asking >> individual maintainers to fix their packages isn't worth their >> time. It's a safe change, > > Is it? I haven't found whether this

Re: Packages which needlessly use %defattr

2018-07-04 Thread Jan Kratochvil
On Wed, 04 Jul 2018 12:18:00 +0200, Zbigniew Jędrzejewski-Szmek wrote: > What about just doing a mass specfile update now? I think asking > individual maintainers to fix their packages isn't worth their > time. It's a safe change, Is it? I haven't found whether this change is compatible with

Re: Packages which needlessly use %defattr

2018-07-04 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jul 03, 2018 at 02:02:16PM -0500, Jason L Tibbitts III wrote: > I ran the find-needless-defattr command from > https://pagure.io/fedora-misc-package-utilities to find specfiles which > include a non-default-changing %defattr as the first line of a %files > section. This found 2513

Re: Packages which needlessly use %defattr

2018-07-04 Thread Jonny Heggheim
Hi Nico. On 07/04/2018 03:58 AM, Nico Kadel-Garcia wrote: > Yeah, but since it's many thousands of packages, I think maybe you > didn't have to send the whole list? I like that he sent the whole list, then I can search for my username and check if I am on the list. > It's been useful for

Re: Packages which needlessly use %defattr

2018-07-03 Thread Scott Talbert
On Tue, 3 Jul 2018, Nico Kadel-Garcia wrote: In a %files section of a specfile, the %defattr directive is used to set the default file ownership and permissions. RPM has provided a sensible default since version 4.4 (which predates FC6 and RHEL5), but very many specfiles still include an

Re: Packages which needlessly use %defattr

2018-07-03 Thread Nico Kadel-Garcia
On Tue, Jul 3, 2018 at 3:02 PM, Jason L Tibbitts III wrote: > In a %files section of a specfile, the %defattr directive is used to set > the default file ownership and permissions. RPM has provided a sensible > default since version 4.4 (which predates FC6 and RHEL5), but very many > specfiles