On Tue, Sep 17, 2013 at 03:57:55PM +0200, Michal Toman wrote:
 > In last two weeks these components were crashing the most:
 > 
 > 1. kernel seen 85925 times (52% of all reports)
 >     https://retrace.fedoraproject.org/faf/problems/1174076/
 >     https://retrace.fedoraproject.org/faf/problems/1209703/

I've noticed a problem in your code that attributes blame to the
'function' field.   In that second trace:

Call Trace:
 [<c043e33b>] ? print_hardware_dmi_name+0x2b/0x30
 [<c043e3a3>] warn_slowpath_common+0x63/0x80
 [<f7ea8413>] ? carl9170_op_tx+0x733/0x810 [carl9170]
 [<f7ea8413>] ? carl9170_op_tx+0x733/0x810 [carl9170]
 [<c043e462>] warn_slowpath_null+0x22/0x30
 [<f7ea8413>] carl9170_op_tx+0x733/0x810 [carl9170]

the '?' fields are junk on the stack, and not actually the functions we're in.
Instead of blaming print_hardware_dmi_name, this trace should be attributed
to carl9170_op_tx.  Everything else above that is either noise on the stack
from previous calls, or parts of the "dump trace" logic.

I'd ignore the ? functions completely for this purpose.

        Dave

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Reply via email to