Re: [389-devel] Please review: make sure the DBVERSION file ends in a newline

2011-08-10 Thread Noriko Hosoi
ack. Thanks, Rich!! --noriko Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Introducing an environment variable USE_VALGRIND to clean up the entry cache and dn cache on exit.

2011-08-31 Thread Noriko Hosoi
From 40ac246939d8e7bf8138c85ea00f30beece094d5 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi nho...@jiji.usersys.redhat.com Date: Wed, 31 Aug 2011 11:09:42 -0700 Subject: [PATCH] Introducing an environment variable USE_VALGRIND to clean up the entry cache and dn cache on exit. --- ldap/servers/slapd

Re: [389-devel] Please review: Make all backend operations transaction aware

2011-09-15 Thread Noriko Hosoi
Rich Megginson wrote: http://rmeggins.fedorapeople.org/patches/0001-Make-all-backend-operations-transaction-aware.patch ack. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: convert memberof to use transactions

2011-10-06 Thread Noriko Hosoi
Rich Megginson wrote: There are 3 patches. 0001 fixes a problem with betxn and modrdn to make the ENTRY_POST_OP available to betxnpostop plugins. 0002 allows us to pass the plugin config entry to plugin_init functions (yay! finally!). 0003 is the actual change to memberof. ack. ack. ack.

[389-devel] Please review: Fix Coverity Defects

2011-11-02 Thread Noriko Hosoi
://bugzilla.redhat.com/attachment.cgi?id=531392 (1.04 KB, patch) 2011-11-02 13:05 EDT https://bugzilla.redhat.com/show_bug.cgi?id=750625#attach_531392, Noriko Hosoi mailto:nho...@redhat.com nhosoi: review? Details https://bugzilla.redhat.com/attachment.cgi?id=531392action=edit | Diff https

[389-devel] Please review: [Bug 750625] Fix Coverity minor defects

2011-11-03 Thread Noriko Hosoi
=750625#attach_531631, Noriko Hosoi mailto:nho...@redhat.com nhosoi: review? Details https://bugzilla.redhat.com/attachment.cgi?id=531631action=edit | Diff https://bugzilla.redhat.com/attachment.cgi?id=531631action=diff *Fix Coverity (11062) Resource leak; git patch file (master)* https

[389-devel] Please review: [Bug 619595] Upgrading sub suffix under non-normalized suffix disappears

2010-07-30 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=619595 https://bugzilla.redhat.com/attachment.cgi?id=435442action=diff https://bugzilla.redhat.com/attachment.cgi?id=435442action=edit Fix Description: The cause of this problem is the config attribute nsslapd-parent-suffix was not defined as an

[389-devel] Please review: [Bug 616608] SIGBUS in RDN index reads on platforms with strict alignments

2010-07-30 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=616608 https://bugzilla.redhat.com/attachment.cgi?id=434877action=diff https://bugzilla.redhat.com/attachment.cgi?id=434877action=edit Fix description: Use the marshall/unmarshall technique for the entryrdn index data. Introduced

[389-devel] Please review: [Bug 194531] db2bak is too noisy

2010-08-05 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=194531 https://bugzilla.redhat.com/attachment.cgi?id=436980action=diff https://bugzilla.redhat.com/attachment.cgi?id=436980action=edit Description: Added -v option to db2bak and bak2db and moved the Backing up/ Restoring logs to the verbose mode

[389-devel] Please review: [Bug 621928] Unable to enable replica (rdn problem?) on 1.2.6 rc6

2010-08-09 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=621928 https://bugzilla.redhat.com/attachment.cgi?id=437670action=diff https://bugzilla.redhat.com/attachment.cgi?id=437670action=edit Description: RUV (nsuniqueid=---,suffix) needs to be allowed to add to the DB

[389-devel] Please review: [Bug 622628] fix coverity Defect Type: Integer handling issues

2010-08-10 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=622628 https://bugzilla.redhat.com/attachment.cgi?id=437950action=diff https://bugzilla.redhat.com/attachment.cgi?id=437950action=edit https://bugzilla.redhat.com/attachment.cgi?id=437952action=diff

[389-devel] Please review: [Bug 622903] fix coverity Defect Type: Code maintainability issues

2010-08-11 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=622903 https://bugzilla.redhat.com/attachment.cgi?id=437967action=diff https://bugzilla.redhat.com/attachment.cgi?id=437967action=edit https://bugzilla.redhat.com/attachment.cgi?id=437971action=diff

[389-devel] Please review: [Bug 629710] escape_string does not check '\HEXHEX'

2010-09-02 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=629710 https://bugzilla.redhat.com/attachment.cgi?id=442728action=diff https://bugzilla.redhat.com/attachment.cgi?id=442728action=edit Description: do_escape_string (core of escape_string) converts '\\ (backslash)' to '\5C' even if the following 2

[389-devel] Please review: [Bug 625014] SubTree Renames: ModRDN operation fails and the server hangs if the entry is moved to under the same DN.

2010-09-13 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=625014 https://bugzilla.redhat.com/attachment.cgi?id=447045action=diff https://bugzilla.redhat.com/attachment.cgi?id=447045action=edit Description: adding a check if the newsuperior is the entry itself or its descendent. If it is, modrdn returns

Re: [389-devel] Please review: Only check modrdn ops for backend/suffix correctness if not the default backend

2010-09-13 Thread Noriko Hosoi
On 09/13/2010 03:42 PM, Rich Megginson wrote: This fix allows the datainterop tests to pass at 100% ack. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel smime.p7s Description: S/MIME Cryptographic Signature

Re: [389-devel] 1.2.6-1 crash

2010-09-29 Thread Noriko Hosoi
On 09/29/2010 12:49 PM, Rich Megginson wrote: Gary Morris wrote: ah.. sorry.. ok.. just retried with 1.2.6.1-1.. / [r...@dalp-ct02 logs]# rpm -qa | grep 389 389-dsgw-1.1.5-1.fc13.x86_64 389-admin-console-1.1.5-1.fc13.noarch 389-admin-1.1.11-1.fc13.x86_64 389-ds-base-1.2.6.1-1.fc13.x86_64

Re: [389-devel] 1.2.6-1 crash

2010-09-29 Thread Noriko Hosoi
) thread apply all bt On 09/29/2010 01:29 PM, Gary Morris wrote: sure.. i'll do that and rerun them.. On Wed, Sep 29, 2010 at 4:25 PM, Noriko Hosoi nho...@redhat.com mailto:nho...@redhat.com wrote: On 09/29/2010 12:49 PM, Rich Megginson wrote: Gary Morris wrote: ah

[389-devel] Please review (take 2): [Bug 602456] Allow to add any cn=config attributes; allow to delete some cn=config attributes

2010-10-13 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=602456 https://bugzilla.redhat.com/attachment.cgi?id=453261action=diff https://bugzilla.redhat.com/attachment.cgi?id=453261action=edit Thanks to Nathan for his review on the first proposal. I'm adding this change following Rich's suggestion.

[389-devel] Please review: [Bug 244229] targetattr not verified against schema when setting an aci

2010-10-14 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=244229 https://bugzilla.redhat.com/attachment.cgi?id=453598action=diff https://bugzilla.redhat.com/attachment.cgi?id=453598action=edi Description: 1. When acl contains targetattr keyword: (targetattr [!]= attribute_1 || attribute_2 ...||

[389-devel] Please review (take 2): [Bug 244229] targetattr not verified against schema when setting an aci

2010-10-15 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=244229 https://bugzilla.redhat.com/attachment.cgi?id=453769action=diff https://bugzilla.redhat.com/attachment.cgi?id=453769action=edit Following the comments by Rich, revised the proposal so that: 1) the error message is sent to the client, as well.

[389-devel] Please review: [Bug 567282] server can not abandon searchRequest of simple paged results

2010-11-03 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=567282 https://bugzilla.redhat.com/attachment.cgi?id=457550action=edit https://bugzilla.redhat.com/attachment.cgi?id=457550action=diff Description: Simple Paged Results search keeps the connection per paging, but not an operation. When an abandon

[389-devel] Please review (take 2): [389 Project] #453: db2index with -tattrname:type, type fails

2012-10-03 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/453 https://fedorahosted.org/389/attachment/ticket/453/0001-Trac-Ticket-453-db2index-with-tattrname-type-type-fa.patch Fix Description: 1) db2index and db2index.pl did not handle options with no space between the option type and the value. This patch properly

[389-devel] Resending...: Please review: [389 Project] #537: Improvement of range search

2013-01-09 Thread Noriko Hosoi
(2013/01/07 15:57), Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/537 https://fedorahosted.org/389/attachment/ticket/537/0001-Ticket-537-Improvement-of-range-search.patch Fix description: The index range search function index_range _read_ext was written to call idl_fetch_ext

[389-devel] Please review: [Bug 557224] subtree rename breaks the referential integrity plug-in

2010-01-26 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=557224 Description of problem: Analysis by andrey.iva...@polytechnique.fr I'm pretty sure the referential integrity plug-in will not work for modrdn operations with a new superior. Looking more thoroughly through the code ( ldap / servers / plugins

[389-devel] Please review (revised): [Bug 560827] Admin Server templates: DistinguishName validation fails

2010-02-03 Thread Noriko Hosoi
Thanks to Rich and Nathan for their comments and even debugging my code :). I revised the proposal based upon their suggestions. Summary: Admin Server templates: DistinguishName validation fails https://bugzilla.redhat.com/show_bug.cgi?id=560827 Description of problem: Some template file

[389-devel] Please review: [Bug 527848] make sure db upgrade to 4.7 and later works correctly

2010-02-18 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=527848 Subject: make sure db upgrade to 4.7 and later works correctly Proposed Fix: https://bugzilla.redhat.com/attachment.cgi?id=395003action=diff Change Description: https://bugzilla.redhat.com/attachment.cgi?id=395003action=edit Thanks, --noriko

[389-devel] Please review (take 2): [Bug 570667] MMR: simultaneous total updates on the masters cause deadlock and data loss

2010-03-05 Thread Noriko Hosoi
Subject: MMR: simultaneous total updates on the masters cause deadlock and data loss https://bugzilla.redhat.com/show_bug.cgi?id=570667 [Revised proposal] -- (https://bugzilla.redhat.com/attachment.cgi?id=398089) git patch file I revised the previous patch to allow sending simultaneous

Re: [389-devel] Please review: cleanup build warnings

2010-03-05 Thread Noriko Hosoi
On 03/05/2010 02:56 PM, Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. --noriko smime.p7s Description: S/MIME Cryptographic Signature -- 389-devel mailing list

[389-devel] Please review: [Bug 199923] subtree search fails to find items under a db containing special characters

2010-03-08 Thread Noriko Hosoi
Subject: subtree search fails to find items under a db containing special characters https://bugzilla.redhat.com/show_bug.cgi?id=199923 This bug had been reopened due to the regression. [Proposed Fix] https://bugzilla.redhat.com/attachment.cgi?id=398612action=diff

Re: [389-devel] Please review: Add support for additional schema/matching rules included with 389

2010-03-09 Thread Noriko Hosoi
(2010?03?08? 19:54), Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] Please review (take 2): [Bug 199923] subtree search fails to find items under a db containing special characters

2010-03-10 Thread Noriko Hosoi
Subject: subtree search fails to find items under a db containing special characters https://bugzilla.redhat.com/show_bug.cgi?id=199923 Files: ldap/servers/plugins/syntaxes/validate.c ldap/servers/slapd/back-ldbm/ldbm_add.c ldap/servers/slapd/dn.c Fix Description: dn.c: Based upon RFC

Re: [389-devel] DN normalisation design document

2010-03-17 Thread Noriko Hosoi
On 03/17/2010 01:13 PM, Andrey Ivanov wrote: In order to support Old DN format including DN in the double quotes another cn=config switch may be necessary. It seems there was recently a new switch introduced to make the dn syntax validation a little more relaxed -

Re: [389-devel] Please Review: Fix parsing of start-slapd scripts

2010-04-01 Thread Noriko Hosoi
On 04/01/2010 11:18 AM, Nathan Kinder wrote: On 03/31/2010 10:04 PM, Nathan Kinder wrote: On 03/31/2010 09:52 PM, Endi Sukma Dewata wrote: - Nathan Kindernkin...@redhat.com wrote: The admin server CGIs parse the start-slapd scripts to determine the DS instance names. A recent format

[389-devel] Please review: [389 Project] #605: support TLS 1.1 - adding backward compatibility

2013-12-04 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/605 https://fedorahosted.org/389/attachment/ticket/605/0001-Ticket-605-support-TLS-1.1-adding-backward-compatibi.patch Description: commit 88d4beccb9d9f7bb89f5e24c47828d7516ba7ca8 always expected the NSS version supporting TLS 1.2. It broke the build on

[389-devel] Please review: [Bug 651571] When attrcrypt is on, entrydn is stored in the backend db

2010-11-09 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=651571 https://bugzilla.redhat.com/attachment.cgi?id=459236action=diff https://bugzilla.redhat.com/attachment.cgi?id=459236action=edit Description: If an entry contains a to-be-encrypted attribute, id2entry_add_ext handles a copy of the entry in

[389-devel] Please review: [Bug 182507] clear-password mod from replica is discarded before changelogged

2010-12-07 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=182507 https://bugzilla.redhat.com/attachment.cgi?id=467113action=diff https://bugzilla.redhat.com/attachment.cgi?id=467113action=edit Description: Replication drops unhashed passwords which is necessary for the AD password sync. This patch allows

Re: [389-devel] Please review: [Bug 182507] clear-password mod from replica is discarded before changelogged

2010-12-14 Thread Noriko Hosoi
Hi Andrey, Andrey Ivanov wrote: Hi Noriko, i've read the changelog encryption design document. Indeed, it's a sound idea to make AD-389 replication more robust. I have two questions about it: * if i understand correctly you say that the server needs a certificate in order to generate

[389-devel] Please review: [Bug 616850] ldapmodify failed to reject the replace operation if its targeted for an Unknown attribute

2011-01-19 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=616850 https://bugzilla.redhat.com/attachment.cgi?id=474335action=diff https://bugzilla.redhat.com/attachment.cgi?id=474335action=edit Description: Attempting to modify an unknown attribute in the config entry fails with LDAP_UNWILLING_TO_PERFORM,

[389-devel] Please review (admin server): [Bug 616260] libds-admin-serv linking fails due to unresolved link-time dependencies

2011-02-04 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=616260 https://bugzilla.redhat.com/attachment.cgi?id=476923action=diff https://bugzilla.redhat.com/attachment.cgi?id=476923action=edit Description: 1) Do not use nodist_property_DATA for ICU resource files, but use BUILT_SOURCES to keep them just

[389-devel] Please review: [Bug 675265] preventryusn gets added to entries on a failed delete

2011-02-07 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=675265 https://bugzilla.redhat.com/attachment.cgi?id=477486action=diff https://bugzilla.redhat.com/attachment.cgi?id=477486action=edit Description: When an entry is deleted with Entry USN plugin enabled, an operational attribute preventryusn is added

[389-devel] Please review (take 3) Admin Server: [Bug 245278] Changing to a password with a single quote does not work

2011-02-12 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=245278 https://bugzilla.redhat.com/attachment.cgi?id=478422action=diff https://bugzilla.redhat.com/attachment.cgi?id=478422action=edit Thanks to Rich for his comments. Instead of doing the in-place escape, changed to duplicate the given password and

[389-devel] Please review: [Bug 668909] Can't modify replication agreement in some cases

2011-03-11 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=668909 https://bugzilla.redhat.com/attachment.cgi?id=483808action=diff https://bugzilla.redhat.com/attachment.cgi?id=483808action=edit Description: Code to modify nsds5ReplicaPort in replication agreement was not implemented. This patch adds it. When

[389-devel] Please review: [Bug 684996] Exported tombstone cannot be imported correctly.

2011-03-17 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=684996 https://bugzilla.redhat.com/attachment.cgi?id=486083action=diff https://bugzilla.redhat.com/attachment.cgi?id=486083action=edit Description: When nsslapd-subtree-rename-switch is on, a tombstone entry has a special RDN which looks like this:

[389-devel] Please review: [Bug 689866] ns-newpwpolicy.pl needs to use the new DN format

2011-03-22 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=689866 https://bugzilla.redhat.com/attachment.cgi?id=486852action=diff https://bugzilla.redhat.com/attachment.cgi?id=486852action=diff https://bugzilla.redhat.com/attachment.cgi?id=486852action=edit

Re: [389-devel] Please review: add skin support to admin server

2011-06-16 Thread Noriko Hosoi
On 06/16/2011 11:28 AM, Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel Looks good to me. ACK. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] Please review: [Bug 719069] clean up compiler warnings in 389-ds-base 1.2.9

2011-07-05 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=719069 https://bugzilla.redhat.com/attachment.cgi?id=511349action=diff https://bugzilla.redhat.com/attachment.cgi?id=511349action=edit Thanks, --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #19: Convert entryUSN plugin to transaction aware type

2012-04-23 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/19 https://fedorahosted.org/389/attachment/ticket/19/0001-Trac-Ticket-19-Convert-entryUSN-plugin-to-transactio.patch Fix description: * Separated usn_bepreop operations from usn_betxnpreop operations. usn_bepreop_modify and _modrdn add entryusn: # to the

[389-devel] Please review (take 2'): [389 Project] #359: Database RUV could mismatch the one in changelog under the stress

2012-05-09 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/359 Please review these 2 patches: https://fedorahosted.org/389/attachment/ticket/359/0001-Trac-Ticket-359-Database-RUV-could-mismatch-the-one.2.patch (389-ds-base-1.2.10)

Re: [389-devel] Please review: coverity - mbo dead code - winsync leaks, deadcode, null check, test code

2012-08-21 Thread Noriko Hosoi
Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (take 2): [389 Project] #351: use betxn plugins by default

2012-09-05 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/351 https://fedorahosted.org/389/attachment/ticket/351/0001-Trac-Ticket-351-use-betxn-plugins-by-default.2.patch Fix description: In addition to the fixes following the Rich's suggestions (comment 11), the take 2 patch contains ... . to register

[389-devel] Please review: [389 Project] #18: Data inconsitency during replication

2012-01-19 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/18 https://fedorahosted.org/389/attachment/ticket/18/0001-Trac-Ticket-18-Data-inconsitency-during-replication.patch Bug description: If promote a hub server to a new master and assign the same replica ID as the original master server had, some new

Re: [389-devel] Please review: Remove redundant code - make a global into a static

2012-01-20 Thread Noriko Hosoi
Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #139: RFE: eliminate the use of char *dn in favor of Slapi_DN *dn

2012-01-23 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/139 https://fedorahosted.org/389/attachment/ticket/139/0001-Trac-Ticket-139-eliminate-the-use-of-char-dn-in-favo.patch Fix description: The oritinal RFE had been already implemented in the commit f6397113666f06848412bb12f754f04258cfa5fa: Reduce the number

[389-devel] Please review: [389 Project] #52: FQDN set to nsslapd-listenhost makes the server start fail if IPv4-mapped-IPv6 address is given

2012-01-24 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/52 https://fedorahosted.org/389/attachment/ticket/52/0001-Trac-Ticket-52-FQDN-set-to-nsslapd-listenhost.patch Fix description: Added a code to check netaddr is duplicated or not. When the address is IPv4-mapped-IPv6, cut the IPv4 part out of the address and

[389-devel] Please review: [389 Project] #35: Log not clear enough on schema errors

2012-01-25 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/35 https://fedorahosted.org/389/attachment/ticket/35/0001-Trac-Ticket-35-Log-not-clear-enough-on-schema-errors.patch Comment: Fix description: Cryptic error message: dse - parsing dse entry [attributeTypes] is now replaced with: dse - Parsing

[389-devel] Please review (take 2): [389 Project] #35: Log not clear enough on schema errors

2012-01-25 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/35 https://fedorahosted.org/389/attachment/ticket/35/0001-Trac-Ticket-35-Log-not-clear-enough-on-schema-errors.patch Thanks to Rich for his review. The new patch logs the lineno of the corrupted entry in the input ldif file. Comment: Improved the error

[389-devel] Please review: [389 Project] #27: SASL/PLAIN binds do not work

2012-02-07 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/27 https://fedorahosted.org/389/attachment/ticket/27/0001-Trac-Ticket-27-SASL-PLAIN-binds-do-not-work.patch Bug description: ids_sasl_canon_user failed to set dn: in front of the dn string in the output argument out_user. The dn string is used in the next

[389-devel] Please review (take 2): [389 Project] #27: SASL/PLAIN binds do not work

2012-02-08 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/27 https://fedorahosted.org/389/attachment/ticket/27/0001-Trac-Ticket-27-SASL-PLAIN-binds-do-not-work.patch Thanks to Rich for his comment. Fixed the code based upon his suggestions. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #84: 389 Directory Server Unnecessary Checkpoints

2012-02-08 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/84 https://fedorahosted.org/389/attachment/ticket/84/0001-Trac-Ticket-84-389-Directory-Server-Unnecessary-Chec.patch Fix description: txn_checkpoint was always called with DB_FORCE flag. This patch introduces db_force arg to dblayer_txn_checkpoint and

[389-devel] Please review: [389 Project] #169: allow 389 to use db5

2012-02-10 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/169 https://fedorahosted.org/389/attachment/ticket/169/0001-Trac-Ticket-169-allow-389-to-use-db5.patch git patch file (master) -- excluded autogen files Fix description: 1. DB suffix .db4 is changed to .db if the server is linked with db5 (libdb); it

[389-devel] Please review: [389 Project] #260: 389 DS does not support multiple paging controls on a single connection

2012-02-28 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/260 https://fedorahosted.org/389/attachment/ticket/260/0001-Trac-Ticket-260-389-DS-does-not-support-multiple.patch Fix description: 1. Connection object holds the paged results related values. Now they are packaged in one PagedResults object. And the

Re: [389-devel] Please review: coverity 12563 Read from pointer after free

2012-03-06 Thread Noriko Hosoi
Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #303: make DNA range requests work with transactions

2012-03-13 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/303 https://fedorahosted.org/389/attachment/ticket/303/0001-Trac-Ticket-303-make-DNA-range-requests-work-with-tr.patch Fix Description: 1. pre_op: Adding missing dnatypes (e.g., uidNumber) should be done in the pre op phase (outside of the transaction)

[389-devel] Please review: coverity 12606 Logically dead code

2012-03-15 Thread Noriko Hosoi
4e0c70fd1a52d4bc943613bc496751fab2e390c0 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi nho...@totoro.usersys.redhat.com Date: Thu, 15 Mar 2012 09:17:33 -0700 Subject: [PATCH] coverity 12606 Logically dead code The previous fix (commit 325abca7135d06225adf5380d726de60dacda5a4) for Ticket #303 - make DNA range requests work

Re: [389-devel] Please review: schema def must have DESC '' - close paren must be preceded by space

2012-03-30 Thread Noriko Hosoi
Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [Bug 597375] Deleting LDBM database causes backup/restore problem

2010-06-03 Thread Noriko Hosoi
https://bugzilla.redhat.com/attachment.cgi?id=419482action=diff https://bugzilla.redhat.com/attachment.cgi?id=419482action=edit Fix Description: 1) When a backend is removed, the db instance directory was removed as well (See also 463774 - index files for database should be deleted when db is

[389-devel] Please review: [Bug 578296] Attribute type entrydn needs to be added when subtree rename switch is on.

2010-06-24 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=578296 https://bugzilla.redhat.com/attachment.cgi?id=426726action=diff https://bugzilla.redhat.com/attachment.cgi?id=426726action=edit Files: ldap/servers/slapd/back-ldbm/back-ldbm.h ldap/servers/slapd/back-ldbm/id2entry.c

[389-devel] Please review: [389 Project] #576: DNA: use event queue for config update only at the start up.

2013-02-08 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/576 https://fedorahosted.org/389/attachment/ticket/576/0001-Ticket-576-DNA-use-event-queue-for-config-update-onl.patch Bug description: DNA config updates were always put into the event queue and executed in 30 seconds, which increased a chance to conflict

[389-devel] Please review: [389 Project] #603: A logic error in str2simple

2013-02-28 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/603 https://fedorahosted.org/389/attachment/ticket/603/0001-Ticket-603-A-logic-error-in-str2simple.patch Fix description: str2simple sets the strdup'ed type this way: if ( f-f_choice == LDAP_FILTER_PRESENT ) { f-f_type = slapi_ch_strdup( str );

[389-devel] Please review (additinal fix): [389 Project] #47391: deleting and adding userpassword fails to update the password

2013-06-17 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/47391 https://fedorahosted.org/389/attachment/ticket/47391/0001-Ticket-47391-deleting-and-adding-userpassword-fails-.patch Bug description: ldapmodify with changetype modify is supposed to skip checking unhashed password in acl_check_mods. delete and

[389-devel] Please review: Ticket #47384 - Plugin library path validation

2013-07-03 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/47384 https://fedorahosted.org/389/attachment/ticket/47384/0001-Ticket-47384-Plugin-library-path-validation.3.patch Description: commit a4b81c0ae59a4246d2d44790efea093a62fc972c https://fedorahosted.org/389/changeset/a4b81c0ae59a4246d2d44790efea093a62fc972c/

[389-devel] Please review: [389 Project] #47367: ldapdelete returns non-leaf entry error while trying to remove a leaf entry

2013-07-18 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/47367 https://fedorahosted.org/389/attachment/ticket/47367/0001-Ticket-47367-phase-1-ldapdelete-returns-non-leaf-ent.2.patch git patch file (master) - phase1: ported from 1.2.11 The difference from 1.2.11: [urp.c] 2) The urp calling timing was moved from

[389-devel] Please review: [389 Project] #47435: Very large entryusn values after enabling the USN plugin and the lastusn value is negative.

2013-07-19 Thread Noriko Hosoi
https://fedorahosted.org/389/ticket/47435 https://fedorahosted.org/389/attachment/ticket/47435/0001-Ticket-47435-Very-large-entryusn-values-after-enabli.patch 1. Bug description: The initial value of lastusn is -1, but since the entryusn has the unsigned long long integer type, the server

[389-devel] Please review (coverity fix): [389 Project] #48: Active Directory has certain uids which are reserved and will cause a Directory Server replica initialization of an AD server to abort.

2013-08-22 Thread Noriko Hosoi
mistakenly put the Ignoring ALREADY EXIST case code before retrieving the ldap_result_code. This patch fixes the order. commit b00b8acca54267560c6d7ec614bc52cfe541200a Author: Noriko Hosoi nho...@redhat.com Date: Fri Aug 16 14:04:27 2013 -0700 -- 389-devel mailing list 389-de

Re: [389-devel] Please Review: (460209) Correct configure help message (adminserver)

2010-02-15 Thread Noriko Hosoi
On 02/15/2010 11:20 AM, Nathan Kinder wrote: https://bugzilla.redhat.com/show_bug.cgi?id=460209 https://bugzilla.redhat.com/attachment.cgi?id=394380action=diff https://bugzilla.redhat.com/attachment.cgi?id=394380action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: [Bug 573896] initializing subtree with invalid syntax crashes ns-slapd

2010-03-16 Thread Noriko Hosoi
Subject: initializing subtree with invalid syntax crashes ns-slapd https://bugzilla.redhat.com/show_bug.cgi?id=573896 Files: ldap/servers/slapd/slap.h ldap/servers/slapd/task.c Description: When an import is executed using a task mechanism, slapi_task_log_notice is called for logging, where

[389-devel] Please review: [Bug 515805] Stop initialize Database crashes the server

2010-03-18 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=515805 Steps to Reproduce: 1. On the DS Console, Configuration tab | expand Data, choose a backend icon in a suffix 2. Right click and choose initialize database, put an LDIF file name and click OK 3. Once the import started, click Stop on the

[389-devel] Please review: [Bug 548533] memory leak in Repl_5_Inc_Protocol_new

2010-03-21 Thread Noriko Hosoi
[Bug 548533] memory leak in Repl_5_Inc_Protocol_new https://bugzilla.redhat.com/show_bug.cgi?id=548533 Proposed Fix: https://bugzilla.redhat.com/attachment.cgi?id=401614action=diff https://bugzilla.redhat.com/attachment.cgi?id=401614action=edit Description: repl5_inc_delete and repl5_tot_delete

Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-30 Thread Noriko Hosoi
(2010?03?30? 13:56), Nathan Kinder wrote: New patch attached. Ack. --noriko -NGK On 03/30/2010 01:24 PM, Nathan Kinder wrote: Please hold off on the review. I noticed one other thing that I need to address. A new patch will be sent out shortly. -NGK On 03/30/2010 01:18 PM, Nathan

[389-devel] Please review (take 2): Update to New DN Format

2010-04-25 Thread Noriko Hosoi
=409036action=edit Thanks, --noriko On 4/21/10 4:22 PM, Noriko Hosoi wrote: Background info: http://directory.fedoraproject.org/wiki/Upgrade_to_New_DN_Format Fix Description: . adding slapi_dn_normalize_ext and its siblings to normalize/validate invalid DNs; deprecating slapi_dn_normalize

[389-devel] Please review: [Bug 531642] EntryUSN: RFE: a configuration option to make entryusn global

2010-08-26 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=531642 https://bugzilla.redhat.com/attachment.cgi?id=441366action=diff https://bugzilla.redhat.com/attachment.cgi?id=441366action=edit Fix description: 1. Introduced a config parameter nsslapd-entryusn-global: on|off to enable | disable the

[389-devel] Please review (revised): [Bug 635987] Incorrect sub scope search result with ACL containing ldap:///self

2010-09-24 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=635987 https://bugzilla.redhat.com/attachment.cgi?id=449487action=diff https://bugzilla.redhat.com/attachment.cgi?id=449487action=edit Thanks to Rich for analysing the bug introduced by the previous commit. The attached patch should fix it.

Re: [389-devel] 1.2.6-1 crash

2010-09-28 Thread Noriko Hosoi
The stack traces from the ns-slapd core would be very helpful. 1. login as root 2. ps -ef | grep ns-slapd ldapuser 27526 1 0 Sep24 ?00:02:21 ./ns-slapd -D ... 3. attach the process to gdb # gdb /usr/sbin/ns-slapd 27526 gdb continue 4. start the LDAP intensive application

Re: [389-devel] Please review: openldap ber_init will assert if the bv-bv_val is NULL

2010-10-01 Thread Noriko Hosoi
ack. Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [Bug 640027] Naming attribute with a special char sequence parsing bug

2010-10-05 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=640027 https://bugzilla.redhat.com/attachment.cgi?id=451775action=diff https://bugzilla.redhat.com/attachment.cgi?id=451775action=edit Description: When DN is made from RDNs containing escaped plus \+, the dn normalizer considers the value could be

Re: [389-devel] Please Review: (cov#16300) Unused variable in account policy plugin

2010-10-08 Thread Noriko Hosoi
On 10/08/2010 03:17 PM, Nathan Kinder wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. smime.p7s Description: S/MIME Cryptographic Signature -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review (take 3): [Bug 653007] db2ldif export of clear text passwords lacks storage scheme

2011-01-06 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=653007 https://bugzilla.redhat.com/attachment.cgi?id=472145action=diff https://bugzilla.redhat.com/attachment.cgi?id=472145action=edit Discussed with Nathan and removed the passwordStorageScheme check. My previous proposals added {CLEAR} only when the

[389-devel] Please review (Admin Server 389-ds-console): [Bug 387981] plain files can be chosen on the Restore Directory dialog

2011-02-07 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=387981 AS: git patch file (master) https://bugzilla.redhat.com/attachment.cgi?id=477544action=diff https://bugzilla.redhat.com/attachment.cgi?id=477544action=edit Description: dsalib_ldif_parse_line: OpenLDAP ldif_read_record takes buffer with its

[389-devel] Please review: [Bug 676053] export task followed by import task causes cache assertion

2011-02-10 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=676053 https://bugzilla.redhat.com/attachment.cgi?id=478160action=diff https://bugzilla.redhat.com/attachment.cgi?id=478160action=edit Description: Task version of export had a bug in handling the busy instance error case. When returning due to the

[389-devel] Please review: [Bug 676053] export task followed by import task causes cache assertion

2011-02-15 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=676053 https://bugzilla.redhat.com/attachment.cgi?id=479007action=diff https://bugzilla.redhat.com/attachment.cgi?id=479007action=edit Description: When a search request with VLV and/or SORT control fails, it did not returning an entry to the entry

[389-devel] Please review: [Bug 625424] repl-monitor.pl doesn't work in hub node

2011-02-23 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=625424 https://bugzilla.redhat.com/attachment.cgi?id=480602action=diff https://bugzilla.redhat.com/attachment.cgi?id=480602action=edit Description: repl-monitor.pl has been designed to display the entire replication topology. This patch allows to show

[389-devel] Please review: [Bug 211296] Clean up all HTML pages (Admin Express, Repl Monitor, etc)

2011-02-25 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=211296 Admin Server https://bugzilla.redhat.com/attachment.cgi?id=481106action=diff https://bugzilla.redhat.com/attachment.cgi?id=481106action=edit Description: 1) Using HTML Validator, reviewed html pages (static as well as the generated ones) and

[389-devel] Please review: [Bug 681015] RFE: allow fine grained password policy duration attributes in days, hours, minutes, as well

2011-03-01 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=681015 https://bugzilla.redhat.com/attachment.cgi?id=481753action=diff https://bugzilla.redhat.com/attachment.cgi?id=481753action=edit Description: Adding an ability to handle ##D|d, ##H|h, ##M|m, ##S|s format to the fine grained password policy

[389-devel] Please review: [Bug 158926] Unable to install CA certificate when using hardware token ( LunaSA )

2011-03-03 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=158926 Admin Server (security CGI): https://bugzilla.redhat.com/attachment.cgi?id=482179action=diff https://bugzilla.redhat.com/attachment.cgi?id=482179action=edit Description: Installing/Importing CA cert to the hardware token was not correctly

Re: [389-devel] Please Review: Auto Membership Plug-in

2011-04-19 Thread Noriko Hosoi
On 04/19/2011 01:44 PM, Nathan Kinder wrote: I've attached a revised patch to address some comments given by Noriko. The only differences here are in the plug-in close() function. We free the config lock now, and we also check if the started flag was set before freeing any of the resources.

Re: [389-devel] rfc2307bis.ldif Parsing Error

2011-05-02 Thread Noriko Hosoi
Thanks a lot, Adrien. I've added your fixed schema file to the *Bug 170791* https://bugzilla.redhat.com/show_bug.cgi?id=170791 -Schema file parsing overly picky?. On 05/02/2011 05:55 PM, Adrien Guillon wrote: Today on #389 on freenode we spent some time attempting to understand why

Re: [389-devel] about Bug 590826 - Reloading database from ldif causes changelog to emit data no longer matches errors

2011-09-07 Thread Noriko Hosoi
Rich Megginson wrote: The problem comes from the method we use to check if the changelog does not match the database in replica_check_for_data_reload(). The RUV in the database contains obsolete elements from replicas that are no longer in use. replica_check_for_data_reload() uses

Re: [389-devel] Please review: Add support for pre/post db transaction plugins

2011-09-13 Thread Noriko Hosoi
Rich Megginson wrote: http://rmeggins.fedorapeople.org/patches/0001-Add-support-for-pre-post-db-transaction-plugins.patch -- ack. 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list

Re: [389-devel] Please review: convert memberof to use transactions

2011-10-06 Thread Noriko Hosoi
Rich Megginson wrote: On 10/06/2011 12:04 PM, Noriko Hosoi wrote: Rich Megginson wrote: There are 3 patches. 0001 fixes a problem with betxn and modrdn to make the ENTRY_POST_OP available to betxnpostop plugins. 0002 allows us to pass the plugin config entry to plugin_init functions (yay

[389-devel] Please review: [Bug 744945] nsslapd-counters attribute value cannot be set to off

2011-10-10 Thread Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=744945 https://bugzilla.redhat.com/attachment.cgi?id=527345action=diff https://bugzilla.redhat.com/attachment.cgi?id=527345action=edit Description: nsslapd-counters (cn=config) is allowed to have the value off. Once it's set, cache monitor would not

  1   2   3   4   >