Re: new section for 'Join the package collection maintainers'

[Jonathan Wakely]

On 17/03/18 16:51 +0100, René Genz wrote:

Thanks to Jonathan, Athos, and Tom for the discussion.
I added one of Tom's links and pushed the text:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#One-off_contributions


Thanks!

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[René Genz]

Thanks to Jonathan, Athos, and Tom for the discussion.
I added one of Tom's links and pushed the text:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#One-off_contributions

I am going to unsubscribe from this list due to high volume.
-- 
Kind regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[René Genz]

On 15.03.2018 17:09, Jonathan Wakely wrote:
> On 15/03/18 00:54 +0100, René Genz wrote:
>> On 14.03.2018 14:40, Jonathan Wakely wrote:
>>> On 14/03/18 01:02 +0100, René Genz wrote:
 On 13.03.2018 15:13, Jonathan Wakely wrote:
> On 12/03/18 21:02 -0300, Athos Ribeiro wrote:
[snip]
>>
>> Taking feedback from Athos and you into account here is a new proposal:
>> ---8<---
>> 3. One-off contributions
>>
>> Changes to existing packages can be suggested by submitting > (https://docs.pagure.org/pagure/usage/pull_requests.html)>.
>> You must have a  to create a pull 
>> request.
>>
>> If your account is not a member of the 'packager' group:
>> * cloning your fork works only with the HTTPS URL and
> 
> What is "your fork"? Nothing on this page talks about having a fork.

Package maintainers do not need a fork because they can write to the repository.
One-off contributors use their copy of the project (="fork") to contribute 
changes to the project with the help of pull requests.
On the website of the "pull request" link the text "Create a Fork on Pagure" 
links to:
https://docs.pagure.org/pagure/usage/forks.html#create-fork

> And since you can't write to it, there is not point creating your own
> fork. You might as well just create the fork somewhere else like
> pagure.io
> 
> Explaining that you can't write to your fork is not necessary if you
> don't encourage people to create useless forks.
On the one hand explaining the situation might ease confusion why an external 
Git hosting platform must be used.
On the other hand the text is much shorter.
OK, let us use a shorter version.

> So I still think my previous suggestion is better, with one small
> correction:
> 
> Changes to existing packages can be suggested by submitting  requests (https://docs.pagure.org/pagure/usage/pull_requests.html)>.
> You must have a  to create
> a pull request. If your account is not in the 'packager' group then
> you cannot push changes to forks on src.fedoraproject.org so must use
> an external Git hosting platform (e.g. https://pagure.io/new) and use
> a  (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.

I made some minor changes (add a link, add "you", add a comma (because the last 
sentence is a conditional sentence to me)):
---8<---
3. One-off contributions
Changes to https://src.fedoraproject.org/browse/projects/)> 
can be suggested by submitting https://docs.pagure.org/pagure/usage/pull_requests.html)>.
You must have a  to create a pull 
request.
If your account is not in the 'packager' group, then you cannot push changes to 
forks on src.fedoraproject.org so you must use an external Git hosting platform 
(e.g. https://pagure.io/new) and use https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.
---8<---
Is it OK?
-- 
Kind regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Jonathan Wakely]

On 15/03/18 16:24 +, Tom Hughes wrote:

On 15/03/18 16:09, Jonathan Wakely wrote:


And since you can't write to it, there is not point creating your own
fork. You might as well just create the fork somewhere else like
pagure.io

Explaining that you can't write to your fork is not necessary if you
don't encourage people to create useless forks.


The intention is that you should be able to. There is a ticket somewhere
where Fesco said that people should be able to push to their own forks
without being in the packager group.

It just hasn't actually been implemented yet.

Here are the relevant tickets:

https://pagure.io/fesco/issue/1770
https://pagure.io/fedora-infrastructure/issue/6361


But as Athos said, when that happens the whole thing will need to be
rewritten anyway. Until then it doesn't add anything very useful to
the "here's how to make a one-off contribution" docs.


___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Tom Hughes]

On 15/03/18 16:09, Jonathan Wakely wrote:


And since you can't write to it, there is not point creating your own
fork. You might as well just create the fork somewhere else like
pagure.io

Explaining that you can't write to your fork is not necessary if you
don't encourage people to create useless forks.


The intention is that you should be able to. There is a ticket somewhere
where Fesco said that people should be able to push to their own forks
without being in the packager group.

It just hasn't actually been implemented yet.

Here are the relevant tickets:

https://pagure.io/fesco/issue/1770
https://pagure.io/fedora-infrastructure/issue/6361

Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Jonathan Wakely]

On 15/03/18 00:54 +0100, René Genz wrote:

On 14.03.2018 14:40, Jonathan Wakely wrote:

On 14/03/18 01:02 +0100, René Genz wrote:

On 13.03.2018 15:13, Jonathan Wakely wrote:

On 12/03/18 21:02 -0300, Athos Ribeiro wrote:

[snip]


You could add a link saying something like "To make a one-off
contribution see below" to skip past the main content of the page, but
the new content should still come after the main content.



I will add it to the end of the table of contents and the end of the page. Less 
links that could break.

[snip]

you cannot create a fork on src.fedoraproject.org so must use an


You can create a fork on src.fedoraproject.org if your account is not a member 
of the 'packager' group.


Really?



Yes.


Wow, that's weird.


For this account and repo:
* up- and downloading with the SSH URL fails
* downloading with the HTTPS URL works
(I guess uploading with the HTTPS URL is not supported, like it is in pagure.io)


That's not creating a fork on src.fedoraproject.org, it's cloning the
repo onto your local machine.



True, I wanted to describe the behavior of the repo for accounts without 
'packager' group membership.


Taking feedback from Athos and you into account here is a new proposal:
---8<---
3. One-off contributions

Changes to existing packages can be suggested by submitting https://docs.pagure.org/pagure/usage/pull_requests.html)>.
You must have a  to create a pull 
request.

If your account is not a member of the 'packager' group:
* cloning your fork works only with the HTTPS URL and


What is "your fork"? Nothing on this page talks about having a fork.

And since you can't write to it, there is not point creating your own
fork. You might as well just create the fork somewhere else like
pagure.io

Explaining that you can't write to your fork is not necessary if you
don't encourage people to create useless forks.


So I still think my previous suggestion is better, with one small
correction:

Changes to existing packages can be suggested by submitting https://docs.pagure.org/pagure/usage/pull_requests.html)>.
You must have a  to create
a pull request. If your account is not in the 'packager' group then
you cannot push changes to forks on src.fedoraproject.org so must use
an external Git hosting platform (e.g. https://pagure.io/new) and use
a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.

(This just changes "cannot create a fork on src.fp.org" to "cannot
push changes to forks on src.fp.o" compared to my previous suggestion.



* you cannot write to your fork
That is why you must upload your changes to an external Git hosting platform (e.g. 
https://pagure.io/new)>) and use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.

The requirement for accounts to be a member of the 'packager' group in order to 
be able to write to their forks on src.fedoraproject.org is being worked on.
---8<---

Anything that should be changed?
--
Kind regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Athos Ribeiro]

On Thu, Mar 15, 2018 at 12:54:07AM +0100, René Genz wrote:
> Taking feedback from Athos and you into account here is a new proposal:
> ---8<---
> 3. One-off contributions
> 
> Changes to existing packages can be suggested by submitting  (https://docs.pagure.org/pagure/usage/pull_requests.html)>.
> You must have a  to create a pull 
> request.
> 
> If your account is not a member of the 'packager' group:
> * cloning your fork works only with the HTTPS URL and
> * you cannot write to your fork
> That is why you must upload your changes to an external Git hosting platform 
> (e.g. https://pagure.io/new)>) and use a  (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.

Looks great. I'd suggest the following substitution:
s/That is why/Hence,/

> 
> The requirement for accounts to be a member of the 'packager' group in order 
> to be able to write to their forks on src.fedoraproject.org is being worked 
> on.
> ---8<---

I believe this last paragraph does not add anything to the documentation
and could be ommited. Whenever the feature is implemented, the whole
section will need to be refactored anyway.

> 
> Anything that should be changed?

Thanks for the effort :)

-- 
Athos Ribeiro

http://www.ime.usp.br/~athoscr
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[René Genz]

On 14.03.2018 14:40, Jonathan Wakely wrote:
> On 14/03/18 01:02 +0100, René Genz wrote:
>> On 13.03.2018 15:13, Jonathan Wakely wrote:
>>> On 12/03/18 21:02 -0300, Athos Ribeiro wrote:
[snip]
> 
> You could add a link saying something like "To make a one-off
> contribution see below" to skip past the main content of the page, but
> the new content should still come after the main content.
> 

I will add it to the end of the table of contents and the end of the page. Less 
links that could break.

[snip]
>>> you cannot create a fork on src.fedoraproject.org so must use an
>>
>> You can create a fork on src.fedoraproject.org if your account is not a 
>> member of the 'packager' group.
> 
> Really?
> 

Yes.

>> For this account and repo:
>> * up- and downloading with the SSH URL fails
>> * downloading with the HTTPS URL works
>> (I guess uploading with the HTTPS URL is not supported, like it is in 
>> pagure.io)
> 
> That's not creating a fork on src.fedoraproject.org, it's cloning the
> repo onto your local machine.
> 

True, I wanted to describe the behavior of the repo for accounts without 
'packager' group membership.


Taking feedback from Athos and you into account here is a new proposal:
---8<---
3. One-off contributions

Changes to existing packages can be suggested by submitting https://docs.pagure.org/pagure/usage/pull_requests.html)>.
You must have a  to create a pull 
request.

If your account is not a member of the 'packager' group:
* cloning your fork works only with the HTTPS URL and
* you cannot write to your fork
That is why you must upload your changes to an external Git hosting platform 
(e.g. https://pagure.io/new)>) and use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.

The requirement for accounts to be a member of the 'packager' group in order to 
be able to write to their forks on src.fedoraproject.org is being worked on.
---8<---

Anything that should be changed?
-- 
Kind regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Jonathan Wakely]

On 14/03/18 01:02 +0100, René Genz wrote:

On 13.03.2018 15:13, Jonathan Wakely wrote:

On 12/03/18 21:02 -0300, Athos Ribeiro wrote:

On Tue, Mar 13, 2018 at 12:35:19AM +0100, René Genz wrote:

[snip]

I propose to:
add a new major point 2, so:
"2. How to join the Fedora Package Collection Maintainers?"
will be:
"3. How to join the Fedora Package Collection Maintainers?"


Should your new item really come first? The page is about joining the
package maintainers, so why should "how to contribute without joining"
come before "how to join"?


I considered my case, only a one-off contribution, it is less text to read.


That's not a very good reason. The topic of the page should come

You could add a link saying something like "To make a one-off
contribution see below" to skip past the main content of the page, but
the new content should still come after the main content.


I am fine with adding the new information to the end.

[snip]


At the moment any repos, including forks, on https://src.fedoraproject.org require your 
FAS account to have 'packager' status for write access (and read access if you use the 
"SSH" Source GIT URL).


I don't think it's helpful to mention the SSH URL part. If you don't
have write access, just use the HTTPS URL.



The SSH URL can be used to download too, but `git clone` printed 'permission 
denied' as far as I remember.


Either you get the status or you use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
 f.e. with https://pagure.io/new)>, as a workaround.


This should be "for example" or "e.g." not "f.e."


OK



And it doesn't seem like a workaround, it seems like the proper way to
do it.


Other git hosting platforms support write access for users' forks.
I was surprised to find out this is not the case for src.fedoraproject.org.
Of course, with this behavior the remote pull-request is the proper way to do 
it.




The requirement to be a packager is being worked on.
---8<---


I would rather see something like:

If you are not an Fedora packager, i.e., you are not in the 'packager'
FAS group, you can send pull requests to  src.fedoraproject.org. To do


Yes, I agree it's better to say "in the 'packager' FAS group" rather
than "have 'packager' status".


OK




so, you must use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
f.e. with https://pagure.io/new)>


How about:

3. One-off contributions

Changes to existing packages can be suggested by submitting https://docs.pagure.org/pagure/usage/pull_requests.html)>.
You must have a  to create
a pull request. If your account is not in the 'packager' group then


Should it not be written with a comma, like "If ... group, then"?


No.


you cannot create a fork on src.fedoraproject.org so must use an


You can create a fork on src.fedoraproject.org if your account is not a member 
of the 'packager' group.


Really?


For this account and repo:
* up- and downloading with the SSH URL fails
* downloading with the HTTPS URL works
(I guess uploading with the HTTPS URL is not supported, like it is in pagure.io)


That's not creating a fork on src.fedoraproject.org, it's cloning the
repo onto your local machine.



external Git hosting platform (e.g. https://pagure.io/new) and use a
https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.


Thank you for your input. :)
Too late for me to write a new version of the proposal today. Feel free to beat 
me to it.

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[René Genz]

On 13.03.2018 15:13, Jonathan Wakely wrote:
> On 12/03/18 21:02 -0300, Athos Ribeiro wrote:
>> On Tue, Mar 13, 2018 at 12:35:19AM +0100, René Genz wrote:
[snip]
>>> I propose to:
>>> add a new major point 2, so:
>>> "2. How to join the Fedora Package Collection Maintainers?"
>>> will be:
>>> "3. How to join the Fedora Package Collection Maintainers?"
> 
> Should your new item really come first? The page is about joining the
> package maintainers, so why should "how to contribute without joining"
> come before "how to join"?

I considered my case, only a one-off contribution, it is less text to read.
I am fine with adding the new information to the end.

[snip]
>>>
>>> At the moment any repos, including forks, on https://src.fedoraproject.org 
>>> require your FAS account to have 'packager' status for write access (and 
>>> read access if you use the "SSH" Source GIT URL).
> 
> I don't think it's helpful to mention the SSH URL part. If you don't
> have write access, just use the HTTPS URL.
> 

The SSH URL can be used to download too, but `git clone` printed 'permission 
denied' as far as I remember.

>>> Either you get the status or you use a >> (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
>>>  f.e. with https://pagure.io/new)>, as a workaround.
> 
> This should be "for example" or "e.g." not "f.e."

OK

> 
> And it doesn't seem like a workaround, it seems like the proper way to
> do it.

Other git hosting platforms support write access for users' forks.
I was surprised to find out this is not the case for src.fedoraproject.org.
Of course, with this behavior the remote pull-request is the proper way to do 
it.

> 
>>> The requirement to be a packager is being worked on.
>>> ---8<---
>>
>> I would rather see something like:
>>
>> If you are not an Fedora packager, i.e., you are not in the 'packager'
>> FAS group, you can send pull requests to  src.fedoraproject.org. To do
> 
> Yes, I agree it's better to say "in the 'packager' FAS group" rather
> than "have 'packager' status".

OK

> 
>> so, you must use a > (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
>> f.e. with https://pagure.io/new)>
> 
> How about:
> 
> 3. One-off contributions
> 
> Changes to existing packages can be suggested by submitting  requests (https://docs.pagure.org/pagure/usage/pull_requests.html)>.
> You must have a  to create
> a pull request. If your account is not in the 'packager' group then

Should it not be written with a comma, like "If ... group, then"?

> you cannot create a fork on src.fedoraproject.org so must use an

You can create a fork on src.fedoraproject.org if your account is not a member 
of the 'packager' group.
For this account and repo:
* up- and downloading with the SSH URL fails
* downloading with the HTTPS URL works
(I guess uploading with the HTTPS URL is not supported, like it is in pagure.io)

> external Git hosting platform (e.g. https://pagure.io/new) and use a
>  (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.

Thank you for your input. :)
Too late for me to write a new version of the proposal today. Feel free to beat 
me to it.
-- 
Kind regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[René Genz]

On 13.03.2018 01:02, Athos Ribeiro wrote:
> On Tue, Mar 13, 2018 at 12:35:19AM +0100, René Genz wrote:
>> I propose to:
>> add a new major point 2, so:
>> "2. How to join the Fedora Package Collection Maintainers?"
>> will be:
>> "3. How to join the Fedora Package Collection Maintainers?"
>>
>> The new major point 2 would be something like:
>> ---8<---
>> 2. Notes for one-off contributors
>>
>> Your contribution is welcome.
>>
>> At first you must > (https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Fedora_Account)>.
>>
>> Before proceeding, please sync your account by login on 
>> https://src.fedoraproject.org/ using your FAS credentials.
> 
> See 2.3.1 - It deals with the FAS account creation. Maybe you could link
> there to avoid replication :)
> 

The proposed link:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Fedora_Account
links to section 2.1.3 "Create a Fedora Account".

Or do you recommend the following link for the same target?
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_a_Fedora_Account

>>
>> At the moment any repos, including forks, on https://src.fedoraproject.org 
>> require your FAS account to have 'packager' status for write access (and 
>> read access if you use the "SSH" Source GIT URL).
>>
>> Either you get the status or you use a > (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
>>  f.e. with https://pagure.io/new)>, as a workaround.
>> The requirement to be a packager is being worked on.
>> ---8<---
> 
> I would rather see something like:
> 
> If you are not an Fedora packager, i.e., you are not in the 'packager'
> FAS group, you can send pull requests to  src.fedoraproject.org. To do
> so, you must use a  (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
> f.e. with https://pagure.io/new)>
> 

Your proposal is easier to read. I will use it.
To explain why non-packager have to use remote pull-requests, instead of 
forking on src.fedoraproject.org, I would append something like:

Any repos on https://src.fedoraproject.org, including forks, are read-only for 
non-packager. Only packager can write.
It is being worked on that forks will be writable for non-packager.

> Also, I do not understood what you meant with
> 
> "The requirement to be a packager is being worked on."

As far as I remember that is what puiterwijk wrote in the IRC channel.
Due to read-only forks for non-packager on src.fedoraproject.org the code must 
be hosted on a remote git repo and a remote pull-requests must be used.
I assume puiterwijk meant that in the future forks on src.fedoraproject.org 
will be writable for non-packager.

>>
>> What do you think?
> 
> I think it is valuable information and should be added to the wiki :)
> Thanks!
> 

Thank you for your support and help. :)

>> I can edit the wiki.
> 
> Can you? Note that to edit the wiki you must be in at least one extra
> FAS group other the the CLA ones.
> 

In my FAS account one group reads "wikiedit (user)".
I requested that membership in order to fix a wrong command in a SSSD or 
FreeIPA testcase in the wiki during Fedora 26 branching as far as I remember.
-- 
Kind regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Athos Ribeiro]

On Tue, Mar 13, 2018 at 02:13:14PM +, Jonathan Wakely wrote:
[snip...]
> How about:
> 
> 3. One-off contributions
> 
> Changes to existing packages can be suggested by submitting  requests (https://docs.pagure.org/pagure/usage/pull_requests.html)>.
> You must have a  to create
> a pull request. If your account is not in the 'packager' group then
> you cannot create a fork on src.fedoraproject.org so must use an
> external Git hosting platform (e.g. https://pagure.io/new) and use a
>  (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org

I believe this will do it. +1

-- 
Athos Ribeiro

http://www.ime.usp.br/~athoscr
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Jonathan Wakely]

On 12/03/18 21:02 -0300, Athos Ribeiro wrote:

On Tue, Mar 13, 2018 at 12:35:19AM +0100, René Genz wrote:

the other day I wanted to contribute a fix to an RPM package's spec file.

I struggled with uploading my changes to my fork on src.fedoraproject.org.
puiterwijk and clime from #fedora-admin IRC channel on freenode.net pointed me 
in the right direction:
* 'packager' status for FAS account required, else all repos, including forks, 
are read-only
* workaround is to use a "Remote pull-request"
* requirement of 'packager' status is being worked on.

With this information contributing the fix was easy.


[snip...]


Now I try to add the information to Fedora's documentation.
From my point of view, this would be a good website:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers


I propose to:
add a new major point 2, so:
"2. How to join the Fedora Package Collection Maintainers?"
will be:
"3. How to join the Fedora Package Collection Maintainers?"


Should your new item really come first? The page is about joining the
package maintainers, so why should "how to contribute without joining"
come before "how to join"?



The new major point 2 would be something like:
---8<---
2. Notes for one-off contributors

Your contribution is welcome.

At first you must https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Fedora_Account)>.

Before proceeding, please sync your account by login on 
https://src.fedoraproject.org/ using your FAS credentials.


See 2.3.1 - It deals with the FAS account creation. Maybe you could link
there to avoid replication :)



At the moment any repos, including forks, on https://src.fedoraproject.org require your 
FAS account to have 'packager' status for write access (and read access if you use the 
"SSH" Source GIT URL).


I don't think it's helpful to mention the SSH URL part. If you don't
have write access, just use the HTTPS URL.


Either you get the status or you use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
 f.e. with https://pagure.io/new)>, as a workaround.


This should be "for example" or "e.g." not "f.e."

And it doesn't seem like a workaround, it seems like the proper way to
do it.


The requirement to be a packager is being worked on.
---8<---


I would rather see something like:

If you are not an Fedora packager, i.e., you are not in the 'packager'
FAS group, you can send pull requests to  src.fedoraproject.org. To do


Yes, I agree it's better to say "in the 'packager' FAS group" rather
than "have 'packager' status".


so, you must use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
f.e. with https://pagure.io/new)>


How about:

3. One-off contributions

Changes to existing packages can be suggested by submitting https://docs.pagure.org/pagure/usage/pull_requests.html)>.
You must have a  to create
a pull request. If your account is not in the 'packager' group then
you cannot create a fork on src.fedoraproject.org so must use an
external Git hosting platform (e.g. https://pagure.io/new) and use a
https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: new section for 'Join the package collection maintainers'

[Athos Ribeiro]

On Tue, Mar 13, 2018 at 12:35:19AM +0100, René Genz wrote:
> the other day I wanted to contribute a fix to an RPM package's spec file.
> 
> I struggled with uploading my changes to my fork on src.fedoraproject.org.
> puiterwijk and clime from #fedora-admin IRC channel on freenode.net pointed 
> me in the right direction:
> * 'packager' status for FAS account required, else all repos, including 
> forks, are read-only
> * workaround is to use a "Remote pull-request"
> * requirement of 'packager' status is being worked on.
> 
> With this information contributing the fix was easy.
> 
[snip...]
> 
> Now I try to add the information to Fedora's documentation.
> From my point of view, this would be a good website:
> https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
> 
> 
> I propose to:
> add a new major point 2, so:
> "2. How to join the Fedora Package Collection Maintainers?"
> will be:
> "3. How to join the Fedora Package Collection Maintainers?"
> 
> The new major point 2 would be something like:
> ---8<---
> 2. Notes for one-off contributors
> 
> Your contribution is welcome.
> 
> At first you must  (https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Fedora_Account)>.
> 
> Before proceeding, please sync your account by login on 
> https://src.fedoraproject.org/ using your FAS credentials.

See 2.3.1 - It deals with the FAS account creation. Maybe you could link
there to avoid replication :)

> 
> At the moment any repos, including forks, on https://src.fedoraproject.org 
> require your FAS account to have 'packager' status for write access (and read 
> access if you use the "SSH" Source GIT URL).
>
> Either you get the status or you use a  (https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
>  f.e. with https://pagure.io/new)>, as a workaround.
> The requirement to be a packager is being worked on.
> ---8<---

I would rather see something like:

If you are not an Fedora packager, i.e., you are not in the 'packager'
FAS group, you can send pull requests to  src.fedoraproject.org. To do
so, you must use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
f.e. with https://pagure.io/new)>

Also, I do not understood what you meant with

"The requirement to be a packager is being worked on."

> 
> What do you think?

I think it is valuable information and should be added to the wiki :)
Thanks!

> I can edit the wiki.

Can you? Note that to edit the wiki you must be in at least one extra
FAS group other the the CLA ones.


-- 
Athos Ribeiro

http://www.ime.usp.br/~athoscr
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

new section for 'Join the package collection maintainers'

[René Genz]

Dear sir or madam,

the other day I wanted to contribute a fix to an RPM package's spec file.

I struggled with uploading my changes to my fork on src.fedoraproject.org.
puiterwijk and clime from #fedora-admin IRC channel on freenode.net pointed me 
in the right direction:
* 'packager' status for FAS account required, else all repos, including forks, 
are read-only
* workaround is to use a "Remote pull-request"
* requirement of 'packager' status is being worked on.

With this information contributing the fix was easy.

I could not find the information given on IRC channel in the documentation of 
Fedora or Pagure.
Hence I created a pull-request to update Pagure's documentation:
https://pagure.io/pagure/pull-request/3057

pingou would rather not include it in Pagure's documentation because, from his 
point of view, it is too specific to https://src.fedoraproject.org for Pagure's 
documentation.

I will remove my proposal to modify "doc/usage/pull_requests.rst" from the pull 
request. Hence I write it down here as a reference:
* add at line 5:
At the moment any repos, including forks, on `src.fedoraproject.org 
` require your `FAS account 
` to have 'packager' status for 
write access (and read access if you use the "SSH" Source GIT URL).
Either you request the status or you use the 
:ref:`Remote-Git-to-Pagure-pull-request` workaround.
The requirement to be a packager is being worked on.

* replace at line 23:
You can create a pull request from another git hosting platform (e.g. GitHub, 
GitLab).
with:
You can create a pull request from another git hosting platform (e.g. `Pagure 
` (for src.fedoraproject.org), GitHub, GitLab).



Now I try to add the information to Fedora's documentation.
From my point of view, this would be a good website:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers


I propose to:
add a new major point 2, so:
"2. How to join the Fedora Package Collection Maintainers?"
will be:
"3. How to join the Fedora Package Collection Maintainers?"

The new major point 2 would be something like:
---8<---
2. Notes for one-off contributors

Your contribution is welcome.

At first you must https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Fedora_Account)>.

Before proceeding, please sync your account by login on 
https://src.fedoraproject.org/ using your FAS credentials.

At the moment any repos, including forks, on https://src.fedoraproject.org 
require your FAS account to have 'packager' status for write access (and read 
access if you use the "SSH" Source GIT URL).
Either you get the status or you use a https://docs.pagure.org/pagure/usage/pull_requests.html#remote-git-to-pagure-pull-request)>,
 f.e. with https://pagure.io/new)>, as a workaround.
The requirement to be a packager is being worked on.
---8<---

What do you think?
I can edit the wiki.
I ask first in order to avoid an edit war.

It is OK for me if you do not want this change. Just let me know.
-- 
Best regards,
René
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org