Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2022-01-04 Thread Tom Stellard
On 12/20/21 12:39, Florian Weimer wrote: * Ben Cotton: This change will be implemented by updating the %__spec_build_pre and %__speck_check_pre macros in redhat-rpm-config to include %set_build_flags. This will set these environment variables automatically before the %build and %check

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-28 Thread Neal Gompa
On Tue, Dec 28, 2021 at 8:37 AM Vitaly Zaitsev via devel wrote: > > On 28/12/2021 13:17, Neal Gompa wrote: > > It is. There are plenty of packages that compile for tests. I have > > one, for example (libeconf). > > I think all compilation should be done in %build. > It is not always reasonably

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-28 Thread Vitaly Zaitsev via devel
On 28/12/2021 13:17, Neal Gompa wrote: It is. There are plenty of packages that compile for tests. I have one, for example (libeconf). I think all compilation should be done in %build. Why? If the package is being maintained as a single spec across multiple branches, you'd have to ask them

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-28 Thread Neal Gompa
On Tue, Dec 28, 2021 at 3:26 AM Vitaly Zaitsev via devel wrote: > > On 20/12/2021 18:41, Ben Cotton wrote: > > Call %set_build_flags macro automatically at the beginning of the > > %build and %check phases of RPM builds in Fedora Linux. This will > > ensure that the compiler flag environment

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-28 Thread Vitaly Zaitsev via devel
On 20/12/2021 18:41, Ben Cotton wrote: Call %set_build_flags macro automatically at the beginning of the %build and %check phases of RPM builds in Fedora Linux. This will ensure that the compiler flag environment variables are set for every RPM build. +1 for the %build section, but I doubt it

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-23 Thread Vít Ondruch
Dne 22. 12. 21 v 18:44 Tom Stellard napsal(a): On 12/22/21 01:56, Vít Ondruch wrote: Dne 21. 12. 21 v 21:56 Tom Stellard napsal(a): On 12/21/21 01:42, Vít Ondruch wrote: Hi Tom, Since you are digging into this and AFAIK you are involved with toolchains, this reminds me this dreaded issue:

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-22 Thread Miro Hrončok
On 22. 12. 21 18:44, Tom Stellard wrote: I wasn't suggesting modifying the extension flags directly.  What I meant was that we should be able to specify a set of flags for extensions to use when we build python, for example.  And then extensions would pick up those flags up the same way they do

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-22 Thread Tom Stellard
On 12/22/21 01:56, Vít Ondruch wrote: Dne 21. 12. 21 v 21:56 Tom Stellard napsal(a): On 12/21/21 01:42, Vít Ondruch wrote: Hi Tom, Since you are digging into this and AFAIK you are involved with toolchains, this reminds me this dreaded issue:

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-22 Thread Vít Ondruch
Dne 21. 12. 21 v 21:56 Tom Stellard napsal(a): On 12/21/21 01:42, Vít Ondruch wrote: Hi Tom, Since you are digging into this and AFAIK you are involved with toolchains, this reminds me this dreaded issue: https://bugzilla.redhat.com/show_bug.cgi?id=1284684 In short, various languages,

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-21 Thread Tom Stellard
On 12/21/21 01:42, Vít Ondruch wrote: Hi Tom, Since you are digging into this and AFAIK you are involved with toolchains, this reminds me this dreaded issue: https://bugzilla.redhat.com/show_bug.cgi?id=1284684 In short, various languages, such as Ruby embeds the build time options and reuse

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-21 Thread Vít Ondruch
Dne 21. 12. 21 v 11:01 Florian Weimer napsal(a): * Vít Ondruch: Since you are digging into this and AFAIK you are involved with toolchains, this reminds me this dreaded issue: https://bugzilla.redhat.com/show_bug.cgi?id=1284684 In short, various languages, such as Ruby embeds the build time

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-21 Thread Florian Weimer
* Vít Ondruch: > Since you are digging into this and AFAIK you are involved with > toolchains, this reminds me this dreaded issue: > > https://bugzilla.redhat.com/show_bug.cgi?id=1284684 > > In short, various languages, such as Ruby embeds the build time > options and reuse them for build of

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-21 Thread Vít Ondruch
Hi Tom, Since you are digging into this and AFAIK you are involved with toolchains, this reminds me this dreaded issue: https://bugzilla.redhat.com/show_bug.cgi?id=1284684 In short, various languages, such as Ruby embeds the build time options and reuse them for build of extensions. And I

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Florian Weimer
* Tom Stellard: > What do you think the best place is to document this? > I was thinking in the Packaging Guidelines: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags Please update the in-place package documentation (buildflags.md) at the very least. Thanks,

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Florian Weimer
* Miro Hrončok: > On 20. 12. 21 21:39, Florian Weimer wrote: >> * Ben Cotton: >> >>> This change will be implemented by updating the %__spec_build_pre and >>> %__speck_check_pre macros in redhat-rpm-config to include >>> %set_build_flags. This will set these environment variables >>>

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Tom Stellard
On 12/20/21 14:04, Miro Hrončok wrote: On 20. 12. 21 21:39, Florian Weimer wrote: * Ben Cotton: This change will be implemented by updating the %__spec_build_pre and %__speck_check_pre macros in redhat-rpm-config to include %set_build_flags.  This will set these environment variables

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Miro Hrončok
On 20. 12. 21 21:39, Florian Weimer wrote: * Ben Cotton: This change will be implemented by updating the %__spec_build_pre and %__speck_check_pre macros in redhat-rpm-config to include %set_build_flags. This will set these environment variables automatically before the %build and %check

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Florian Weimer
* Ben Cotton: > This change will be implemented by updating the %__spec_build_pre and > %__speck_check_pre macros in redhat-rpm-config to include > %set_build_flags. This will set these environment variables > automatically before the %build and %check sections. See the proposed >

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Tom Stellard
On 12/20/21 10:17, Miro Hrončok wrote: On 20. 12. 21 18:41, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck == Summary == Call %set_build_flags macro automatically at the beginning of the %build and %check phases of RPM builds in Fedora Linux.  This will ensure

Re: F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Miro Hrončok
On 20. 12. 21 18:41, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck == Summary == Call %set_build_flags macro automatically at the beginning of the %build and %check phases of RPM builds in Fedora Linux. This will ensure that the compiler flag environment

F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck == Summary == Call %set_build_flags macro automatically at the beginning of the %build and %check phases of RPM builds in Fedora Linux. This will ensure that the compiler flag environment variables are set for every RPM build. ==

F36 Change: %set_build_flags for %build and %check (System-Wide Change proposal)

2021-12-20 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck == Summary == Call %set_build_flags macro automatically at the beginning of the %build and %check phases of RPM builds in Fedora Linux. This will ensure that the compiler flag environment variables are set for every RPM build. ==