Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/24/2020 08:25 AM, Vít Ondruch wrote: > I wonder if there is PR with the implementation somewhere or is this just dry > theoretical discussion O:-) > > I have been experimenting with these changes over the past few months, so there are a number of PRs where I have implemented these

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

I wonder if there is PR with the implementation somewhere or is this just dry theoretical discussion O:-) Vít Dne 19. 06. 20 v 23:11 Ben Cotton napsal(a): > https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro > > == Summary == > This change will update all spec files in Fedora

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Tom Stellard wrote: > The benefits for using the macro are mentioned in the proposal, so this is > not just a cosmetic change. I have addressed those points further down in my message: I do not believe that the proposed change will achieve the mentioned goals, and I think the side effects are

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/22/2020 10:54 AM, Björn Persson wrote: > Tom Stellard wrote: >> On 06/22/2020 10:00 AM, Björn Persson wrote: >>> Tom Stellard wrote: The reason I put in the proposal that all make invocations would be updated, is because this is easier to script and it would be hard for

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/22/2020 10:14 AM, Neal Gompa wrote: > On Mon, Jun 22, 2020 at 11:51 AM Tom Stellard wrote: >> >> On 06/20/2020 11:20 AM, Neal Gompa wrote: >>> On Sat, Jun 20, 2020 at 2:16 PM Zbigniew Jędrzejewski-Szmek >>> wrote: On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: >

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Tom Stellard wrote: > On 06/22/2020 10:00 AM, Björn Persson wrote: > > Tom Stellard wrote: > >> The reason I put in the proposal that all make invocations would be > >> updated, > >> is because this is easier to script and it would be hard for someone who > >> doesn't know the package to make

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Mon, Jun 22, 2020 at 11:51 AM Tom Stellard wrote: > > On 06/20/2020 11:20 AM, Neal Gompa wrote: > > On Sat, Jun 20, 2020 at 2:16 PM Zbigniew Jędrzejewski-Szmek > > wrote: > >> > >> On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: > >>> The %make_build macro enables parallel make

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/22/2020 10:00 AM, Björn Persson wrote: > Tom Stellard wrote: >> The reason I put in the proposal that all make invocations would be updated, >> is because this is easier to script and it would be hard for someone who >> doesn't know the package to make the call about which invocations don't

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Tom Stellard wrote: > The reason I put in the proposal that all make invocations would be updated, > is because this is easier to script and it would be hard for someone who > doesn't know the package to make the call about which invocations don't > need to use parallel make. It's often tempting

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/20/2020 05:11 PM, Kevin Kofler wrote: > Ben Cotton wrote: >> == Summary == >> This change will update all spec files in Fedora that use make and replace >> the make invocations with either the %make_build or %make_install macros. >> >> == Owner == >> * Name: [[User:tstellar| Tom Stellard]]

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/20/2020 11:20 AM, Neal Gompa wrote: > On Sat, Jun 20, 2020 at 2:16 PM Zbigniew Jędrzejewski-Szmek > wrote: >> >> On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: >>> The %make_build macro enables parallel make builds using the -j option. In >>> case a package does not build

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/20/2020 11:14 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: >> The %make_build macro enables parallel make builds using the -j option. In >> case a package does not build correctly with parallel make, then parallel >> make will be

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/20/2020 02:23 AM, Dan Čermák wrote: > Sorry about the empty email, I've hit send too fast… > > Anyway, on the topic of parallel builds: what is everyone's opinion on > adding the %limit_build macro from openSUSE (see: >

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/20/2020 02:18 PM, Björn Persson wrote: > Miro Hrončok wrote: >> On 19. 06. 20 23:11, Ben Cotton wrote: >>> All make invocations in spec files that don't use the install target will >>> be >>> modified to use the %make_build macro >> >> Many Python packages build Sphinx documentation with

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 22. 06. 20 17:21, Tom Stellard wrote: On 06/19/2020 03:37 PM, Miro Hrončok wrote: On 19. 06. 20 23:11, Ben Cotton wrote: All make invocations in spec files that don't use the install target will be modified to use the %make_build macro Many Python packages build Sphinx documentation with

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/19/2020 03:37 PM, Miro Hrončok wrote: > On 19. 06. 20 23:11, Ben Cotton wrote: >> All make invocations in spec files that don't use the install target will be >> modified to use the %make_build macro > > Many Python packages build Sphinx documentation with variant of "make html". > Such

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 06/19/2020 03:17 PM, Tomasz Kłoczko wrote: > On Fri, 19 Jun 2020 at 22:20, Ben Cotton > wrote: > [..] > > The %make_build macro enables parallel make builds using the -j option. > In case a package does not build correctly with parallel make, then parallel >

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 6/20/20 9:14 PM, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: The %make_build macro enables parallel make builds using the -j option. In case a package does not build correctly with parallel make, then parallel make will be disabled for that

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro > > == Summary == > This change will update all spec files in Fedora that use make and replace > the make invocations with either the %make_build or %make_install macros.

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Sat, Jun 20, 2020 at 11:24 AM Dan Čermák wrote: > Sorry about the empty email, I've hit send too fast… > > Anyway, on the topic of parallel builds: what is everyone's opinion on > adding the %limit_build macro from openSUSE (see: > >

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Saturday, 20 June 2020 at 09:20, Kamil Dudka wrote: > On Saturday, June 20, 2020 12:17:26 AM CEST Tomasz Kłoczko wrote: > > All parallel build issues should be treated *as critical bugs* > > which should be *ASAP fixed*. > > > > kloczek > > Seriously, are you saying that bugs causing slower

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 20. 06. 20 23:18, Björn Persson wrote: Also: Is it set in stone that "make_build" means "make in parallel" and nothing else? If so, why isn't the macro called "parallel_make"? Or is it the case that "make_build" means "the typical make command to use in a build stage", and a future version

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Ben Cotton wrote: > == Summary == > This change will update all spec files in Fedora that use make and replace > the make invocations with either the %make_build or %make_install macros. > > == Owner == > * Name: [[User:tstellar| Tom Stellard]] > * Email: I am opposed to this change. Unlike

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Miro Hrončok wrote: > On 19. 06. 20 23:11, Ben Cotton wrote: > > All make invocations in spec files that don't use the install target will > > be > > modified to use the %make_build macro > > Many Python packages build Sphinx documentation with variant of "make html". > Such invocation will

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Sat, Jun 20, 2020 at 2:16 PM Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: > > The %make_build macro enables parallel make builds using the -j option. In > > case a package does not build correctly with parallel make, then parallel > > make

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote: > The %make_build macro enables parallel make builds using the -j option. In > case a package does not build correctly with parallel make, then parallel > make will be disabled for that package by redefining the %_smp_mflags macro > like

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 20. 06. 20 14:47, Andy Mender wrote: On Sat, 20 Jun 2020 at 00:38, Miro Hrončok > wrote: On 19. 06. 20 23:11, Ben Cotton wrote: > All make invocations in spec files that don't use the install target will be > modified to use the %make_build macro

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Sat, 20 Jun 2020 at 00:38, Miro Hrončok wrote: > On 19. 06. 20 23:11, Ben Cotton wrote: > > All make invocations in spec files that don't use the install target > will be > > modified to use the %make_build macro > > Many Python packages build Sphinx documentation with variant of "make >

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Sorry about the empty email, I've hit send too fast… Anyway, on the topic of parallel builds: what is everyone's opinion on adding the %limit_build macro from openSUSE (see: https://build.opensuse.org/package/view_file/network:chromium/memory-constraints/memory-constraints.macros?expand=1)?

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

Ben Cotton writes: > https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro > > == Summary == > This change will update all spec files in Fedora that use make and replace > the make invocations with either the %make_build or %make_install macros. > > == Owner == > * Name:

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Saturday, June 20, 2020 12:17:26 AM CEST Tomasz Kłoczko wrote: > All parallel build issues should be treated *as critical bugs* > which should be *ASAP fixed*. > > kloczek Seriously, are you saying that bugs causing slower build are as important as bugs causing data lost or security

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On 19. 06. 20 23:11, Ben Cotton wrote: All make invocations in spec files that don't use the install target will be modified to use the %make_build macro Many Python packages build Sphinx documentation with variant of "make html". Such invocation will always be just 1 job. Hence there is no

Re: Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

On Fri, 19 Jun 2020 at 22:20, Ben Cotton wrote: [..] > The %make_build macro enables parallel make builds using the -j option. > In case a package does not build correctly with parallel make, then > parallel make will be disabled for that package by redefining the > %_smp_mflags macro like this:

Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro == Summary == This change will update all spec files in Fedora that use make and replace the make invocations with either the %make_build or %make_install macros. == Owner == * Name: [[User:tstellar| Tom Stellard]] * Email: ==

Fedora 33 System-Wide Change proposal: Use %make_build and %make_install macros

https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro == Summary == This change will update all spec files in Fedora that use make and replace the make invocations with either the %make_build or %make_install macros. == Owner == * Name: [[User:tstellar| Tom Stellard]] * Email: ==