Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"
On Mon, 2022-06-20 at 12:02 +0200, Lubomír Sedlář wrote: > Richard W.M. Jones píše v So 18. 06. 2022 v 12:08 +0100: > > I thought I'd be nice and use a suffix for my side tag so it would > > be > > clear (not least to me!) which side tag was being used for the > > OCaml > > rebuild in Rawhide, but ... > > > > $ fedpkg request-side-tag --help > > usage: fedpkg request-side-tag [-h] [--base-tag BASE_TAG] [--suffix > > SUFFIX] > > > > options: > > -h, --help show this help message and exit > > --base-tag BASE_TAG name of base tag > > --suffix SUFFIX A suffix to be appended to the side tag > > name. > > The > > suffix must be allowed in Koji > > configuration. > > > > $ fedpkg request-side-tag --suffix ocaml > > Could not execute request_side_tag: ocaml suffix is not allowed for > > sidetag > > > > Looking at this it seems there's a hard-coded list of allowed > > suffixes. I couldn't find where this is defined, but obviously > > "ocaml" ain't on the list so it's not getting in. > > > > I don't understand this - what's it for? Or do I have to request > > the > > ocaml is added to the list? > > > > The allowed suffixes are listed in Koji hub configuration (and the > list > defaults to empty). exactly, in others worlds is not allowed ( for non-admin I guess) I arrived to this conclusion some weeks ago ... > The reason for restricting it is that Koji hub is using the tag name > for checking policy. Allowing unrestricted strings in the tag name > could potentially allow e.g. building from SRPMs. > > https://pagure.io/sidetag-koji-plugin/issue/7 > > Lubomír > > > Rich. > > > > -- > > Richard Jones, Virtualization Group, Red Hat > > http://people.redhat.com/~rjones > > Read my programming and virtualization blog: > > http://rwmj.wordpress.com > > virt-builder quickly builds VMs from scratch > > http://libguestfs.org/virt-builder.1.html > > ___ > > devel mailing list -- devel@lists.fedoraproject.org > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > Fedora Code of Conduct: > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: > > https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > Do not reply to spam on the list, report it: > > https://pagure.io/fedora-infrastructure > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam on the list, report it: > https://pagure.io/fedora-infrastructure -- Sérgio M. B. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"
Richard W.M. Jones píše v So 18. 06. 2022 v 12:08 +0100: > I thought I'd be nice and use a suffix for my side tag so it would be > clear (not least to me!) which side tag was being used for the OCaml > rebuild in Rawhide, but ... > > $ fedpkg request-side-tag --help > usage: fedpkg request-side-tag [-h] [--base-tag BASE_TAG] [--suffix > SUFFIX] > > options: > -h, --help show this help message and exit > --base-tag BASE_TAG name of base tag > --suffix SUFFIX A suffix to be appended to the side tag name. > The > suffix must be allowed in Koji configuration. > > $ fedpkg request-side-tag --suffix ocaml > Could not execute request_side_tag: ocaml suffix is not allowed for > sidetag > > Looking at this it seems there's a hard-coded list of allowed > suffixes. I couldn't find where this is defined, but obviously > "ocaml" ain't on the list so it's not getting in. > > I don't understand this - what's it for? Or do I have to request the > ocaml is added to the list? > The allowed suffixes are listed in Koji hub configuration (and the list defaults to empty). The reason for restricting it is that Koji hub is using the tag name for checking policy. Allowing unrestricted strings in the tag name could potentially allow e.g. building from SRPMs. https://pagure.io/sidetag-koji-plugin/issue/7 Lubomír > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat > http://people.redhat.com/~rjones > Read my programming and virtualization blog: > http://rwmj.wordpress.com > virt-builder quickly builds VMs from scratch > http://libguestfs.org/virt-builder.1.html > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam on the list, report it: > https://pagure.io/fedora-infrastructure ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"
On Sat, Jun 18, 2022 at 02:00:03PM +0200, Vitaly Zaitsev via devel wrote: > On 18/06/2022 13:47, Richard W.M. Jones wrote: > > So it sounds like the suffix is used for the purpose I guessed. Why > > not let any packager use a descriptive suffix (without pre-approval)? > > +1. I like this idea. well, I think several reasons: First, I don't think that was available when we enabled side tags, so we just never looked too closely at doing so. But most importantly, I'm not sure it really conveys too much useful information. I mean you could call a tag: f37-side-NN-ocaml but is that a mass rebuild? A small set of deps? What if someone else is rebuilding some small subset of ocaml packages and calls there tag: f37-side-XX-ocaml Which one is for what? But I suppose it does give a slight bit more information and let you know to look at a sidetag for something. Can you file a infrastructure ticket on it and we can look at getting it enabled? Thanks, kevin signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"
On 18/06/2022 13:47, Richard W.M. Jones wrote: So it sounds like the suffix is used for the purpose I guessed. Why not let any packager use a descriptive suffix (without pre-approval)? +1. I like this idea. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"
On Sat, Jun 18, 2022 at 01:32:47PM +0200, Vitaly Zaitsev via devel wrote: > On 18/06/2022 13:08, Richard W.M. Jones wrote: > >I thought I'd be nice and use a suffix for my side tag so it would be > >clear (not least to me!) which side tag was being used for the OCaml > >rebuild in Rawhide, but ... > > You don't need any suffixes to perform a routine rebuild. Suffixes > are only needed for big projects such as kde/gnome with multiple > package maintainers. These maintainers can build their packages in > this tag and then the tag owner will merge it. > > >I don't understand this - what's it for? Or do I have to request the > >ocaml is added to the list? > > FESCo approval is required, I guess. So it sounds like the suffix is used for the purpose I guessed. Why not let any packager use a descriptive suffix (without pre-approval)? At the moment: $ fedpkg list-side-tags epel7-build-side-54017 (id 54017) (user rcurtin|2196) epel9-next-build-side-54492 (id 54492) (user gotmax23|5165) f33-build-side-47516(id 47516) (user gd|421) f35-build-side-54404(id 54404) (user churchyard|2274) f35-build-side-54410(id 54410) (user ppisar|1374) f35-build-side-54478(id 54478) (user gotmax23|5165) f35-build-side-54490(id 54490) (user luya|304) f35-build-side-54518(id 54518) (user mikelo2|4275) f35-build-side-54524(id 54524) (user abompard|158) f35-build-side-54540(id 54540) (user mikelo2|4275) f36-build-side-54354(id 54354) (user mizdebsk|2045) f36-build-side-54402(id 54402) (user churchyard|2274) f36-build-side-54408(id 54408) (user ppisar|1374) f36-build-side-54488(id 54488) (user luya|304) f36-build-side-54516(id 54516) (user mikelo2|4275) f36-build-side-54536(id 54536) (user mikelo2|4275) f37-build-side-53831(id 53831) (user tstellar|3805) f37-build-side-54438(id 54438) (user mikelo2|4275) f37-build-side-54486(id 54486) (user luya|304) f37-build-side-54500(id 54500) (user tbaeder|4642) f37-build-side-54510(id 54510) (user petersen|56) f37-build-side-54514(id 54514) (user mikelo2|4275) f37-build-side-54538(id 54538) (user abulimov|5179) f37-build-side-54552(id 54552) (user eclipseo|3950) f37-build-side-54554(id 54554) (user eclipseo|3950) f37-build-side-54556(id 54556) (user sergiomb|1918) f37-build-side-54560(id 54560) (user rjones|458) It's not very easy to tell what each side tag is used for, or whether for example those epel7 or f33 tags are truly obsolete. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"
On 18/06/2022 13:08, Richard W.M. Jones wrote: I thought I'd be nice and use a suffix for my side tag so it would be clear (not least to me!) which side tag was being used for the OCaml rebuild in Rawhide, but ... You don't need any suffixes to perform a routine rebuild. Suffixes are only needed for big projects such as kde/gnome with multiple package maintainers. These maintainers can build their packages in this tag and then the tag owner will merge it. I don't understand this - what's it for? Or do I have to request the ocaml is added to the list? FESCo approval is required, I guess. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
fedpkg request-side-tag: I don't understand "allowed_suffixes"
I thought I'd be nice and use a suffix for my side tag so it would be clear (not least to me!) which side tag was being used for the OCaml rebuild in Rawhide, but ... $ fedpkg request-side-tag --help usage: fedpkg request-side-tag [-h] [--base-tag BASE_TAG] [--suffix SUFFIX] options: -h, --help show this help message and exit --base-tag BASE_TAG name of base tag --suffix SUFFIX A suffix to be appended to the side tag name. The suffix must be allowed in Koji configuration. $ fedpkg request-side-tag --suffix ocaml Could not execute request_side_tag: ocaml suffix is not allowed for sidetag Looking at this it seems there's a hard-coded list of allowed suffixes. I couldn't find where this is defined, but obviously "ocaml" ain't on the list so it's not getting in. I don't understand this - what's it for? Or do I have to request the ocaml is added to the list? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
