Re: grub2 and setting crashkernel kernel argument

2011-12-07 Thread Chuck Ebbert
On Tue, 06 Dec 2011 15:08:09 +0100
Roman Rakus rra...@redhat.com wrote:

 Thanks all for answers. And I will get back to this point. I will
 change GRUB_CMDLINE_LINUX variable and run grub2-mkconfig. Hopefully
 it will not brake anything.

It will break... everything. Any custom boot options for specific
kernels will be replaced with the generic GRUB_CMDLINE_LINUX.

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-12-06 Thread Roman Rakus
On 11/28/2011 06:20 PM, Frank Ch. Eigler wrote:
 Roman Rakusrra...@redhat.com  writes:

 How are fedora with grub2 users supposed to set up crashkernel kernel
 argument? [...]
 Does GRUB_CMDLINE_LINUX=crashkernel=auto in /etc/default/grub work,
 followed by grub2-mkconfig?

 - FChE
I thought that `auto' option was never used in Fedora.

RR
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-12-06 Thread Roman Rakus
On 11/28/2011 04:30 PM, Roman Rakus wrote:
 How are fedora with grub2 users supposed to set up crashkernel kernel
 argument? Or even any argument? Writing own script for it?
 I'm asking because I'm maintaining system-config-kdump and I'm not sure
 how to ensure this.

 RR
Thanks all for answers. And I will get back to this point. I will change 
GRUB_CMDLINE_LINUX variable and run grub2-mkconfig. Hopefully it will 
not brake anything.

RR
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

grub2 and setting crashkernel kernel argument

2011-11-28 Thread Roman Rakus
How are fedora with grub2 users supposed to set up crashkernel kernel 
argument? Or even any argument? Writing own script for it?
I'm asking because I'm maintaining system-config-kdump and I'm not sure 
how to ensure this.

RR
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-11-28 Thread Frank Ch. Eigler
Roman Rakus rra...@redhat.com writes:

 How are fedora with grub2 users supposed to set up crashkernel kernel 
 argument? [...]

Does GRUB_CMDLINE_LINUX=crashkernel=auto in /etc/default/grub work,
followed by grub2-mkconfig?

- FChE
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-11-28 Thread Chuck Ebbert
On Mon, 28 Nov 2011 16:30:10 +0100
Roman Rakus rra...@redhat.com wrote:

 How are fedora with grub2 users supposed to set up crashkernel kernel 
 argument? Or even any argument? Writing own script for it?
 I'm asking because I'm maintaining system-config-kdump and I'm not sure 
 how to ensure this.

What specific problems are you having? (I've been playing with kdump on
F15, I guess I should have been trying F16.)
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-11-28 Thread Jason L Tibbitts III
 RR == Roman Rakus rra...@redhat.com writes:

RR How are fedora with grub2 users supposed to set up crashkernel
RR kernel argument? Or even any argument?

One possibility is /etc/default/grub.  This contains
GRUB_CMDLINE_LINUX.  After changing that, grub2-mkconfig -o
/boot/grub2/grub.cfg.

You can also edit grub.cfg directly, but it gets wiped out if anything
ever runs grub2-mkconfig.  Finally, grubby has options for modifying
kernel arguments, but I do not believe that goes in and does anything
with the /etc/default/grub line so again that gets wiped out of anything
runs grub2-mkconfig.

The grub2 situation is definitely suboptimal at this point.

 - J
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-11-28 Thread Richard W.M. Jones
On Mon, Nov 28, 2011 at 02:17:39PM -0600, Jason L Tibbitts III wrote:
  RR == Roman Rakus rra...@redhat.com writes:
 
 RR How are fedora with grub2 users supposed to set up crashkernel
 RR kernel argument? Or even any argument?
 
 One possibility is /etc/default/grub.  This contains
 GRUB_CMDLINE_LINUX.  After changing that, grub2-mkconfig -o
 /boot/grub2/grub.cfg.
 
 You can also edit grub.cfg directly, but it gets wiped out if anything
 ever runs grub2-mkconfig.  Finally, grubby has options for modifying
 kernel arguments, but I do not believe that goes in and does anything
 with the /etc/default/grub line so again that gets wiped out of anything
 runs grub2-mkconfig.
 
 The grub2 situation is definitely suboptimal at this point.

It is the source of entertaining rants, however:

  https://bugzilla.redhat.com/show_bug.cgi?id=647976#c5

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-11-28 Thread Kevin Kofler
Jason L Tibbitts III wrote:
 You can also edit grub.cfg directly, but it gets wiped out if anything
 ever runs grub2-mkconfig.  Finally, grubby has options for modifying
 kernel arguments, but I do not believe that goes in and does anything
 with the /etc/default/grub line so again that gets wiped out of anything
 runs grub2-mkconfig.

But does anything in Fedora actually run grub2-mkconfig automatically? 
Kernel updates sure don't, they have grubby edit the grub.cfg file directly 
instead.

I wonder whether it might actually make sense to patch grub2-mkconfig to no 
longer emit that warning and to make it a packaging guideline that RPM 
scriptlets MUST NOT run grub2-mkconfig. The template system may be a nice 
idea, but it doesn't cover everything, it makes things more complicated, and 
it doesn't seem to be actually needed in Fedora, thanks to grubby.

On the other hand, unfortunately, tools such as kcm-grub2, which we probably 
want to package for Fedora at some point, run grub2-mkconfig, and we can't 
even blame them for that given that it is what GRUB upstream recommends. :-( 
(That said, kcm-grub2's KAuth helper's code also scares me for other 
reasons:
* The config file to write to is soft-coded as a configuration option, which 
means that giving out org.kde.kcontrol.kcmgrub2.save permissions to a user 
essentially gives that user root. (It doesn't just allow to Save the GRUB2 
Bootloader settings as the action description claims, but to write to ANY 
file on the system as root.)
* The executable names to run are hard-coded as grub-*, which is wrong for 
Fedora.
IMHO, the proper solution would be to make both of those compile-time CMake 
options.)

So the situation is indeed a mess.

Kevin Kofler

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: grub2 and setting crashkernel kernel argument

2011-11-28 Thread Adam Williamson
On Tue, 2011-11-29 at 00:46 +0100, Kevin Kofler wrote:
 Jason L Tibbitts III wrote:
  You can also edit grub.cfg directly, but it gets wiped out if anything
  ever runs grub2-mkconfig.  Finally, grubby has options for modifying
  kernel arguments, but I do not believe that goes in and does anything
  with the /etc/default/grub line so again that gets wiped out of anything
  runs grub2-mkconfig.
 
 But does anything in Fedora actually run grub2-mkconfig automatically? 
 Kernel updates sure don't, they have grubby edit the grub.cfg file directly 
 instead.
 
 I wonder whether it might actually make sense to patch grub2-mkconfig to no 
 longer emit that warning and to make it a packaging guideline that RPM 
 scriptlets MUST NOT run grub2-mkconfig. The template system may be a nice 
 idea, but it doesn't cover everything, it makes things more complicated, and 
 it doesn't seem to be actually needed in Fedora, thanks to grubby.
 
 On the other hand, unfortunately, tools such as kcm-grub2, which we probably 
 want to package for Fedora at some point, run grub2-mkconfig, and we can't 
 even blame them for that given that it is what GRUB upstream recommends. :-( 
 (That said, kcm-grub2's KAuth helper's code also scares me for other 
 reasons:
 * The config file to write to is soft-coded as a configuration option, which 
 means that giving out org.kde.kcontrol.kcmgrub2.save permissions to a user 
 essentially gives that user root. (It doesn't just allow to Save the GRUB2 
 Bootloader settings as the action description claims, but to write to ANY 
 file on the system as root.)
 * The executable names to run are hard-coded as grub-*, which is wrong for 
 Fedora.
 IMHO, the proper solution would be to make both of those compile-time CMake 
 options.)
 
 So the situation is indeed a mess.

Well, it's _something_ of a mess, but as far as end-user customization
goes it is, AFAIK, pretty much always safe just to do things
via /etc/default/grub and grub2-mkconfig, because any changes you
produce in this way will then get inherited by grubby when updating the
kernel, and now everything's in sync.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel