Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-25 Thread Dimitar Zhekov
On 19.4.2015 г. 16:43, Enrico Tröger wrote: On 17/04/15 21:42, Dimitar Zhekov wrote: Alright, I finally got it. To whoever might be interested: 1. The default theme for gtk+ 2.24 under Windows has been changed [...] 2. The horizontal (only) notebook tabs backgrounds under MS-Windows is

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-19 Thread Enrico Tröger
On 17/04/15 21:42, Dimitar Zhekov wrote: On 16.4.2015 г. 23:36, Colomban Wendling wrote: I can't seem to really change the colors when using the MS-Windows theme, but I guess it's kinda expected some things aren't really overridable with a native theme that uses the Windows theming API or

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-17 Thread Thomas Martitz
Am 16.04.2015 um 23:20 schrieb Colomban Wendling: Is a pref necessary? Yes. In that case it's not the best solution and we should find an indication that people don't want to outright disable. The underline gets the job done but I'm not married to it. Can you suggest a better alternative?

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-17 Thread Lex Trotman
I don't mind some form of underline, highlight or something to indicate the active tab, and as Thomas says, that future-proofs it if one day we get slipt or multi windows. It would be good if it had a pref so it could be turned off on those platforms/themes that don't need it. Forcing something

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-17 Thread Dimitar Zhekov
On 16.4.2015 г. 23:36, Colomban Wendling wrote: I can't seem to really change the colors when using the MS-Windows theme, but I guess it's kinda expected some things aren't really overridable with a native theme that uses the Windows theming API or something. But the vertical tabs still

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-16 Thread Dimitar Zhekov
On 16.4.2015 г. 03:41, Matthew Brush wrote: On 15-04-15 10:15 AM, Dimitar Zhekov wrote: That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost [...] We could re-parent the Scintilla widget into a frame (or

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-16 Thread Colomban Wendling
Le 16/04/2015 19:15, Dimitar Zhekov a écrit : On 16.4.2015 г. 14:41, Colomban Wendling wrote: Le 15/04/2015 19:15, Dimitar Zhekov a écrit : That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost lost [...] the white

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-16 Thread Enrico Tröger
On 16/04/15 21:51, Enrico Tröger wrote: On 15/04/15 19:15, Dimitar Zhekov wrote: On 14.4.2015 г. 22:37, Enrico Tröger wrote: On 13/04/15 19:33, Dimitar Zhekov wrote: In 2.24, the horizontal tabs under Win~1 have this flat or modern or whatever look, and you can only distinguish the current

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-16 Thread Enrico Tröger
On 16/04/15 18:47, Dimitar Zhekov wrote: On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline [vertical_tabs], but is almost [...] due to the white editor

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-16 Thread Thomas Martitz
Am 16.04.2015 um 21:47 schrieb Enrico Tröger: On 16/04/15 18:47, Dimitar Zhekov wrote: On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: That's exactly what I'm talking about. The white horizontal line, which normally gives nice outline

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-16 Thread Matthew Brush
On 15-04-16 02:20 PM, Colomban Wendling wrote: Le 16/04/2015 23:14, Thomas Martitz a écrit : Am 16.04.2015 um 21:47 schrieb Enrico Tröger: On 16/04/15 18:47, Dimitar Zhekov wrote: On 16.4.2015 г. 12:37, Thomas Martitz wrote: Am 15.04.2015 um 19:15 schrieb Dimitar Zhekov: […] In my

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-15 Thread Matthew Brush
On 15-04-15 10:15 AM, Dimitar Zhekov wrote: On 14.4.2015 г. 22:37, Enrico Tröger wrote: On 13/04/15 19:33, Dimitar Zhekov wrote: In 2.24, the horizontal tabs under Win~1 have this flat or modern or whatever look, and you can only distinguish the current tab via a slight 3D effect. And unlike

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-13 Thread Colomban Wendling
Le 12/04/2015 19:20, Dimitar Zhekov a écrit : On 10.4.2015 г. 18:36, Colomban Wendling wrote: waf: Fix the checks for openpty() on FreeBSD ACK. Please, be sure to use the same check for debugger, it probably needs it. The same commits should already have altered both Scope and Debugger to

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-13 Thread Dimitar Zhekov
On 13.4.2015 г. 04:11, Matthew Brush wrote: While on configuring, the README file still lists gtk+ 2.16 as a minimum requirement for Geany - but it's actually 2.18 with GtkInfoBar now, right? I just merged PR #245[0], so 2.24 should be good version to use. On 13.4.2015 г. 04:12, Lex Trotman

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-12 Thread Matthew Brush
On 15-04-12 10:20 AM, Dimitar Zhekov wrote: [snip] While on configuring, the README file still lists gtk+ 2.16 as a minimum requirement for Geany - but it's actually 2.18 with GtkInfoBar now, right? I can cut an entire module (gtk216.[ch]) from Scope if 2.18 is the minimum required version...

Re: [Geany-Devel] [geany/geany-plugins] 73ae49: waf: Fix the checks for openpty() on FreeBSD

2015-04-12 Thread Dimitar Zhekov
On 10.4.2015 г. 18:36, Colomban Wendling wrote: waf: Fix the checks for openpty() on FreeBSD ACK. Please, be sure to use the same check for debugger, it probably needs it. While on configuring, the README file still lists gtk+ 2.16 as a minimum requirement for Geany - but it's actually