Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-14 Thread Steven Blatnick
Thanks for the heads up :-D On 07/13/2015 11:00 PM, Lex Trotman wrote: Hi Steve, There are some changes coming soon (hopefully) in the keybinding which will probably add API and might help you, check out #376. Cheers Lex On 9 July 2015 at 03:57, Steven Blatnick steve8tr...@yahoo.com wrote:

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-13 Thread Lex Trotman
Hi Steve, There are some changes coming soon (hopefully) in the keybinding which will probably add API and might help you, check out #376. Cheers Lex On 9 July 2015 at 03:57, Steven Blatnick steve8tr...@yahoo.com wrote: So I've finally got a chance to look at my non-API calls. I was able to

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-09 Thread Thomas Martitz
Am 09.07.2015 um 18:00 schrieb Steven Blatnick: Responses below: On 07/08/2015 11:23 PM, Thomas Martitz wrote: Remember that plugin_set_key_group() can be called repeatedly. Calling it again will simply clear all existing keybindings, then you can start over again with keybindings_set_item().

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-09 Thread Steven Blatnick
Responses below: On 07/08/2015 11:23 PM, Thomas Martitz wrote: Remember that plugin_set_key_group() can be called repeatedly. Calling it again will simply clear all existing keybindings, then you can start over again with keybindings_set_item(). So it looks like this can be achieved with

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-09 Thread Steven Blatnick
Thanks! I'd love to get this into geany-plugins, but I keep procrastinating because of lack of time to figure out how to integrate into the build system. Any suggestions on where to start with that? I'm a bit unclear on what files are generated vs what I need to edit to add my plugins.

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Steven Blatnick
So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier if we could make them APIs. (I haven't pushed any of these changes to my git repo yet.) Could we consider making these API? *

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Steve
On Jul 8, 2015 7:18 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls.  I was able to code around most of them, but there are two that would be much easier if we could make them APIs. 

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Matthew Brush
On 2015-07-08 07:28 PM, Steve wrote: On Jul 8, 2015 7:18 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Matthew Brush
On 2015-07-08 10:57 AM, Steven Blatnick wrote: [snip] Let me know if this is possible or how I should proceed. I use geany with my plugins daily, and can't upgrade my code base until my plugins are working. I forgot to mention, if you made your plugin part of the Geany-Plugins project (I'm

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Thomas Martitz
Am 09.07.2015 um 04:28 schrieb Steve: On Jul 8, 2015 7:18 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-07-08 Thread Matthew Brush
On 2015-07-08 10:57 AM, Steven Blatnick wrote: So I've finally got a chance to look at my non-API calls. I was able to code around most of them, but there are two that would be much easier if we could make them APIs. (I haven't pushed any of these changes to my git repo yet.) Could we

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-06-14 Thread Matthew Brush
On 2015-05-27 05:25 AM, marius buzea wrote: Hello, I would like to add GeanyHighlightSelectedWords, to Geany Plugins. [snip] See https://github.com/geany/geany/pull/513 Cheers, Matthew Brush ___ Devel mailing list Devel@lists.geany.org

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-06-01 Thread Jiří Techet
On Sun, May 31, 2015 at 10:57 AM, Colomban Wendling lists@herbesfolles.org wrote: Le 31/05/2015 07:41, Lex Trotman a écrit : On 31 May 2015 at 11:46, Lex Trotman ele...@gmail.com wrote: On 31 May 2015 at 08:05, Thomas Martitz ku...@rockbox.org wrote: Am 30.05.2015 um 03:19 schrieb

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-06-01 Thread Colomban Wendling
Le 01/06/2015 15:48, Steven Blatnick a écrit : […] Odd, I don't see this reply from Marius in my inbox. Was this in private separately? No, it was sent to the mailing list just like the rest… maybe a spam filter got confused? […] BTW, @Steven: search_find_text() is *NOT* part of the

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-06-01 Thread Steven Blatnick
Thanks Matthew. I was wondering how to tell what was API. (Colomban can disregard that question in the other email). On 05/29/2015 08:29 PM, Matthew Brush wrote: Lessons learned: - Messing with build system flags can affect API (and ABI for that matter) without ever touching the code

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-06-01 Thread Steven Blatnick
I kind of like the idea of selection highlighting being separate highlighting from the search highlighting. That allows you to have multiple groups highlighted differently, which has come in handy in using plugin versions of these features. Alternatively, perhaps we could add having multiple

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-06-01 Thread Steven Blatnick
Responses: On 05/29/2015 07:21 PM, Colomban Wendling wrote: Le 29/05/2015 00:10, marius buzea a écrit : https://github.com/sblatnick/geany-plugins/blob/master/quick-search/src/quick-search.c. […] The quick-search.c calls Geany's search_find_text several times in one processing, and each

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-30 Thread Lex Trotman
On 31 May 2015 at 08:05, Thomas Martitz ku...@rockbox.org wrote: Am 30.05.2015 um 03:19 schrieb Matthew Brush: Just because it's such a trivial search algorithm, using strstr() is much more simple and probably more efficient than using Scintilla's API to find text, but if manual and

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-30 Thread Thomas Martitz
Am 30.05.2015 um 03:19 schrieb Matthew Brush: Just because it's such a trivial search algorithm, using strstr() is much more simple and probably more efficient than using Scintilla's API to find text, but if manual and automatic mode is supported, it would make sense to share the existing

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
KMP calculates a table of how many characters it can skip if some of the search string matches but not all of it. Its more useful for relatively large search strings since it can skip potentially a lot of compares. Since this use is always going to search the whole file, to mark all occurrances

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
On Fri, 5/29/15, Thomas Martitz ku...@rockbox.org wrote: Subject: Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins To: devel@lists.geany.org Date: Friday, May 29, 2015, 1:49 PM Am 29.05.2015 um 12:44 schrieb marius

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins To: devel@lists.geany.org Date: Friday, May 29, 2015, 1:49 PM Am 29.05.2015 um 12:44 schrieb marius buzea: Hello, With KMP it is possible to search all occurrences of a m length

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Matthew Brush
On 2015-05-29 02:03 PM, Jiří Techet wrote: On Fri, May 29, 2015 at 1:25 AM, Matthew Brush mbr...@codebrainz.ca wrote: Ideally you could improve the underlying implementation of an existing one if your way is better[0] and they perform the same function. It's really confusing for users to

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Matthew Brush
On 2015-05-29 04:45 PM, Matthew Brush wrote: [snip] I was thinking something like this for implementation: [snip] - Upon Scintilla notification of position changed, check if there's a current word at the cursor. Question: Is it important to make it mark the selection if there is one,

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Colomban Wendling
Le 29/05/2015 02:38, Lex Trotman a écrit : […] That being said, showing occurrences of the word is such a common and fairly useful feature for an IDE, I'd personally rather see the 3-4 existing plugins obsoleted by a good implementation in core Geany[1]. +1 Gotta agree, this is so

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Colomban Wendling
Hey, Le 30/05/2015 01:45, Matthew Brush a écrit : […] I was thinking something like this for implementation: - Have a preference to enable the feature (since it would now be automatic). Have the preference turned off by default. Put the preference in Preferences-Editor-Display as a

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Lex Trotman
On 30 May 2015 at 11:24, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-05-29 06:09 PM, Colomban Wendling wrote: Le 29/05/2015 02:38, Lex Trotman a écrit : […] That being said, showing occurrences of the word is such a common and fairly useful feature for an IDE, I'd personally rather

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-29 Thread Jiří Techet
On Fri, May 29, 2015 at 1:25 AM, Matthew Brush mbr...@codebrainz.ca wrote: Ideally you could improve the underlying implementation of an existing one if your way is better[0] and they perform the same function. It's really confusing for users to figure out what is the right plugin when

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-27 Thread Thomas Martitz
Am 27.05.2015 um 14:25 schrieb marius buzea: Hello, I would like to add GeanyHighlightSelectedWords, to Geany Plugins. Would it be okay that I do a git pull-request for doing this? I am the mgnt user on sourceforge, and last week there was a ticket added to GeanyHighlightSelectedWords, ticket

[Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-27 Thread marius buzea
Hello, I would like to add GeanyHighlightSelectedWords, to Geany Plugins.Would it be okay that I do a git pull-request for doing this?   I am the mgnt user on sourceforge, and last week there was a ticketadded to GeanyHighlightSelectedWords, ticket #2, and in thisticket was a question:  why not

Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins

2015-05-27 Thread marius buzea
Hello, It highlights all occurrences of the selected word in the visible text.Processing complexity is O(n+m) time and space  (the KMP algorithm isused to achieve this.) I estimated it should introduce littlelatency when processing is triggered ( 200 milliseconds).  Worksvery well (I