On 5 December 2010 14:26, Paul Fox wrote:
> like chris, i don't think this is a great name. we already use at
> least two naming styles (olpc_dcon_xo_1_5.c, olpc-pm-1.5.c) and
> introducing a third doesn't seem great. frankly, i think "xo15",
> "xo175", etc, would be sufficient, since the lack o
daniel wrote:
> Hi Paul,
>
> I've made some small changes to your code for the XO-1.5 ebook switch
> driver and am wondering if you have any comments before I submit this
> upstream.
this looks great. thanks again for taking this on. i haven't yet had
a chance to do a close review (will do
On 4 December 2010 18:03, Chris Ball wrote:
> Hi Dan,
>
> > - driver renamed to "xo1p5-ebook"
>
> Not sure where the 'p' comes from -- how about "xo1_5-ebook"?
> We could do the same on 1.75, e.g. olpc-ec-1_75.c.
It's only a detail, but...
I was thinking that it makes sense to use something o
Hi Dan,
> - driver renamed to "xo1p5-ebook"
Not sure where the 'p' comes from -- how about "xo1_5-ebook"?
We could do the same on 1.75, e.g. olpc-ec-1_75.c.
Thanks,
- Chris.
--
Chris Ball
One Laptop Per Child
___
Devel mailing list
Devel@lists
Hi Paul,
I've made some small changes to your code for the XO-1.5 ebook switch
driver and am wondering if you have any comments before I submit this
upstream.
- driver renamed to "xo1p5-ebook"
- THRM# bit handling removed, since we'll do that in the DSDT
(pending Mitch's approval)
- /proc i
