[PATCH 07/12] qemu: process: Ensure that 'beingDestroyed' gets cleared only after VM id is reset

' is processing shutdown of the VM. Ensure that this doesn't happen by clearing the 'beingDestroyed' flag only after the VM id is cleared. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/qemu

[PATCH 11/12] qemuMigrationSrcRun: Re-check whether VM is active before accessing job data

values of those functions. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 3524915e9d..89ddc586bd 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c

[PATCH 00/12] qemu: migration: Fix crashes when VM shutdowns itself during migration in active state

The daemon crashes due to unexpected cleanup happening due to bad assumptions about locking and state. See patch 5. Peter Krempa (12): qemuBlockJobProcessEventConcludedBackup: Handle potentially NULL 'job->disk' qemuDomainDiskPrivateDispose: Prevent dangling 'disk' pointer in block

[PATCH 05/12] qemuProcessStop: Prevent crash when qemuDomainObjStopWorker() unlocks the VM

https://gitlab.com/libvirt/libvirt/-/issues/640 Reported-by: grass-lu <https://gitlab.com/grass-lu> Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7ef70

[PATCH 08/12] qemu: domain: Introduce qemuDomainObjIsActive helper

The helper checks whether VM is active including the internal qemu state. This helper will become useful in situations when an async job is in use as VIR_JOB_DESTROY can run along async jobs thus both checks are necessary. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 18

[PATCH 09/12] qemu: migration: Properly check for live VM after qemuDomainObjWait()

Similarly to the one change in commit 4d1a1fdffda19a62d62fa2457d162362 we should be checking that the VM is not being yet destroyed if we've invoked qemuDomainObjWait(). Use the new helper qemuDomainObjIsActive(). Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 11 +-- 1

[PATCH 12/12] qemu: migration: Preserve error across qemuDomainSetMaxMemLock() on error paths

on error paths in qemuMigrationSrcConfirmPhase and qemuMigrationSrcPerformPhase. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 89ddc586bd..26c082fc08 100644

[PATCH 10/12] qemu: migration: Inline 'qemuMigrationDstFinishResume()'

The function is a pointless wrapper on top of qemuMigrationDstWaitForCompletion. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index

[PATCH 06/12] qemuProcessStop: Move code not depending on 'vm->def->id' after reset of the ID

of potential bugs. This patch moves all the code which does not require the 'id' (except for the log entry and closing the monitor socket) after the statement clearing the id and adds a comment explaining that anything in the section must not unlock the VM object. Signed-off-by: Peter Krempa --- src/qemu

[PATCH 04/12] qemuDomainObjWait: Add documentation

Document why this function exists and meaning of return values. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 12 1 file changed, 12 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9bbad887e0..8fe1b1924d 100644 --- a/src/qemu

[PATCH 03/12] qemuDomainDeviceBackendChardevForeach: Fix typo in comment

Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a39f361a64..9bbad887e0 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -12302,7 +12302,7

[PATCH 02/12] qemuDomainDiskPrivateDispose: Prevent dangling 'disk' pointer in blockjob data

Clear the 'disk' member of 'blockjob' as we're freeing the disk object at this point. While this should not normally happen it was observed when other bug allowed the VM to be cleared while other threads didn't yet finish. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 8 +++- 1

[PATCH 01/12] qemuBlockJobProcessEventConcludedBackup: Handle potentially NULL 'job->disk'

Similarly to other blockjob handlers, if there's no disk associated with the blockjob the handler needs to behave correctly. This is needed as the disk might have been de-associated on unplug or other operations. Signed-off-by: Peter Krempa --- src/qemu/qemu_backup.c | 6 +++--- src/qemu

[PATCH 2/3] qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices

The support will be dropped soon by qemu, and libvirt is not rejecting such configurations. Add validation of this explicitly requested config. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu

[PATCH 1/3] qemuValidateDomainDeviceDefDiskFrontend: Refactor validation of

Use a switch statement for checks based on the disk bus. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 95af93d606

[PATCH 0/3] qemu: Fix missing validation of 'scsi' property support for 'virtio-blk' and update capabilites dump for qemu-9.1

Peter Krempa (3): qemuValidateDomainDeviceDefDiskFrontend: Refactor validation of qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices qemucapabilitiestest: Update test data for qemu 9.1 dev cycle src/qemu/qemu_validate.c | 38

Re: [PATCH] qemu_block: Validate number of hosts for iSCSI disk device

On Thu, Jun 06, 2024 at 16:17:41 +0530, Rayhan Faizel wrote: > Hi, Hi, please *always* keep replies on-list (use reply-all). I've re-added the mailing list again. > > On Thu, Jun 6, 2024 at 4:12 PM Peter Krempa wrote: > > > > On Thu, Jun 06, 2024 at 15:45:16 +0530

Re: [PATCH] qemu_block: Validate number of hosts for iSCSI disk device

On Thu, Jun 06, 2024 at 15:45:16 +0530, Rayhan Faizel wrote: > An iSCSI device with zero hosts will result in a segmentation fault. This > patch > adds a check for the number of hosts, which must be one in the case of iSCSI. > > Minimal reproducing XML: > > > MyGuest >

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

On Thu, Jun 06, 2024 at 08:07:37 -, Chun Feng Wu wrote: > for comment > "Preferrably all these definitions should be shared with as any > change would now need to change two places." Trimming the context and mentioning this random bit makes it rather hard to remember what I've based that

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

On Thu, Jun 06, 2024 at 07:58:04 -, Chun Feng Wu wrote: > Thanks Peter for above comments! > > My original design goal is exact the same as what QEMU doc says at > https://github.com/qemu/qemu/blob/master/docs/throttle.txt: > "In this example the individual drives have IOPS limits of 2000,

Re: [PATCH v2 4/4] qemu: Reject TPM 1.2 in most scenarios

/qemu/qemu_validate.c | 22 --- > ...aarch64-tpm-wrong-model.aarch64-latest.err | 2 +- > 2 files changed, 10 insertions(+), 14 deletions(-) Reviewed-by: Peter Krempa

Re: [PATCH v2 3/4] qemu: Default to TPM 2.0 in most scenarios

domain.c | 13 - > ...irt-default-models.riscv64-latest.abi-update.xml | 2 +- > .../riscv64-virt-default-models.riscv64-latest.xml | 2 +- > 3 files changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Peter Krempa

Re: [PATCH v2 1/4] tests: Add TPM coverage to default-models tests

default in QEMU: loongarch64 and s390x. > The situation might change for the former, but that's unlikely > to happen for the latter. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Peter Krempa

Re: [PATCH] rpm: fix setting of VIR_TEST_DEBUG

> which has no effect, since VIR_TEST_DEBUG isn't exported. > > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Peter Krempa

Re: [PATCH] interface: fix udev reference leak with invalid flags

iel P. Berrangé > --- > src/interface/interface_backend_udev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Peter Krempa

[PATCH pushed] NEWS: Fix misindented bullet point

Fixes: 296b6badc10c43480ec51eb2c73a1c8b5c8fb15e Signed-off-by: Peter Krempa --- Trivial. NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 4dd7530f0c..b3ad60d7c1 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -93,7 +93,7 @@ v10.4.0 (unreleased

[PATCH] ci: Always run 'pages' job

this will update the web when the web part is buildable. Signed-off-by: Peter Krempa --- Note that it's upnpleasant to test the pages deployment stuff separately as various hacks are needed to do that successfully. Let's test this one in production. .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion

[PATCH 2/4] qemu: hotplug: Validate definition of 'FS' device after address allocation

Some of the checks make sense only after the address is allocated and thus we need to re-do the validation after the address is assigned. Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu

[PATCH 3/4] qemu: validate: Fix check for unsupported FS-device bootindex use on un-assigned addresses

will still be caught as previous commit re-checks the definition after address assignment prior to hotplug. Resolves: https://issues.redhat.com/browse/RHEL-39271 Fixes: 4690058b6d3dab672bd18ff69c83392245253024 Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 5 - 1 file changed, 4

[PATCH 4/4] NEWS: Mention fix for broken 'fs' device bootindex support check

Signed-off-by: Peter Krempa --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 14505116b1..edb4a9965d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -70,6 +70,12 @@ v10.4.0 (unreleased) The bug was introduced in `v10.1.0 (2024-03-01)`_. + * qemu: Fix

[PATCH 0/4] qemu: Fix broken check rejecting virtiofs hotplug with 'bootindex' set

See 3/4 Peter Krempa (4): syms: Properly export 'virDomainDeviceDefValidate' qemu: hotplug: Validate definition of 'FS' device after address allocation qemu: validate: Fix check for unsupported FS-device bootindex use on un-assigned addresses NEWS: Mention fix for broken 'fs

[PATCH 1/4] syms: Properly export 'virDomainDeviceDefValidate'

While the function is exported via header, the symbol itself was not. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index f0f7aa8654..653c84a520 100644 --- a/src

Re: [PATCH v3 2/5] qemu: Introduce shared_filesystems configuration option

On Thu, May 09, 2024 at 17:51:59 +0100, Daniel P. Berrangé wrote: > On Thu, May 09, 2024 at 04:47:48PM +, Andrea Bolognani wrote: > > On Thu, May 09, 2024 at 05:10:50PM GMT, Peter Krempa wrote: > > > Now things I see as problem in case when NFS not supporting xattr is >

Re: Add iommu device when VM configured with > 255 vcpus

On Tue, May 28, 2024 at 16:26:18 -0600, Jim Fehlig via Devel wrote: > Hi All, > > I vaguely recall a discussion about $subject, but can't find it now. Perhaps > buried in another thread. The topic has been raised internally again, and > I'd like to gauge the community's interest in automatically

Re: [PATCH] virsh: Provide completer for some pool-X-as commands

On Mon, May 27, 2024 at 18:34:38 +, Abhiram Tilak wrote: > Provides completers for auth-type and source-format commands for > virsh pool-create-as and pool-define-as commands. Use Empty completers > for options where completions are not required. I left the ones where > I was not sure if they

Re: [PATCH 2/3] tests: Delete some redundant test cases

data/aarch64-tpm.xml > delete mode 100644 tests/qemuxmlconfdata/tpm-emulator-spapr.ppc64-latest.args > delete mode 12 tests/qemuxmlconfdata/tpm-emulator-spapr.ppc64-latest.xml > delete mode 100644 tests/qemuxmlconfdata/tpm-emulator-spapr.xml Reviewed-by: Peter Krempa

Re: [PATCH 1/3] tests: Add TPM coverage to default-models tests

tform itself or just was omitted when building qemu which was used for the caps dump. I think it will be even harder to understand this for anyone who finds this comment later. I suggest: TPM was not compiled into the QEMU binary used for the capability dump, but platform supports it Or something similar more clear. Reviewed-by: Peter Krempa

Re: [PATCH 6/6] vsh: Don't crash when @text is NULL in vshCompleterFilter()

amp;& !STRPREFIX((*list)[i], text)) { > g_clear_pointer(&(*list)[i], g_free); > continue; Reviewed-by: Peter Krempa

Re: [PATCH 5/6] vsh: Restore original rl_line_buffer after completion

he parser code. Do we even need to call 'vshReadlineCompletion' (which just does: return rl_completion_matches(text, vshReadlineParse); from 'cmdComplete'? What does that do? Can't we use 'vshReadlineParse' instead? The fix makes sense as is, but I never really understood why 'cmdComplete' even needed readline in the first place. Reviewed-by: Peter Krempa

Re: [PATCH 4/6] vsh: Close stderr among with stdin in cmdComplete

ust consider opening a connection), just > close the stderr. We're already closing stdin. > > Signed-off-by: Michal Privoznik > --- > tools/vsh.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) Reviewed-by: Peter Krempa

Re: [PATCH 3/6] bash-completion: Run virsh/virt-admin in quiet mode

2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Krempa

Re: [PATCH 2/6] virt-admin: Make --timeout of daemon-timeout positional argument

'0' is used as way to disable the timeout. So your justification here makes sense, it's just that I really don't like positional arguments. Reviewed-by: Peter Krempa

Re: [PATCH 1/6] kbase: Use virt-admin daemon-timeout correctly

unexpected data '0' > > This is because --timeout is required. Update examples to include > it. > > Signed-off-by: Michal Privoznik > --- > docs/kbase/debuglogs.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Peter Krempa

[PATCH 3/4] virFileOpenForked: Fix handling of return value from virSocketSendFD()

: https://issues.redhat.com/browse/RHEL-36721 Signed-off-by: Peter Krempa --- src/util/virfile.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index c4d22921ce..d820172405 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c

[PATCH 4/4] NEWS: Mention migration/save bug on root_squash NFS

Signed-off-by: Peter Krempa --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index b6985980ba..4a532bb673 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -51,7 +51,14 @@ v10.4.0 (unreleased) $ virsh help list + * qemu: Fix ``virsh save`` and migration

[PATCH 0/4] qemu: Fix saving of VMs and certain migration cases on root_squash NFS

See 3/4 for explanation. Peter Krempa (4): virfile: Modernize definition of virFileOpenForked/virFileOpenForceOwnerMode/virFileOpenAs virGetGroupList: Refactor and fix callers virFileOpenForked: Fix handling of return value from virSocketSendFD() NEWS: Mention migration/save bug

[PATCH 2/4] virGetGroupList: Refactor and fix callers

Use contemporary style for declarations and automatic memory clearing for a helper string. Since the function can't fail any more, remove any mention of returning errno and remove error checks from all callers. Signed-off-by: Peter Krempa --- src/lxc/lxc_container.c | 4 ++-- src

[PATCH 1/4] virfile: Modernize definition of virFileOpenForked/virFileOpenForceOwnerMode/virFileOpenAs

Declare one argument per line and one variable per line and use boolean operators at the end of the line rather than at the beginning. Signed-off-by: Peter Krempa --- src/util/virfile.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git

Re: [PATCH] qemu: Optimize monitor event name lookup with hash tables

On Tue, May 21, 2024 at 17:36:48 +0530, Rayhan Faizel wrote: > Currently, monitor event names are looked up using binary search which has > O(log(n)) time complexity. This can be optimized even further with a > compile-time static hash table generated by the gperf tool. As gperf ensures > perfect

Re: [PATCH] Сheck snapshot disk is not NULL when searching it in the VM config

On Mon, May 20, 2024 at 14:48:47 +, Efim Shevrin via Devel wrote: > Hello, > > > If vmdisk is NULL, shouldn't this function (qemuSnapshotDeleteValidate()) > > return an error? > > I think this qemuSnapshotDeleteValidate should not return an error. > > It seems to me that when vmdisk is

[PATCH] virt-host-validate: Improve translatability of messages printed by 'virHostMsgCheck()'

Move the word 'Checking' into the appropriate formatting strings and mark all outstanding ones for translation. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/637 Signed-off-by: Peter Krempa --- tools/virt-host-validate-bhyve.c | 2 +- tools/virt-host-validate-ch.c | 2 +- tools

Re: [PATCH] qemu: fix qemu command for pci hostdevs and ramfb='off'

tests/qemuxmlconfdata/hostdev-pci-display-ramfb.xml | 5 + > 4 files changed, 13 insertions(+), 1 deletion(-) Reviewed-by: Peter Krempa

[PATCH 2/3] virshtest: Add tests for '--help'

Add test cases for help handling. Signed-off-by: Peter Krempa --- tests/virshtest.c | 3 ++ tests/virshtestdata/help-option.in | 4 ++ tests/virshtestdata/help-option.out | 64 + 3 files changed, 71 insertions(+) create mode 100644 tests

[PATCH 3/3] NEWS: Mention '--help' bug in virsh and virt-admin

Signed-off-by: Peter Krempa --- NEWS.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index bca18e8c43..b6985980ba 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,6 +37,21 @@ v10.4.0 (unreleased) * **Bug fixes** + * virsh/virt-admin: Fix ``--help

[PATCH 1/3] vsh: Fix '--help' option for virsh/virt-admin

the real options. Re-introduce the separate handling to the new parser code. Fixes: 5540c3d2415c194b206f8946cf74b13648163332 Reported-by: Lili Zhu Signed-off-by: Peter Krempa --- tools/vsh.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index

[PATCH 0/3] vsh: Fix handling of '--help' for all commands

Brown paper box was applied due to lack of paper bags. Peter Krempa (3): vsh: Fix '--help' option for virsh/virt-admin virshtest: Add tests for '--help' NEWS: Mention '--help' bug in virsh and virt-admin NEWS.rst| 15 +++ tests/virshtest.c

Re: [PATCH v2] docs: formatsnapshot: add docs for snapshotDeleteInProgress

- Insert a note to advise users against adding or removing the internal tag > "snapshotDeleteInProgress" manually. I've reworded the docs a bit further and pushed this patch. Reviewed-by: Peter Krempa

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

On Tue, May 14, 2024 at 14:49:58 +0200, Peter Krempa wrote: > On Thu, Apr 11, 2024 at 19:01:55 -0700, w...@linux.ibm.com wrote: [...] > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > > index e2f66b982c..ee9ee8b10c 100644 > > --- a/docs/formatdoma

Re: [PATCH RFC v2 12/12] config: validate: Verify throttle group fields

On Thu, Apr 11, 2024 at 19:02:00 -0700, w...@linux.ibm.com wrote: > From: Hao Ning Xin > > Both throttlegroup and iotune share the same fields, so they share the same > verification logic > > Signed-off-by: Hao Ning Xin > --- Split out the bit adding +virDomainDefValidateThrottleGroups,

Re: [PATCH RFC v2 11/12] config: validate: Use "iotune" and "throttlefilters" exclusively for specific disk

On Thu, Apr 11, 2024 at 19:01:59 -0700, w...@linux.ibm.com wrote: > From: Yan Xiu Wu > > No need to use both "iotune" and "throttlefilters" for specific disk > > Signed-off-by: Yan Xiu Wu > --- > src/conf/domain_validate.c | 8 > src/qemu/qemu_driver.c | 6 ++ > 2 files

Re: [PATCH RFC v2 10/12] virsh: Add support for throttle group operations

On Thu, Apr 11, 2024 at 19:01:58 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Add new cmds: throttlegroupset, throttlegrouplist, throttlegroupinfo, > throttlegroupdel > * Update "attach_disk" to support new option: throttle-groups to > form filter chain in QEMU for specific

Re: [PATCH RFC v2 08/12] test: Test throttle group lifecycle APIs

In subject: Refer to 'test_driver' to make it more obvious that this is not tests. On Thu, Apr 11, 2024 at 19:01:56 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Test "Set": testDomainSetThrottleGroup > * Test "Get": testDomainGetThrottleGroup > * Test "Del":

Re: [PATCH RFC v2 07/12] schema: Add new domain elements to support multiple throttle filters

On Thu, Apr 11, 2024 at 19:01:55 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Add new elements '' and '' > * contains defintions > * can include multiple throttlegroup references to form > filter chain in qemu > * Chained throttle filters feature in qemu is described at >

Re: [PATCH] docs: mention migrate-setmaxdowntime's impact on snapshot-create

On Mon, May 13, 2024 at 01:36:27 +0530, Abhiram Tilak wrote: > The migrate-setmaxdowntime command sets the max allowed downtime during > live-migration, but since `snapshot-create` performs qmp migration, it also > affects the downtime during internal/external snapshot creation. > > Resolves:

Re: [PATCH] "docs: formatsnapshot: add docs for snapshotDeleteInProgress"

On Sun, May 12, 2024 at 01:30:45 +0530, Abhiram Tilak wrote: > Adds documentation for the element to > the libvirt snapshot format XML reference. The > element, introduced at commit 565bcb5d79, ensures the consistency of qcow2 > images during snapshot deletion operations by marking disks in

Test mail

Testing messages posted via web. ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH v3 2/5] qemu: Introduce shared_filesystems configuration option

On Thu, May 09, 2024 at 06:40:01 -0700, Andrea Bolognani wrote: > On Thu, May 09, 2024 at 01:58:21PM GMT, Peter Krempa wrote: > > On Thu, May 02, 2024 at 19:39:39 +0200, Andrea Bolognani wrote: > > > +# libvirt will normally prevent migration if the stor

Re: [PATCH v3 4/5] utils: Use overrides in virFileIsSharedFS()

On Thu, May 09, 2024 at 06:54:11 -0700, Andrea Bolognani wrote: > On Thu, May 09, 2024 at 02:28:15PM GMT, Peter Krempa wrote: > > On Thu, May 02, 2024 at 19:39:41 +0200, Andrea Bolognani wrote: > > > +static bool > > > +virFileIsShared

Re: [PATCH v3 3/5] qemu: Propagate shared_filesystems

On Thu, May 09, 2024 at 06:48:36 -0700, Andrea Bolognani wrote: > On Thu, May 09, 2024 at 02:17:21PM GMT, Peter Krempa wrote: > > I'd go with 'exportedFilesystems' instead of 'sharedFilesystems' > > throughout this patch(set) for any case when the list contains only the >

Re: [PATCH v3 4/5] utils: Use overrides in virFileIsSharedFS()

On Thu, May 09, 2024 at 14:28:15 +0200, Peter Krempa wrote: > On Thu, May 02, 2024 at 19:39:41 +0200, Andrea Bolognani wrote: [...] > foreach override in overrides: > > pc = canonicalize(path); > po = canonicalize(override); > > if (STRPREFIX(pc, po)) > re

Re: [PATCH v3 5/5] qemu: Always set labels for TPM state

y exists for disks and other types of persistent > storage such as NVRAM files, which always get relabeled. > > Signed-off-by: Andrea Bolognani > Reviewed-by: Stefan Berger > --- > src/qemu/qemu_tpm.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(

Re: [PATCH v3 4/5] utils: Use overrides in virFileIsSharedFS()

On Thu, May 02, 2024 at 19:39:41 +0200, Andrea Bolognani wrote: > If the local admin has explicitly declared that a certain > filesystem is to be considered shared, we should treat it as > such. > > Signed-off-by: Andrea Bolognani > Reviewed-by: Stefan Berger > --- > src/util/virfile.c | 42

Re: [PATCH v3 3/5] qemu: Propagate shared_filesystems

ration = flags & (VIR_MIGRATE_NON_SHARED_DISK | > VIR_MIGRATE_NON_SHARED_INC); [...] With the rename very strongly considered: Reviewed-by: Peter Krempa ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH v3 2/5] qemu: Introduce shared_filesystems configuration option

On Thu, May 02, 2024 at 19:39:39 +0200, Andrea Bolognani wrote: > As explained in the comment, this can help in scenarios where > a shared filesystem can't be detected as such by libvirt, by > giving the admin the opportunity to provide this information > manually. > > Signed-off-by: Andrea

Re: [PATCH v3 1/5] security: Fix alignment

On Thu, May 02, 2024 at 19:39:38 +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > Reviewed-by: Stefan Berger > --- > src/security/security_selinux.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-b

Re: [PATCH RFC v2 00/12] Support throttle block filters

On Thu, May 09, 2024 at 16:33:17 +0800, Chun Feng Wu wrote: > Thanks Peter for above detailed review comments! just let you know, I am > addressing those comments, I will push v3 to include fixings in coming > weeks. You can fix stuff I've pointed out but there's more review to come. Please post

[PATCH] qemuxmlconftest: Test 'page_per_vq' config option for 'vhostuser' backed disk

Add a missing option for the test to prove that we parse/format this option. Signed-off-by: Peter Krempa --- Added to see whether the claim in https://gitlab.com/libvirt/libvirt/-/issues/627 is true as I was fairly certain that virtio options are parsed commonly and thus this should 'Just

Re: [PATCH 00/12] fix many test failures in various build config scenarios

slow and is likely > to be overkill. Whoah, that's rather cool. But as you note I don't think this is anything for CI and even if, this'd be something to run once a month perhaps. Otherwise it's almost as useful as mining cryptocurrencies With the few things I've pointed out inline: Series: Reviewed-by: Peter Krempa ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH 07/12] tests: build driver modules before virdrivermoduletest

On Tue, May 07, 2024 at 14:59:02 +0100, Daniel P. Berrangé wrote: > The virdrivermoduletest will attempt to dlopen() each driver module, > so they must be build before the test can run. > > Signed-off-by: Daniel P. Berrangé > --- > src/meson.build | 3 +++ > tests/meson.build | 2 +- > 2

Re: [PATCH 07/12] tests: build driver modules before virdrivermoduletest

On Tue, May 07, 2024 at 14:59:02 +0100, Daniel P. Berrangé wrote: > The virdrivermoduletest will attempt to dlopen() each driver module, > so they must be build before the test can run. > > Signed-off-by: Daniel P. Berrangé > --- > src/meson.build | 3 +++ > tests/meson.build | 2 +- > 2

Re: [PATCH 06/12] tests: build 'virsh' before running virsh-auth test

On Tue, May 07, 2024 at 14:59:01 +0100, Daniel P. Berrangé wrote: > The 'virsh-auth' test needs to be able to invoke the 'virsh' binary > > Signed-off-by: Daniel P. Berrangé > --- > tests/meson.build | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH 03/12] meson: record which other options are a pre-requisite

On Tue, May 07, 2024 at 14:58:58 +0100, Daniel P. Berrangé wrote: > Several meson options cannot be enabled, without first enabling another > option. This adds a small comment prior to an optino to record its s/optino/option/ > mandatory dependencies. > > Signed-off-by: Daniel P. Berrangé >

[PATCH 0/2] interface: Refactor code and fix old listing API when interface is unbound

Patch 1/2 removes a pointless helper in favor of making an almost identical function more universal, so that patch 2/2 then fixes all cases in one place. Peter Krempa (2): interface_udev: Replace udevNumOfInterfacesByStatus by udevListInterfacesByStatus udevListInterfacesByStatus: Don't

[PATCH 2/2] udevListInterfacesByStatus: Don't try to return NULL names

this by simply ignoring such interfaces as there's nothing we can report in such case. A similar fix was done to 'udevConnectListAllInterfaces' in commit 2ca94317ac6. Resolves: https://issues.redhat.com/browse/RHEL-34615 Signed-off-by: Peter Krempa --- src/interface/interface_backend_udev.c | 10

[PATCH 1/2] interface_udev: Replace udevNumOfInterfacesByStatus by udevListInterfacesByStatus

Make the array-filling operation of udevListInterfacesByStatus optional and replace the completely redundant udevNumOfInterfacesByStatus by it. Further patches fixing the listing will not need to be duplicated. Signed-off-by: Peter Krempa --- src/interface/interface_backend_udev.c | 76

Re: [PATCH RFC v2 06/12] qemu: command: Support throttle groups and filters during qemuProcessLaunch

On Thu, Apr 11, 2024 at 19:01:54 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Add qemuBuildThrottleGroupCommandLine in qemuBuildCommandLine > * Add qemuBuildThrottleFiltersCommandLine in qemuBuildDiskCommandLine > * Make sure referenced throttle group exists > > Signed-off-by:

Re: [PATCH RFC v2 05/12] qemu: hotplug: Support hot attach block disk along with throttle filters

On Thu, Apr 11, 2024 at 19:01:53 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > When attaching disk along with specified throttle groups, those groups will > be chained up by parent node name, this change includes service side codes: > * Each filter references one throttle group by

Re: [PATCH RFC v2 04/12] qemu: Implement qemu driver for throttle API

On Thu, Apr 11, 2024 at 19:01:52 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Implement the following methods: > * virDomainSetThrottleGroup > * virDomainGetThrottleGroup > * virDomainDelThrottleGroup Similarly to previous patch, note how you've done this rather than what you've

Re: [PATCH RFC v2 01/12] config: Introduce ThrottleGroup and ThrottleFilter

On Thu, Apr 11, 2024 at 19:01:49 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Define new structs 'virDomainThrottleGroupDef' and > 'virDomainThrottleFilterDef' > * Update _virDomainDef to include virDomainThrottleGroupDef > * Update _virDomainDiskDef to include

Re: [PATCH RFC v2 03/12] remote: New APIs for ThrottleGroup lifecycle management

On Thu, Apr 11, 2024 at 19:01:51 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Support throttlegroup lifecycle management by the following implementation: > * New methods defined in "include/libvirt/libvirt-domain.h" > * And they're exported in "src/libvirt_public.syms" > *

Re: [PATCH RFC v2 09/12] tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup

On Thu, Apr 11, 2024 at 19:01:57 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup" > * Test qemuMonitorJSONGetThrottleGroup > * Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through > "qom-set" > >

Re: [PATCH RFC v2 02/12] qemu: monitor: Add support for ThrottleGroup operations

On Thu, Apr 11, 2024 at 19:01:50 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > * ThrottleGroup is deleted by reusing

Re: [PATCH RFC v2 02/12] qemu: monitor: Add support for ThrottleGroup operations

On Thu, Apr 11, 2024 at 19:01:50 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > * ThrottleGroup is deleted by reusing

Re: [PATCH RFC v2 01/12] config: Introduce ThrottleGroup and ThrottleFilter

On Thu, Apr 11, 2024 at 19:01:49 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Define new structs 'virDomainThrottleGroupDef' and > 'virDomainThrottleFilterDef' > * Update _virDomainDef to include virDomainThrottleGroupDef > * Update _virDomainDiskDef to include

Re: [PATCH RESEND] NEWS: Document my contributions for upcoming release

On Thu, May 02, 2024 at 09:41:09 +0200, Michal Prívozník wrote: > On 5/2/24 09:33, Peter Krempa wrote: > > On Thu, May 02, 2024 at 08:52:17 +0200, Michal Privoznik wrote: > >> Signed-off-by: Michal Privoznik > >> --- > >> > >> Rebased versio

Re: [PATCH RESEND] NEWS: Document my contributions for upcoming release

he firmware does stuff correctly. I don't know the details but is really firmware the problem when hotplugging? Isn't this more of a hint to the guest OS? As I don't have a better suggestion: Reviewed-by: Peter Krempa ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

[PATCH 2/2] NEWS: Document TLS migration bug, usb-net support and two fixes

Signed-off-by: Peter Krempa --- NEWS.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index da3fdb21ac..6b92270c9d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,8 +17,24 @@ v10.3.0 (unreleased) * **New features** + * qemu: Proper support

[PATCH 0/2] NEWS fix/update

Peter Krempa (2): NEWS: Fix marking of 'path' as inline literal NEWS: Document TLS migration bug, usb-net support and two fixes NEWS.rst | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) -- 2.44.0 ___ Devel mailing

[PATCH 1/2] NEWS: Fix marking of 'path' as inline literal

Signed-off-by: Peter Krempa --- NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 852dadf532..da3fdb21ac 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -39,7 +39,7 @@ v10.2.0 (2024-04-02) The ch driver now supports basic save and restore

Re: [PATCH] fix detach disk device failed with device not found

On Fri, Apr 26, 2024 at 12:29:05 +0800, long.yunj...@zte.com.cn wrote: > From: Long YunJian > > We detach windows disk with libvirt-python api > dom.detachDeviceFlags(xmlstr,3), > but files in windows disk is opened and busy, and libvirt return success. > We found disk not detached actually.

  1   2   3   4   5   6   7   8   9   >