Hi,
A week has passed, so I'm bumping this.
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On 4/17/24 15:58, Cole Robinson wrote:
Simplest solution is to fill in `active_config` at XML define time
as well. The real node_device driver already takes care to free any
`active_config` when it live updates this info, so we are safe there.
I do not think that it is a good idea to hack the ge
The purpose of ERROR() macro in our NSS module is to print error
message provided as arguments followed by error string
corresponding to errno. Historically, we've used strerror_r() for
that (please note, we want our NSS module to be free of libvirt
internal functions, or glib even - hence, g_strer
On Thu, Apr 18, 2024 at 13:00:48 +0200, Michal Privoznik wrote:
> The purpose of ERROR() macro in our NSS module is to print error
> message provided as arguments followed by error string
> corresponding to errno. Historically, we've used strerror_r() for
> that (please note, we want our NSS module
On 27/3/24 15:48, Philippe Mathieu-Daudé wrote:
The Nios II target is deprecated since v8.2 in commit 9997771bc1
("target/nios2: Deprecate the Nios II architecture").
Remove:
- Buildsys / CI infra
- User emulation
- System emulation (10m50-ghrd & nios2-generic-nommu machines)
- Tests
Cc: Marek
On 4/17/24 10:12 AM, Daniel P. Berrangé wrote:
> On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote:
>> On 4/9/24 11:20 AM, Boris Fiuczynski wrote:
>>> On 4/9/24 16:56, Cole Robinson wrote:
Commit v10.0.0-265-ge67bca23e4 added a `active_config` and
`defined_config` to nodedev m
On 4/18/24 5:11 AM, Boris Fiuczynski wrote:
> On 4/17/24 15:58, Cole Robinson wrote:
Simplest solution is to fill in `active_config` at XML define time
as well. The real node_device driver already takes care to free any
`active_config` when it live updates this info, so we are safe t
On 4/18/24 8:52 AM, Cole Robinson wrote:
On 4/17/24 10:12 AM, Daniel P. Berrangé wrote:
On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote:
On 4/9/24 11:20 AM, Boris Fiuczynski wrote:
On 4/9/24 16:56, Cole Robinson wrote:
Commit v10.0.0-265-ge67bca23e4 added a `active_config` and
`
On Thu, Apr 18, 2024 at 09:03:45AM -0500, Jonathon Jongsma wrote:
> On 4/18/24 8:52 AM, Cole Robinson wrote:
> > On 4/17/24 10:12 AM, Daniel P. Berrangé wrote:
> > > On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote:
> > > > On 4/9/24 11:20 AM, Boris Fiuczynski wrote:
> > > > > On 4/9/2
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
From: Boris Fiuczynski
When an udev add event occurs the mdev active config data requires an
update via mdevctl as the udev does not contain all config data.
This update needs to occur immediate and to be finished before the
s/immediate/immediately/
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
From: Boris Fiuczynski
When a mdev device is destroyed or stopped the udev remove event
handling needs to reset the active config data of the node object
representing a persisted mdev.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
Signe
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
Remove the timeout when the udevEventData is disposed, analogous to priv->watch.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/node_devic
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
It is done a little differently everywhere in libvirt, but most common is to
test for != -1.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
Commit a99d876a0f58 ("node_device: Use automatic mutex management") replaced the
locking mechanism and accidentally removed the comment with the reason why the
lock is taken. Restore this comment and add a new comment about the lock.
Reviewed-by: Boris F
On 4/17/24 11:20, Andrea Bolognani wrote:
On Wed, Mar 20, 2024 at 09:10:48AM -0700, Andrea Bolognani wrote:
On Wed, Mar 20, 2024 at 10:18:39AM -0400, Stefan Berger wrote:
On 3/20/24 08:23, Peter Krempa wrote:
Did you consider the case when the migration fails and the VM will be
restored to r
On 4/17/24 09:29, Andrea Bolognani wrote:
If the local admin has explicitly declared that a certain
filesystem is to be considered shared, we should treat it as
such.
Signed-off-by: Andrea Bolognani
---
src/util/virfile.c | 42 +-
1 file changed,
On 4/17/24 09:29, Andrea Bolognani wrote:
virFileIsSharedFS() is the function that ultimately decides
whether a filesystem should be considered shared, but the list
of manually configured shared filesystems is part of the QEMU
driver's configuration, so we need to pass the information
through s
On 4/17/24 09:29, Andrea Bolognani wrote:
Up until this point, we have avoided setting labels for
incoming migration when the TPM state is stored on a shared
filesystem. This seems to make sense, because since the
underlying storage is shared surely the labels will be as
well.
There's one prob
On Wed, Mar 20, 2024 at 01:22:15PM +0100, Peter Krempa wrote:
> On Wed, Mar 20, 2024 at 12:37:37 +0100, Peter Krempa wrote:
> > On Wed, Mar 20, 2024 at 10:19:11 +0100, Andrea Bolognani wrote:
> > > As explained in the comment, this can help in scenarios where
> > > a shared filesystem can't be dete
On Wed, Mar 20, 2024 at 09:10:48AM -0700, Andrea Bolognani wrote:
> On Wed, Mar 20, 2024 at 10:18:39AM -0400, Stefan Berger wrote:
> > On 3/20/24 08:23, Peter Krempa wrote:
> > > On Wed, Mar 20, 2024 at 10:19:14 +0100, Andrea Bolognani wrote:
> > > > Consider the case in which one host (mig-one) ex
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
Since @driver->privateData is modified take the lock.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/node_de
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
The new names make it easier to understand the purpose of the data.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 48 +++---
1 file changed, 24 insertions(+), 24 deletion
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
Inline `udevRemoveOneDevice` as it's used only once.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
Use the proper driver functions for the node state shutdown preparation and
wait. In the next patch, these functions will be extended.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 54 +++---
1 file ch
On 4/12/24 8:36 AM, Marc Hartmayer wrote:
Use a worker pool for processing the udev events and the initialization instead
of a separate initThread and a mdevctl-thread. This has the large advantage that
we can leverage the job API and now this thread pool is responsible to do all
the "costly-work
25 matches
Mail list logo
