Re: [OMPI devel] [EXTERNAL] Re: [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Jeff Squyres]

I see that Automake is including a .l.c rule.  And I see that if I touch a .l 
file, it automatically runs flex to generate a new .c file, and then compiles 
that .c file.  For example:

--
[13:19] jsquyres-mac:~/svn/ompi3/opal/util % touch show_help_lex.l
[13:20] jsquyres-mac:~/svn/ompi3/opal/util % make
Making all in keyval
make[1]: Nothing to be done for `all'.
  LEXshow_help_lex.c
  CC show_help_lex.lo
  CCLD   libopalutil.la
/usr/bin/ranlib: file: .libs/libopalutil.a(qsort.o) has no symbols
-

So I guess I'd like to see a specific case where editing a .l file does not 
re-generate the .c file properly.


On Dec 4, 2012, at 9:58 AM, Barrett, Brian W wrote:

> We should never have to have the makefile extension. Just making sure the lex 
> file gets included should work. When Nathan commits his patch, I'll take a 
> look.
> 
> Brian
> 
> 
> 
> Sent with Good (www.good.com)
> 
> 
> -Original Message-
> 
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

Re: [OMPI devel] [EXTERNAL] Re: [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Barrett, Brian W]

We should never have to have the makefile extension. Just making sure the lex 
file gets included should work. When Nathan commits his patch, I'll take a look.

Brian



Sent with Good (www.good.com)


 -Original Message-

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Jeff Squyres]

On Dec 3, 2012, at 5:39 PM, Hjelm, Nathan T wrote:

> Oh, and I don't know if you have tried this but we don't recreate the 
> keyval_lex.c file if it already exists. This allows use to not put a flex 
> requirement on the end user.

Why?  Shouldn't we have a proper .l.c rule in the Makefile.am?

Does that somehow cause tarball builds to invoke flex?  And if so, should we 
put the .l.c rule in an automake conditional something like:

if THIS_IS_A_DEVELOPER_BUILD
.l.c:
   flex 
endif

-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Hjelm, Nathan T]

Ok, looks like the patch I am working on will solve your issue then. I will 
push on getting it pushed today.

-Nathan

On Tuesday, December 04, 2012 2:37 AM, devel-boun...@open-mpi.org 
[devel-boun...@open-mpi.org] on behalf of George Bosilca [bosi...@icl.utk.edu] 
wrote:
> To: Open MPI Developers
> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:
> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml
> opal/util/keyval orte/mca/rmaps/rank_file
> 
> This doesn't work on a subversion checkout. However, there is a similar trick 
> that seems to work in this case. If one copies the 
> opal/util/keyval/keyval_lex.c file from a platform with a recent version of 
> flex (2.5.37 in my case) the compilation proceed without issues.
> 
>   george.
> 
> On Dec 4, 2012, at 02:39 , "Hjelm, Nathan T"  wrote:
> 
>> Oh, and I don't know if you have tried this but we don't recreate the 
>> keyval_lex.c file if it already exists. This allows use to not put a flex 
>> requirement on the end user. Have you tried removing 
>> opal/util/keyval/keyval_lex.c? If that works you might want to run 
>> configure/make from an empty directory.
>>
>> -Nathan
>>
>> On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
>> [devel-boun...@open-mpi.org] on behalf of George Bosilca 
>> [bosi...@icl.utk.edu] wrote:
>>> To: de...@open-mpi.org
>>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:
>>> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
>>> orte/mca/rmaps/rank_file
>>>
>>> I remember there were some discussions about lex (or flex) and their 
>>> version, but I don't remember the specifics. Whatever the outcome was, 
>>> we're back at having a problem there, more specifically a missing reference 
>>> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
>>> fixed.
>>>
>>>  george.
>>>
>>>
>>>
>>>
>>> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
>>>
 Author: hjelmn (Nathan Hjelm)
 Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
 New Revision: 27580
 URL: https://svn.open-mpi.org/trac/ompi/changeset/27580

 Log:
 add prototypes for lex destroy functions

 Text files modified:
  trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
  trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
  trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
  trunk/opal/util/keyval/keyval_lex.h  | 1 +
  trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
  5 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

[OMPI devel] Collective SM memory affinity possible error

[Juan A. Rico]

I am studying the collective SM code and I think that there is a small error in 
the code related to how the memory affinity is achieved. I attach a patch file 
(from subversion revision 27653), I hope it can be useful:

Index: coll_sm_module.c
===
--- coll_sm_module.c(revisión: 27653)
+++ coll_sm_module.c(copia de trabajo)
@@ -434,7 +434,7 @@
 maffinity[j].mbs_len = c->sm_fragment_size;
 maffinity[j].mbs_start_addr = 
 data->mcb_data_index[i].mcbmi_data +
-(rank * c->sm_control_size);
+(rank * c->sm_fragment_size);
 ++j;
 #endif
 }


Regards,
Juan A. Rico




__
Juan Antonio Rico Gallego
Dept. Computer Systems Engineering and Telematics
University of Extremadura
E. U. Politécnica
10003, Cáceres
Tlf.: (+34) 927 25 7200 ext. 51655
jar...@unex.es
http://gim.unex.es/azequiampi

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[George Bosilca]

This doesn't work on a subversion checkout. However, there is a similar trick 
that seems to work in this case. If one copies the 
opal/util/keyval/keyval_lex.c file from a platform with a recent version of 
flex (2.5.37 in my case) the compilation proceed without issues.

  george.

On Dec 4, 2012, at 02:39 , "Hjelm, Nathan T"  wrote:

> Oh, and I don't know if you have tried this but we don't recreate the 
> keyval_lex.c file if it already exists. This allows use to not put a flex 
> requirement on the end user. Have you tried removing 
> opal/util/keyval/keyval_lex.c? If that works you might want to run 
> configure/make from an empty directory.
> 
> -Nathan
> 
> On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
> [devel-boun...@open-mpi.org] on behalf of George Bosilca 
> [bosi...@icl.utk.edu] wrote:
>> To: de...@open-mpi.org
>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:
>> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
>> orte/mca/rmaps/rank_file
>> 
>> I remember there were some discussions about lex (or flex) and their 
>> version, but I don't remember the specifics. Whatever the outcome was, we're 
>> back at having a problem there, more specifically a missing reference 
>> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
>> fixed.
>> 
>>  george.
>> 
>> 
>> 
>> 
>> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
>> 
>>> Author: hjelmn (Nathan Hjelm)
>>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>>> New Revision: 27580
>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>> 
>>> Log:
>>> add prototypes for lex destroy functions
>>> 
>>> Text files modified:
>>>  trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>>  trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>>  trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>>  trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>>  trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>>  5 files changed, 6 insertions(+), 0 deletions(-)
>> 
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel