Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Hjelm, Nathan T]

Well, I *think* the destroy functions I added to the .l files for the old flex 
case will clean up everything correctly. What I mean is we will correctly clean 
up  when using new flex (valgrind clean). We still recommend using new flex 
(2.5.33 or newer recommended) but we will continue to support old flex because 
of Redhat's decision to include old flex in RHEL 5.

-Nathan

From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of Paul 
Hargrove [phhargr...@lbl.gov]
Sent: Thursday, December 06, 2012 5:20 PM
To: Open MPI Developers
Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: 
ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval 
orte/mca/rmaps/rank_file

Nathan,

What does this mean with respect to "clean up" and old flex?
Have you simply conceded that old flex will leak memory?

-Paul

On Thu, Dec 6, 2012 at 4:16 PM, Hjelm, Nathan T 
<hje...@lanl.gov<mailto:hje...@lanl.gov>> wrote:
Done. We now clean up correctly in new flex while having support for old flex.

-Nathan

--
Paul H. Hargrove  
phhargr...@lbl.gov<mailto:phhargr...@lbl.gov>
Future Technologies Group
Computer and Data Sciences Department Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory Fax: +1-510-486-6900

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Paul Hargrove]

Nathan,

What does this mean with respect to "clean up" and old flex?
Have you simply conceded that old flex will leak memory?

-Paul

On Thu, Dec 6, 2012 at 4:16 PM, Hjelm, Nathan T  wrote:

> Done. We now clean up correctly in new flex while having support for old
> flex.
>
> -Nathan


-- 
Paul H. Hargrove  phhargr...@lbl.gov
Future Technologies Group
Computer and Data Sciences Department Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory Fax: +1-510-486-6900

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Hjelm, Nathan T]

Done. We now clean up correctly in new flex while having support for old flex.

-Nathan

On Monday, December 03, 2012 6:36 PM, devel-boun...@open-mpi.org 
[devel-boun...@open-mpi.org] on behalf of George Bosilca [bosi...@icl.utk.edu] 
wrote:
> To: Open MPI Developers
> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:    
> ompi/mca/btl/openib ompi/mca/btl/wv     ompi/mca/coll/ml    
> opal/util/keyval orte/mca/rmaps/rank_file
> 
> Cool, I'm looking forward. Meanwhile I'll go back and use the 1.6, which 
> hopefully compiles.
> 
>   Thanks,
> george.
> 
> 
> On Dec 4, 2012, at 02:34 , "Hjelm, Nathan T" <hje...@lanl.gov> wrote:
> 
>> Sorry about that. We are working on a fix that both supports flex 2.5.4 
>> (*#*&@ redhat) and cleans up the lex state correctly in modern flex. It 
>> should be done in the next day or so.
>>
>> -Nathan
>>
>> On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
>> [devel-boun...@open-mpi.org] on behalf of George Bosilca 
>> [bosi...@icl.utk.edu] wrote:
>>> To: de...@open-mpi.org
>>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:
>>> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
>>> orte/mca/rmaps/rank_file
>>>
>>> I remember there were some discussions about lex (or flex) and their 
>>> version, but I don't remember the specifics. Whatever the outcome was, 
>>> we're back at having a problem there, more specifically a missing reference 
>>> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
>>> fixed.
>>>
>>>  george.
>>>
>>>
>>>
>>>
>>> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
>>>
>>>> Author: hjelmn (Nathan Hjelm)
>>>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>>>> New Revision: 27580
>>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>>>
>>>> Log:
>>>> add prototypes for lex destroy functions
>>>>
>>>> Text files modified:
>>>>  trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>>>  trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>>>  trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>>>  trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>>>  trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>>>  5 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Jeff Squyres]

On Dec 3, 2012, at 5:39 PM, Hjelm, Nathan T wrote:

> Oh, and I don't know if you have tried this but we don't recreate the 
> keyval_lex.c file if it already exists. This allows use to not put a flex 
> requirement on the end user.

Why?  Shouldn't we have a proper .l.c rule in the Makefile.am?

Does that somehow cause tarball builds to invoke flex?  And if so, should we 
put the .l.c rule in an automake conditional something like:

if THIS_IS_A_DEVELOPER_BUILD
.l.c:
   flex 
endif

-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Hjelm, Nathan T]

Ok, looks like the patch I am working on will solve your issue then. I will 
push on getting it pushed today.

-Nathan

On Tuesday, December 04, 2012 2:37 AM, devel-boun...@open-mpi.org 
[devel-boun...@open-mpi.org] on behalf of George Bosilca [bosi...@icl.utk.edu] 
wrote:
> To: Open MPI Developers
> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:    
> ompi/mca/btl/openib ompi/mca/btl/wv     ompi/mca/coll/ml    
> opal/util/keyval orte/mca/rmaps/rank_file
> 
> This doesn't work on a subversion checkout. However, there is a similar trick 
> that seems to work in this case. If one copies the 
> opal/util/keyval/keyval_lex.c file from a platform with a recent version of 
> flex (2.5.37 in my case) the compilation proceed without issues.
> 
>   george.
> 
> On Dec 4, 2012, at 02:39 , "Hjelm, Nathan T" <hje...@lanl.gov> wrote:
> 
>> Oh, and I don't know if you have tried this but we don't recreate the 
>> keyval_lex.c file if it already exists. This allows use to not put a flex 
>> requirement on the end user. Have you tried removing 
>> opal/util/keyval/keyval_lex.c? If that works you might want to run 
>> configure/make from an empty directory.
>>
>> -Nathan
>>
>> On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
>> [devel-boun...@open-mpi.org] on behalf of George Bosilca 
>> [bosi...@icl.utk.edu] wrote:
>>> To: de...@open-mpi.org
>>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:
>>> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
>>> orte/mca/rmaps/rank_file
>>>
>>> I remember there were some discussions about lex (or flex) and their 
>>> version, but I don't remember the specifics. Whatever the outcome was, 
>>> we're back at having a problem there, more specifically a missing reference 
>>> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
>>> fixed.
>>>
>>>  george.
>>>
>>>
>>>
>>>
>>> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
>>>
>>>> Author: hjelmn (Nathan Hjelm)
>>>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>>>> New Revision: 27580
>>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>>>
>>>> Log:
>>>> add prototypes for lex destroy functions
>>>>
>>>> Text files modified:
>>>>  trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>>>  trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>>>  trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>>>  trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>>>  trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>>>  5 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[George Bosilca]

This doesn't work on a subversion checkout. However, there is a similar trick 
that seems to work in this case. If one copies the 
opal/util/keyval/keyval_lex.c file from a platform with a recent version of 
flex (2.5.37 in my case) the compilation proceed without issues.

  george.

On Dec 4, 2012, at 02:39 , "Hjelm, Nathan T" <hje...@lanl.gov> wrote:

> Oh, and I don't know if you have tried this but we don't recreate the 
> keyval_lex.c file if it already exists. This allows use to not put a flex 
> requirement on the end user. Have you tried removing 
> opal/util/keyval/keyval_lex.c? If that works you might want to run 
> configure/make from an empty directory.
> 
> -Nathan
> 
> On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
> [devel-boun...@open-mpi.org] on behalf of George Bosilca 
> [bosi...@icl.utk.edu] wrote:
>> To: de...@open-mpi.org
>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:    
>> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
>> orte/mca/rmaps/rank_file
>> 
>> I remember there were some discussions about lex (or flex) and their 
>> version, but I don't remember the specifics. Whatever the outcome was, we're 
>> back at having a problem there, more specifically a missing reference 
>> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
>> fixed.
>> 
>>  george.
>> 
>> 
>> 
>> 
>> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
>> 
>>> Author: hjelmn (Nathan Hjelm)
>>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>>> New Revision: 27580
>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>> 
>>> Log:
>>> add prototypes for lex destroy functions
>>> 
>>> Text files modified:
>>>  trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>>  trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>>  trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>>  trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>>  trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>>  5 files changed, 6 insertions(+), 0 deletions(-)
>> 
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Hjelm, Nathan T]

Oh, and I don't know if you have tried this but we don't recreate the 
keyval_lex.c file if it already exists. This allows use to not put a flex 
requirement on the end user. Have you tried removing 
opal/util/keyval/keyval_lex.c? If that works you might want to run 
configure/make from an empty directory.

-Nathan

On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
[devel-boun...@open-mpi.org] on behalf of George Bosilca [bosi...@icl.utk.edu] 
wrote:
> To: de...@open-mpi.org
> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:    
> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
> orte/mca/rmaps/rank_file
> 
> I remember there were some discussions about lex (or flex) and their version, 
> but I don't remember the specifics. Whatever the outcome was, we're back at 
> having a problem there, more specifically a missing reference 
> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
> fixed.
> 
>   george.
> 
> 
> 
> 
> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
> 
>> Author: hjelmn (Nathan Hjelm)
>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>> New Revision: 27580
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>
>> Log:
>> add prototypes for lex destroy functions
>>
>> Text files modified:
>>   trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>   trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>   trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>   trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>   trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>   5 files changed, 6 insertions(+), 0 deletions(-)
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[George Bosilca]

Cool, I'm looking forward. Meanwhile I'll go back and use the 1.6, which 
hopefully compiles.

  Thanks,
george.


On Dec 4, 2012, at 02:34 , "Hjelm, Nathan T" <hje...@lanl.gov> wrote:

> Sorry about that. We are working on a fix that both supports flex 2.5.4 
> (*#*&@ redhat) and cleans up the lex state correctly in modern flex. It 
> should be done in the next day or so.
> 
> -Nathan
> 
> On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
> [devel-boun...@open-mpi.org] on behalf of George Bosilca 
> [bosi...@icl.utk.edu] wrote:
>> To: de...@open-mpi.org
>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:    
>> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/mlopal/util/keyval 
>> orte/mca/rmaps/rank_file
>> 
>> I remember there were some discussions about lex (or flex) and their 
>> version, but I don't remember the specifics. Whatever the outcome was, we're 
>> back at having a problem there, more specifically a missing reference 
>> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
>> fixed.
>> 
>>  george.
>> 
>> 
>> 
>> 
>> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
>> 
>>> Author: hjelmn (Nathan Hjelm)
>>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>>> New Revision: 27580
>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>> 
>>> Log:
>>> add prototypes for lex destroy functions
>>> 
>>> Text files modified:
>>>  trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>>  trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>>  trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>>  trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>>  trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>>  5 files changed, 6 insertions(+), 0 deletions(-)
>> 
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[Hjelm, Nathan T]

Sorry about that. We are working on a fix that both supports flex 2.5.4 (*#*&@ 
redhat) and cleans up the lex state correctly in modern flex. It should be done 
in the next day or so.

-Nathan

On Monday, December 03, 2012 6:28 PM, devel-boun...@open-mpi.org 
[devel-boun...@open-mpi.org] on behalf of George Bosilca [bosi...@icl.utk.edu] 
wrote:
> To: de...@open-mpi.org
> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk:    
> ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml    opal/util/keyval 
> orte/mca/rmaps/rank_file
> 
> I remember there were some discussions about lex (or flex) and their version, 
> but I don't remember the specifics. Whatever the outcome was, we're back at 
> having a problem there, more specifically a missing reference 
> (opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
> fixed.
> 
>   george.
> 
> 
> 
> 
> On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:
> 
>> Author: hjelmn (Nathan Hjelm)
>> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
>> New Revision: 27580
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
>>
>> Log:
>> add prototypes for lex destroy functions
>>
>> Text files modified:
>>   trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +
>>   trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +
>>   trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +
>>   trunk/opal/util/keyval/keyval_lex.h  | 1 +
>>   trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++
>>   5 files changed, 6 insertions(+), 0 deletions(-)
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r27580 - in trunk: ompi/mca/btl/openib ompi/mca/btl/wv ompi/mca/coll/ml opal/util/keyval orte/mca/rmaps/rank_file

[George Bosilca]

I remember there were some discussions about lex (or flex) and their version, 
but I don't remember the specifics. Whatever the outcome was, we're back at 
having a problem there, more specifically a missing reference 
(opal_util_keyval_yylex_destroy) which seems to indicate the issue was not 
fixed.

  george.

 

config.log.bz2
Description: BZip2 compressed data


On Nov 9, 2012, at 23:00 , svn-commit-mai...@open-mpi.org wrote:

> Author: hjelmn (Nathan Hjelm)
> Date: 2012-11-09 17:00:27 EST (Fri, 09 Nov 2012)
> New Revision: 27580
> URL: https://svn.open-mpi.org/trac/ompi/changeset/27580
> 
> Log:
> add prototypes for lex destroy functions
> 
> Text files modified: 
>   trunk/ompi/mca/btl/openib/btl_openib_lex.h   | 1 +  
>  
>   trunk/ompi/mca/btl/wv/btl_wv_lex.h   | 1 +  
>  
>   trunk/ompi/mca/coll/ml/coll_ml_lex.h | 1 +  
>  
>   trunk/opal/util/keyval/keyval_lex.h  | 1 +  
>  
>   trunk/orte/mca/rmaps/rank_file/rmaps_rank_file.h | 2 ++ 
>  
>   5 files changed, 6 insertions(+), 0 deletions(-)