Re: [Devel] locking on SunOS

2008-09-18 Thread Jason Pollock
P. A. Bagyenda wrote: Jason, Thanks. It would be nice to see a full patch against latest CVS for this. As I've said, my version of Mbuni is drastically different from CVS. :) I'll see what I can do. On Sep 19, 2008, at 02:16, Jason Pollock wrote: P. A. Bagyenda wrote: Thanks for the

Re: [Devel] locking on SunOS

2008-09-18 Thread P. A. Bagyenda
Jason, Thanks. It would be nice to see a full patch against latest CVS for this. On Sep 19, 2008, at 02:16, Jason Pollock wrote: P. A. Bagyenda wrote: Thanks for the review. If you would, kindly share a non-destructive patch for further discussion. Here are the changes that I applied

Re: [Devel] locking on SunOS

2008-09-18 Thread Jason Pollock
P. A. Bagyenda wrote: Thanks for the review. If you would, kindly share a non-destructive patch for further discussion. Here are the changes that I applied based on the comments. Index: mms_util.c === RCS file: /home/cvs/MBUNI

Re: [Devel] locking on SunOS

2008-09-18 Thread Jason Pollock
Christian Theil Have wrote: I've been testing the patch and it seems to work out allright :-) A few notes; #include must be outside #ifdef SunOS - other systems needs it too in unlock_and_fclose(FILE *fp) fclose is only called in #else, I suppose that should have been like for unlock_and_clos

Re: [Devel] locking on SunOS

2008-09-18 Thread P. A. Bagyenda
Thanks for the review. If you would, kindly share a non-destructive patch for further discussion. P. On Sep 18, 2008, at 17:05, Christian Theil Have wrote: I've been testing the patch and it seems to work out allright :-) A few notes; #include must be outside #ifdef SunOS - other syste

Re: [Devel] locking on SunOS

2008-09-18 Thread Christian Theil Have
I've been testing the patch and it seems to work out allright :-) A few notes; #include must be outside #ifdef SunOS - other systems needs it too in unlock_and_fclose(FILE *fp) fclose is only called in #else, I suppose that should have been like for unlock_and_close or we'll run out of filehand