David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Wed, 26 Sep 2007 17:53:40 -0600
This patch add support for dynamically allocating the statistics counters
for the loopback device and adds appropriate device methods for allocating
and freeing the
KAMEZAWA Hiroyuki wrote:
Following patch is for successful rmdir in memory cgroup.
Currently, rmdir against memory cgroup will fail if charged page caches are
in cgroup.
(even if no tasks in cgroup.)
I don't like this. This patch implements forced uncharge against memory
cgroup.
Christoph Lameter wrote:
On Wed, 26 Sep 2007, Pavel Emelyanov wrote:
Is it necessary to mark all the existing slabs with SLAB_DEBUG? Would it
Yup. Otherwise we can never receive a single event e.g. if we make
alloc/free in a loop, or similar, so that new slabs simply are not
created.
Christoph Lameter wrote:
On Wed, 26 Sep 2007, Pavel Emelyanov wrote:
True, but we mark the slubs as notifyable at runtime, after they
are merged. However, once someone decides to make his slab notifyable
from the very beginning this makes sense, thanks.
This also makes sense if a device
Eric W. Biederman wrote:
Daniel Lezcano [EMAIL PROTECTED] writes:
From: Daniel Lezcano [EMAIL PROTECTED]
Denis Lunev spotted that if we take a reference to the network namespace
with the timewait sockets, we will need to wait for their expiration to
have the network namespace freed. This is a
Eric W. Biederman wrote:
This patch allows you to create a new network namespace
using sys_clone, or sys_unshare.
As the network namespace is still experimental and under development
clone and unshare support is only made available when CONFIG_NET_NS is
selected at compile time.
As this
[EMAIL PROTECTED] writes:
From: Daniel Lezcano [EMAIL PROTECTED]
Actually when a network device is linked to another, the name appears
to be @link. For example, if a macvlan0 is created on top of eth0,
the ip link show is:
6: [EMAIL PROTECTED]: BROADCAST,MULTICAST mtu 1500 qdisc noop
Denis Lunev spotted that using a reference to the network namespace
with the timewait sockets will be a waste of time because they
are pointless while we will remove the network stack at network
namespace exit.
The following patches do the following:
- fix missing network namespace
From: Daniel Lezcano [EMAIL PROTECTED]
When a socket changes to a timewait socket, the network namespace
is not copied from the original socket.
Here we hold a usage reference, not the ref count on the network
namespace, so the network namespace will be freed either the usage
reference is not 0.
From: Daniel Lezcano [EMAIL PROTECTED]
Denis Lunev spotted that if we take a reference to the network namespace
with the timewait sockets, we will need to wait for their expiration to
have the network namespace freed. This is a waste of time, the timewait
sockets are for avoiding to receive a
Eric W. Biederman wrote:
This patch makes loopback_dev per network namespace. Adding
code to create a different loopback device for each network
namespace and adding the code to free a loopback device
when a network namespace exits.
This patch modifies all users the loopback_dev so they
Loopback device is special. It should be initialized at the very
beginning. Initialization order has been changed by
Eric W. Biederman [EMAIL PROTECTED] and this change is non-obvious
and important enough to add proper comment.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
Pavel Emelyanov wrote:
The option is called NAMESPACES. It can be selectable only
if EMBEDDED is chosen (this was Eric's requisition). When
the EMBEDDED is off namespaces will be on automatically.
One more option (NAMESPACES_EXPERIMENTAL) was added by
Serge's request to move there all the
Pavel Emelyanov wrote:
Currently all the namespace management code is in the
kernel/utsname.c file, so just compile it out and make
stub in .h file.
The init namespace itself is in init/version.c and is
left in the kernel.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by:
Pavel Emelyanov wrote:
We currently have a CONFIG_USER_NS option. Just rename it
into CONFIG_NAMESPACES_EXPERIMANTAL and move the init_user_ns
into user.c file to make the kernel compile and work without
the namespaces support.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by:
Daniel Lezcano wrote:
From: Daniel Lezcano [EMAIL PROTECTED]
When a socket changes to a timewait socket, the network namespace
is not copied from the original socket.
Here we hold a usage reference, not the ref count on the network
namespace, so the network namespace will be freed either
Pavel Emelyanov wrote:
Currently all the IPC namespace management code is in
ipc/util.c. I moved this code into ipc/namespace.c file
which is compiled out when needed.
The linux/ipc_namespace.h file is used to store the
prototypes of the functions in namespace.c and the stubs
for
Sorry for a delay in answer. A was ill last three days.
Some stylistic comments inside
Daniel Lezcano wrote:
From: Daniel Lezcano [EMAIL PROTECTED]
The network namespace cleanup will remove all timewait sockets
related to it because there are pointless.
The problem is we need to browse
Denis V. Lunev wrote:
Sorry for a delay in answer. A was ill last three days.
Some stylistic comments inside
Daniel Lezcano wrote:
From: Daniel Lezcano [EMAIL PROTECTED]
The network namespace cleanup will remove all timewait sockets
related to it because there are pointless.
The problem is
Daniel Lezcano wrote:
[ cut ]
+
see above about inet_twsk_unehash. We should insert
/* Disassociate with bind bucket. */
here
+return 0;
+}
Is this comment for me ?
yes. It will be dropped in the upper part of the code and have to be
inserted here instead
Daniel Lezcano wrote:
From: Daniel Lezcano [EMAIL PROTECTED]
Denis Lunev spotted that if we take a reference to the network namespace
with the timewait sockets, we will need to wait for their expiration to
have the network namespace freed. This is a waste of time, the timewait
sockets are
Moving dst entries into init_net.loopback_dev is not a good thing.
This hides obvious and non-obvious ref-counting bugs.
This patch uses net_ns loopback instead of init_net loopback.
This allowes to catch various bugs like recent one in IPv6 DAD handling.
Signed-off-by: Denis V. Lunev [EMAIL
Andrew,
This is a resend of the patch I had sent earlier at:
http://marc.info/?l=linux-kernelm=119065506607858
This patch enables group cpu scheduler feature to work with control
groups.
Could you include this in -mm for folks to test it?
--
Enable cgroup (formerly containers)
Denis V. Lunev wrote:
Daniel Lezcano wrote:
From: Daniel Lezcano [EMAIL PROTECTED]
Denis Lunev spotted that if we take a reference to the network namespace
with the timewait sockets, we will need to wait for their expiration to
have the network namespace freed. This is a waste of time, the
On Wed, 2007-09-26 at 13:09 -0600, Eric W. Biederman wrote:
Dave Hansen [EMAIL PROTECTED] writes:
On Tue, 2007-09-25 at 07:30 -0600, Eric W. Biederman wrote:
Pavel Emelyanov [EMAIL PROTECTED] writes:
Oh! Can you provide us an example when after the migration some
device's
Daniel Lezcano [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Now that multiple loopback devices are becoming possible it makes
the code a little cleaner and more maintainable to test if a deivice
is th a loopback device by testing dev-flags IFF_LOOPBACK instead
of dev == loopback_dev.
Denis V. Lunev [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
This patch makes loopback_dev per network namespace. Adding
code to create a different loopback device for each network
namespace and adding the code to free a loopback device
when a network namespace exits.
This patch
On Thu, 2007-09-27 at 16:30 +0900, KAMEZAWA Hiroyuki wrote:
Following patch is for successful rmdir in memory cgroup.
Currently, rmdir against memory cgroup will fail if charged page caches are
in cgroup.
(even if no tasks in cgroup.)
I don't like this. This patch implements forced
Cedric Le Goater [EMAIL PROTECTED] writes:
diff --git a/include/linux/sched.h b/include/linux/sched.h
index a01ac6d..e10a0a8 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -27,6 +27,7 @@
#define CLONE_NEWUTS0x0400 /* New utsname group? */
On Thu, 27 Sep 2007 20:36:24 +0530 Srivatsa Vaddagiri wrote:
Andrew,
This is a resend of the patch I had sent earlier at:
http://marc.info/?l=linux-kernelm=119065506607858
This patch enables group cpu scheduler feature to work with control
groups.
Could you include this in
On Thu, Sep 27, 2007 at 10:40:05AM -0700, Randy Dunlap wrote:
On Thu, 27 Sep 2007 20:36:24 +0530 Srivatsa Vaddagiri wrote:
Hi :)
Uh, a few of my previous comments weren't fixed... (below)
--
Enable cgroup (formerly containers) based fair group scheduling.
This will let
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 01:48:00 -0600
I'm not doing get_cpu/put_cpu so does the comment make sense
in relationship to per_cpu_ptr?
It is possible. But someone would need to go check for
sure.
___
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Thu, 27 Sep 2007 16:25:27 +0400
Subject: [PATCH] proper comment for loopback initialization order
From: Denis V. Lunev [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED], devel@openvz.org, [EMAIL PROTECTED],
[EMAIL PROTECTED]
On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote:
+config RESOURCE_COUNTERS
+ bool Resource counters
+ help
+ This option enables controller independent resource accounting
+ infrastructure that works with cgroups
Use tab + 2 spaces consistently for help text
I still need to look at the code in detail but I have some concerns
I want to inject into this conversation of future sysfs architecture.
- If we want to carefully limit sysfs from going to wild code review
is clearly not enough. We need some technological measures to
assist us. As the
On Thu, Sep 27, 2007 at 12:00:33PM -0700, Randy Dunlap wrote:
On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote:
+config RESOURCE_COUNTERS
+ bool Resource counters
+ help
+ This option enables controller independent resource accounting
Above line is tab + 2 spaces
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 10:27:43 -0600
Denis V. Lunev [EMAIL PROTECTED] writes:
Moving dst entries into init_net.loopback_dev is not a good thing.
This hides obvious and non-obvious ref-counting bugs.
Acked-by: Eric W. Biederman [EMAIL
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 11:14:33 -0600
Thanks for pointing this out, it's on my todo list to look into,
and ensure we resolve.
I'm confused because my notes have 0x8000 for the pid namespace,
and 0x4000 for the time namespace.
Eric, pick
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 01:48:00 -0600
I'm not doing get_cpu/put_cpu so does the comment make sense
in relationship to per_cpu_ptr?
It is possible. But someone would need to go check for
sure.
Verified.
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 14:44:37 -0600
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 01:48:00 -0600
I'm not doing get_cpu/put_cpu so does the comment make sense
in relationship to
David Miller [EMAIL PROTECTED] writes:
Eric, pick an appropriate new non-conflicting number NOW.
Done. My apologies for the confusion. I thought the
way Cedric and the IBM guys were testing someone would have
shouted at me long before now.
This adds unnecessary extra work for Andrew Morton,
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
include/linux/sched.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index e10a0a8..d82c1f7 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -27,7
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 16:40:31 -0600
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
Applied.
___
Containers mailing list
[EMAIL PROTECTED]
On Fri, 28 Sep 2007 01:05:12 +0530
Dhaval Giani [EMAIL PROTECTED] wrote:
On Thu, Sep 27, 2007 at 12:00:33PM -0700, Randy Dunlap wrote:
On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote:
+config RESOURCE_COUNTERS
+ bool Resource counters
+ help
+ This option enables
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 17:00:23 -0600
I will gladly do what I can, to help. Working against 3 trees
development at the moment is a bit of a development challenge.
Andrew has to work against 30 or so, so multiply your pain
by 10 to understand what he
On Thu, Sep 27, 2007 at 04:42:41PM -0700, Andrew Morton wrote:
@@ -219,6 +225,9 @@ static inline struct task_grp *task_grp(
#ifdef CONFIG_FAIR_USER_SCHED
tg = p-user-tg;
+#elif CONFIG_FAIR_CGROUP_SCHED
+ tg = container_of(task_subsys_state(p, cpu_cgroup_subsys_id),
+
In the -mm tree the rules for access an nsproxy have changed,
and in get_net_ns_by_pid we access the nsproxy, so update
it to follow the new rules.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 739fbad..1caba10 100644
---
Andrew Morton [EMAIL PROTECTED] writes:
On Thu, 27 Sep 2007 17:10:53 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
I will gladly do what I can, to help. Working against 3 trees
development at the moment is a bit of a development challenge.
Andrew has to work against 30 or so
I
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 27 Sep 2007 21:28:45 -0600
David, Andrew thanks you both are really are good upstream
maintainers to work with.
Just keep the coffee flowing :-)
___
Containers mailing list
[EMAIL PROTECTED]
Eric W. Biederman wrote:
David Miller [EMAIL PROTECTED] writes:
Eric, pick an appropriate new non-conflicting number NOW.
Done. My apologies for the confusion. I thought the
way Cedric and the IBM guys were testing someone would have
shouted at me long before now.
Sorry Eric, that was
Dhaval Giani wrote:
+config FAIR_CGROUP_SCHED
+ bool Control groups
+ depends on CGROUPS
+ help
There are also stray spaces before the tab on the last two lines above.
Cheers,
Frans Pop
___
Containers mailing list
[EMAIL PROTECTED]
On Thu, 27 Sep 2007, Cedric Le Goater wrote:
diff --git a/include/linux/user_namespace.h b/include/linux/user_namespace.h
index b5f41d4..dda160c 100644
--- a/include/linux/user_namespace.h
+++ b/include/linux/user_namespace.h
@@ -17,7 +17,7 @@ struct user_namespace {
extern struct
52 matches
Mail list logo
