When lookup succeeds we don't need the new user struct which hasn't
been linked into the uidhash. So we can immediately drop the lock and
then free new rather than free it with the lock held.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: David Howells dhowe...@redhat.com
Cc: Pavel Emelyanov
those patches towards
mainline along with your enhancements for reducing wakeups rather
than modify the freezer cgroup subsystem.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
On Tue, Feb 15, 2011 at 12:59:40AM +0200, Kirill A. Shutemov wrote:
On Mon, Feb 14, 2011 at 05:59:26AM -0800, Matt Helsley wrote:
On Mon, Feb 14, 2011 at 03:06:27PM +0200, Kirill A. Shutsemov wrote:
From: Kirill A. Shutemov kir...@shutemov.name
snip
+ list_for_each_entry(cur, cgroup
is useful. It seems
prudent to add as little interface as possible and only when
we clearly see the utility of it.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman
On Mon, Feb 14, 2011 at 11:41:42AM -0800, jacob pan wrote:
On Sat, 12 Feb 2011 15:29:07 -0800
Matt Helsley matth...@us.ibm.com wrote:
On Fri, Feb 11, 2011 at 11:10:44AM -0800,
jacob.jun@linux.intel.com wrote:
From: Jacob Pan jacob.jun@linux.intel.com
snip
cgroup. +To make
,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org
On Thu, Feb 10, 2011 at 11:15:22AM +0200, Kirill A. Shutemov wrote:
On Wed, Feb 09, 2011 at 07:04:42PM -0800, Matt Helsley wrote:
+{
+ struct cgroup *cgroup = (struct cgroup *)data;
+ struct freezer *freezer = cgroup_freezer(cgroup);
+
+ do {
+ if (freezer-duty.ratio
On Wed, Feb 09, 2011 at 07:06:15PM -0800, Arjan van de Ven wrote:
On 2/9/2011 7:04 PM, Matt Helsley wrote:
On Tue, Feb 08, 2011 at 05:05:41PM -0800, jacob.jun@linux.intel.com
wrote:
From: Jacob Panjacob.jun@linux.intel.com
Freezer subsystem is used to manage batch jobs which can
On Thu, Feb 10, 2011 at 02:22:21PM -0800, jacob pan wrote:
On Thu, 10 Feb 2011 11:11:17 -0800
Matt Helsley matth...@us.ibm.com wrote:
On Wed, Feb 09, 2011 at 07:06:15PM -0800, Arjan van de Ven wrote:
On 2/9/2011 7:04 PM, Matt Helsley wrote:
On Tue, Feb 08, 2011 at 05:05:41PM -0800
-1000 if you wanted sub-1% granularity...)
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel
and strongly dislike #1 because cgroup subsystem
information should stay out of the task struct as much as possible.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman
On Thu, Feb 03, 2011 at 11:41:38AM +0200, Kirill A. Shutemov wrote:
On Wed, Feb 02, 2011 at 09:46:16PM -0800, Matt Helsley wrote:
On Wed, Feb 02, 2011 at 10:47:36PM +0200, Kirill A. Shutsemov wrote:
From: Kirill A. Shutemov kir...@shutemov.name
snip
diff --git a/kernel
use less likely.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel
is appropriate for things which should never happen. These
fd lookups should always return non-NULL file pointers because we
just successfully created them and no other control flow path exists
that could modify the file table of a restarting task.
Signed-off-by: Matt Helsley matth...@us.ibm.com
diff --git
On Wed, Feb 02, 2011 at 10:47:36PM +0200, Kirill A. Shutsemov wrote:
From: Kirill A. Shutemov kir...@shutemov.name
Provides a way of tasks grouping by timer slack value. Introduces per
cgroup max and min timer slack value. When a task attaches to a cgroup,
its timer slack value adjusts (if
-max_slack_ns = val;
+ break;
+ default:
+ BUG();
+ }
+
Don't we want to keep the min/max applied hierarchically as well? i.e.
a child can't set its min/max outside the range of its parents?
That was my expectation as well.
Cheers,
-Matt
On Tue, Feb 01, 2011 at 02:41:43PM -0800, jacob.jun@linux.intel.com wrote:
From: Jacob Pan jacob.jun@linux.intel.com
Per cgroup timer slack value is used to manage task groups
for more friendly power management behavior. Once a task is
attached to a cgroup, we should not allow user
On Tue, Feb 01, 2011 at 11:07:43PM -0800, Matt Helsley wrote:
On Tue, Feb 01, 2011 at 02:41:43PM -0800, jacob.jun@linux.intel.com wrote:
From: Jacob Pan jacob.jun@linux.intel.com
Per cgroup timer slack value is used to manage task groups
for more friendly power management
with lots of small buffers which would
cause splice() to hit the PIPE_BUFFERS limit before having read the
requested amount of data.
Instead, drop the optimization and just read() and write() data into
the pipe.
Looks good:
Reviewed-by: Matt Helsley matth...@us.ibm.com
While it seems like
update_freezer_state() was renamed to update_if_frozen(). Use the
newly name of the function and remove the old copy.
Signed-off-by: Matt Helsley matth...@us.ibm.com
---
kernel/cgroup_freezer.c | 33 +
1 files changed, 1 insertions(+), 32 deletions(-)
diff
as a later, independent patch.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: Nathan Lynch n...@pobox.com
---
arch/powerpc/kernel/checkpoint.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/kernel/checkpoint.c b/arch/powerpc/kernel/checkpoint.c
index
the new
debug register support.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing
On Tue, Jan 11, 2011 at 08:05:38AM -0600, Rob Landley wrote:
On 01/11/2011 01:12 AM, Matt Helsley wrote:
On Mon, Jan 10, 2011 at 10:35:19PM -0600, Rob Landley wrote:
From: Rob Landley rland...@parallels.com
Teach cifs about network namespaces, so mounting uses adresses and
routing
On Mon, Jan 10, 2011 at 10:35:19PM -0600, Rob Landley wrote:
From: Rob Landley rland...@parallels.com
Teach cifs about network namespaces, so mounting uses adresses and
routing visible from a container rather than from init context.
For a long drawn out test reproduction sequence, see:
with the host cache.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel
On Thu, Jan 06, 2011 at 01:50:05PM -0800, Dave Hansen wrote:
On Thu, 2011-01-06 at 13:43 -0800, Matt Helsley wrote:
That said, the more important question is why should we provide
drop_caches inside a container? My understanding is it's largely a
workload-debugging tool and not something
attaching a task.
So not only do you need to set those masks but each mask must have at
least one cpu and mem respectively.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org
looked at that closely
enough yet to say how pretty/ugly that'd be but it entails
modifications to lxc-restart itself. And since #1 above would still
be an issue I'm not sure it's worth doing it that way.
Cheers,
-Matt Helsley
___
Containers mailing
if a
fatal signal is pending; callers of these functions are supposed to be
checking return values.
We do alot more than read/write the image -- e.g. collecting references at
the beginning prior to checkpoint. Perhaps should add some to the objhash
code too.
Cheers,
-Matt Helsley
effort at making this a proper ABI (I say
'almost' because we still need to export a description of it at runtime
and we need to do something better in place of the logfd output). Still,
the essentials of a proper checkpoint/restart ABI are already there.
Cheers,
-Matt Helsley
On Mon, Nov 01, 2010 at 12:38:23PM -0400, Oren Laadan wrote:
Matt,
This is v2, right ?
Nope. I'm still getting ready to post v2.
Cheers,
-Matt
___
Containers mailing list
contain...@lists.linux-foundation.org
if the freezer is involved and, if so,
where it's stuck.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
argument. Then just don't fill in the
freezer's unbind op and refuse to unbind subsystems that lack
the unbind op. That seems a bit cleaner for now at least.
Cheers,
-Matt Helsley
---
include/linux/cgroup.h |3 ++-
kernel/cgroup.c | 22 --
kernel
]-unbind)
return -EBUSY;
snip
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
On Fri, Oct 22, 2010 at 01:57:55PM -0700, Matt Helsley wrote:
On Fri, Oct 22, 2010 at 04:11:41PM +0800, Li Zefan wrote:
To make it bindable, we need to thaw all processes when unbinding
the freezer subsystem from a cgroup hierarchy.
Signed-off-by: Li Zefan l...@cn.fujitsu.com
snip
On Wed, Oct 20, 2010 at 01:56:36PM -0500, Nathan Lynch wrote:
If the vma record contains unsupported flags restore_vma() returns
-ENOSYS without releasing the record.
Signed-off-by: Nathan Lynch n...@pobox.com
Reviewed-by: Matt Helsley matth...@us.ibm.com
---
mm/checkpoint.c |3
the type against the actual size of the
array.
I don't know about more to-the-point but I think it's a clear
improvement from a code maintenance perspective.
Reviewed-by: Matt Helsley matth...@us.ibm.com
Signed-off-by: Nathan Lynch n...@pobox.com
---
mm/checkpoint.c |2 +-
1 files changed
Reviewed-by: Matt Helsley matth...@us.ibm.com
---
include/linux/checkpoint.h | 15 +++
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
index a11d40e..49cf01e 100644
--- a/include/linux/checkpoint.h
+++ b
structures there to be free()'d later during the cleanup
process.
Changes in v2:
- Avoid adding another list_head to ckpt_obj by re-using the hlist
hash node for the free list
Signed-off-by: Dan Smith da...@us.ibm.com
Looks good.
Reviewed-by: Matt Helsley matth...@us.ibm.com
,
-Matt Helsley
Signed-off-by: Dan Smith da...@us.ibm.com
---
include/linux/checkpoint.h |1 +
kernel/checkpoint/objhash.c | 20 +---
kernel/checkpoint/restart.c |2 ++
3 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/include/linux/checkpoint.h b
confusing as it's not
quite what happens. I'm mostly OK with it but I'm not sure we
should enable user-ns by default just yet.
Acked-By: Matt Helsley matth...@us.ibm.com
---
init/Kconfig |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
On Wed, Sep 29, 2010 at 04:19:31PM -0400, Oren Laadan wrote:
On 09/23/2010 05:53 PM, Matt Helsley wrote:
Not all filesystems will necessarily be able to support relinking an
orphan inode back into the filesystem. Some offlist feedback suggested
that instead of overloading .link
[ Persistent readers may wish to grab some coffee because this is gonna be
a long reply. ]
On Wed, Sep 29, 2010 at 06:22:37PM -0400, Oren Laadan wrote:
On 09/23/2010 05:53 PM, Matt Helsley wrote:
Implement checkpoint of unlinked files by relinking them into their
filesystem at lost+found
On Sun, Sep 26, 2010 at 12:08:37PM -0700, Brad Boyer wrote:
On Thu, Sep 23, 2010 at 02:53:28PM -0700, Matt Helsley wrote:
Not all filesystems will necessarily be able to support relinking an
orphan inode back into the filesystem. Some offlist feedback suggested
that instead of overloading
.relink where
possible and .link otherwise.
The next commit will change ext3/4 to enable this operation.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: Theodore Ts'o ty...@mit.edu
Cc: Andreas Dilger adilger.ker...@dilger.ca
Cc: Jan Kara j...@suse.cz
Cc: linux-fsde...@vger.kernel.org
Cc: linux
Checkpoint/restart code will be using the sys-wrappers. Move it to a more
appropriate location.
Signed-off-by: Matt Helsley matth...@us.ibm.com
---
include/linux/sys-wrapper.h | 216 +++
init/sys-wrapper.h | 216
Separate the __user pathname handling from the bulk of the syscall.
Since we're doing this to enable relinking of unlinked files by
sys_checkpoint and not sys_linkat we're not using a sys-wrapper.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: contain...@lists.linux-foundation.org
Cc: Oren
showing where/how they are
handled differently. All I could find in ext3/4 was the orphan inode list.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: Eric Sandeen sand...@redhat.com
Cc: Theodore Ts'o ty...@mit.edu
Cc: Andreas Dilger adilger.ker...@dilger.ca
Cc: linux-e...@vger.kernel.org
Cc: Jan
Unlinked fifos are special files which share some of their
checkpoint/restart code with pipes. Re-use the code for normal
unlinked files for unlinked fifos too.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: contain...@lists.linux-foundation.org
Cc: Oren Laadan or...@cs.columbia.edu
---
fs
to one that already exists: link.
Signed-off-by: Matt Helsley matth...@us.ibm.com
Cc: Eric Sandeen sand...@redhat.com
Cc: Theodore Ts'o ty...@mit.edu
Cc: Andreas Dilger adilger.ker...@dilger.ca
Cc: linux-e...@vger.kernel.org
Cc: Jan Kara j...@suse.cz
Cc: contain...@lists.linux-foundation.org
Cc
,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org/mailman
. Adding Oren to Cc)
Reviewed-by: Matt Helsley matth...@us.ibm.com
---
ipc/shm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index eed4b9a..1ba9193 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -334,7 +334,7 @@ int ipcshm_restore(struct
Fixes a bug in the way that hardward breakpoints pass around [v]pids.
The last two patches move the pid resolution closer to the syscall
and avoid passing pids entirely so that the perf event code does not
need to worry about being in the wrong pid namespace when kernel
counters are created.
...@linux.vnet.ibm.com
Signed-off-by: Matt Helsley matth...@us.ibm.com
---
kernel/perf_event.c | 63 --
1 files changed, 40 insertions(+), 23 deletions(-)
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index 440f9ca..3f5309d 100644
--- a/kernel
a...@redhat.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Ingo Molnar mi...@elte.hu
Cc: Will Deacon will.dea...@arm.com
Cc: Mahesh Salgaonkar mah...@linux.vnet.ibm.com
Signed-off-by: Matt Helsley matth...@us.ibm.com
---
arch/arm/oprofile/common.c |2 +-
include/linux/perf_event.h |2
On Thu, Sep 09, 2010 at 12:37:20PM +0200, Louis Rilling wrote:
On 08/09/10 21:06 -0700, Matt Helsley wrote:
On Wed, Sep 08, 2010 at 08:03:52PM -0500, Serge E. Hallyn wrote:
Quoting Matt Helsley (matth...@us.ibm.com):
On Wed, Sep 08, 2010 at 08:09:31AM -0500, Serge E. Hallyn wrote:
I
,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org
On Wed, Sep 08, 2010 at 08:03:52PM -0500, Serge E. Hallyn wrote:
Quoting Matt Helsley (matth...@us.ibm.com):
On Wed, Sep 08, 2010 at 08:09:31AM -0500, Serge E. Hallyn wrote:
Quoting Matthieu Fertré (matthieu.fer...@kerlabs.com):
Hi,
Here is a proposal for a C/R related feature
presently most-keenly aware of. I
haven't had time to follow what's new with openvz so I'll leave the
rest of the comparison to other folks.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
On Wed, Aug 18, 2010 at 03:13:02AM +0200, Tomasz Buchert wrote:
Le 12/08/2010 22:13, Matt Helsley a écrit :
snip
Matt,
Am I supposed to do something right now? The discussion
became a bit quiet recently.
Cheers,
Tomasz
Hi Tomasz,
I'm sorry. I haven't had much time to review
the events if I understand the issues correctly. Those rules plus user
namespaces would still be quite useful I think. Do they seem reasonable to
implement? Am I forgetting anything important?
Cheers,
-Matt Helsley
___
Containers mailing list
contain
On Thu, Aug 12, 2010 at 02:53:25AM +0200, Tomasz Buchert wrote:
Matt Helsley a écrit :
On Wed, Aug 11, 2010 at 09:35:43AM +0200, Tomasz Buchert wrote:
Matt Helsley a écrit :
On Wed, Aug 11, 2010 at 12:18:44AM +0200, Tomasz Buchert wrote:
Matt Helsley a écrit :
On Tue, Aug 10, 2010 at 09
as breaks out the allocation of the undo list to a
separate function (which is needed in a later C/R patch anyway).
Signed-off-by: Dan Smith da...@us.ibm.com
---
Reviewed-by: Matt Helsley matth...@us.ibm.com
include/linux/sem.h |2 ++
ipc/sem.c | 30
On Wed, Aug 11, 2010 at 12:18:44AM +0200, Tomasz Buchert wrote:
Matt Helsley a écrit :
On Tue, Aug 10, 2010 at 09:53:21PM +0200, Tomasz Buchert wrote:
Writing 'FROZEN' to freezer.state file does not
forbid the task to be moved away from its cgroup
(for a very short time). Nevertheless
Hi Oren,
I made a mistake -- I should've sent these 3 to you and cc'd
containers@ to indicate I'm proposing them for your tree. Would you mind
if I avoid a resend and just ask you to take them this way?
Cheers,
-Matt
On Sat, Aug 07, 2010 at 07:27:02PM -0700, Matt Helsley wrote
as breaks out the allocation of the undo list to a
separate function (which is needed in a later C/R patch anyway).
Signed-off-by: Dan Smith da...@us.ibm.com
Reviewed-by: Matt Helsley matth...@us.ibm.com
---
include/linux/sem.h |2 ++
ipc/sem.c | 30
is too slow we can work on
improving it or we can try something else.
So perhaps the best thing we can do to help you is learn how
folks backup their cluster filesystems. Got any pointers to basic info
on that?
Cheers,
-Matt Helsley
cleaner.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https
expect performance
issues of this.
Should work so long as we know the glibc mmap wrappers themselves are
reentrant/thread-safe. I expect they are but this might be a good thing
to confirm.
Cheers,
-Matt Helsley
___
Containers mailing list
contain
On Fri, Jul 30, 2010 at 05:35:04PM -0700, Sukadev Bhattiprolu wrote:
Oren Laadan [or...@cs.columbia.edu] wrote:
john stultz wrote:
On Fri, 2010-07-30 at 15:45 -0400, Oren Laadan wrote:
Sukadev Bhattiprolu wrote:
Oren Laadan [or...@cs.columbia.edu] wrote:
| | |
it required some
fairly nasty code contortions and only the ns cgroup needed/used it.
Acked-by: Matt Helsley matth...@us.ibm.com
---
Documentation/cgroups/cgroups.txt|2 +-
arch/ia64/configs/generic_defconfig |1 -
arch/mips/configs/bcm47xx_defconfig |1 -
arch
On Thu, Jul 29, 2010 at 05:39:57PM -0500, Serge E. Hallyn wrote:
Quoting Matt Helsley (matth...@us.ibm.com):
On Thu, Jul 29, 2010 at 02:58:12PM -0500, Serge E. Hallyn wrote:
snip
BTW in the past the only reason I saw for keeping ns cgroup was
to lock tasks into a devices cgroup. Until
));
rcu_read_unlock();
return ret;
}
[ My Notes: unlike check_kill_permission() it does not check CAP_KILL.
Also check_kill_permission() calls audit as if the signal is about to be
delivered but sigio_perm() does not. ]
Cheers,
-Matt Helsley
On Fri, Jul 23, 2010 at 01:10:43AM +0200, Kay Sievers wrote:
On Thu, Jul 22, 2010 at 23:48, Matt Helsley matth...@us.ibm.com wrote:
So I'd suggest
those cgroup mounts go in /var/run/systemd/cgroup or something like that.
Impossible, we need it at bootup, and / is usually read-only
of standardizing these mounts may be something to be
wary of.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
On Tue, Jul 13, 2010 at 10:44:18AM -0500, Nathan Lynch wrote:
fill_siginfo and load_siginfo both have parameters that can be const.
Signed-off-by: Nathan Lynch n...@pobox.com
Reviewed-by: Matt Helsley matth...@us.ibm.com
---
kernel/signal.c |4 ++--
1 files changed, 2 insertions
-by: Matt Helsley matth...@us.ibm.com
---
[only noticed this after posting the series, oops]
kernel/signal.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index cc7aee9..ba8a623 100644
--- a/kernel/signal.c
+++ b/kernel
On Sun, Jul 11, 2010 at 05:00:10AM -0400, Albert Cahalan wrote:
On Tue, Jul 6, 2010 at 6:25 PM, Sukadev Bhattiprolu
suka...@linux.vnet.ibm.com wrote:
Arnd Bergmann [a...@arndb.de] wrote:
| On Monday 05 July 2010, Albert Cahalan wrote:
| On Sun, Jul 4, 2010 at 7:39 PM, Matt Helsley matth
,
-Matt Helsley
Thanks,
Miklos
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
---
fs/namei.c | 34 +-
1 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index a6a8093..9a7b71a 100644
.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https
children
are not supposed to make syscalls other than execve, kill(SIGABRT), or
_exit. To me that clearly justifies not being able to call restart from
a vfork child.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux
also less code.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel
anyone can give me a hand.
You verified that the task shows up in /cgroup/0/tasks? (I ask because you
can't move a task into an already-frozen cgroup)
Are you still using v19?
Cheers,
-Matt Helsley
___
Containers mailing list
contain
kernel boot
line in grub/your bootloader.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
probably explain this much better
than I can (cc'd). Here's a thread on the subject:
http://lwn.net/Articles/378472/
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
:602: warning: excess elements in struct initializer
net/core/net_namespace.c:602: warning: (near initialization for
‘netns_operations’)
make[3]: *** [net/core/net_namespace.o] Error 1
Signed-off-by: Matt Helsley matth...@us.ibm.com
---
net/core/net_namespace.c |1 +
1 files changed, 1
On Mon, May 10, 2010 at 11:01:45PM +0200, Rafael J. Wysocki wrote:
On Thursday 06 May 2010, Oren Laadan wrote:
On 05/06/2010 03:40 PM, Rafael J. Wysocki wrote:
On Saturday 01 May 2010, Oren Laadan wrote:
From: Matt Helsley matth...@us.ibm.com
Update stale comments regarding
On Thu, May 06, 2010 at 09:40:19PM +0200, Rafael J. Wysocki wrote:
On Saturday 01 May 2010, Oren Laadan wrote:
From: Matt Helsley matth...@us.ibm.com
Update stale comments regarding locking order and add a little more detail
so it's easier to follow the locking between the cgroup freezer
On Thu, May 06, 2010 at 01:31:17PM -0700, Matt Helsley wrote:
On Thu, May 06, 2010 at 09:40:19PM +0200, Rafael J. Wysocki wrote:
On Saturday 01 May 2010, Oren Laadan wrote:
From: Matt Helsley matth...@us.ibm.com
Update stale comments regarding locking order and add a little more
() to set the lock on the file.
As pointed out by Matt Helsley, no special handling is necessary for a
process P2 in the checkpointed container that is blocked on a lock, L1
Which was inspired by Dave Hansen's explanation of c/r of futex locking :).
Cheers,
-Matt
checkpoint image. I think a u64,
like ckpt_hdr_file's f_pos field, is called for.
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
On Mon, May 03, 2010 at 09:10:42AM -0700, Darren Hart wrote:
Oren Laadan wrote:
From: Matt Helsley matth...@us.ibm.com
These lists record which futexes the task holds. To keep the overhead of
robust futexes low the list is kept in userspace. When the task exits the
kernel carefully walks
than
the 10 or so we post at a time.
Sorry again,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel
On Thu, Apr 29, 2010 at 10:28:48AM -0500, Serge E. Hallyn wrote:
We don't support multiple devpts mounts in a container. So
bail on checkpoint if a container has them. This will cause
checkpoint to fail of a container which still has a pty from
parent container in use.
Note one issue with
-hand side is used. In contrast the
right-hand side of := is evaluated everywhere the left-hand side is defined
(usually once). This is faster and non-recursive. See
The Two Flavors of Variables in the GNU Make info file for a more rigorous
discussion of the differences.
Cheers,
-Matt Helsley
these
situations with the RCU annotations? (I think your response re: Li's
freezer patch was correct and illustrates the problem I'm referring to.)
Cheers,
-Matt Helsley
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
-off-by: Li Zefan l...@cn.fujitsu.com
Acked-by: Matt Helsley matth...@us.ibm.com
---
I'm not sure which is preferable - access -alloc_lock directly
like this patch or add task_lock_is_held() in sched.h
---
include/linux/cgroup.h |1 +
1 files changed, 1 insertions(+), 0 deletions
-by: Matt Helsley matth...@us.ibm.com
---
fs/eventfd.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/eventfd.c b/fs/eventfd.c
index e412a02..65307e0 100644
--- a/fs/eventfd.c
+++ b/fs/eventfd.c
@@ -303,8 +303,10 @@ static int eventfd_checkpoint(struct ckpt_ctx *ckpt_ctx
On Mon, Apr 12, 2010 at 07:06:29PM -0500, Serge E. Hallyn wrote:
My first patchset did this, but subsequent revisions dropped
the put_pid_ns...
Applied, thanks!
Cheers,
-Matt Helsley
Signed-off-by: Serge E. Hallyn se...@us.ibm.com
---
kernel/checkpoint/sys.c |2 ++
1 files
)
for (loop = 0; loop (1 i_hash_shift); loop++)
INIT_HLIST_HEAD(inode_hashtable[loop]);
-
-#ifdef CONFIG_CHECKPOINT
- ckpt_obj_register(ckpt_obj_inode_ops);
The latest set does:
s/ckpt_obj_register/register_checkpoint_obj/
Cheers,
-Matt Helsley
1 - 100 of 609 matches
Mail list logo
