[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-08 Thread Pablo Neira Ayuso
Patrick McHardy wrote: Alexey Dobriyan wrote: On Thu, Sep 04, 2008 at 06:54:16PM +0200, Patrick McHardy wrote: [EMAIL PROTECTED] wrote: Make untracked conntrack per-netns. Compare conntracks with relevant untracked one. The following code you'll start laughing at this code: if (ct ==

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-05 Thread Patrick McHardy
Alexey Dobriyan wrote: On Thu, Sep 04, 2008 at 06:54:16PM +0200, Patrick McHardy wrote: [EMAIL PROTECTED] wrote: Make untracked conntrack per-netns. Compare conntracks with relevant untracked one. The following code you'll start laughing at this code: if (ct == ct-ct_net-ct.untracked)

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: Make untracked conntrack per-netns. Compare conntracks with relevant untracked one. The following code you'll start laughing at this code: if (ct == ct-ct_net-ct.untracked) ... let me remind you that -ct_net is set in only one place, and

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-04 Thread Alexey Dobriyan
On Thu, Sep 04, 2008 at 06:54:16PM +0200, Patrick McHardy wrote: [EMAIL PROTECTED] wrote: Make untracked conntrack per-netns. Compare conntracks with relevant untracked one. The following code you'll start laughing at this code: if (ct == ct-ct_net-ct.untracked) ... let

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-04 Thread Jan Engelhardt
On Thursday 2008-09-04 22:58, Alexey Dobriyan wrote: In conntrack_mt_v0() ct-status can be used even for untracked connection, is this right? Yes. For example, does setting IPS_NAT_DONE_MASK and IPS_CONFIRMED_BIT on untracked conntracked really necessary? Does it even happen? Something smells

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-08-28 Thread Jan Engelhardt
On Thursday 2008-08-21 18:04, [EMAIL PROTECTED] wrote: Make untracked conntrack per-netns. Why? It does not store any useful information per se, it is merely used to add a third type of ct, iow: (a) ct==NULL (b) ct!=NULL (c) ct==untracked mmap(2)'s return value for example has something

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-08-28 Thread Jan Engelhardt
On Friday 2008-08-22 07:30, [EMAIL PROTECTED] wrote: We wait for untracked ct refcount to drop to 1 back: /* wait until all references to nf_conntrack_untracked are dropped */ while (atomic_read(nf_conntrack_untracked.ct_general.use) 1) schedule(); Consequently it

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-08-24 Thread Alexey Dobriyan
On Sat, Aug 23, 2008 at 08:35:07PM -0400, Jan Engelhardt wrote: On Friday 2008-08-22 07:30, [EMAIL PROTECTED] wrote: We wait for untracked ct refcount to drop to 1 back: /* wait until all references to nf_conntrack_untracked are dropped */ while

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-08-22 Thread adobriyan
On Thu, Aug 21, 2008 at 07:06:37PM -0400, Jan Engelhardt wrote: On Thursday 2008-08-21 18:04, [EMAIL PROTECTED] wrote: Make untracked conntrack per-netns. Why? It does not store any useful information per se, it is merely used to add a third type of ct, iow: (a) ct==NULL (b) ct!=NULL