[Devel] Re: [PATCH 5/5][NFS] Cleanup explicit check for mandatory locks

2007-09-18 Thread Pavel Emelyanov
Trond Myklebust wrote: On Mon, 2007-09-17 at 11:57 +0400, Pavel Emelyanov wrote: The __mandatory_lock(inode) macro makes the same check, but makes the code more readable. Could we please avoid using underscores in macros. Also, why are we breaking the usual convention of capitalising macro

[Devel] Re: [PATCH 5/5][NFS] Cleanup explicit check for mandatory locks

2007-09-17 Thread Trond Myklebust
On Mon, 2007-09-17 at 11:57 +0400, Pavel Emelyanov wrote: The __mandatory_lock(inode) macro makes the same check, but makes the code more readable. Could we please avoid using underscores in macros. Also, why are we breaking the usual convention of capitalising macro names? Cheers Trond