[Devel] [PATCH] Fix user struct leakage with locked IPC shem segment

2007-07-16 Thread Pavel Emelianov
When user locks an ipc shmem segmant with SHM_LOCK ctl and the segment is already locked the shmem_lock() function returns 0. After this the subsequent code leaks the existing user struct: == ipc/shm.c: sys_shmctl() == ... err = shmem_lock(shp-shm_file, 1, user); if (!err) {

[Devel] [PATCH 2/2] Make unregister_binfmt() return void

2007-07-16 Thread Alexey Dobriyan
list_del() hardly can fail, so checking for return value is pointless (and current code always return 0). Nobody really cared that return value anyway. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- arch/ia64/ia32/binfmt_elf32.c |2 +- fs/exec.c |3 +--

[Devel] Re: [PATCH 1/6] user namespace : add the framework

2007-07-16 Thread Serge E. Hallyn
Quoting Andrew Morton ([EMAIL PROTECTED]): On Mon, 4 Jun 2007 14:40:24 -0500 Serge E. Hallyn [EMAIL PROTECTED] wrote: Add the user namespace struct and framework Basically, it will allow a process to unshare its user_struct table, resetting at the same time its own user_struct and

[Devel] Re: [PATCH 1/6] user namespace : add the framework

2007-07-16 Thread Serge E. Hallyn
Quoting Serge E. Hallyn ([EMAIL PROTECTED]): Quoting Andrew Morton ([EMAIL PROTECTED]): On Mon, 4 Jun 2007 14:40:24 -0500 Serge E. Hallyn [EMAIL PROTECTED] wrote: Add the user namespace struct and framework Basically, it will allow a process to unshare its user_struct table,

[Devel] Re: [PATCH 1/6] user namespace : add the framework

2007-07-16 Thread Serge E. Hallyn
Quoting Kirill Korotaev ([EMAIL PROTECTED]): Serge E. Hallyn wrote: Quoting Andrew Morton ([EMAIL PROTECTED]): On Mon, 4 Jun 2007 14:40:24 -0500 Serge E. Hallyn [EMAIL PROTECTED] wrote: Add the user namespace struct and framework Basically, it will allow a process to unshare its

[Devel] Containers: css_put() dilemma

2007-07-16 Thread Balbir Singh
Hi, Paul, I've run into a strange problem with css_put(). After the changes for notify_on_release(), the css_put() routine can now block and it blocks on the container_mutex. This implies that css_put() cannot be called if 1. We cannot block 2. We already hold the container_mutex The problem I

[Devel] Re: [PATCH 3/5] Use task_pid() to find leader's pid

2007-07-16 Thread sukadev
Oleg Nesterov [EMAIL PROTECTED] wrote: | Sukadev Bhattiprolu wrote: | | Use task_pid() to get leader's pid since find_pid() cannot be used | after detach_pid(). See comments in the code below for more details. | | ... | | +* Note: With multiple pid namespaces, active pid

[Devel] Re: [PATCH] Fix user struct leakage with locked IPC shem segment

2007-07-16 Thread Andrew Morton
On Mon, 16 Jul 2007 16:24:12 +0400 Pavel Emelianov [EMAIL PROTECTED] wrote: When user locks an ipc shmem segmant with SHM_LOCK ctl and the segment is already locked the shmem_lock() function returns 0. After this the subsequent code leaks the existing user struct: I'm curious. For the past

[Devel] Re: [PATCH 5/5] Move alloc_pid call to copy_process

2007-07-16 Thread sukadev
Oleg Nesterov [EMAIL PROTECTED] wrote: | Sukadev Bhattiprolu wrote: | | --- lx26-22-rc6-mm1.orig/kernel/pid.c 2007-07-13 18:23:55.0 -0700 | +++ lx26-22-rc6-mm1/kernel/pid.c2007-07-13 18:23:55.0 -0700 | @@ -206,6 +206,10 @@ fastcall void free_pid(struct pid *pid) |

Re: [Devel] containers development plans

2007-07-16 Thread Rohit Seth
On Sat, 2007-07-14 at 05:21 +0200, Kir Kolyshkin wrote: I just got an idea -- what about organizing a one-day containers mini-summit just before the Kernel Summit? We can all meet face to face, discuss all the issues and come out with a good plan for KS talk. Do you know who is doing the

[Devel] Re: [PATCH 0/16] Pid namespaces

2007-07-16 Thread sukadev
Pavel Emelianov [EMAIL PROTECTED] wrote: | My x86_64 system boots fine but crashes as below, when I run my | 'pidns_exec' test with a simple program that prints getpid(), getppid() | etc of the process in the child pid ns. | | Pls see | |