[Devel] Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-06 Thread Denis V. Lunev
Greg KH wrote: On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: The following calltrace is possible now: handle_sysrq machine_emergency_restart mach_reboot_fixups pci_get_device pci_get_subsys down_read The patch obtains PCI device during

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Pavel Emelyanov
Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task exits it may send a signal to its parent (SIGCHLD), but if the parent has already exited its namespaces there will be no way to decide what pid to dever to him - parent can

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Oleg Nesterov
On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task exits it may send a signal to its parent (SIGCHLD), but if the parent has already exited its namespaces there will be no way to decide

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Oleg Nesterov
On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task exits it may send a signal to its parent (SIGCHLD), but if the parent has

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Pavel Emelyanov
Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task exits it may send a signal to its parent (SIGCHLD), but if

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Pavel Emelyanov
Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task exits it may send a signal to its parent (SIGCHLD), but if

[Devel] [PATCH 1/2] sysctl: remove binary sysctls from kernel.sched_domain

2007-08-06 Thread Alexey Dobriyan
kernel.sched_domain hierarchy is under CTL_UNNUMBERED and thus unreachable to sysctl(2). Generating .ctl_number's in such situation is not useful. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- kernel/sched.c | 38 +- 1 file changed, 21 insertions(+),

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Oleg Nesterov
On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task exits it may send a

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Oleg Nesterov
On 08/06, Pavel Emelyanov wrote: If task X is exiting and has already exit_task_namespaces()-ed task Y will OOPs during its exit in determining parent's namespace. I agree that in that case this is not important what namespace X belongs to, but we need to handle the race with changing the

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Pavel Emelyanov
Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: If task X is exiting and has already exit_task_namespaces()-ed task Y will OOPs during its exit in determining parent's namespace. I agree that in that case this is not important what namespace X belongs to, but we need to handle the race

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Oleg Nesterov
On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after

[Devel] Re: [PATCH 1/15] Move exit_task_namespaces()

2007-08-06 Thread Pavel Emelyanov
Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 08/06, Pavel Emelyanov wrote: Oleg Nesterov wrote: On 07/26, Pavel Emelyanov wrote: The reason to release namespaces after reparenting is that when task

[Devel] Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-06 Thread Andrew Morton
On Fri, 3 Aug 2007 14:39:24 +0400 Denis V. Lunev [EMAIL PROTECTED] wrote: The following calltrace is possible now: handle_sysrq machine_emergency_restart mach_reboot_fixups pci_get_device pci_get_subsys down_read The patch obtains PCI device during

[Devel] Re: [RFC, PATCH] handle the multi-threaded init's exit() properly

2007-08-06 Thread Andrew Morton
On Fri, 3 Aug 2007 01:20:09 +0400 Oleg Nesterov [EMAIL PROTECTED] wrote: With or without this patch, multi-threaded init's are not fully supported, but do_exit() is completely wrong. This becomes a real problem when we support pid namespaces. 1. do_exit() panics when the main thread of

[Devel] Re: [RFC, PATCH] handle the multi-threaded init's exit() properly

2007-08-06 Thread Oleg Nesterov
On 08/06, Andrew Morton wrote: On Fri, 3 Aug 2007 01:20:09 +0400 Oleg Nesterov [EMAIL PROTECTED] wrote: 2. We are playing games with -nsproxy-pid_ns. This code is bogus today, and it has to be changed anyway when we really support pid namespaces, just remove it. This patch

[Devel] Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-06 Thread Greg KH
On Mon, Aug 06, 2007 at 11:16:20AM +0400, Denis V. Lunev wrote: Greg KH wrote: On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: The following calltrace is possible now: handle_sysrq machine_emergency_restart mach_reboot_fixups pci_get_device

[Devel] Re: [RFC, PATCH] handle the multi-threaded init's exit() properly

2007-08-06 Thread Andrew Morton
On Tue, 7 Aug 2007 00:33:26 +0400 Oleg Nesterov [EMAIL PROTECTED] wrote: On 08/06, Andrew Morton wrote: On Fri, 3 Aug 2007 01:20:09 +0400 Oleg Nesterov [EMAIL PROTECTED] wrote: 2. We are playing games with -nsproxy-pid_ns. This code is bogus today, and it has to be changed