[Devel] [PATCH] [NETFILTER] Consolidate nf_sockopt and compat_nf_sockopt v2

2007-11-06 Thread Pavel Emelyanov
Both lookup the nf_sockopt_ops object to call the get/set callbacks from, but they perform it in a completely similar way. Introduce the helper for finding the ops. Ported at the top of today's net-2.6 tree to resolve conflict with the patch from Alexey Dobriyan. Signed-off-by: Pavel Emelyanov

[Devel] [PATCH -net 1/2] Convert /proc/net/ipv6_route to seq_file interface

2007-11-06 Thread Alexey Dobriyan
This removes last proc_net_create() user. Kudos to Benjamin Thery and Stephen Hemminger for comments on previous version. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/ipv6/route.c | 91 +-- 1 file changed, 29 insertions(+), 62

[Devel] [PATCH -net 2/2] Put proc_net_create() on death row

2007-11-06 Thread Alexey Dobriyan
proc_net_create() stands on the way of shrinking the number of interfaces one can use for /proc files, namely, it uses -get_info hook which will be converted, deprecated and deleted on its own schedule. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] ---

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Kirill Korotaev
imho very good idea and we'll have more and more docs there... (the only issue I see - it would be nice to have cgroups docs in the same place, though cgroups are not about namespaces directly.) Acked-By: Kirill Korotaev [EMAIL PROTECTED] Pavel Emelyanov wrote: Hi guys! As you might have

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Cedric Le Goater
Pavel Emelyanov wrote: Hi guys! As you might have seen, recently there was some spontaneous discussion about the namespaces-working-together problems. Ted T'so proposed to create some document that describes what problems user may have when he/she creates some new namespace, but keeps

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Pavel Emelyanov
Cedric Le Goater wrote: Pavel Emelyanov wrote: Hi guys! As you might have seen, recently there was some spontaneous discussion about the namespaces-working-together problems. Ted T'so proposed to create some document that describes what problems user may have when he/she creates some new

[Devel] Re: [PATCH -net 2/2] Put proc_net_create() on death row

2007-11-06 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Tue, 6 Nov 2007 15:23:50 +0300 proc_net_create() stands on the way of shrinking the number of interfaces one can use for /proc files, namely, it uses -get_info hook which will be converted, deprecated and deleted on its own schedule.

[Devel] Re: [PATCH -net 2/2] Put proc_net_create() on death row

2007-11-06 Thread Christoph Hellwig
On Tue, Nov 06, 2007 at 03:23:50PM +0300, Alexey Dobriyan wrote: proc_net_create() stands on the way of shrinking the number of interfaces one can use for /proc files, namely, it uses -get_info hook which will be converted, deprecated and deleted on its own schedule. It's just a trivial

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Cedric Le Goater
Pavel Emelyanov wrote: Cedric Le Goater wrote: Pavel Emelyanov wrote: Hi guys! As you might have seen, recently there was some spontaneous discussion about the namespaces-working-together problems. Ted T'so proposed to create some document that describes what problems user may have when

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Eric W. Biederman
Pavel Emelyanov [EMAIL PROTECTED] writes: +2. Intentionnaly, two equal user ids in different user namespaces + should not be equal from the VFS point of view. In other + words, user 10 in one user namespace shouldn't have the same + access permissions to files, beloging to user 10 in

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Cedric Le Goater
Pavel Emelyanov wrote: Cedric Le Goater wrote: Pavel Emelyanov wrote: Cedric Le Goater wrote: Pavel Emelyanov wrote: Hi guys! As you might have seen, recently there was some spontaneous discussion about the namespaces-working-together problems. Ted T'so proposed to create some document

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Cedric Le Goater
Eric W. Biederman wrote: Pavel Emelyanov [EMAIL PROTECTED] writes: +2. Intentionnaly, two equal user ids in different user namespaces + should not be equal from the VFS point of view. In other + words, user 10 in one user namespace shouldn't have the same + access permissions to

[Devel] Re: Pid namespaces problems

2007-11-06 Thread Eric W. Biederman
Pavel Emelyanov [EMAIL PROTECTED] writes: Yup. I agree with this too. I'm about to deprecate the pid and tgid fields in the task_struct (but not remove to make printk-s faster and smaller). The work is in progress here. Last time I looked at the printks, it looked to me like we wanted to

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Eric W. Biederman
Cedric Le Goater [EMAIL PROTECTED] writes: right. I think we can address Ulrich concerns first because we have a solution for it (which looks like unsharing all namespaces at once, here comes back the container object story :) It doesn't work because we can't create a fresh mount namespace.

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Pavel Emelyanov
Eric W. Biederman wrote: Cedric Le Goater [EMAIL PROTECTED] writes: right. I think we can address Ulrich concerns first because we have a solution for it (which looks like unsharing all namespaces at once, here comes back the container object story :) It doesn't work because we can't

[Devel] [PATCH] Clean proto_(un)register from in-code ifdefs

2007-11-06 Thread Pavel Emelyanov
The struct proto has the per-cpu inuse counter, which is handled with a special care. All the handling code hides under the ifdef CONFIG_SMP and it introduces some code duplication and makes it look worse than it could. Clean this. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff

[Devel] Re: namespaces compatibility list

2007-11-06 Thread Eric W. Biederman
Pavel Emelyanov [EMAIL PROTECTED] writes: Eric W. Biederman wrote: Cedric Le Goater [EMAIL PROTECTED] writes: right. I think we can address Ulrich concerns first because we have a solution for it (which looks like unsharing all namespaces at once, here comes back the container object story