Re: [Devel] [PATCH 3/3] fuse: Switch unused engines off in Kconfig

2018-10-30 Thread Pavel Butsykin
On 30.10.2018 11:55, Kirill Tkhai wrote: > We do not test and do not use these engines. They were > needed on initial stage of development, but now their > time is over. > > It's not safe to distribute untested (and never used) > debug modules in production, so this patch disables > them by

Re: [Devel] [PATCH 1/3] fuse: Fix parse_fuse_opt() return values wrong interpretation

2018-10-30 Thread Pavel Butsykin
On 30.10.2018 11:55, Kirill Tkhai wrote: > This function returns not 0 in case of success, and 0 in case > of failure. So, error values like -EPERM are interpreted as > success, which is wrong. Fix that. > Note, that fuse has generic EINVAL return value for all types > of unacceptable parameters.

Re: [Devel] [PATCH 2/3] fuse: Prohibit kio engine from containers

2018-10-30 Thread Pavel Butsykin
On 30.10.2018 11:55, Kirill Tkhai wrote: > Currently we have several BUG_ON() ported from userspace, > and they may fire in case of it's used malicious daemon > instead of original vstorage-mount. So, just prohibit > mounting with kio from inside container. > >

[Devel] [PATCH 2/3] fuse: Prohibit kio engine from containers

2018-10-30 Thread Kirill Tkhai
Currently we have several BUG_ON() ported from userspace, and they may fire in case of it's used malicious daemon instead of original vstorage-mount. So, just prohibit mounting with kio from inside container. https://pmc.acronis.com/browse/VSTOR-16325 Signed-off-by: Kirill Tkhai ---

[Devel] [PATCH 3/3] fuse: Switch unused engines off in Kconfig

2018-10-30 Thread Kirill Tkhai
We do not test and do not use these engines. They were needed on initial stage of development, but now their time is over. It's not safe to distribute untested (and never used) debug modules in production, so this patch disables them by default. Some time later, if there is no at least a single

[Devel] [PATCH 1/3] fuse: Fix parse_fuse_opt() return values wrong interpretation

2018-10-30 Thread Kirill Tkhai
This function returns not 0 in case of success, and 0 in case of failure. So, error values like -EPERM are interpreted as success, which is wrong. Fix that. Note, that fuse has generic EINVAL return value for all types of unacceptable parameters. Signed-off-by: Kirill Tkhai --- fs/fuse/inode.c