[ovirt-devel] OST failure NoClassDefFoundError

[Roy Golan]

I get this on basic suite from a built RPM[1]:

Caused by: java.lang.NoClassDefFoundError: org/apache/commons/lang/StringUtils
at 
org.ovirt.vdsm.jsonrpc.client.reactors.stomp.impl.Message.withCorrelationId(Message.java:75)
[vdsm-jsonrpc-java-client.jar:]
at 
org.ovirt.vdsm.jsonrpc.client.reactors.stomp.SSLStompClient.sendMessage(SSLStompClient.java:85)
[vdsm-jsonrpc-java-client.jar:]
at 
org.ovirt.vdsm.jsonrpc.client.JsonRpcClient.call(JsonRpcClient.java:83)
[vdsm-jsonrpc-java-client.jar:]


My patch under test certainly didn't touch this area [2]

[1]
http://jenkins.ovirt.org/job/ovirt-system-tests_manual/290/artifact/exported-artifacts/test_logs/basic-suite-master/post-002_bootstrap.py/lago-basic-suite-master-engine/_var_log/ovirt-engine/engine.log

[2] https://gerrit.ovirt.org/#/c/75262/

Did anyone see that?
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Subject: [ OST Failure Report ] [ oVirt master ] [ 24-04-2017 ] [import_template_from_glance]

[Nadav Goldin]

Test failed: add_secondary_storage_domains/import_template_from_glance

Link to suspected patches: https://gerrit.ovirt.org/#/c/74382/

Link to Job: 
http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6456/
(started in 6451)

Link to all logs:
http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6456/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/

Engine log: 
http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6456/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/lago-basic-suite-master-engine/_var_log/ovirt-engine/engine.log

Error snippet from the test log:



lago.utils: ERROR: Error while running thread
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/lago/utils.py", line 58, in
_ret_via_queue
queue.put({'return': func()})
  File 
"/home/jenkins/workspace/test-repo_ovirt_experimental_master/ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py",
line 803, in import_template_from_glance
generic_import_from_glance(api, image_name=CIRROS_IMAGE_NAME,
image_ext='_glance_template', as_template=True)
  File 
"/home/jenkins/workspace/test-repo_ovirt_experimental_master/ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py",
line 641, in generic_import_from_glance
lambda: api.disks.get(disk_name).status.state == 'ok',
  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
264, in assert_true_within_long
assert_equals_within_long(func, True, allowed_exceptions)
  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
251, in assert_equals_within_long
func, value, LONG_TIMEOUT, allowed_exceptions=allowed_exceptions
  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
230, in assert_equals_within
'%s != %s after %s seconds' % (res, value, timeout)
AssertionError: False != True after 600 seconds





the engine.log has this sequence repeating(apparently at the end of
the task - 199ed356):

2017-04-24 13:34:50,079-04 INFO
[org.ovirt.engine.core.bll.storage.repoimage.ImportRepoImageCommand]
(DefaultQuartzScheduler10) [199ed356-0960-4ef4-9637-09c76a07c932]
Ending command 
'org.ovirt.engine.core.bll.storage.repoimage.ImportRepoImageCommand'
successfully.
2017-04-24 13:34:50,090-04 ERROR
[org.ovirt.engine.core.bll.CommandsFactory] (DefaultQuartzScheduler10)
[] An exception has occurred while trying to create a command object
for command 'AddVmTemplate' with parameters
'AddVmTemplateParameters:{commandId='a6d45092-dfe0-4a65-bdc4-4c23a68fe7d5',
user='admin', commandType='Unknown'}': WELD-49: Unable to invoke
protected final void
org.ovirt.engine.core.bll.CommandBase.postConstruct() on
org.ovirt.engine.core.bll.AddVmTemplateCommand@35c1cbd5
2017-04-24 13:34:50,095-04 INFO
[org.ovirt.engine.core.utils.transaction.TransactionSupport]
(DefaultQuartzScheduler10) [] transaction rolled back
2017-04-24 13:34:50,123-04 INFO
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
(DefaultQuartzScheduler10) [] EVENT_ID:
USER_IMPORT_IMAGE_AS_TEMPLATE_FINISHED_SUCCESS(3,018), Correlation ID:
199ed356-0960-4ef4-9637-09c76a07c932, Job ID:
0b91fec3-97be-493f-9dfb-af1230e4d3ee, Call Stack: null, Custom Event
ID: -1, Message: User admin@internal-authz successfully imported image
CirrOS_0.3.4_for_x86_64_glance_template as template
CirrOS_0.3.4_for_x86_64_glance_template to domain iscsi.
2017-04-24 13:34:50,123-04 ERROR
[org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller]
(DefaultQuartzScheduler10) [] Failed invoking callback end method
'onSucceeded' for command '25028c51-d877-44e3-b1ef-40b315b469d3' with
exception 'null', the callback is marked for end method retries

Thanks,
Nadav.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [ACTION SUGGESTED] can't start VMs on master? run engine-setup

[Greg Sheremeta]

Hi,

I noticed today that I couldn't start a VM on master. Turns out I needed to
run engine-setup to pull in some database changes (I assume). For what it's
worth, the stacktrace [1] didn't say anything about missing columns (as it
usually will for things like this). It just said it couldn't create a new
RunVm because of NPE.

Best wishes,
Greg

[1]
https://paste.fedoraproject.org/paste/TYNKZh1tR0f2XU3ifboHCF5M1UNdIGYhyRLivL9gydE=

-- 
Greg Sheremeta, MBA
Sr. Software Engineer
Red Hat, Inc.
gsher...@redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] GSoC Mentors Needed

[Tomas Jelinek]

On Mon, Apr 24, 2017 at 3:29 PM, Tomas Jelinek  wrote:

>
>
> On Mon, Apr 24, 2017 at 2:25 PM, Brian Proffitt 
> wrote:
>
>> All:
>>
>> We have been given five slots for projects in Google Summer of Code this
>> year and thus far only one has a
>>
>
> do you mean GSoC or GSoC + Outreachy?
>
>
>> mentor. If anyone is interested in mentoring one of these projects,
>> please contact me immediately. The deadline is 1200 EDT today.
>>
>
> Are there also promising intern candidates? Or only slots?
>
>
>>
>> --
>>
>> Configuring Backup storage for Ovirt
>>
>> This proposal is about configuring any Storage Domain as a new Backup
>> Storage Domain.This will help to replace the use of Export storage domain
>> which use dedicated storage domain for backup and disaster recovery.
>>
>> --
>>
>> Implement oVirt integration tests using Lago
>>
>> Complete the ovirt-system-tests with the necessary tests
>>
>
> This one has been proposed also under Outreachy - there were some
> candidates, not sure now how promising though.
>

OK, I can mentor this project. Yaniv/Doron/Brian: can you please register
me as a mentor?


>
>
>>
>> --
>>
>> oVirt log analyzer
>>
>> oVirt is a distributed system and all parts of the system have their own
>> logs. In order to analyze/troubleshoot an issue, it is useful to correlate
>> an action triggered on one subsystem and how it travelled over the other
>> parts. This would be a greenfield project written in Python. Timeline of
>> the work:
>>
>> Develop a method for recognizing the contents of log files of different
>> formats - May, 30 - June, 15
>> Implement matching events in different log files with each other - June,
>> 15 - July, 1
>> Develop and implement methods for automatic analysis of the logs and the
>> events occurring in them, such as identifying errors, unusual events, VM
>> properties, etc. - July, 1 - August, 1
>> Add an interactive user interface to the developed algorithms, testing
>> and improving - August, 1 - August, 30
>>
>> The initial version of steps 1-3 implementation was proposed under mentor
>> (Milan Zamazal) control, the results are in repository
>> https://github.com/aantsiferova/ovirt-log-analyzer
>>
>>
> this one has been proposed under the Outreachy, Milan is the mentor and
> there is an intern accepted.
>
>
>>
>>
>>
>> --
>>
>> BRIAN PROFFITT
>>
>> PRINCIPAL COMMUNITY ANALYST
>>
>> Red Hat Inc. 
>>
>> bprof...@redhat.comT: 574.383.9BKP
>> M:
>> 574.780.5695 
>> 
>> T: @redhatopen    F: Red Hat Community
>> 
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] GSoC Mentors Needed

[Tomas Jelinek]

On Mon, Apr 24, 2017 at 2:25 PM, Brian Proffitt  wrote:

> All:
>
> We have been given five slots for projects in Google Summer of Code this
> year and thus far only one has a
>

do you mean GSoC or GSoC + Outreachy?


> mentor. If anyone is interested in mentoring one of these projects, please
> contact me immediately. The deadline is 1200 EDT today.
>

Are there also promising intern candidates? Or only slots?


>
> --
>
> Configuring Backup storage for Ovirt
>
> This proposal is about configuring any Storage Domain as a new Backup
> Storage Domain.This will help to replace the use of Export storage domain
> which use dedicated storage domain for backup and disaster recovery.
>
> --
>
> Implement oVirt integration tests using Lago
>
> Complete the ovirt-system-tests with the necessary tests
>

This one has been proposed also under Outreachy - there were some
candidates, not sure now how promising though.


>
> --
>
> oVirt log analyzer
>
> oVirt is a distributed system and all parts of the system have their own
> logs. In order to analyze/troubleshoot an issue, it is useful to correlate
> an action triggered on one subsystem and how it travelled over the other
> parts. This would be a greenfield project written in Python. Timeline of
> the work:
>
> Develop a method for recognizing the contents of log files of different
> formats - May, 30 - June, 15
> Implement matching events in different log files with each other - June,
> 15 - July, 1
> Develop and implement methods for automatic analysis of the logs and the
> events occurring in them, such as identifying errors, unusual events, VM
> properties, etc. - July, 1 - August, 1
> Add an interactive user interface to the developed algorithms, testing and
> improving - August, 1 - August, 30
>
> The initial version of steps 1-3 implementation was proposed under mentor
> (Milan Zamazal) control, the results are in repository https://github.com/
> aantsiferova/ovirt-log-analyzer
>
>
this one has been proposed under the Outreachy, Milan is the mentor and
there is an intern accepted.


>
>
>
> --
>
> BRIAN PROFFITT
>
> PRINCIPAL COMMUNITY ANALYST
>
> Red Hat Inc. 
>
> bprof...@redhat.comT: 574.383.9BKP
> M:
> 574.780.5695 
> 
> T: @redhatopen    F: Red Hat Community
> 
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] GSoC Mentors Needed

[Brian Proffitt]

All:

We have been given five slots for projects in Google Summer of Code this
year and thus far only one has a mentor. If anyone is interested in
mentoring one of these projects, please contact me immediately. The
deadline is 1200 EDT today.

--

Configuring Backup storage for Ovirt

This proposal is about configuring any Storage Domain as a new Backup
Storage Domain.This will help to replace the use of Export storage domain
which use dedicated storage domain for backup and disaster recovery.

--

Implement oVirt integration tests using Lago

Complete the ovirt-system-tests with the necessary tests

--

oVirt log analyzer

oVirt is a distributed system and all parts of the system have their own
logs. In order to analyze/troubleshoot an issue, it is useful to correlate
an action triggered on one subsystem and how it travelled over the other
parts. This would be a greenfield project written in Python. Timeline of
the work:

Develop a method for recognizing the contents of log files of different
formats - May, 30 - June, 15
Implement matching events in different log files with each other - June, 15
- July, 1
Develop and implement methods for automatic analysis of the logs and the
events occurring in them, such as identifying errors, unusual events, VM
properties, etc. - July, 1 - August, 1
Add an interactive user interface to the developed algorithms, testing and
improving - August, 1 - August, 30

The initial version of steps 1-3 implementation was proposed under mentor
(Milan Zamazal) control, the results are in repository
https://github.com/aantsiferova/ovirt-log-analyzer




-- 

BRIAN PROFFITT

PRINCIPAL COMMUNITY ANALYST

Red Hat Inc. 

bprof...@redhat.comT: 574.383.9BKP
M: 574.780.5695


T: @redhatopen    F: Red Hat Community

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Abusing injection and DB access

[Roy Golan]

On Thu, Apr 6, 2017 at 11:26 AM Roy Golan  wrote:

> On Wed, Apr 5, 2017 at 11:34 PM Moti Asayag  wrote:
>
>> On Wed, Apr 5, 2017 at 11:17 PM, Roy Golan  wrote:
>>
>>
>>
>> On Wed, Apr 5, 2017 at 9:06 PM Moti Asayag  wrote:
>>
>> Hi All,
>>
>> ATM, there are 78 occurrences of "Injector.injectMembers(new
>> AuditLogableBase())" in ovirt-engine project, which their main purpose is
>> to ease the resolve of the placeholders of the audit log message while
>> logging an event.
>>
>> For instance AuditLogType.MAC_ADDRESS_IS_EXTERNAL is being used from
>> ImportVmCommandBase.java in the following way:
>>
>> private AuditLogableBase createExternalMacsAuditLog(VM vm, Set
>> externalMacs) {
>> AuditLogableBase logable = *Injector.injectMembers*(new
>> AuditLogableBase());
>> logable.setVmId(vm.getId());
>> logable.setCustomCommaSeparatedValues("MACAddr", externalMacs);
>> return logable;
>> }
>>
>> The entry in the properties file is:
>> MAC_ADDRESS_IS_EXTERNAL=VM ${*VmName*} has MAC address(es) ${MACAddr},
>> which is/are out of its MAC pool definitions.
>>
>> Therefore the only purpose of the injection is to allow the
>> AuditLogDirector to resolve the ${*VmName*} which is already known at
>> the time of creating the AuditLogableBase entry.
>>
>> The result is injecting the DAOs for the AuditLogableBase instance and
>> using the VM dao to retrieve the VM entry from the DB.
>> This is just a wastef of injection and DB access while both can be spared.
>>
>> This could have been easily replaced by one of the following:
>>
>>- auditLogableBase.setVmName(vm.getName());
>>
>> - setVmName is protected so not usable as is
>>
>>
>> It will become public if we agree on
>>
>>
>> https://gerrit.ovirt.org/#/c/75244/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
>>
>>
>>
>>- auditLogableBase.addCustomValue("VmName", vm.getName());
>>
>> I prefer this, it is readable. and BTW it is fluent, it returns 'this' so
>> use
>>
>>   AuditLogDirector(new AuditLogableBase(type)
>>   .addCustomValue("VmName", vm.getName()));
>>
>>
>> I'm okay with this as well.
>>
>>
>> Please pick up any occurrence from your domain and send a patch to
>> replace it where possible.
>> Thanks in advance,
>> Moti
>>
>>
>> +1
>>
>> Frankly the fact that all the DAOs sets protected access in
>> AuditLogableBase is a total abuse. Every command should declare its own
>> deps.
>>
>>
>> That will require a huge effort.
>>
>
> Removed them all, https://gerrit.ovirt.org/75262 compile +1
> Now need to fix the tests - I'd appreciate help here
>
> Verified +1 the removal of all protected DAO's in AuditLogableBase.
Instead of constant injection of *66* dao fields for *every* command inject
only *9* which are most atm, They will be removed as well in the future.

Please help review, its a long, but stupid patch which just adds injections.
https://gerrit.ovirt.org/75262




>
>>
>> ___
>>
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>>
>>
>>
>> --
>> Regards,
>> Moti
>>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] abrt integration in vdsm 4.1

[Yaniv Bronheim]

I'll contact QE. Lets continue follow
https://bugzilla.redhat.com/show_bug.cgi?id=917062 for more information and
requests. This "devel" mail is only aimed for the rest to be aware of this
integration

On Sun, Apr 23, 2017 at 6:53 PM Dan Kenigsberg  wrote:

>
>
> On Apr 23, 2017 5:21 PM, "Yaniv Bronheim"  wrote:
>
> All, Great to hear the interest.
> Sandro - Maybe I can install sos-abrt package - I didn't try. However,
> ovirt collects only vdsm-sos report and I want to include this information
> there - so it was easier and simplest way to expose it
> Yaniv - We don't see why not to include it in 4.1, it runs already two
> weeks or so in master :) and its something that we want for quite long, and
> its ready ... why not let others benefit from it without waiting for next
> major release
>
>
> No patch is harmless. When introducing new code to a stable branch, it is
> your responsibility to explain what does the feature do, what are it's
> dangers, how well was it tested.
>
> Dan - I will raise the need for more intensive testings. I didn't want to
> share the information with fedora, because I didn't think about it much..
> maybe it can be nice. From my point of you, having abrt output locally and
> exposed by vdsm is enough for ovirt orchestration with abrt.
>
>
> On Fri, Apr 21, 2017 at 2:38 PM Dan Kenigsberg  wrote:
>
>> On Wed, Apr 19, 2017 at 5:43 PM, Yaniv Bronheim 
>> wrote:
>> > Hi, I posted the new integration [1] to 4.1 -
>> > https://gerrit.ovirt.org/#/q/topic:backport-abrt-intgr for review.
>> > Abrt is a service that runs in parallel to vdsm and collect binaries and
>> > python crashes under /var/run/tmp - to try that out you can crash a qemu
>> > process or vdsm with signal -6 and watch the report using "abrt-cli
>> list"
>> > command, which its output will be reported by our sos plugin.
>> >
>> > Thanks,
>> > Yaniv Bronhaim.
>> >
>> > [1] https://bugzilla.redhat.com/show_bug.cgi?id=917062
>>
>> I love to see this integration. It could provide us a lot of
>> information about common failures.
>> The downside is that it can also swamp us with meaningless spam.
>>
>> I see that the bug is destined to 4.1.3. It makes sense to me, since
>> it would let us test it thoroughly on master. Did we do extensive
>> testing already? Can a user disable this (per cluster? on each host?)
>> if he does not like to share the data with Fedora?
>>
>> Regards,
>> Dan.
>>
> --
> Yaniv Bronhaim.
>
>
> --
Yaniv Bronhaim.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [Vdsm] silence existing pylint errors

[Francesco Romani]

On 04/23/2017 02:54 AM, Nir Soffer wrote:
> On Fri, Apr 21, 2017 at 4:05 PM Nir Soffer  > wrote:
>
> > I think the last patch is too big, and there are some storage
> issues that we
>
> > can fix
> > now. Can you split by vertical? I would like to take over
> the the storage
> > part.
>
> Please do. 
>
>
> I splitted the patches to:
>
> - https://gerrit.ovirt.org/75728 pylint: brutally silence two
> network-related errors
> - https://gerrit.ovirt.org/75730 pylint: Silence pylint errors in
> gluster
> - https://gerrit.ovirt.org/75748 pylint: Silence pylint errors in
> infra
> - https://gerrit.ovirt.org/75749 pylint: Silence pylint errors in virt
>

I'm taking care of this today

Thanks for kickstarting this!

-- 
Francesco Romani
Senior SW Eng., Virtualization R
Red Hat
IRC: fromani github: @fromanirh

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel