Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Vojtech Szocs]

- Original Message -
> From: "Greg Sheremeta" 
> To: "Vojtech Szocs" 
> Cc: "devel" , "Oved Ourfali" , "Juan 
> Hernández" 
> Sent: Tuesday, January 10, 2017 10:28:06 PM
> Subject: Re: PatternFly upgrade - how to handle JS dependencies
> 
> On Tue, Jan 10, 2017 at 1:00 PM, Vojtech Szocs  wrote:
> 
> >
> >
> > - Original Message -
> > > From: "Greg Sheremeta" 
> > > To: "Vojtech Szocs" 
> > > Cc: "devel" , "Oved Ourfali" ,
> > "Juan Hernández" 
> > > Sent: Monday, January 9, 2017 9:46:18 PM
> > > Subject: Re: PatternFly upgrade - how to handle JS dependencies
> > >
> > > On Fri, Jan 6, 2017 at 12:45 PM, Vojtech Szocs 
> > wrote:
> > >
> > > > Hello,
> > > >
> > > > we'd like to upgrade the version of PatternFly (plus associated
> > libraries,
> > > > namely Bootstrap and jQuery) used in oVirt UI.
> > > >
> > > > Today, PatternFly stuff (PF + associated libraries) comes from
> > > > `patternfly1`
> > > > package hosted at Copr repo:
> > > >
> > > >   https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
> > > >
> > > > Today, we require `patternfly1` as both Engine RPM build dependency
> > and the
> > > > Engine devel. env. dependency.
> > > >
> > > > To keep things simple, I'd like to propose the following approach:
> > > >
> > > > - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at
> > Copr,
> > > >   containing PatternFly + associated libraries (Bootstrap, jQuery)
> > which
> > > >   are intended *specifically* for use by oVirt UI (hence the ovirt
> > prefix)
> > > >
> > >
> > > I've already done this, although it's currently named 'patternfly3'
> > > https://copr.fedorainfracloud.org/coprs/patternfly/patternfly3/
> >
> > I really think we should put some `ovirt` prefix there, to avoid
> > people thinking that it's some kind of general-purpose PatternFly
> > package.
> >
> > For example, `ovirt-engine-ui-dependencies` (for Engine GWT UI).
> >
> 
> That's fine. I had created the repo long before your suggestion, that's all.

I know, I just wanted to suggest the future change.

Having `patternfly3` right now allows us to experiment with upgrading
the PatternFly version in GWT UI so for the moment, I'm OK with that.

> 
> I think it should have 'js' in the name somewhere.

OK, this is Martin's suggestion actually =) ovirt-js-dependencies.

> 
> 
> >
> > >
> > > However, we want to move it to our ovirt infra because copr sometimes
> > goes
> > > down, and that breaks CI jobs.
> >
> > If we really want to do that, maybe we should add a new project
> > into releng-tools repo. The project would be at
> >
> >   releng-tools/specs/ovirt-engine-ui-dependencies
> >
> > containing package.json and build script that downloads JS dep's
> > and then packages all JS stuff as RPM.
> >
> > (Basically a very similar build process as with nodejs-modules.)
> >
> 
> Sure, that sounds good. Let me verify with infra where it should go.

Thanks.

Note that I'm totally OK with Copr too. But having an RPM built by
oVirt infra (with JS dependencies fetched in a way consistent with
e.g. nodejs-modules) indeed seems as the more correct approach.

> 
> 
> >
> > >
> > > So, +1 from me, but let's move to ovirt infra.
> > >
> > >
> > > >
> > > > - discontinue maintenance of `patternfly1` package at Copr
> > > >
> > > > - keep the existing approach: require `ovirt-patternfly` as both the
> > Engine
> > > >   build dependency and the Engine devel. env. dependency
> > > >
> > > > An alternative approach would be to introduce Node.js as Engine devel.
> > env.
> > > > dependency (use `npm install` to pull PF stuff), while using the
> > existing
> > > > ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
> > > >
> > > > However, this alternative has some downsides, namely complication of
> > devel.
> > > > env. just to fetch the PF stuff. I don't like the idea of complicating
> > the
> > > > existing devel. env. just for the sake of fetching some 3rd party libs.
> > > >
> > > > I'm wondering what others think about this.
> > > >
> > > > Regards,
> > > > Vojtech
> > > >
> > >
> > >
> > >
> > > --
> > > Greg Sheremeta, MBA
> > > Red Hat, Inc.
> > > Sr. Software Engineer
> > > gsher...@redhat.com
> > >
> >
> 
> 
> 
> --
> Greg Sheremeta, MBA
> Red Hat, Inc.
> Sr. Software Engineer
> gsher...@redhat.com
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Martin Perina]

On Tue, Jan 10, 2017 at 6:43 PM, Vojtech Szocs <vsz...@redhat.com> wrote:

>
>
> - Original Message -
> > From: "Martin Perina" <mper...@redhat.com>
> > To: "Vojtech Szocs" <vsz...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>, "Juan Hernández" <jhern...@redhat.com>
> > Sent: Friday, January 6, 2017 10:14:22 PM
> > Subject: Re: [ovirt-devel] PatternFly upgrade - how to handle JS
> dependencies
> >
> > On Fri, Jan 6, 2017 at 6:45 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> >
> > > Hello,
> > >
> > > we'd like to upgrade the version of PatternFly (plus associated
> libraries,
> > > namely Bootstrap and jQuery) used in oVirt UI.
> > >
> > > Today, PatternFly stuff (PF + associated libraries) comes from
> > > `patternfly1`
> > > package hosted at Copr repo:
> > >
> > >   https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
> > >
> > > Today, we require `patternfly1` as both Engine RPM build dependency
> and the
> > > Engine devel. env. dependency.
> > >
> > > To keep things simple, I'd like to propose the following approach:
> > >
> > > - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at
> Copr,
> > >   containing PatternFly + associated libraries (Bootstrap, jQuery)
> which
> > >   are intended *specifically* for use by oVirt UI (hence the ovirt
> prefix)
> > >
> > > - discontinue maintenance of `patternfly1` package at Copr
> > >
> > > - keep the existing approach: require `ovirt-patternfly` as both the
> Engine
> > >   build dependency and the Engine devel. env. dependency
> > >
> >
> > ​+1 from me.
> >
> > The only issue is that we combine several javascript libraries in a
> package
> > named ovirt-patternfly.
>
> Well, this is the same approach like with ovirt-engine-nodejs-modules,
> with a difference that nodejs-modules is intended for build-time only.
>
> The proposed `ovirt-patternfly` (or whatever it's called) is intended
> for Engine run-time + as Engine devel. env. pre-requisite.
>
> The idea is to bundle all JS/CSS/etc. files required by $PROJECT into
> a single package. In case of `ovirt-patternfly`, $PROJECT == Engine.
>
> > Is there a high probabily that we will need some
> > other javascript libraries in near future?
>
> Not too likely, but there's always the chance.
>
> > If so, then I'd rather call the
> > package ovirt-javascript-dependencies (or ovirt-js-dependencies).
>
> OK, maybe even putting `engine` in the name, since we actually need it
> for the Engine (GWT UI), e.g. `ovirt-engine-ui-dependencies`.
>

​AFAIK new user portal is called ovirt-web-ui​

​so term engine​ is really not needed in package name :-)


> > ​
> >
> >
> > >
> > > An alternative approach would be to introduce Node.js as Engine devel.
> env.
> > > dependency (use `npm install` to pull PF stuff), while using the
> existing
> > > ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
> > >
> > > However, this alternative has some downsides, namely complication of
> devel.
> > > env. just to fetch the PF stuff. I don't like the idea of complicating
> the
> > > existing devel. env. just for the sake of fetching some 3rd party libs.
> > >
> > > I'm wondering what others think about this.
> > >
> > > Regards,
> > > Vojtech
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > >
> >
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Vojtech Szocs]

- Original Message -
> From: "Greg Sheremeta" 
> To: "Vojtech Szocs" 
> Cc: "devel" , "Oved Ourfali" , "Juan 
> Hernández" 
> Sent: Monday, January 9, 2017 9:46:18 PM
> Subject: Re: PatternFly upgrade - how to handle JS dependencies
> 
> On Fri, Jan 6, 2017 at 12:45 PM, Vojtech Szocs  wrote:
> 
> > Hello,
> >
> > we'd like to upgrade the version of PatternFly (plus associated libraries,
> > namely Bootstrap and jQuery) used in oVirt UI.
> >
> > Today, PatternFly stuff (PF + associated libraries) comes from
> > `patternfly1`
> > package hosted at Copr repo:
> >
> >   https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
> >
> > Today, we require `patternfly1` as both Engine RPM build dependency and the
> > Engine devel. env. dependency.
> >
> > To keep things simple, I'd like to propose the following approach:
> >
> > - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
> >   containing PatternFly + associated libraries (Bootstrap, jQuery) which
> >   are intended *specifically* for use by oVirt UI (hence the ovirt prefix)
> >
> 
> I've already done this, although it's currently named 'patternfly3'
> https://copr.fedorainfracloud.org/coprs/patternfly/patternfly3/

I really think we should put some `ovirt` prefix there, to avoid
people thinking that it's some kind of general-purpose PatternFly
package.

For example, `ovirt-engine-ui-dependencies` (for Engine GWT UI).

> 
> However, we want to move it to our ovirt infra because copr sometimes goes
> down, and that breaks CI jobs.

If we really want to do that, maybe we should add a new project
into releng-tools repo. The project would be at

  releng-tools/specs/ovirt-engine-ui-dependencies

containing package.json and build script that downloads JS dep's
and then packages all JS stuff as RPM.

(Basically a very similar build process as with nodejs-modules.)

> 
> So, +1 from me, but let's move to ovirt infra.
> 
> 
> >
> > - discontinue maintenance of `patternfly1` package at Copr
> >
> > - keep the existing approach: require `ovirt-patternfly` as both the Engine
> >   build dependency and the Engine devel. env. dependency
> >
> > An alternative approach would be to introduce Node.js as Engine devel. env.
> > dependency (use `npm install` to pull PF stuff), while using the existing
> > ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
> >
> > However, this alternative has some downsides, namely complication of devel.
> > env. just to fetch the PF stuff. I don't like the idea of complicating the
> > existing devel. env. just for the sake of fetching some 3rd party libs.
> >
> > I'm wondering what others think about this.
> >
> > Regards,
> > Vojtech
> >
> 
> 
> 
> --
> Greg Sheremeta, MBA
> Red Hat, Inc.
> Sr. Software Engineer
> gsher...@redhat.com
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Greg Sheremeta]

On Fri, Jan 6, 2017 at 12:45 PM, Vojtech Szocs  wrote:

> Hello,
>
> we'd like to upgrade the version of PatternFly (plus associated libraries,
> namely Bootstrap and jQuery) used in oVirt UI.
>
> Today, PatternFly stuff (PF + associated libraries) comes from
> `patternfly1`
> package hosted at Copr repo:
>
>   https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
>
> Today, we require `patternfly1` as both Engine RPM build dependency and the
> Engine devel. env. dependency.
>
> To keep things simple, I'd like to propose the following approach:
>
> - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
>   containing PatternFly + associated libraries (Bootstrap, jQuery) which
>   are intended *specifically* for use by oVirt UI (hence the ovirt prefix)
>

I've already done this, although it's currently named 'patternfly3'
https://copr.fedorainfracloud.org/coprs/patternfly/patternfly3/

However, we want to move it to our ovirt infra because copr sometimes goes
down, and that breaks CI jobs.

So, +1 from me, but let's move to ovirt infra.


>
> - discontinue maintenance of `patternfly1` package at Copr
>
> - keep the existing approach: require `ovirt-patternfly` as both the Engine
>   build dependency and the Engine devel. env. dependency
>
> An alternative approach would be to introduce Node.js as Engine devel. env.
> dependency (use `npm install` to pull PF stuff), while using the existing
> ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
>
> However, this alternative has some downsides, namely complication of devel.
> env. just to fetch the PF stuff. I don't like the idea of complicating the
> existing devel. env. just for the sake of fetching some 3rd party libs.
>
> I'm wondering what others think about this.
>
> Regards,
> Vojtech
>



-- 
Greg Sheremeta, MBA
Red Hat, Inc.
Sr. Software Engineer
gsher...@redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Greg Sheremeta]

On Sat, Jan 7, 2017 at 11:01 AM, Sven Kieske  wrote:

> On 06/01/17 18:45, Vojtech Szocs wrote:
> > Today, we require `patternfly1` as both Engine RPM build dependency and
> the
> > Engine devel. env. dependency.
> >
> > To keep things simple, I'd like to propose the following approach:
> >
> > - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
> >   containing PatternFly + associated libraries (Bootstrap, jQuery) which
> >   are intended *specifically* for use by oVirt UI (hence the ovirt
> prefix)
> >
> > - discontinue maintenance of `patternfly1` package at Copr
>
> afaik you're also requiring patternfly1 for ovirt-engine installation,
> not just dev or build env?
>
> if that is correct and your new "ovirt-patternfly" would superseed that
> I'm afraid you would violate fedora and rhel/centos package guidelines
> by throwing this all together in one package?
>

Yeah. It's all thrown into the 'patternfly1' package currently anyway, so
there's really no change here.


>
> I hope I understood the scope of this correct, if not, just disregard my
> comment.
>
> --
> Mit freundlichen Grüßen / Regards
>
> Sven Kieske
>
> Systemadministrator
> Mittwald CM Service GmbH & Co. KG
> Königsberger Straße 6
> 32339 Espelkamp
> T: +495772 293100
> F: +495772 29
> https://www.mittwald.de
> Geschäftsführer: Robert Meyer
> St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Greg Sheremeta, MBA
Red Hat, Inc.
Sr. Software Engineer
gsher...@redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Sven Kieske]

On 06/01/17 18:45, Vojtech Szocs wrote:
> Today, we require `patternfly1` as both Engine RPM build dependency and the
> Engine devel. env. dependency.
> 
> To keep things simple, I'd like to propose the following approach:
> 
> - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
>   containing PatternFly + associated libraries (Bootstrap, jQuery) which
>   are intended *specifically* for use by oVirt UI (hence the ovirt prefix)
> 
> - discontinue maintenance of `patternfly1` package at Copr

afaik you're also requiring patternfly1 for ovirt-engine installation,
not just dev or build env?

if that is correct and your new "ovirt-patternfly" would superseed that
I'm afraid you would violate fedora and rhel/centos package guidelines
by throwing this all together in one package?

I hope I understood the scope of this correct, if not, just disregard my
comment.

-- 
Mit freundlichen Grüßen / Regards

Sven Kieske

Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +495772 293100
F: +495772 29
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen



signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Martin Perina]

On Fri, Jan 6, 2017 at 6:45 PM, Vojtech Szocs  wrote:

> Hello,
>
> we'd like to upgrade the version of PatternFly (plus associated libraries,
> namely Bootstrap and jQuery) used in oVirt UI.
>
> Today, PatternFly stuff (PF + associated libraries) comes from
> `patternfly1`
> package hosted at Copr repo:
>
>   https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
>
> Today, we require `patternfly1` as both Engine RPM build dependency and the
> Engine devel. env. dependency.
>
> To keep things simple, I'd like to propose the following approach:
>
> - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
>   containing PatternFly + associated libraries (Bootstrap, jQuery) which
>   are intended *specifically* for use by oVirt UI (hence the ovirt prefix)
>
> - discontinue maintenance of `patternfly1` package at Copr
>
> - keep the existing approach: require `ovirt-patternfly` as both the Engine
>   build dependency and the Engine devel. env. dependency
>

​+1 from me.

The only issue is that we combine several javascript libraries in a package
named ovirt-patternfly. Is there a high probabily that we will need some
other javascript libraries in near future? If so, then I'd rather call the
package ovirt-javascript-dependencies (or ovirt-js-dependencies).
​


>
> An alternative approach would be to introduce Node.js as Engine devel. env.
> dependency (use `npm install` to pull PF stuff), while using the existing
> ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
>
> However, this alternative has some downsides, namely complication of devel.
> env. just to fetch the PF stuff. I don't like the idea of complicating the
> existing devel. env. just for the sake of fetching some 3rd party libs.
>
> I'm wondering what others think about this.
>
> Regards,
> Vojtech
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Vojtech Szocs]

Hello,

we'd like to upgrade the version of PatternFly (plus associated libraries,
namely Bootstrap and jQuery) used in oVirt UI.

Today, PatternFly stuff (PF + associated libraries) comes from `patternfly1`
package hosted at Copr repo:

  https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/

Today, we require `patternfly1` as both Engine RPM build dependency and the
Engine devel. env. dependency.

To keep things simple, I'd like to propose the following approach:

- create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
  containing PatternFly + associated libraries (Bootstrap, jQuery) which
  are intended *specifically* for use by oVirt UI (hence the ovirt prefix)

- discontinue maintenance of `patternfly1` package at Copr

- keep the existing approach: require `ovirt-patternfly` as both the Engine
  build dependency and the Engine devel. env. dependency

An alternative approach would be to introduce Node.js as Engine devel. env.
dependency (use `npm install` to pull PF stuff), while using the existing
ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.

However, this alternative has some downsides, namely complication of devel.
env. just to fetch the PF stuff. I don't like the idea of complicating the
existing devel. env. just for the sake of fetching some 3rd party libs.

I'm wondering what others think about this.

Regards,
Vojtech
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel