Re: [PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Chris Johns
On 13/06/2018 13:04, Vidushi Vashishth wrote: > > I have made the changes you suggested. Thanks. > I am still working on CTF support. > >>> +  $ ../samples >>What is this command? > > This is not a command. It is used to show which directory we are in. This > method > was used in the

Re: [PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Vidushi Vashishth
Hi I have made the changes you suggested. I am still working on CTF support. >> + $ ../samples >What is this command? This is not a command. It is used to show which directory we are in. This method was used in the quickstart section. But I have removed this. >There is some doco that would be

Re: [PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Chris Johns
Hi, This documentation looks good and I welcome this being done and added to the RTEMS project. I have some comments below I hope are easy to resolve. Thanks Chris On 13/06/2018 11:23, Vidushi Vashishth wrote: > --- > user/index.rst | 2 + > user/tracing/captureengine.rst |

Re: [PATCH v3 2/2] Adding trace documentation

2018-06-12 Thread Vidushi Vashishth
I was using Sublime text. It appeared okay on the editor. I have changed my editor and sent another patch. Thanks. On Tue, Jun 12, 2018 at 9:46 PM, Gedare Bloom wrote: > On Tue, Jun 12, 2018 at 11:15 AM, Vidushi Vashishth > wrote: > > > > Adjusted line length to 79-80 > > --- > >

[PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Vidushi Vashishth
--- user/index.rst | 2 + user/tracing/captureengine.rst | 184 ++ user/tracing/examples.rst | 12 ++ user/tracing/index.rst | 29 + user/tracing/introduction.rst | 182 ++ user/tracing/tracelinker.rst | 287

[PATCH v3 2/2] Adding trace documentation

2018-06-12 Thread Vidushi Vashishth
Adjusted line length to 79-80 --- user/index.rst | 2 + user/tracing/captureengine.rst | 188 ++ user/tracing/examples.rst | 12 ++ user/tracing/index.rst | 33 + user/tracing/introduction.rst | 184 ++

Re: [GSoC - Tracing] Status

2018-06-12 Thread Vidushi Vashishth
Hi! >in case you receive comments for your patches the highest priority should be to fix the problems with the patches and send the next revision of the patch to the list, e.g. fixing trivial things like the line ?>length should be done in a couple of minutes. If you think a comment is invalid or

Re: [PATCH] Fix --show-commands.

2018-06-12 Thread Christian Mauderer
Am 12.06.2018 um 09:29 schrieb Chris Johns: > On 12/06/2018 17:18, Christian Mauderer wrote: >> Am 12.06.2018 um 07:08 schrieb Chris Johns: >>> On 09/06/2018 02:45, Christian Mauderer wrote: Did you also note Gedares suggestion to move the rtems_waf.git to the public repos? Maybe

Re: [PATCH] Fix --show-commands.

2018-06-12 Thread Chris Johns
On 12/06/2018 17:18, Christian Mauderer wrote: > Am 12.06.2018 um 07:08 schrieb Chris Johns: >> On 09/06/2018 02:45, Christian Mauderer wrote: >>> >>> Did you also note Gedares suggestion to move the rtems_waf.git to the >>> public repos? Maybe that would be a good idea. >>> >> >> Yes I did and it

Re: [PATCH] Fix --show-commands.

2018-06-12 Thread Christian Mauderer
Am 12.06.2018 um 09:18 schrieb Christian Mauderer: > The first one has a longer backward compatibility (relative URLs are > there since 2007: https://github.com/git/git/commit/f31a522a2d which > should be somewhere between git 1.5 and git 1.6). Just noted: That feature has been merged in 1.7.12.

Re: [PATCH] coverage : Add support to run coverage in supported bsp without extra options

2018-06-12 Thread Cillian O'Donnell
Looks fine to me. Chris will have the final say though. On Tue, 12 Jun 2018, 08:00 Vijay Kumar Banerjee, wrote: > > > On Tue, 12 Jun 2018, 12:27 Joel Sherrill, wrote: > >> Chris needs to speak up since it is Python. >> >> I see changes to HTML output which I doubt are related to the core

Re: [PATCH] Fix --show-commands.

2018-06-12 Thread Christian Mauderer
Am 12.06.2018 um 07:08 schrieb Chris Johns: > On 09/06/2018 02:45, Christian Mauderer wrote: >> >> Did you also note Gedares suggestion to move the rtems_waf.git to the >> public repos? Maybe that would be a good idea. >> > > Yes I did and it is a good idea. I have move the repo to the top level

Re: [PATCH] coverage : Add support to run coverage in supported bsp without extra options

2018-06-12 Thread Vijay Kumar Banerjee
On Tue, 12 Jun 2018, 12:27 Joel Sherrill, wrote: > Chris needs to speak up since it is Python. > > I see changes to HTML output which I doubt are related to the core change. > There are no real changes to HTML, I have just added line breaks in the code because it was too long. > > On Tue, Jun

Re: [PATCH] coverage : Add support to run coverage in supported bsp without extra options

2018-06-12 Thread Joel Sherrill
Chris needs to speak up since it is Python. I see changes to HTML output which I doubt are related to the core change. On Tue, Jun 12, 2018, 8:39 AM Vijay Kumar Banerjee wrote: > Please review this patch. :) > On 7 June 2018 at 16:38, Vijay Kumar Banerjee > wrote: > >> Close #3440 >> --- >>

Re: [PATCH] coverage : Add support to run coverage in supported bsp without extra options

2018-06-12 Thread Vijay Kumar Banerjee
Please review this patch. :) On 7 June 2018 at 16:38, Vijay Kumar Banerjee wrote: > Close #3440 > --- > tester/rt/coverage.py | 6 -- > tester/rt/test.py | 15 ++- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/tester/rt/coverage.py