Re: [PATCH] posix: Use alias for pthread_self()

2021-04-27 Thread Sebastian Huber
On 28/04/2021 00:28, Joel Sherrill wrote: On Tue, Apr 27, 2021, 11:24 AM Sebastian Huber > wrote: On 27/04/2021 18:23, Gedare Bloom wrote: > PS: the git-rm is missing? Oh, yes. I will fix this if Joel is happy with the change. Can

Re: [PATCH] c-user: Generate region manager documentation

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 12:03 PM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were

Re: [PATCH v2] STM32 lwIP addition and CMake support

2021-04-27 Thread Chris Johns
On 28/4/21 2:58 am, Robin Müller wrote: > Okay, I can understand that you'd like to have one build system only. We had > the > same issue with a former Makefile build system and the new CMake system and > decided to make the former system obsolete> because maintaining both of them > would be too

Re: [PATCH v3 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-27 Thread Vijay Kumar Banerjee
On Tue, Apr 27, 2021 at 2:22 PM Gedare Bloom wrote: > > ok, vijay, please check the build and push if all good > Checked the build and pushed it. Thanks. > On Tue, Apr 27, 2021 at 11:48 AM wrote: > > > > From: Peter Dufault > > > > With these two changes the "powerpc/shared/console" code

Re: [PATCH] posix: Use alias for pthread_self()

2021-04-27 Thread Joel Sherrill
On Tue, Apr 27, 2021, 11:24 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 27/04/2021 18:23, Gedare Bloom wrote: > > > PS: the git-rm is missing? > Oh, yes. I will fix this if Joel is happy with the change. > Can you set a breakpoint on it as pthread_self? It is an odd

Re: [PATCH v3 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-27 Thread Gedare Bloom
ok, vijay, please check the build and push if all good On Tue, Apr 27, 2021 at 11:48 AM wrote: > > From: Peter Dufault > > With these two changes the "powerpc/shared/console" code supports a > configurable baud rate. > > Peter Dufault (2): > powerpc/shared/console: Make console baud rate

Re: [PATCH] STM32 lwIP addition

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 2:09 PM Gedare Bloom wrote: > > On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller > wrote: > > I'm not sure what happened, it looks like my email client garbled the inline threaded reply. Hopefully my comments come through for you ok.

Re: [PATCH] STM32 lwIP addition

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller wrote: > > This patch adds the STM32H7 / NUCLEO-H743ZI lwIP port. > It also improves the architecture to make integration > of new BSPs easier. > > https://github.com/rmspacefish/rtems-stm32-lwip is a self-contained > repository to test the lwIP

Re: [PATCH v2] STM32 lwIP addition and CMake support

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 10:58 AM Robin Müller wrote: > > Okay, I can understand that you'd like to have one build system only. We had > the same issue with a former Makefile build system and the new CMake system > and decided to make the former system obsolete > because maintaining both of them

Exception Management

2021-04-27 Thread Kinsey Moore
Currently, code that needs to consume exceptions has two points where it can hook exceptions: 1) The consumer can hook the exception vectors directly. This allows for full control of how the exceptions are handled, but requires very low level platform-specific code even where it might not

Re: [PATCH] c-user: Generate task manager documentation

2021-04-27 Thread Gedare Bloom
your suggestions look good On Tue, Apr 27, 2021 at 11:52 AM Sebastian Huber wrote: > > Hello Gedare, > > thanks a lot for the review. > > On 27/04/2021 18:01, Gedare Bloom wrote: > > > On Tue, Apr 27, 2021 at 3:31 AM Sebastian Huber > > wrote: > >> The documentation is a consolidation of the

Re: [PATCH v2] STM32 lwIP addition and CMake support

2021-04-27 Thread Robin Müller
Almost all files in the Cube repository have the new BSD3 license, but some application and example files still appear to be licensed under SLA0044. I created an issue in the STM32H7 Cube repository ( https://github.com/STMicroelectronics/STM32CubeH7/issues/139) , and the Cube developers seem to

[PATCH] c-user: Generate region manager documentation

2021-04-27 Thread Sebastian Huber
The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. The documentation source files were generated from the items by a script. Update #3993. --- Here is the

[PATCH] CMake support for the STM32 lwIP addition

2021-04-27 Thread Robin Mueller
This patch adds full CMake support for the lwIP support. It can be easily extended to other architectures as well. More information can also be found in the README, which also specifies how to build with CMake. The waf build system still needs to be adapted to perform the same function. ---

Re: [PATCH] c-user: Generate task manager documentation

2021-04-27 Thread Sebastian Huber
Hello Gedare, thanks a lot for the review. On 27/04/2021 18:01, Gedare Bloom wrote: On Tue, Apr 27, 2021 at 3:31 AM Sebastian Huber wrote: The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered

[PATCH v3 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-27 Thread dufault
From: Peter Dufault With these two changes the "powerpc/shared/console" code supports a configurable baud rate. Peter Dufault (2): powerpc/shared/console: Make console baud rate configurable. powerpc/shared/console: "termios" first open sets console baud to 9600

[PATCH v3 1/2] powerpc/shared/console: Make console baud rate configurable.

2021-04-27 Thread dufault
From: Peter Dufault The "powerpc/shared/console" code has the start-up console value fixed at 9600 baud. This changes the hard-wired constant "9600" in the code to the configuration setting "BSP_CONSOLE_BAUD" and adds configuration support in both the "waf" and the legacy configuration systems.

[PATCH v3 2/2] powerpc/shared/console: "termios" first open sets console baud to 9600

2021-04-27 Thread dufault
From: Peter Dufault When the PowerPC shared console baud rate starts at anything other than 9600 the termios code will set it to 9600 at the first open. --- bsps/powerpc/shared/console/uart.c | 4 1 file changed, 4 insertions(+) diff --git a/bsps/powerpc/shared/console/uart.c

Re: [PATCH 0/2] powerpc/shared/console: Console buad rate fixes

2021-04-27 Thread dufault
I forgot to specify V2. I'll try again, sorry for the noise. > On Apr 27, 2021, at 13:40 , wrote: > > From: Peter Dufault > > With these two changes the "powerpc/shared/console" code supports a > configurable baud rate. > > - Remove hard-wired start-up baud of 9600. > - Fix "termios"

[PATCH] STM32 lwIP addition

2021-04-27 Thread Robin Mueller
This patch adds the STM32H7 / NUCLEO-H743ZI lwIP port. It also improves the architecture to make integration of new BSPs easier. https://github.com/rmspacefish/rtems-stm32-lwip is a self-contained repository to test the lwIP integration for the arm/stm32h7 and arm/nucleo-h743zi BSP. The STM32

[PATCH 2/2] powerpc/shared/console: "termios" first open sets console baud to 9600

2021-04-27 Thread dufault
From: Peter Dufault When the PowerPC shared console baud rate starts at anything other than 9600 the termios code will set it to 9600 at the first open. --- bsps/powerpc/shared/console/uart.c | 4 1 file changed, 4 insertions(+) diff --git a/bsps/powerpc/shared/console/uart.c

[PATCH 1/2] powerpc/shared/console: Make console baud rate configurable.

2021-04-27 Thread dufault
From: Peter Dufault The "powerpc/shared/console" code has the start-up console value fixed at 9600 baud. This changes the hard-wired constant "9600" in the code to the configuration setting "BSP_CONSOLE_BAUD" and adds configuration support in both the "waf" and the legacy configuration systems.

[PATCH 0/2] powerpc/shared/console: Console buad rate fixes

2021-04-27 Thread dufault
From: Peter Dufault With these two changes the "powerpc/shared/console" code supports a configurable baud rate. - Remove hard-wired start-up baud of 9600. - Fix "termios" first-open that resets baud rate to 9600. Peter Dufault (2): powerpc/shared/console: Make console baud rate configurable.

Re: [PATCH v2] STM32 lwIP addition and CMake support

2021-04-27 Thread Robin Müller
Okay, I can understand that you'd like to have one build system only. We had the same issue with a former Makefile build system and the new CMake system and decided to make the former system obsolete because maintaining both of them would be too much work. First thing I can do is that I split up

tcpreplay for testing network stacks

2021-04-27 Thread Vijay Kumar Banerjee
Hi, I came across the tcpreplay tool and it looks like a nice tool for testing the network stacks. It can be used to capture network traffic and then play it back, this will help with testing the network packets from different network stacks. My proposal is to add the tcpreply as a host-side

Re: [PATCH v2 2/2] powerpc/shared/console: "termios" first open sets console baud to 9600

2021-04-27 Thread Gedare Bloom
On Sat, Apr 10, 2021 at 6:41 AM wrote: > > From: Peter Dufault > > When the PowerPC shared console baud rate starts at anything other than > 9600 the termios code will set it to 9600 at the first open. > --- > bsps/powerpc/shared/console/uart.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [PATCH v2] STM32 lwIP addition and CMake support

2021-04-27 Thread Sebastian Huber
On 27/04/2021 17:23, Gedare Bloom wrote: I can try to get a better license for the files taken from the example. If that doesn't work out, I guess some scripting will be necessary. The problem is that these files were modified to be usable for RTEMS.. Thanks. It might require iterating with

Re: [PATCH] posix: Use alias for pthread_self()

2021-04-27 Thread Sebastian Huber
On 27/04/2021 18:23, Gedare Bloom wrote: PS: the git-rm is missing? Oh, yes. I will fix this if Joel is happy with the change. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax:

Re: [PATCH] posix: Use alias for pthread_self()

2021-04-27 Thread Gedare Bloom
PS: the git-rm is missing? On Tue, Apr 27, 2021, 10:09 AM Gedare Bloom wrote: > @Joel: you ok with this cross-link between classic and posix layers? > > On Tue, Apr 27, 2021 at 3:12 AM Sebastian Huber > wrote: > > > > This may reduce the code size a bit. > > --- > > cpukit/Makefile.am

Re: [PATCH] posix: Use alias for pthread_self()

2021-04-27 Thread Gedare Bloom
@Joel: you ok with this cross-link between classic and posix layers? On Tue, Apr 27, 2021 at 3:12 AM Sebastian Huber wrote: > > This may reduce the code size a bit. > --- > cpukit/Makefile.am| 1 - > cpukit/rtems/src/taskself.c | 4 > spec/build/cpukit/librtemscpu.yml

Re: [PATCH] rtems: Constify timer fire when directives

2021-04-27 Thread Gedare Bloom
add ticket On Tue, Apr 27, 2021 at 2:54 AM Sebastian Huber wrote: > > --- > cpukit/include/rtems/rtems/timer.h | 4 ++-- > cpukit/rtems/src/timerfirewhen.c | 2 +- > cpukit/rtems/src/timerserverfirewhen.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] Return status code for _Scheduler_Set_affinity()

2021-04-27 Thread Gedare Bloom
ok On Mon, Apr 26, 2021 at 5:55 AM Sebastian Huber wrote: > > This avoids having conditional statements to get the API-specific status > code. > --- > cpukit/include/rtems/score/scheduler.h| 12 ++--- > cpukit/include/rtems/score/scheduleredfsmp.h | 9 --- >

Re: [PATCH] Return status code for _Thread_Start()

2021-04-27 Thread Gedare Bloom
ok On Mon, Apr 26, 2021 at 5:54 AM Sebastian Huber wrote: > > This avoids having conditional statements to get the API-specific status > code. > --- > cpukit/include/rtems/score/threadimpl.h | 7 +++ > cpukit/posix/src/pthreadcreate.c| 5 ++--- > cpukit/rtems/src/taskstart.c

Re: [PATCH] rtems: Change rtems_task_get_affinity() status

2021-04-27 Thread Gedare Bloom
This is an API visible change. Please add a ticket. On Mon, Apr 26, 2021 at 5:54 AM Sebastian Huber wrote: > > Return RTEMS_INVALID_SIZE if the processor set is too small to contain > the processor affinity set of the task. > --- > cpukit/include/rtems/score/schedulerimpl.h | 2 +- >

Re: [PATCH 2/2] Simplify get affinitiy directives

2021-04-27 Thread Gedare Bloom
ok On Mon, Apr 26, 2021 at 2:41 AM Sebastian Huber wrote: > > There is no need to disable thread dispatching to get the affinity of a > task. > --- > cpukit/posix/src/pthreadgetaffinitynp.c | 3 --- > cpukit/rtems/src/taskgetaffinity.c | 3 --- > 2 files changed, 6 deletions(-) > > diff

Re: [PATCH 1/2] Return status code for _Scheduler_Get_affinity()

2021-04-27 Thread Gedare Bloom
ok On Mon, Apr 26, 2021 at 2:41 AM Sebastian Huber wrote: > > This avoids having conditional expressions to the API-specific status > code. > --- > cpukit/include/rtems/score/schedulerimpl.h | 7 --- > cpukit/posix/src/pthreadgetaffinitynp.c| 7 --- >

Re: [PATCH v2] c-user: Generate interrupt manager documentation

2021-04-27 Thread Gedare Bloom
OK, thanks for the clarification. On Mon, Apr 26, 2021 at 11:39 PM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The

Re: [PATCH] c-user: Generate task manager documentation

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 3:31 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were

[PATCH v3] sb: Merge mailer changes from rtems-tools

2021-04-27 Thread Alex White
This adds the improved mailer.py script from rtems-tools. Closes #4388 --- source-builder/sb/mailer.py | 193 ++-- source-builder/sb/options.py| 26 - source-builder/sb/setbuilder.py | 2 + 3 files changed, 188 insertions(+), 33 deletions(-) diff --git

[PATCH] c-user: Generate task manager documentation

2021-04-27 Thread Sebastian Huber
The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. The documentation source files were generated from the items by a script. Update #3993. --- Here is the

[PATCH] posix: Use alias for pthread_self()

2021-04-27 Thread Sebastian Huber
This may reduce the code size a bit. --- cpukit/Makefile.am| 1 - cpukit/rtems/src/taskself.c | 4 spec/build/cpukit/librtemscpu.yml | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am index

[PATCH] rtems: Constify timer fire when directives

2021-04-27 Thread Sebastian Huber
--- cpukit/include/rtems/rtems/timer.h | 4 ++-- cpukit/rtems/src/timerfirewhen.c | 2 +- cpukit/rtems/src/timerserverfirewhen.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpukit/include/rtems/rtems/timer.h b/cpukit/include/rtems/rtems/timer.h index