Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-22 Thread Pavel Pisa
Hello Gedare, On Thursday 22 of September 2016 03:26:32 Gedare Bloom wrote: > I only added a couple of very minor inline comments. Looks good, I > think you can push directly no one else needs to re-read this > BSP-specific stuff. thanks much for reading that huge pieces. I have corrected some t

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-21 Thread Gedare Bloom
I only added a couple of very minor inline comments. Looks good, I think you can push directly no one else needs to re-read this BSP-specific stuff. On Sun, Sep 18, 2016 at 8:33 PM, Gedare Bloom wrote: > I will try to read your GitHub diffs sometime this week. > > Thanks > > On Sat, Sep 17, 2016

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-18 Thread Gedare Bloom
I will try to read your GitHub diffs sometime this week. Thanks On Sat, Sep 17, 2016 at 6:34 PM, Pavel Pisa wrote: > Hello Gedare, > > I have tried to update code according to your review. > I have added even enabled/uncommented and added implementation > for some more test. Especially ECC integ

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-17 Thread Pavel Pisa
Hello Gedare, I have tried to update code according to your review. I have added even enabled/uncommented and added implementation for some more test. Especially ECC integrated TCRAM single errors correction and reporting test. I have commented why double errors abort exception based test is comme

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-14 Thread Gedare Bloom
On Wed, Sep 14, 2016 at 4:29 AM, Pavel Pisa wrote: > Hello Gedare, > > On Wednesday 14 of September 2016 02:13:47 Gedare Bloom wrote: >> On Tue, Sep 13, 2016 at 5:11 PM, Pavel Pisa wrote: >> > Hello Gedare, >> > >> > thanks for the review. It is huge piece and not in a state >> > as nice as I wou

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-14 Thread Pavel Pisa
Hello Gedare, On Wednesday 14 of September 2016 02:13:47 Gedare Bloom wrote: > On Tue, Sep 13, 2016 at 5:11 PM, Pavel Pisa wrote: > > Hello Gedare, > > > > thanks for the review. It is huge piece and not in a state > > as nice as I would like it. > > > > On Tuesday 13 of September 2016 21:42:48 G

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-13 Thread Gedare Bloom
On Tue, Sep 13, 2016 at 5:11 PM, Pavel Pisa wrote: > Hello Gedare, > > thanks for the review. It is huge piece and not in a state > as nice as I would like it. > > On Tuesday 13 of September 2016 21:42:48 Gedare Bloom wrote: >> I'm slowly reading through these. Is there a doc or is it worth it to

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-13 Thread Pavel Pisa
Hello Gedare, thanks for the review. It is huge piece and not in a state as nice as I would like it. On Tuesday 13 of September 2016 21:42:48 Gedare Bloom wrote: > I'm slowly reading through these. Is there a doc or is it worth it to > generate one that maps the HalcoGen functions to their RTEMS

Re: [PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-13 Thread Gedare Bloom
I'm slowly reading through these. Is there a doc or is it worth it to generate one that maps the HalcoGen functions to their RTEMS renamed versions? I'm not sure if it is of much value. On Mon, Sep 12, 2016 at 5:47 PM, wrote: > From: Pavel Pisa > > The code introduces initialization algorithms

[PATCH 0/5] arm/tms570: include hardware initialization and selftests to run RTEMS directly from Flash without loader on TMS570LS3137 HDK.

2016-09-12 Thread pisa
From: Pavel Pisa The code introduces initialization algorithms bases on Ti HalCoGen generated files. The most of the code has been rewritten to use RTEMS much more complete header files. This allowed to replace most of the hardcoded hexadecimal values by appropriate fields macros documenting how