Re: [PATCH 08/12] gcov: Add functions to dump the gcov information

2022-07-01 Thread Chris Johns
On 1/7/2022 3:59 pm, Sebastian Huber wrote: > On 01.07.22 07:48, Chris Johns wrote: >> On 1/7/2022 3:00 pm, Sebastian Huber wrote: >>> On 01.07.22 02:37, Chris Johns wrote: > +void _IO_Gcov_dump_info_base64( IO_Put_char put_char, void *arg ); > + Why just a per char interface? Given

Re: [PATCH 08/12] gcov: Add functions to dump the gcov information

2022-06-30 Thread Sebastian Huber
On 01.07.22 07:48, Chris Johns wrote: On 1/7/2022 3:00 pm, Sebastian Huber wrote: On 01.07.22 02:37, Chris Johns wrote: +void _IO_Gcov_dump_info_base64( IO_Put_char put_char, void *arg ); + Why just a per char interface? Given this is in the score a buffer plus length interface would make

Re: [PATCH 08/12] gcov: Add functions to dump the gcov information

2022-06-30 Thread Chris Johns
On 1/7/2022 3:00 pm, Sebastian Huber wrote: > On 01.07.22 02:37, Chris Johns wrote: >>> +void _IO_Gcov_dump_info_base64( IO_Put_char put_char, void *arg ); >>> + >> Why just a per char interface? Given this is in the score a buffer plus >> length >> interface would make more sense? It would make

Re: [PATCH 08/12] gcov: Add functions to dump the gcov information

2022-06-30 Thread Sebastian Huber
On 01.07.22 02:37, Chris Johns wrote: +void _IO_Gcov_dump_info_base64( IO_Put_char put_char, void *arg ); + Why just a per char interface? Given this is in the score a buffer plus length interface would make more sense? It would make the interface more efficient. All the test output uses a

Re: [PATCH 08/12] gcov: Add functions to dump the gcov information

2022-06-30 Thread Chris Johns
On 29/6/2022 4:30 pm, Sebastian Huber wrote: > Update #4670. > --- > cpukit/include/rtems/score/io.h | 4 + > cpukit/include/rtems/test-info.h| 6 ++ > cpukit/libtest/testgcovdumpinfo.c | 66 ++ > cpukit/score/src/iogcovdumpinfo.c | 101

[PATCH 08/12] gcov: Add functions to dump the gcov information

2022-06-29 Thread Sebastian Huber
Update #4670. --- cpukit/include/rtems/score/io.h | 4 + cpukit/include/rtems/test-info.h| 6 ++ cpukit/libtest/testgcovdumpinfo.c | 66 ++ cpukit/score/src/iogcovdumpinfo.c | 101 + cpukit/score/src/iogcovdumpinfobase64.c | 111