AW: [PATCH 1/1] misc: tools: fix mkimage.py script type processing

2021-02-16 Thread Andre.Nahrwold
Hi Chris, as far as my understanding of python goes this does not make any difference. Strings are essentially arrays in python which would make the parenthesis obsolete. When this condition should catch another type in the future it would be good practice to do something like this: If options

Re: splinkersets01 test assumptions

2021-02-16 Thread Sebastian Huber
On 16/02/2021 22:26, Kinsey Moore wrote: In verifying AArch64/ILP32 on hardware I ran across quite a few alignment issues, some of which were caused by the use of SUBALIGN() in the linker scripts mentioned here: https://devel.rtems.org/ticket/4178 SUBA

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-16 Thread Sebastian Huber
On 17/02/2021 03:20, Chris Johns wrote: I have looked into this some more with Joel. Comments below .. On 16/2/21 5:49 pm, Chris Johns wrote: Hi Sebastian, Thank you for the review. On 16/2/21 5:05 pm, Sebastian Huber wrote: On 16/02/2021 03:02, chr...@rtems.org wrote: +/* + * Values for t

[libbsd PATCH v2 2/2] bsp/motorola_powerpc: Add dc and ukphy support

2021-02-16 Thread chrisj
From: Chris Johns - Add the dc net dev to the BSP - Add the ukphy support Closes # 4246 --- freebsd/sys/dev/dc/if_dc.c| 7 freebsd/sys/dev/dc/if_dcreg.h | 7 rtemsbsd/include/bsp/nexus-devices.h | 4 +++ .../include/machine/rtems-bsd-ne

[libbsd PATCH v2 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-16 Thread chrisj
From: Chris Johns - Add PCI IO region support - Add support map buffers to PCI address space Closes #4245 --- rtemsbsd/include/machine/bus.h| 282 -- rtemsbsd/rtems/rtems-kernel-bus-dma.c | 5 +- rtemsbsd/rtems/rtems-kernel-nexus.c | 50 - 3 files chang

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-16 Thread Chris Johns
I have looked into this some more with Joel. Comments below .. On 16/2/21 5:49 pm, Chris Johns wrote: > Hi Sebastian, > > Thank you for the review. > > On 16/2/21 5:05 pm, Sebastian Huber wrote: >> >> On 16/02/2021 03:02, chr...@rtems.org wrote: >>> +/* >>> + * Values for the bus space tag, not

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread Chris Johns
On 17/2/21 7:34 am, Gedare Bloom wrote: > On Tue, Feb 16, 2021 at 10:44 AM wrote: >>> On Feb 16, 2021, at 11:33 , Gedare Bloom wrote: The umlaut is part of the official brand. That can be tricky, depending on the corporate policy. > I find it odd to avoid Unicode and not allow

splinkersets01 test assumptions

2021-02-16 Thread Kinsey Moore
In verifying AArch64/ILP32 on hardware I ran across quite a few alignment issues, some of which were caused by the use of SUBALIGN() in the linker scripts mentioned here: https://devel.rtems.org/ticket/4178 SUBALIGN() was necessary for two reasons: * libc sysinit linker sets (this can be fi

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread Gedare Bloom
On Tue, Feb 16, 2021 at 10:44 AM wrote: > > > > > On Feb 16, 2021, at 11:33 , Gedare Bloom wrote: > > > >> The umlaut is part of the official brand. > >> That can be tricky, depending on the corporate policy. > >> > >>> I find it odd to avoid Unicode and not allow umlauts in 2021. > >>> > >> > >

Re: [PATCH 1/1] misc: tools: fix mkimage.py script type processing

2021-02-16 Thread Chris Johns
On 12/2/21 3:23 am, Jan Sommer wrote: > From: Andre Nahrwold > > --- > misc/tools/mkimage.py | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/misc/tools/mkimage.py b/misc/tools/mkimage.py > index fd75f0a..111e224 100755 > --- a/misc/tools/mkimage.py > +++ b/misc/tools/mkimag

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread dufault
> On Feb 16, 2021, at 11:33 , Gedare Bloom wrote: > >> The umlaut is part of the official brand. >> That can be tricky, depending on the corporate policy. >> >>> I find it odd to avoid Unicode and not allow umlauts in 2021. >>> >> > > We do allow unicode with justification. For names, I hav

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread Gedare Bloom
On Tue, Feb 16, 2021 at 8:47 AM wrote: > > > -Original Message- > > From: dufa...@hda.com > > Sent: Tuesday, February 16, 2021 2:05 PM > > To: Sommer, Jan > > Cc: j...@rtems.org; devel@rtems.org > > Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi > > > > You

RE: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread Jan.Sommer
> -Original Message- > From: dufa...@hda.com > Sent: Tuesday, February 16, 2021 2:05 PM > To: Sommer, Jan > Cc: j...@rtems.org; devel@rtems.org > Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi > > You could use "fuer" to replace "für" as was done in the olde

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread dufault
You could use "fuer" to replace "für" as was done in the olden days. Or do you need permission for that as well? I find it odd to avoid Unicode and not allow umlauts in 2021. > On Feb 16, 2021, at 05:21 , jan.som...@dlr.de wrote: > > Ok, I asked if it is ok to use the English name for our orga

RE: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-16 Thread Jan.Sommer
Ok, I asked if it is ok to use the English name for our organization as well. The answer might take some time, though. Best regards, Jan From: Joel Sherrill Sent: Monday, February 15, 2021 9:41 PM To: Peter Dufault Cc: Sommer, Jan ; rtems-de...@rtems.org Subject: Re: [PATCH v3 1/3] bsps/x

RE: [PATCH 0/1] misc: tools: fix mkimage.py script type processing

2021-02-16 Thread Jan.Sommer
> -Original Message- > From: Chris Johns > Sent: Tuesday, February 16, 2021 6:27 AM > To: Sommer, Jan ; devel@rtems.org > Subject: Re: [PATCH 0/1] misc: tools: fix mkimage.py script type processing > > On 12/2/21 3:23 am, Jan Sommer wrote: > > Here is the patch from Andre also in git se