RTEMS on PolarFire SoC ICICLE Kit FPGA

2021-04-22 Thread somesh deshmukh
I was able to test the rtems hello-world example and ticker example on the polarfire soc icicle kit. A little background about Polarfire SoC ICICLE Kit. The PolarFire SoC Icicle kit is a low-cost development platform that enables the evaluation of the five-core Linux capable RISC-V

[PATCH rtems v2] testsuites: Remove telnetd01

2021-04-22 Thread Vijay Kumar Banerjee
telnetd01 test cannot be run without a network stack, so this test is being moved to the rtems-net-legacy repository. --- spec/build/testsuites/libtests/grp.yml | 2 - spec/build/testsuites/libtests/telnetd01.yml | 22 testsuites/libtests/telnetd01/init.c | 120

Re: [PATCH rtems-docs] legacy-networking: Add note with build instructions for rtems-net-legacy

2021-04-22 Thread Vijay Kumar Banerjee
On Thu, Apr 22, 2021 at 12:18 PM Gedare Bloom wrote: > > On Thu, Apr 22, 2021 at 12:08 PM Vijay Kumar Banerjee wrote: > > > > ping. :) > > > > On Mon, Apr 19, 2021 at 12:12 PM Vijay Kumar Banerjee > > wrote: > > > > > > --- > > > legacy-networking/index.rst | 1 + > > >

[PATCH rtems-docs v2] legacy-networking: Add note with build instructions for rtems-net-legacy

2021-04-22 Thread Vijay Kumar Banerjee
--- legacy-networking/index.rst | 1 + legacy-networking/quick_start.rst | 33 +++ 2 files changed, 34 insertions(+) create mode 100644 legacy-networking/quick_start.rst diff --git a/legacy-networking/index.rst b/legacy-networking/index.rst index

Re: [PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-22 Thread Niteesh G. S.
Hello Christian, On Thu, Apr 22, 2021 at 10:24 PM Christian Mauderer wrote: > Hello Niteesh, > > thanks for the reminder and the patches. I pushed them. > Thanks for pushing them Thank you, Niteesh. > > Best regards > > Christian > > On 22/04/2021 05:54, Niteesh G. S. wrote: > > Hello

Implimenting timer_monotonic

2021-04-22 Thread zack_on_the_speed_chanel
Hello, So in looking at the ticket i realized it was more the making the test and only testing the creation of a timer object. I also have to implement the monotonic timer. Right now it seems like a monumental task for me currently. I began to look at the code for timergettime. I'm looking at

[PATCH v2] psx13: Reworked and relicensed

2021-04-22 Thread Ryan Long
Changed the way the tests were structured, added rtems_test_assert()'s, updated psx13.scn and the license. --- testsuites/psxtests/psx13/main.c| 37 +- testsuites/psxtests/psx13/psx13.scn | 21 +- testsuites/psxtests/psx13/test.c| 852 3 files

Re: [PATCH rtems 1/2] telnetd.c: Remove RTEMS_NETWORKING check

2021-04-22 Thread Gedare Bloom
I guess there's not much else to do here without a network stack API to manipulate the network task(s). Is there a ticket to fix the lack of ability to configure and access network task priorities? I'm guessing libbsd and lwip will both need to figure out how to do this somehow. The design isn't

Re: [PATCH rtems-docs] legacy-networking: Add note with build instructions for rtems-net-legacy

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 12:08 PM Vijay Kumar Banerjee wrote: > > ping. :) > > On Mon, Apr 19, 2021 at 12:12 PM Vijay Kumar Banerjee wrote: > > > > --- > > legacy-networking/index.rst | 1 + > > legacy-networking/quick_start.rst | 29 + > > 2 files changed, 30

Re: [PATCH rtems 2/2] testsuites: Remove telnetd01

2021-04-22 Thread Vijay Kumar Banerjee
On Thu, Apr 22, 2021 at 12:16 PM Gedare Bloom wrote: > > Should the commit message indicate where these files have been moved? > Ok, I'll send a v2 with a clearer message and add it in the messages that it's being removed as it cannot be tested without a networking stack. > Otherwise, it's ok to

Re: [PATCH rtems 2/2] testsuites: Remove telnetd01

2021-04-22 Thread Gedare Bloom
Should the commit message indicate where these files have been moved? Otherwise, it's ok to me. Can't run this test without building a stack. On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee wrote: > > --- > spec/build/testsuites/libtests/grp.yml | 2 - >

Re: [PATCH rtems-docs] legacy-networking: Add note with build instructions for rtems-net-legacy

2021-04-22 Thread Vijay Kumar Banerjee
ping. :) On Mon, Apr 19, 2021 at 12:12 PM Vijay Kumar Banerjee wrote: > > --- > legacy-networking/index.rst | 1 + > legacy-networking/quick_start.rst | 29 + > 2 files changed, 30 insertions(+) > create mode 100644 legacy-networking/quick_start.rst > > diff

Re: [PATCH rtems 2/2] testsuites: Remove telnetd01

2021-04-22 Thread Vijay Kumar Banerjee
ping :) On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee wrote: > > --- > spec/build/testsuites/libtests/grp.yml | 2 - > spec/build/testsuites/libtests/telnetd01.yml | 22 > testsuites/libtests/telnetd01/init.c | 120 --- >

Re: [PATCH rtems 1/2] telnetd.c: Remove RTEMS_NETWORKING check

2021-04-22 Thread Vijay Kumar Banerjee
Ping :) On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee wrote: > > Set the priority manually to make telnetd compatible with the > --- > cpukit/telnetd/telnetd.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/cpukit/telnetd/telnetd.c

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 11:33 AM Sebastian Huber wrote: > > On 22/04/2021 17:44, Gedare Bloom wrote: > > > Also not related to the documentation, but it seems that > > rtems_message_queue_construct() will not handle a NULL configuration. > > Is this intentional, or a bug to fix in the code and an

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 11:52 AM Sebastian Huber wrote: > > On 22/04/2021 17:44, Gedare Bloom wrote: > > >> +:c:macro:`RTEMS_ILLEGAL_ON_REMOTE_OBJECT` > >> +The semaphore resided on a remote node. > > s/semaphore/message queue > > > Thanks for the review. I fixed the typos. Should I still

Re: [PATCH] Correct NUCLEO-H743ZI Ethernet Pins

2021-04-22 Thread Sebastian Huber
On 22/04/2021 19:35, Robin Mueller wrote: Please change this to (add an option for STM32H7_ETH_GPIOB_PINS) #ifdef STM32H7_ETH_GPIOB_PINS +static const stm32h7_gpio_config gpiob = { + .regs = GPIOB, + .config = { +.Pin = GPIO_PIN_13, +.Mode = GPIO_MODE_AF_PP, +.Pull =

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:44, Gedare Bloom wrote: +:c:macro:`RTEMS_ILLEGAL_ON_REMOTE_OBJECT` +The semaphore resided on a remote node. s/semaphore/message queue Thanks for the review. I fixed the typos. Should I still send a v2 of the patch? -- embedded brains GmbH Herr Sebastian HUBER

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:44, Gedare Bloom wrote: +.. index:: RTEMS_MESSAGE_QUEUE_BUFFER() + +.. _InterfaceRTEMSMESSAGEQUEUEBUFFER: + +RTEMS_MESSAGE_QUEUE_BUFFER() Before now, this was not well documented. It is good to add, but I wonder if this is also a good time to make it more like other

Re: STM32H7 UART pins Update

2021-04-22 Thread Robin Müller
I think the pins for the UART 3 still need to be adapted. Everything can be simplified because the pins are the same after all with GPIOD PIN 8 and PIN9 for both variants. I sent a patch which configures the ETH correctly for the Nucleo BSP variant. Kind Regards Robin On Thu, 22 Apr 2021 at

[PATCH] Correct NUCLEO-H743ZI Ethernet Pins

2021-04-22 Thread Robin Mueller
The nucleo BSP has different pins for the Ethernet configuration. This patch adds support for this. --- bsps/arm/stm32h7/start/stm32h7-hal-eth.c | 18 +- spec/build/bsps/arm/stm32h7/grp.yml | 2 ++ .../bsps/arm/stm32h7/optethgpiogregs.yml | 19

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:44, Gedare Bloom wrote: Also not related to the documentation, but it seems that rtems_message_queue_construct() will not handle a NULL configuration. Is this intentional, or a bug to fix in the code and an error status to add? If it is intentional, an assert(config) should be

[PATCH] Implementation for STM32 HAL_GetTick using RTEMS

2021-04-22 Thread Robin Mueller
Accounts for the tick base not being 1ms now. Perform division first to reduce chance of arithmetic overflow. --- bsps/arm/stm32h7/start/bspstart.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bsps/arm/stm32h7/start/bspstart.c b/bsps/arm/stm32h7/start/bspstart.c index

Re: STM32H7 UART pins Update

2021-04-22 Thread Robin Müller
Thanks :-) I was able to omit the HAL_ETH_MspInit override in my lwIP code now. Kind Regards Robin On Thu, 22 Apr 2021 at 15:32, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Robin, > > I hope it is now fixed. For the Ethernet pin customization, you can use > the same

Re: [PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-22 Thread Christian Mauderer
Hello Niteesh, thanks for the reminder and the patches. I pushed them. Best regards Christian On 22/04/2021 05:54, Niteesh G. S. wrote: Hello Christian, Reminder to push the patches. Thanks, Niteesh On Sun, Apr 18, 2021 at 11:57 PM Christian Mauderer > wrote:

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 10:06 AM Ryan Long wrote: > > >> +#ifdef __sparc__ > >What's this for? > Joel said this was a special case, and that it needed to be put in, so I'm > not sure. > Joel: Please address. > For the printf's in test_main(), I should take out all of the print > statements

RE: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Ryan Long
>> +#ifdef __sparc__ >What's this for? Joel said this was a special case, and that it needed to be put in, so I'm not sure. For the printf's in test_main(), I should take out all of the print statements saying "Testing .Success"? -Original Message- From: Gedare Bloom Sent:

Re: Qemu for ultra96

2021-04-22 Thread Kinsey Moore
On 4/22/2021 08:47, Alireza Banejad wrote: Hello I want to know could I run applications for the ultra96 bsp in qemu? I tried the qemu-system-arm with the virt machine and cpu specified as cortex-a7 yet I don't get anything I also tried the qemu-system-aarch64 specifying the machine as

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Joel Sherrill
https://git.rtems.org/rtems/tree/testsuites/psxtests/psx13/main.c On Thu, Apr 22, 2021, 10:48 AM Gedare Bloom wrote: > On Thu, Apr 22, 2021 at 9:44 AM Ryan Long wrote: > > > > What other file? > > > > ls rtems/testsuites/psxtests/psx13 > > > > > > > > From: Joel Sherrill > > Sent: Thursday,

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 9:44 AM Ryan Long wrote: > > What other file? > ls rtems/testsuites/psxtests/psx13 > > > From: Joel Sherrill > Sent: Thursday, April 22, 2021 9:21 AM > To: Sebastian Huber > Cc: Gedare Bloom ; Ryan Long ; > rtems-de...@rtems.org > Subject: Re: [PATCH] psx13: Reworked

Re: [PATCH 1/2] c-user: Generate rate-monotonic manager docs

2021-04-22 Thread Gedare Bloom
this one is fine, if you want to resend separately I can ACK it right away, or resend with the v2 of the message queue is fine with me. On Thu, Apr 22, 2021 at 8:07 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 8:07 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were

RE: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Ryan Long
What other file? From: Joel Sherrill Sent: Thursday, April 22, 2021 9:21 AM To: Sebastian Huber Cc: Gedare Bloom ; Ryan Long ; rtems-de...@rtems.org Subject: Re: [PATCH] psx13: Reworked and relicensed While you are updating the license on the OAR authored code, you should pick up the other

Re: [PATCH] c-user: fix broken definition in rate-monotonic background.

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:21, Gedare Bloom wrote: Just formatting, but Sebastian works in this area right now, so maybe he can pluck it or ACK a push is ok. I noticed it while reviewing his doc generation patches. Thanks, I checked it in. The generated files are the introduction.rst and the

Re: [PATCH] c-user: fix broken definition in rate-monotonic background.

2021-04-22 Thread Gedare Bloom
Just formatting, but Sebastian works in this area right now, so maybe he can pluck it or ACK a push is ok. I noticed it while reviewing his doc generation patches. On Thu, Apr 22, 2021 at 9:12 AM Joel Sherrill wrote: > > If that's just a formatting error fix, looks good. Push it. > > If it's

Re: [PATCH] c-user: Mention timer server fire directives

2021-04-22 Thread Sebastian Huber
On 22/04/2021 15:53, Gedare Bloom wrote: ok, nice catch. Frank found it, he is currently busy with the Timer Manager specification and the validation tests. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone:

Re: [PATCH] c-user: fix broken definition in rate-monotonic background.

2021-04-22 Thread Joel Sherrill
If that's just a formatting error fix, looks good. Push it. If it's more, poke me. On Thu, Apr 22, 2021, 10:10 AM Gedare Bloom wrote: > --- > c-user/rate-monotonic/background.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/c-user/rate-monotonic/background.rst >

[PATCH] c-user: fix broken definition in rate-monotonic background.

2021-04-22 Thread Gedare Bloom
--- c-user/rate-monotonic/background.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/c-user/rate-monotonic/background.rst b/c-user/rate-monotonic/background.rst index 9ca7dff..c81af4e 100644 --- a/c-user/rate-monotonic/background.rst +++

Re: [PATCH] Updated tick implementation for HAL_GetTick

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 8:02 AM Sebastian Huber wrote: > > On 22/04/2021 14:17, Robin Müller wrote: > > > It worked for me. Can you specify that? The overflow check would have > > to be implemented by an upper layer, right? > > I can adapt my former patch using the tick solution to do the > >

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Joel Sherrill
On Thu, Apr 22, 2021, 9:23 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 22/04/2021 16:21, Joel Sherrill wrote: > > > While you are updating the license on the OAR authored code, you > > should pick up the other file in this directory. > Sorry, what do you mean? > There is

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Sebastian Huber
On 22/04/2021 16:21, Joel Sherrill wrote: While you are updating the license on the OAR authored code, you should pick up the other file in this directory. Sorry, what do you mean? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email:

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Joel Sherrill
While you are updating the license on the OAR authored code, you should pick up the other file in this directory. On Thu, Apr 22, 2021, 9:09 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 22/04/2021 15:44, Gedare Bloom wrote: > > >> + rv = close( fd1 ); > >> +

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Sebastian Huber
On 22/04/2021 15:44, Gedare Bloom wrote: + rv = close( fd1 ); + rtems_test_assert( rv == 0 ); Just curious, why be inconsistent how you check for the return from close? Above using != EOF, here using == 0. It doesn't matter greatly. Different APIs are tested. One uses 0, the other uses

[PATCH 1/2] c-user: Generate rate-monotonic manager docs

2021-04-22 Thread Sebastian Huber
The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. The documentation source files were generated from the items by a script. Update #3993. ---

[PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. The documentation source files were generated from the items by a script. Update #3993. ---

[PATCH 0/2] Generate documentation for managers

2021-04-22 Thread Sebastian Huber
The two patches add the generated documentation for the Rate Monotonic and Message Managers. Here is the updated document for review: https://ftp.rtems.org/pub/rtems/people/sebh/c-user.pdf Sebastian Huber (2): c-user: Generate rate-monotonic manager docs c-user: Generate message manager

Re: [PATCH] Updated tick implementation for HAL_GetTick

2021-04-22 Thread Sebastian Huber
On 22/04/2021 14:17, Robin Müller wrote: It worked for me. Can you specify that? The overflow check would have to be implemented by an upper layer, right? I can adapt my former patch using the tick solution to do the multiplication first if this is better. If you call HAL_GetTick() when the

Re: [PATCH] c-user: Mention timer server fire directives

2021-04-22 Thread Gedare Bloom
ok, nice catch. On Thu, Apr 22, 2021 at 5:52 AM Sebastian Huber wrote: > > A timer may be also reinitiated by the timer server fire directives. > --- > c-user/timer/directives.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/c-user/timer/directives.rst

Re: [PATCH v2] sb: Merge mailer changes from rtems-tools

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 7:18 AM Alex White wrote: > > This adds the improved mailer.py script from rtems-tools. > > Closes #4388 > --- > source-builder/sb/mailer.py | 192 ++-- > source-builder/sb/options.py| 26 - > source-builder/sb/setbuilder.py | 2

Qemu for ultra96

2021-04-22 Thread Alireza Banejad
Hello I want to know could I run applications for the ultra96 bsp in qemu? I tried the qemu-system-arm with the virt machine and cpu specified as cortex-a7 yet I don't get anything I also tried the qemu-system-aarch64 specifying the machine as xlnx-zcu102 and it still couldn't run the application.

Re: [PATCH] psx13: Reworked and relicensed

2021-04-22 Thread Gedare Bloom
See below for comments. This test suite might be a good candidate for conversion to T_TEST_CASE framework. At any rate, this refactor is a marked improvement. On Wed, Apr 21, 2021 at 2:57 PM Ryan Long wrote: > > Changed the way the tests were structured, added rtems_test_assert()'s, > updated

Re: STM32H7 UART pins Update

2021-04-22 Thread Sebastian Huber
Hello Robin, I hope it is now fixed. For the Ethernet pin customization, you can use the same approach. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08

Re: STM32H7 UART pins Update

2021-04-22 Thread Robin Müller
Small corrections: I was always referring to GPIOB PIN9 and PIN10 of course. Kind Regards Robin On Thu, 22 Apr 2021 at 15:20, Robin Müller wrote: > Hi Sebastian > > You recently updated the UART pins configuration, allowing different > variants. > I recently checked the CubeH7 library about

STM32H7 UART pins Update

2021-04-22 Thread Robin Müller
Hi Sebastian You recently updated the UART pins configuration, allowing different variants. I recently checked the CubeH7 library about pin differences between the NUCLEO and the STM32H7 after finding out about the pin differences for the Ethernet module and I found out some weird things. I

[PATCH v2] sb: Merge mailer changes from rtems-tools

2021-04-22 Thread Alex White
This adds the improved mailer.py script from rtems-tools. Closes #4388 --- source-builder/sb/mailer.py | 192 ++-- source-builder/sb/options.py| 26 - source-builder/sb/setbuilder.py | 2 + 3 files changed, 187 insertions(+), 33 deletions(-) diff --git

Re: [PATCH] Updated tick implementation for HAL_GetTick

2021-04-22 Thread Robin Müller
It worked for me. Can you specify that? The overflow check would have to be implemented by an upper layer, right? I can adapt my former patch using the tick solution to do the multiplication first if this is better. Kind Regards Robin On Wed, 21 Apr 2021 at 20:25, Sebastian Huber <

[PATCH] c-user: Mention timer server fire directives

2021-04-22 Thread Sebastian Huber
A timer may be also reinitiated by the timer server fire directives. --- c-user/timer/directives.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/c-user/timer/directives.rst b/c-user/timer/directives.rst index b5ec8f4..5199105 100644 --- a/c-user/timer/directives.rst