Re: AW: AW: [PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

On 07/04/2022 15:16, Sebastian Huber wrote: On 07/04/2022 15:10, gabriel.moy...@dlr.de wrote: Which sequence of function calls and timings cases the problem? This should be definitely a test case. The generation is updated every time tc_windup() is called. So it is more or less a race

Re: AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

On 08/04/2022 02:45, Chris Johns wrote: On 7/4/2022 9:56 pm, Sebastian Huber wrote: We should avoid new CPU options in general. Is this documented with a suitable rational? This could be something for: https://docs.rtems.org/branches/master/eng/coding-conventions.html -- embedded brains

Re: AW: AW: AW: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

On 07/04/2022 16:05, gabriel.moy...@dlr.de wrote: On 07/04/2022 14:51, gabriel.moy...@dlr.de wrote: On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_ntptime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

On 7/4/2022 9:56 pm, Sebastian Huber wrote: > We should avoid new CPU options in general. Is this documented with a suitable rational? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v1] x86_64/elf_machdep.h: Replace stub with NetBSD version

On 7/4/2022 11:43 pm, Ryan Long wrote: > The other ports included that architecture's version of this file from > NetBSD. This patch follows that pattern. OK to push. Chris ___ devel mailing list devel@rtems.org

Re: [PATCH] imfs: Fix index underrun when extending empty file

On 7/4/2022 6:50 pm, Christian MAUDERER wrote: > I applied the patch to all three branches (master, 5, 4.11). Thanks and I appreciate updating 4.11 as well. > I only skipped > adding the test for 4.11 because that part didn't apply without problems. But > the bug is fixed there too. Understood.

[PATCH] bsp/arm: allocate .rtemsstack on REGION_STACK instead of on REGION_WORK

REGION_WORK may be backed by external RAM which may not be initialized in a time we need stack to work well. E.g. code loaded in flash, stack allocated on in-cpu SRAM and data (REGION_WORK) on external SDRAM. Sponsored-By: Precidata --- bsps/arm/shared/start/linkcmds.base | 2 +- 1 file

AW: AW: AW: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

> On 07/04/2022 14:51, gabriel.moy...@dlr.de wrote: > >> On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: > On 07/04/2022 10:36, Gabriel Moyano wrote: > > --- > > cpukit/score/src/kern_ntptime.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git

[PATCH v1] x86_64/elf_machdep.h: Replace stub with NetBSD version

The other ports included that architecture's version of this file from NetBSD. This patch follows that pattern. closes #4641 --- .../score/cpu/x86_64/include/machine/elf_machdep.h | 80 -- 1 file changed, 76 insertions(+), 4 deletions(-) diff --git

Re: AW: AW: [PATCH 05/12] kern_tc.c: Replace atomic functions required by PPS API

On 07/04/2022 15:14, gabriel.moy...@dlr.de wrote: In FreeBSD, it seems the sequence is sometimes incremented using a normal increment, for example: *pcount = pps->capcount; (*pseq)++; *tsp = ts; So, just add the atomic_load_int() as an relaxed atomic load to the other

Re: AW: AW: [PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

On 07/04/2022 15:10, gabriel.moy...@dlr.de wrote: Which sequence of function calls and timings cases the problem? This should be definitely a test case. The generation is updated every time tc_windup() is called. So it is more or less a race condition when it happens. This is not a race

AW: AW: [PATCH 05/12] kern_tc.c: Replace atomic functions required by PPS API

> On 07/04/2022 11:55, gabriel.moy...@dlr.de wrote: > >> On 07/04/2022 10:36, Gabriel Moyano wrote: > >>> --- > >>>cpukit/include/sys/timepps.h | 4 > >>>cpukit/score/src/kern_tc.c | 7 +++ > >>>2 files changed, 11 insertions(+) > >>> > >>> diff --git

AW: AW: [PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

> On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: > >> On 07/04/2022 10:36, Gabriel Moyano wrote: > >>> --- > >>>cpukit/score/src/kern_tc.c | 6 ++ > >>>1 file changed, 6 insertions(+) > >>> > >>> diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c > >>> index

Re: AW: AW: [PATCH 08/12] kern_tc.c: Add definition of tc_getfrequency in kern_tc

On 07/04/2022 14:54, gabriel.moy...@dlr.de wrote: On 07/04/2022 12:43,gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/src/kern_tc.c

Re: AW: AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

On 07/04/2022 14:51, gabriel.moy...@dlr.de wrote: In general, the patch set lacks test cases. I was thinking that the next step could be to add a generic device which is required to use the API (a file descriptor is needed). This is something that wanted to ask in the mailing list first. When

Re: AW: AW: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

On 07/04/2022 14:51, gabriel.moy...@dlr.de wrote: On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_ntptime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/score/src/kern_ntptime.c

AW: AW: [PATCH 08/12] kern_tc.c: Add definition of tc_getfrequency in kern_tc

> On 07/04/2022 12:43, gabriel.moy...@dlr.de wrote: > > > >> On 07/04/2022 10:36, Gabriel Moyano wrote: > >>> --- > >>>cpukit/score/src/kern_tc.c | 2 +- > >>>1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c > >>>

AW: AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

> On 07/04/2022 11:57, gabriel.moy...@dlr.de wrote: > >> On 07/04/2022 10:36, Gabriel Moyano wrote: > >>> --- > >>>spec/build/cpukit/cpuopts.yml| 2 ++ > >>>spec/build/cpukit/optppssync.yml | 16 > >>>2 files changed, 18 insertions(+) > >>>create mode 100644

AW: AW: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

> On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: > >> On 07/04/2022 10:36, Gabriel Moyano wrote: > >>> --- > >>>cpukit/score/src/kern_ntptime.c | 3 +++ > >>>1 file changed, 3 insertions(+) > >>> > >>> diff --git a/cpukit/score/src/kern_ntptime.c > >>> b/cpukit/score/src/kern_ntptime.c

Re: AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

On 07/04/2022 11:57, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- spec/build/cpukit/cpuopts.yml| 2 ++ spec/build/cpukit/optppssync.yml | 16 2 files changed, 18 insertions(+) create mode 100644 spec/build/cpukit/optppssync.yml

Re: AW: [PATCH 08/12] kern_tc.c: Add definition of tc_getfrequency in kern_tc

On 07/04/2022 12:43, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index a8ba268ea3..dd718b3bab 100644

Re: AW: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

On 07/04/2022 11:57, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: +#else /* __rtems__ */ +if (pps->wait_event != NULL) +err = (*pps->wait_event)(pps, fapi->timeout); +else +err = EAGAIN; +#endif /* __rtems__ */

Re: AW: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_ntptime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/score/src/kern_ntptime.c b/cpukit/score/src/kern_ntptime.c index d4a233f67e..d6ea739f5b 100644

Re: AW: [PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_tc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index a5c7b4b841..a8ba268ea3 100644 ---

Re: AW: [PATCH 05/12] kern_tc.c: Replace atomic functions required by PPS API

On 07/04/2022 11:55, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/include/sys/timepps.h | 4 cpukit/score/src/kern_tc.c | 7 +++ 2 files changed, 11 insertions(+) diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h

Re: AW: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

On 07/04/2022 11:56, gabriel.moy...@dlr.de wrote: On 07/04/2022 10:36, Gabriel Moyano wrote: diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h index 5703381ffa..a72579d5d7 100644 --- a/cpukit/include/sys/timepps.h +++ b/cpukit/include/sys/timepps.h @@ -149,6 +149,12 @@

STM32H7 BSP tree refactoring proposal.

Hello Sebastian, I'd like to propose following STM32H7 BSP tree refactoring: - move BSP's board dependent bits into boards//name> directory - get rid of very complex (merged for 3 boards already) start/system_stm32h7xx.c file - get rid of start/ext-mem-ctl.c file (as this is split off of

AW: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

> On 07/04/2022 10:36, Gabriel Moyano wrote: > > --- > > spec/build/cpukit/cpuopts.yml| 2 ++ > > spec/build/cpukit/optppssync.yml | 16 > > 2 files changed, 18 insertions(+) > > create mode 100644 spec/build/cpukit/optppssync.yml > > > > diff --git

AW: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

> On 07/04/2022 10:36, Gabriel Moyano wrote: > > +#else /* __rtems__ */ > > +if (pps->wait_event != NULL) > > +err = (*pps->wait_event)(pps, fapi->timeout); > > +else > > +err = EAGAIN; > > +#endif /* __rtems__ */ > > if

AW: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

> On 07/04/2022 10:36, Gabriel Moyano wrote: > > --- > > cpukit/score/src/kern_ntptime.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/cpukit/score/src/kern_ntptime.c > > b/cpukit/score/src/kern_ntptime.c index d4a233f67e..d6ea739f5b 100644 > > ---

AW: [PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

> On 07/04/2022 10:36, Gabriel Moyano wrote: > > --- > > cpukit/score/src/kern_tc.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c > > index a5c7b4b841..a8ba268ea3 100644 > > --- a/cpukit/score/src/kern_tc.c > > +++

AW: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

> On 07/04/2022 10:36, Gabriel Moyano wrote: > > diff --git a/cpukit/include/sys/timepps.h > > b/cpukit/include/sys/timepps.h index 5703381ffa..a72579d5d7 100644 > > --- a/cpukit/include/sys/timepps.h > > +++ b/cpukit/include/sys/timepps.h > > @@ -149,6 +149,12 @@ struct mtx; > > > > #define

AW: [PATCH 05/12] kern_tc.c: Replace atomic functions required by PPS API

> On 07/04/2022 10:36, Gabriel Moyano wrote: > > --- > > cpukit/include/sys/timepps.h | 4 > > cpukit/score/src/kern_tc.c | 7 +++ > > 2 files changed, 11 insertions(+) > > > > diff --git a/cpukit/include/sys/timepps.h > > b/cpukit/include/sys/timepps.h index 621afb08ec..5703381ffa

Re: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

On 07/04/2022 10:36, Gabriel Moyano wrote: +#else /* __rtems__ */ +if (pps->wait_event != NULL) +err = (*pps->wait_event)(pps, fapi->timeout); +else +err = EAGAIN; +#endif /* __rtems__ */ if (err == EWOULDBLOCK) {

Re: [PATCH] imfs: Fix index underrun when extending empty file

Am 04.04.22 um 16:41 schrieb Christian MAUDERER: Am 04.04.22 um 16:40 schrieb Joel Sherrill: On Mon, Apr 4, 2022, 9:28 AM Christian MAUDERER > wrote:     Please note: I would like to apply this to the 5 branch too. I     created a     ticket

Re: [PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

On 07/04/2022 10:36, Gabriel Moyano wrote: --- spec/build/cpukit/cpuopts.yml| 2 ++ spec/build/cpukit/optppssync.yml | 16 2 files changed, 18 insertions(+) create mode 100644 spec/build/cpukit/optppssync.yml diff --git a/spec/build/cpukit/cpuopts.yml

Re: [PATCH 11/12] kern_ntptime: Add define in order to remove warning

On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_ntptime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/score/src/kern_ntptime.c b/cpukit/score/src/kern_ntptime.c index d4a233f67e..d6ea739f5b 100644 --- a/cpukit/score/src/kern_ntptime.c +++

Re: [PATCH 09/12] kern_tc.c: Add definitions required by PPS API

On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_tc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index dd718b3bab..5db924cebe 100644 --- a/cpukit/score/src/kern_tc.c +++ b/cpukit/score/src/kern_tc.c @@

Re: [PATCH 08/12] kern_tc.c: Add definition of tc_getfrequency in kern_tc

On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index a8ba268ea3..dd718b3bab 100644 --- a/cpukit/score/src/kern_tc.c +++

Re: [PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/score/src/kern_tc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index a5c7b4b841..a8ba268ea3 100644 --- a/cpukit/score/src/kern_tc.c +++ b/cpukit/score/src/kern_tc.c @@

Re: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

On 07/04/2022 10:36, Gabriel Moyano wrote: diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h index 5703381ffa..a72579d5d7 100644 --- a/cpukit/include/sys/timepps.h +++ b/cpukit/include/sys/timepps.h @@ -149,6 +149,12 @@ struct mtx; #define PPSFLAG_MTX_SPIN 0x01 /*

Re: [PATCH 05/12] kern_tc.c: Replace atomic functions required by PPS API

On 07/04/2022 10:36, Gabriel Moyano wrote: --- cpukit/include/sys/timepps.h | 4 cpukit/score/src/kern_tc.c | 7 +++ 2 files changed, 11 insertions(+) diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h index 621afb08ec..5703381ffa 100644 ---

[PATCH 12/12] spec/build/cpukit: Add option for enabling PPS synchronization

--- spec/build/cpukit/cpuopts.yml| 2 ++ spec/build/cpukit/optppssync.yml | 16 2 files changed, 18 insertions(+) create mode 100644 spec/build/cpukit/optppssync.yml diff --git a/spec/build/cpukit/cpuopts.yml b/spec/build/cpukit/cpuopts.yml index 301d49ccea..db0e05395f

[PATCH 11/12] kern_ntptime: Add define in order to remove warning

--- cpukit/score/src/kern_ntptime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/score/src/kern_ntptime.c b/cpukit/score/src/kern_ntptime.c index d4a233f67e..d6ea739f5b 100644 --- a/cpukit/score/src/kern_ntptime.c +++ b/cpukit/score/src/kern_ntptime.c @@ -58,6 +58,9 @@

[PATCH 10/12] kern_tc.c: Enable PPS API support

--- cpukit/score/src/kern_tc.c | 4 1 file changed, 4 deletions(-) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index 5db924cebe..c94e85f85b 100644 --- a/cpukit/score/src/kern_tc.c +++ b/cpukit/score/src/kern_tc.c @@ -1896,7 +1896,6 @@ SYSCTL_PROC(_kern_timecounter,

[PATCH 09/12] kern_tc.c: Add definitions required by PPS API

--- cpukit/score/src/kern_tc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index dd718b3bab..5db924cebe 100644 --- a/cpukit/score/src/kern_tc.c +++ b/cpukit/score/src/kern_tc.c @@ -56,6 +56,11 @@ #definetimecounter

[PATCH 08/12] kern_tc.c: Add definition of tc_getfrequency in kern_tc

--- cpukit/score/src/kern_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index a8ba268ea3..dd718b3bab 100644 --- a/cpukit/score/src/kern_tc.c +++ b/cpukit/score/src/kern_tc.c @@ -1506,7 +1506,6 @@ unlock: #endif /*

[PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

--- cpukit/include/sys/timepps.h | 11 +++ cpukit/score/src/kern_tc.c | 20 +++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h index 5703381ffa..a72579d5d7 100644 ---

[PATCH 07/12] kern_tc.c: Remove verification of th_generation for pps functions

--- cpukit/score/src/kern_tc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c index a5c7b4b841..a8ba268ea3 100644 --- a/cpukit/score/src/kern_tc.c +++ b/cpukit/score/src/kern_tc.c @@ -2109,9 +2109,11 @@ pps_capture(struct

[PATCH 05/12] kern_tc.c: Replace atomic functions required by PPS API

--- cpukit/include/sys/timepps.h | 4 cpukit/score/src/kern_tc.c | 7 +++ 2 files changed, 11 insertions(+) diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h index 621afb08ec..5703381ffa 100644 --- a/cpukit/include/sys/timepps.h +++

[PATCH 04/12] timepps: Add missing include for atomic type

--- cpukit/include/sys/timepps.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/include/sys/timepps.h b/cpukit/include/sys/timepps.h index 01212f0b43..621afb08ec 100644 --- a/cpukit/include/sys/timepps.h +++ b/cpukit/include/sys/timepps.h @@ -24,6 +24,9 @@ #include #include

[PATCH 03/12] kern_ntptime.c: Add lmax() qmin() definitions

--- cpukit/score/src/kern_ntptime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/score/src/kern_ntptime.c b/cpukit/score/src/kern_ntptime.c index 3bbb3290f9..d4a233f67e 100644 --- a/cpukit/score/src/kern_ntptime.c +++ b/cpukit/score/src/kern_ntptime.c @@ -71,6 +71,8 @@

[PATCH 02/12] kern_ntptime.c: Enable status variables when PPS_SYNC is defined

--- cpukit/score/src/kern_ntptime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/score/src/kern_ntptime.c b/cpukit/score/src/kern_ntptime.c index 610386833c..3bbb3290f9 100644 --- a/cpukit/score/src/kern_ntptime.c +++ b/cpukit/score/src/kern_ntptime.c @@ -534,6 +534,7 @@

[PATCH 00/12] Enable PPS API in RTEMS6

Ticket #2349 These commits enable the PPS API support in the master branch. Two pointers to function were added in struct pps_state to replace dependencies which are in rtems-libbsd (as was discussed in the mailing list, see "Dependencies of PPS API in rtems-libsd"). For enabling the

[PATCH 01/12] kern_ntptime.c: Disable freebsd features

--- cpukit/score/src/kern_ntptime.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/score/src/kern_ntptime.c b/cpukit/score/src/kern_ntptime.c index cb39133408..610386833c 100644 --- a/cpukit/score/src/kern_ntptime.c +++ b/cpukit/score/src/kern_ntptime.c @@ -73,9

Re: [PATCH] bsp/stm32h7: update FMC configuration for SRAM and SDRAM usage

On 06/04/2022 14:21, Karel Gardas wrote: let me explain more motivation behind this patch. I'm working on stm32h757i-eval bsp variant and while looking into FMC support while using STM32CubeIDE I've noticed that actual changes between system_stm32h7xx.c files generated for H743i-eval and