Re: [PATCH 5/6] i386/pc386/include: header files for VESA BIOS EXTENSIONS and VESA Extended Display Identification Data

2014-11-13 Thread Gedare Bloom
On Thu, Nov 13, 2014 at 6:45 PM, Pavel Pisa wrote: > Hello Gedare, > > the first thanks much for fast and valuable review. > I expect that Jan Dolezal prepares new patch series > next week (or two in the worst case). > > On Wednesday 12 of November 2014 17:04:04 Gedare Bloom wrote: >> Just a coupl

Re: [PATCH 5/6] i386/pc386/include: header files for VESA BIOS EXTENSIONS and VESA Extended Display Identification Data

2014-11-13 Thread Pavel Pisa
Hello Gedare, the first thanks much for fast and valuable review. I expect that Jan Dolezal prepares new patch series next week (or two in the worst case). On Wednesday 12 of November 2014 17:04:04 Gedare Bloom wrote: > Just a couple high-level comments: > > Is this code entirely written by you?

Re: [PATCH 5/6] i386/pc386/include: header files for VESA BIOS EXTENSIONS and VESA Extended Display Identification Data

2014-11-12 Thread Gedare Bloom
Just a couple high-level comments: Is this code entirely written by you? If the code is i386-specific, I'd like to see it put into i386 namespace. The use of bitfields worries me, especially if the code might be ported to other architectures. I can see now why you put __packed__ on all your stru

[PATCH 5/6] i386/pc386/include: header files for VESA BIOS EXTENSIONS and VESA Extended Display Identification Data

2014-11-12 Thread Jan Dolezal
--- c/src/lib/libbsp/i386/pc386/Makefile.am| 2 + c/src/lib/libbsp/i386/pc386/include/edid.h | 759 + c/src/lib/libbsp/i386/pc386/include/vbe3.h | 461 ++ c/src/lib/libbsp/i386/pc386/preinstall.am | 8 + 4 files changed, 1230 insertions(+) crea