[edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: SNP Statistics may be unsupported

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2160 If EFI_SIMPLE_NETWORK.Statistics() is not supported, it will return EFI_UNSUPPORTED. In this case do not expect input parameters to be checked for conformance. If an error in SnpInterface->Start() occurs we error out. Therefore create

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for IgnoreAutoGen

Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Thursday, September 05, 2019 10:06 PM >To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming > >Cc: Shi, Steven >Subject: RE: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for >IgnoreAutoGen > >Sorry for the incomplete mail. > >I

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

Add prefix in subject. Cc: Supreeth Venkatesh -Original Message- From: Chen, ArvinX Sent: Monday, September 9, 2019 2:29 PM To: devel@edk2.groups.io Cc: Jin, Eric ; Chen, ArvinX Subject: [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest". REF:

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug for Hii Pcd override

Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Thursday, September 05, 2019 5:45 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch 1/1] BaseTools: Fix a bug for Hii Pcd override > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2157

Re: [edk2-devel] [PATCH v6 0/4] Add SCSI Support for Storage Security Command Protocol

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Saturday, September 07, 2019 6:12 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A > Subject: [edk2-devel]

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for IgnoreAutoGen

Sorry, should be Acked-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Monday, September 09, 2019 2:59 PM >To: Feng, Bob C ; devel@edk2.groups.io >Cc: Shi, Steven >Subject: Re: [edk2-devel] [Patch 1/1]

Re: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

Bob: What case will call GenSec without the exist file? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Friday, September 06, 2019 9:23 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject:

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add STATIC_ASSERT macro

Vitaly: I see https://edk2.groups.io/g/devel/message/45743 and https://edk2.groups.io/g/devel/message/45691 gives RB. If no other comments, I will push this change this week. Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io

Re: [edk2-devel] [Patch 1/1] BaseTools: Sort Pcd settings to make PcdTokenNumber be fixed

Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Wednesday, September 04, 2019 3:54 PM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >; Shi, Steven >Subject: [edk2-devel] [Patch 1/1] BaseTools:

Re: [edk2-devel] [External] Re: [edk2-platforms: PATCH 1/1] DisplayLinkPkg: DisplayLinkGop: Added GOP driver for USB docking stations based on DisplayLink chips

Hi Andy, If no one has commented by now, I'd say we're good to go. Pushed as 9df63499ea01. Many thanks for your contribution. Best Regards, Leif On Mon, Sep 09, 2019 at 08:06:48AM +, Andy Hayes wrote: > Hi, > > Is it OK to commit this now? Does anyone else have any comments on it? > >

[edk2-devel] [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155 Now the test item "EFICompliantTest" will be gen in the XXX.csv. However, I find most of the SCT user will not know what platform config they test is, so I think we can independently generate a file of the "EFICompliantTest" tests, then

[edk2-devel] [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155 Now the test item "EFICompliantTest" will be gen in the XXX.csv. However, I find most of the SCT user will not know what platform config they test is, so I think we can independently generate a file of the "EFICompliantTest" tests, then

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 11/22]: BaseTools: BaseTools changes for RISC-V platform.

Hi Abner, Having actually tried to build things, I have come across a bunch of issues with this patch I missed on my (very cursory) ocular review. On Wed, Sep 04, 2019 at 06:43:06PM +0800, Abner Chang wrote: > BaseTools changes for building EDK2 RISC-V platform. > The changes made to

Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

On 09/06/19 14:26, Leif Lindholm wrote: > On Thu, Sep 05, 2019 at 08:38:17PM +0200, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2-CCodingStandardsSpecification.git >> Branch: spurious_assign_bz_607 >> >> HTML-rendered views of the modified pages: >> - >>

Re: [edk2-devel] [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments

On 09/06/19 10:13, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > (Cc'ing Ard) > > On 9/5/19 8:38 PM, Laszlo Ersek wrote: >> Problem statement from Ard: >> >>> Sometimes, the GCC compiler warns about variables potentially being used >>> without having been initialized, while visual inspection

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: buffer overflow in NotifyFunctionTplEx()

Heinrich, Good catch. How about to check the notify order before the operation to close all the events created and Free the pages ? It doesn't impact the result because the patch already enhances the index check against the buffer limits. But it will ensure correct execution sequence in the

Re: [edk2-devel] [patch 2/3] MdeModulePkg: Unload image on EFI_SECURITY_VIOLATION

Hi Ray, Background: This patch series is to review the callers of LoadImage() in edk2, if the LoadImage() with EFI_SECURITY_VIOLATION returned and caller doesn't have the attempt to defer the execution of an image, we should treat EFI_SECURITY_VIOLATION as other normal errors, but we should do

[edk2-devel] [PATCH] Add VS2019 Toolchain def

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template Change-Id: Id52abdc9762cf06bb9a38bbfd1153608c878d839 Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao Signed-off-by: Ching JenX Cheng ---

Re: [edk2-devel] [PATCH v6 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

Hello, One inline comment below: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Saturday, September 07, 2019 6:12 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen; Wang, Jian J; Gao, Liming > Subject:

Re: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

For the case that the Non-Hii Driver does not generate .offset file for uni string offset. -Original Message- From: Gao, Liming Sent: Monday, September 9, 2019 3:46 PM To: devel@edk2.groups.io; Feng, Bob C Subject: RE: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux

Re: [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

Hi Igor, On 09/05/19 17:49, Igor Mammedov wrote: > lpc already has SMI negotiation feature, extend it by adding > optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. > > Writing this bit into "etc/smi/requested-features" fw_cfg file, > tells QEMU to alias 0x3,128K RAM range into

[edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150 V2 changes: Add xchg 16 bit instructions to handle sgdt and sidt base 63:48 bits and 47:32 bits. Add comment to explain why xchg 64bit isnt being used Fix #AC split lock's caused by seperating base and limit from sgdt and sidt by changing

Re: [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

I completely understand the need for granular breakup of changes for code review and future maintenance. I would not send this as a single patch on the mailing list for formal code review. Due to the size of the change, the main point here was to initially focus feedback on the high-level

[edk2-devel] [Patch] SecurityPkg Tcg2Config: Move common definitions to new Tcg2Internal.h

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2178 Common definitions are not consumed by VFR. They are not required to be defined in Tcg2ConfigNvData.h with WA way. New shared internal header file is added to include those common definitions. Cc: Jian Wang Cc: Chao Zhang Signed-off-by:

Re: [edk2-devel] [PATCH] ArmVirtPkg: increase FD/FV size for NOOPT builds

On 09/07/19 00:20, Ard Biesheuvel wrote: > After upgrading the CI system we use for building the ArmVirtPkg > targets, we started seeing failures due to the NOOPT build running > out of space when using the CLANG38 toolchain definition combined > with clang 7. > > We really don't want to increase

Re: [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

On 09/05/19 21:54, Kubacki, Michael A wrote: > Proof-of-Concept Implementation > -- > The implementation is available in the following commit - check the commit > message for some more details. >

Re: [edk2-devel] [PATCH] ArmVirtPkg: increase FD/FV size for NOOPT builds

Hi Ard, On 9/7/19 12:20 AM, Ard Biesheuvel wrote: > After upgrading the CI system we use for building the ArmVirtPkg > targets, we started seeing failures due to the NOOPT build running > out of space when using the CLANG38 toolchain definition combined > with clang 7. > > We really don't want

Re: [edk2-devel] [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments

On 9/9/19 2:25 PM, Laszlo Ersek wrote: > On 09/06/19 10:13, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> (Cc'ing Ard) >> >> On 9/5/19 8:38 PM, Laszlo Ersek wrote: >>> Problem statement from Ard: >>> Sometimes, the GCC compiler warns about variables potentially being used without

Re: [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

On 09/09/19 21:15, Laszlo Ersek wrote: > ... I've done some testing too. Applying the QEMU patch on top of > 89ea03a7dc83, my plan was: > > - do not change OVMF, just see if it continues booting with the QEMU > patch > > - then negotiate bit#1 too, in step (1a) -- this is when I'd expect (3a) >

Re: [edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

Hi Bob, Steven, Thank you for update. Yes, it fails with “build clean”. Example: . ./edksetup.sh build -a AARCH64 -p BroadcomPlatformPkg/StingrayPkg/StingrayPkg.dsc -t GCC5 -b RELEASE -D PLAT=Stingray -D TARGET=RELEASE -D EDK2_STAMP="dev/bcm958742k 59b754c9f697" cleanall Bob, with your

[edk2-devel] [edk2-platforms: PATCH 2/2] Marvell/Drivers: MvSpiFlashDxe: Implement progress bar

This patch implements TFTP-like progress bar in MvSpiFlashUpdateWithProgress. This is necessary because CapsuleRuntimeDxe uses DxeRuntimeCapsuleLib which uses CapsuleProcessLibNull implementation of capsule process. Signed-off-by: Patryk Duda ---

[edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev

This patch fixes missing MdioIndex copying during initialization. This bug appeared as inability to communicate with PHY connected to MDIO other than first. Signed-off-by: Patryk Duda --- Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[edk2-devel] [edk2-platforms: PATCH 1/2] Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining

This commit fixes bug which was causing one sector of bytes to be ommited. It was discovered when bytes to be written was 0 in last block, but total count of bytes was multiplication of sector size. It turned out that in every case one sector of data was missing. This bug can be fixed in various

[edk2-devel] [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements

Hi, This patchset contains progress bar implementation for MvSpiFlash driver and small fix in calculating number of sectors to write. Progress bar implementation was mostly borrowed from TFTP module. During implementation it turned out that when size is multiplication of sector size, then last

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add STATIC_ASSERT macro

Liming, sounds great, thank you. > 9 сент. 2019 г., в 10:57, Gao, Liming написал(а): > > Vitaly: > I see https://edk2.groups.io/g/devel/message/45743 > and > https://edk2.groups.io/g/devel/message/45691 >

[edk2-devel] [edk2-platforms] [PATCH 2/3] SimicsOpenBoardPkg: Fix GCC build issues

Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../PlatformBootManagerLib/BdsPlatform.c | 38 --- .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 --- 2 files

[edk2-devel] [edk2-platforms] [PATCH 3/3] SimicsIch10Pkg: Fix GCC build issues

Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../LibraryPrivate/BasePchSpiCommonLib/SpiCommon.c | 3 --- .../SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c | 7 ++- 2 files

[edk2-devel] [edk2-platforms] [PATCH 1/3] AdvancedFeaturePkg: Fix GCC build

Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build

This patch series fix gcc build issues seen in SimicsOpenBoardPkg. Patches were tested on GCC 5 Prince Agyeman (3): AdvancedFeaturePkg: Fix GCC build SimicsOpenBoardPkg: Fix GCC build issues SimicsIch10Pkg: Fix GCC build issues .../Smbios/SmbiosBasicDxe/SmbiosBasic.h | 2 +-

Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: SNP Statistics may be unsupported

Reviewed-by: Eric Jin -Original Message- From: Heinrich Schuchardt Sent: Monday, September 9, 2019 5:32 PM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuchardt Subject: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: SNP Statistics may be

Re: [edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

Hi Vladimir, Below is an example to do clean build with the cache. The build cache is enabled through --hash --binary-destination and --binary-source options. · Produce the build cache to a folder (e.g. BinCache): $ build -p OvmfPkg/OvmfPkgIa32.dsc -a IA32 -t GCC5 -b DEBUG --hash

Re: [edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

Pushed at 53e2eaba7a19cda3183b1bb2a2619a2494538e52 Thanks, Bob From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com] Sent: Tuesday, September 10, 2019 4:15 AM To: Feng, Bob C ; Shi, Steven ; devel@edk2.groups.io Cc: Gao, Liming ; Rodriguez, Christian ; Johnson, Michael

Re: [edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces

Hi, Thanks for the contribution. I have two minor comments: 1. The subject seems make people a little confused, how about update it to something like" MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec" to make the patch clear? 2. How about update the function comments of