Re: [edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support

2019-09-20 Thread Lendacky, Thomas
On 9/19/19 2:52 PM, Lendacky, Thomas wrote: > From: Tom Lendacky > > This patch series provides support for running EDK2/OVMF under SEV-ES. I wanted to provide the full series so that everyone can see what is involved with the support. Providing multiple, smaller series of patches might be

[edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 * Adds files required to build the GalagoPro3 board to the board directory. * Updates KabylakeOpenBoardPkg/OpenBoardPkg.dec to reference the new GalagoPro3 board directory. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc:

[edk2-devel] [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 The N1xxWU board contents will be moved to KabylakeOpenBoardPkg to reduce code duplication between ClevoOpenBoardPkg and KabylakeOpenBoardPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael

[edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 Adds the modules used for System 76 Galago Pro 3 board support. This override should be removed in a future cleanup change. That is outside the scope of this change which is to move the contents from ClevoOpenBoardPkg/N1xxWU to

[edk2-devel] [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 The flash map currently in KabylakeOpenBoardPkg is only applicable to the KabylakeRvp3 board. This change moves the flash map to that board directory to prepare for other boards to reside in the package. Cc: Chasel Chiu Cc: Nate DeSimone

[edk2-devel] [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h to KabylakeRvp3 board

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 EC command details may vary across Kaby Lake boards. This change moves this set of EC commands to the KabylakeRvp3 directory since these commands are specifically used by that board at this time. Cc: Chasel Chiu Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms][PATCH V1 00/12] Move ClevoOpenBoardPkg/N1xxWU Contents to KabylakeOpenBoardPkg

2019-09-20 Thread Kubacki, Michael A
This patch series moves the N1xxWU board contents currently in ClevoOpenBoardPkg to KabylakeOpenBoardPkg. The actual systems being tested are System 76 Galago Pro laptops so the board itself is renamed from "N1xxWU" to"GalagoPro3". The system models supported are the galp2 (Kaby Lake) and galp3

[edk2-devel] [edk2-platforms][PATCH V1 03/12] ClevoOpenBoardPkg: Remove global files and references

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 Remove references to ClevoOpenBoardPkg external to the package since the package is now removed. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Maintainers.txt | 5

[edk2-devel] [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 PeiSerialPortLibSpiFlash is currently used for early boot closed chassis debug on production systems such as the System 76 Galago Pro laptop. This change moves the library to KabylakeOpenBoardPkg from ClevoOpenBoardPkg since the Clevo

[edk2-devel] [edk2-platforms][PATCH V1 04/12] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 To prepare KabylakeOpenBoardPkg for multi-board support, the policy update libraries should be moved to the individual board directory. Prevously KabylakeOpenBoardPkg only supported the KabylakeRvp3 board and the policy update libraries were

Re: [edk2-devel] [edk2-non-osi][PATCH V1 1/1] edk2-non-osi: Rename ClevoOpenBoardBinPkg to KabylakeOpenBoardBinPkg

2019-09-20 Thread Sinha, Ankit
Reviewed-by: Ankit Sinha -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-non-osi][PATCH V1 1/1] edk2-non-osi: Rename ClevoOpenBoardBinPkg to

[edk2-devel] [edk2-non-osi][PATCH V1 1/1] edk2-non-osi: Rename ClevoOpenBoardBinPkg to KabylakeOpenBoardBinPkg

2019-09-20 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 * Renames the package to align with removal of ClevoOpenBoardPkg. * Updates the KabylakeOpenBoardBinPkg maintainer list. Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Maintainers.txt

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-20 Thread Sean via Groups.Io
Currently it is building on Windows with VS2019. VS2017 would be trivial but not worth it in my perspective given how aligned the two are. If you really wanted to do a weekly or nightly build it could be added to that but I have been focused on a PR build. I have a pipeline for GCC on linux.

[edk2-devel] [edk2/master PATCHv1 1/1] OvmfPkg: Make SOURCE_DEBUG_ENABLE actually need to be set to TRUE

2019-09-20 Thread Peter Jones
Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some tests check if it's defined or not. Additionally, in UefiPayloadPkg as well as some other trees, we define it as FALSE in the .dsc file. This patch changes all of the Ovmf platforms to explicitly define it as FALSE by default,

Re: [edk2-devel] [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess

2019-09-20 Thread Ni, Ray
Thanks for reminding. I will do that. > On Sep 20, 2019, at 1:44 AM, Laszlo Ersek wrote: > > Hi Ray, > >> On 08/26/19 00:45, Ni, Ray wrote: >> NOTE: #5/5 will be pushed in 2nd phase after known close-source code in >> another >> repo is updated to use the new PCD

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ

2019-09-20 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, September 18, 2019 8:08 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace

2019-09-20 Thread Leif Lindholm
On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote: > On 09/19/19 20:06, Leif Lindholm wrote: > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Anthony Perard > > Cc: Julien Grall > > Cc: David Woodhouse > > Signed-off-by: Leif Lindholm > > --- > >

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: use EFI_UNICODE_COLLATION_PROTOCOL2_GUID

2019-09-20 Thread Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1802 The protocol identified by EFI_UNICODE_COLLATION_PROTOCOL_GUID is deprecated. Use the protocol identified by EFI_UNICODE_COLLATION_PROTOCOL2_GUID instead. Both protocols only differ in the values for the SupportedLanguages field.

Re: [edk2-devel] [Patch V3] UefiCpuPkg/CpuExceptionHandlerLib: Fix split lock

2019-09-20 Thread Dong, Eric
Reviewed-by: Eric Dong And pushed: SHA-1: f4c898f2b2db2819c519cdce05403d4ba0234979 Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of John > E Lofgren > Sent: Wednesday, September 18, 2019 11:43 PM > To: devel@edk2.groups.io >

[edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

2019-09-20 Thread Lin, Derek (HPS SW)
Hi BaseTools experts, We saw the clean build performance improvement after updating from edk2-stable201905 to edk2-stable201908, which is promising. But we found the incremental build time increase 25%~35%, which is not good. We're building server platform. And we use --hash to speed up

[edk2-devel] [Patch] Revert "BaseTools: Improve GetDependencyList function"

2019-09-20 Thread Liming Gao
This reverts commit bc9e4194cf3edaf9524c83098ba3f72008c70190. This change causes the dependent header files are missing in Makefile. It makes the incremental build not work. So, revert this change. Cc: Bob Feng Signed-off-by: Liming Gao --- BaseTools/Source/Python/AutoGen/GenMake.py | 29

Re: [edk2-devel] [PATCH v4] BaseTools/LzmaCompress: Add two switches

2019-09-20 Thread Liming Gao
This version is good. Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Friday, September 20, 2019 10:29 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Feng, Bob C > ; Gao, Liming > Subject: [PATCH v4] BaseTools/LzmaCompress: Add two switches > >

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace

2019-09-20 Thread Laszlo Ersek
On 09/19/19 20:06, Leif Lindholm wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Cc: David Woodhouse > Signed-off-by: Leif Lindholm > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- >

Re: [edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg

2019-09-20 Thread Gao, Zhichao
Hi, Jaben would be busy with other work. The patch is pending for a long time. Is there any comment of this? It may be required to get the comments from the stewards. Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Thursday, August 22, 2019 4:56

Re: [edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg

2019-09-20 Thread Liming Gao
I just push @d7bf973e43ad949706f936f61cd6be8e63ce136f > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Friday, September 20, 2019 2:11 PM > To: Ni, Ray ; Carsey, Jaben ; > devel@edk2.groups.io > Cc: Kinney, Michael D ;

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-20 Thread Igor Mammedov
On Thu, 19 Sep 2019 19:02:07 +0200 "Laszlo Ersek" wrote: > Hi Igor, > > (+Brijesh) > > long-ish pondering ahead, with a question at the end. [...] > Finally: can you please remind me why we lock down 128KB (32 pages) at > 0x3_, and not just half of that? What do we need the range at >

Re: [edk2-devel] [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess

2019-09-20 Thread Laszlo Ersek
Hi Ray, On 08/26/19 00:45, Ni, Ray wrote: > NOTE: #5/5 will be pushed in 2nd phase after known close-source code in > another > repo is updated to use the new PCD PcdCpuSmmRestrictedMemoryAccess. you've now pushed patch 5/5 as commit 136dad095660, but you forgot to update the UNI file, which is

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-20 Thread Laszlo Ersek
On 09/20/19 10:28, Igor Mammedov wrote: > On Thu, 19 Sep 2019 19:02:07 +0200 > "Laszlo Ersek" wrote: > >> Hi Igor, >> >> (+Brijesh) >> >> long-ish pondering ahead, with a question at the end. > [...] > >> Finally: can you please remind me why we lock down 128KB (32 pages) at >> 0x3_, and

Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of > "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". > > This is an actual bug. The reason it's never been triggered is likely that > the

Re: [edk2-devel] [PATCH v2 0/9] Various line ending and encoding fixes

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/19/19 6:03 PM, Leif Lindholm wrote: > I have started looking into doing the CRLF->native conversion for EDK2, > and as part of my initial scan, I found a bunch of trivial issues that > would be easier to just fix beforehand. > > Mike asked me to also do a trainling whitespace cleanup, and

Re: [edk2-devel] [PATCH 24/35] OvmfPkg/PlatformDxe: fix EFI_HII_HANDLE parameters of internal functions

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > In the following call tree: > > PlatformInit () >mInstalledPackages = HiiAddPackages () > GopInstalled () > PopulateForm (PackageList = mInstalledPackages) > CreateResolutionOptions (PackageList) > HiiSetString (PackageList >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package.

2019-09-20 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 07:10:16AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > -Original Message- > > > > I personally think we need a longer-term encapsulation of libfdt > > > > that doesn't mess up the coding style. But until then, I would be > > > > much happier if you used

[edk2-devel] [RFC PATCH v2 42/44] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

2019-09-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Before UEFI transfers control to the OS, it must park the AP. This is done using the AsmRelocateApLoop function to transition into 32-bit non-paging mode. For an SEV-ES guest, a few additional things must be done: -

[edk2-devel] [RFC PATCH v2 39/44] OvmfPkg: Move the GHCB allocations into reserved memory

2019-09-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 After having transitioned from UEFI to the OS, the OS will need to boot the APs. For an SEV-ES guest, the APs will have been parked by UEFI using GHCB pages allocated by UEFI. The hypervisor will write to the GHCB

[edk2-devel] [RFC PATCH v2 43/44] UefiCpuPkg/CpuDxe: Provide an DXE MP finalization routine to support SEV-ES

2019-09-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Provide support for the MP finalization routine within DXE. This finalization function will invoke the MpInitLib MpLibFinalize() function to perform the steps necessary to park an AP and be able to successfully boot it

[edk2-devel] [RFC PATCH v2 41/44] UefiCpuPkg/MpInitLib: Add MP finalization interface to MpInitLib

2019-09-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Provide an MP finalization function that can be called from the CPU protocol finalization function. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- UefiCpuPkg/Include/Library/MpInitLib.h

[edk2-devel] [RFC PATCH v2 44/44] MdeModulePkg/DxeCore: Perform the CPU protocol finalization support

2019-09-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Invoke the CPU finalization function when exiting boot services. This allows for DXE and the MP Library to properly setup and park APs for an SEV-ES guest so that it can be booted in the OS. Cc: Jian J Wang Cc: Hao A

Re: [edk2-devel] [PATCH 05/35] EmulatorPkg/DxeTimerLib: drop superfluous cast

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > "gTimerEvent" has type EFI_EVENT already, drop the superfluous cast. > > Cc: Andrew Fish > Cc: Jordan Justen > Cc: Ray Ni > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c | 2