Re: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

Hi Ray， It fails to build with GCC in ubuntu if removing the prefix from all paths insideDSC/FDF/INF. No problem in windows Active Platform = /home/ilabuser/code/hengluo/edk2-platforms/Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc build.py... /home/ilabuser/code/heng

Re: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

What is PACKAGES_PATH env variable set to? > -Original Message- > From: Luo, Heng > Sent: Wednesday, March 25, 2020 3:01 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric > Subject: RE: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to >

Re: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

Hi Ray, Pass build with GCC in ubuntu after adding "~/code/edk2-platforms/Features/Intel/UserInterface" in PACKAGES_PATH. Best Regards Heng > -Original Message- > From: Ni, Ray > Sent: Wednesday, March 25, 2020 3:17 PM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Limin

[edk2-devel] [Patch V3] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2584 1. LogoDxe.inf includes a BMP logo in the EFI file, the driver decodes the BMP file and provide the image via EDKII_PLATFORM_LOGO_PROTOCOL. 2. JpegLogoDxe.inf includes a JPEG logo in the EFI file, the driver use EFI_HII_IMAGE_DECODER_PROTOCO

Re: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

Thanks for confirming that works. > -Original Message- > From: Luo, Heng > Sent: Wednesday, March 25, 2020 3:53 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric > Subject: RE: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to > provide l

[edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: add dummy assignment to work around GCC

GCC 4.8 or 4.9 may throw the following error when building OVMF: Edk2/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c: In function ‘QemuLoadKernelImage’: Edk2/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c:416:30: error: ‘CommandLine’ may be used uninitialized

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

On Wed, 25 Mar 2020 at 03:04, Samer El-Haj-Mahmoud wrote: > > Thanks Laszlo, > > I will wait for the maintainers to accept the patch, then submit an amended > version for ArmVirtQemu. > For this patch Reviewed-by: Ard Biesheuvel For any patch that removes this PCD override from AArch64 platfo

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

(+ Pete) Could you please keep Pete on cc for RPi patches? On Tue, 24 Mar 2020 at 23:02, Samer El-Haj-Mahmoud wrote: > > Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). Both > work pretty well (tested IPv4 and IPv6). > Excellent, thanks. Reviewed-by: Ard Biesheuvel

[edk2-devel] [PATCH] ArmVirtPkg/PlatformPeiLib: add dummy assignment to work around older GCC

Older GCC (<= 4.9) fail to infer that Parent is never used unless it has been assigned before, and may throw an error like /work/git/edk2/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c: In function ‘PlatformPeim’: /work/git/edk2/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c:132:

Re: [edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings

On Mon, 9 Mar 2020 at 15:21, Pete Batard wrote: > > This addresses the following warnings, that are generated during > compilation of the RPi firmware: > Thanks Pete Reviewed-by: Ard Biesheuvel Pushed as 3daa70143953..79c06cfaeaee > ---

[edk2-devel] [PATCH v1 2/3] ShellPkg: acpiview: Add library for SBBR ACPI requirements validation

For Arm-based platforms, define and implement an interface for Server Base Boot Requirements (SBBR) compliance checks. The library is responsible for validating that all mandatory ACPI tables are installed on the platform. Internally, the library maintains a data structure which tracks instance co

[edk2-devel] [PATCH v1 1/3] ShellPkg: acpiview: Add -r parameter for table requirements validation

Define a new command line parameter '-r' to enable checking if all mandatory ACPI tables listed in a specification are present. The -r parameter takes an integer value to specify which specification the validation should be performed against. The parameter is used to set two Acpiview variables. A

[edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed

This patch series adds a new capability to the Acpiview UEFI shell tool. Using the -r command line parameter, it is now possible to choose a specification which lists mandatory ACPI tables. The parameter value is then consumed by a library which validates ACPI tables identified on the platform agai

[edk2-devel] [PATCH v1 3/3] ShellPkg: acpiview: Check if SBBR mandatory ACPI tables are installed

For Arm-based platforms, count the instances of installed tables for each ACPI table listed as 'mandatory' in any Server Base Boot Requirements (SBBR) specification. Validate that the all the mandatory SBBR tables present. Report an error for each missing table. This new feature is optional and c

Re: [edk2-devel] [PATCH 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

On Tue, 10 Mar 2020 at 01:29, Laszlo Ersek wrote: > > Hi Ard, > > On 03/07/20 14:34, Ard Biesheuvel wrote: > > Currently, depending on the size of the region being (re)mapped, the > > page table manipulation code may replace a table entry with a block entry, > > even if the existing table entry us

Re: [EXTERNAL] [edk2-devel] [PATCH v4 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers

Good point. I think the original design limits the usage to be variable driver. As such, the API only gets a "variable root key". A "platform root key" can derive the "variable root key" and some "other features' root key". The tricky part is to regenerate the key, when the variable is under a

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg/ArmPkg.dsc: Add missing components

On Tue, 24 Mar 2020 at 03:16, Michael Kubacki wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2574 > > The following components are currently missing from the [Components] > section of ArmPkg.dsc: > * ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf >

Re: [edk2-devel] [PATCH v1 1/1] ArmPlatformPkg/ArmPlatformPkg.dsc: Add missing components

On Tue, 24 Mar 2020 at 20:30, Michael Kubacki wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2575 > > The following components are currently missing from the [Components] > section of ArmPlatformPkg.dsc: > * ArmPlatformPkg/Library/HdLcd/HdLcd.inf > * A

Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit

On 25/03/2020 3:48, Laszlo Ersek wrote: On 03/24/20 16:35, Liran Alon wrote: On 24/03/2020 17:14, Laszlo Ersek wrote: On 03/16/20 16:01, Liran Alon wrote: I'm going to stop reviewing this iteration now; please rework the rest of the series for v2 with this resource management pattern. Thanks

[edk2-devel] [edk2-platforms][PATCH v3 3/9] Platform/ARM/SgiPkg: move common

Move common platform description entries in platfrom specific DSDT to a SSDT that can be reused on all SGI/RD platforms. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl | 70 +--- Platform/

[edk2-devel] [edk2-platforms][PATCH v3 4/9] Platform/ARM/SgiPkg: remove

The number of CPUs depend on the SGI/RD platform. So instead of defining a Fixed PCD to specify the value of core and cluster count, let each platform define these values. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc

[edk2-devel] [edk2-platforms][PATCH v3 1/9] Platform/ARM/SgiPkg: create individual

From: Vijayenthiran Subramaniam In preparation for adding support for Reference Design (RD) platforms that have different base addresses for GIC distributor or redistributor, create individual platform description files for all SGI/RD platforms and move GIC related base addresses from the common

[edk2-devel] [edk2-platforms][PATCH v3 0/8] Add platform support for RD-Daniel

This patch series adds support for Arm's RD-Daniel platform. There are two configurations of this platform being added in this series - Config-M and Config-XLR. RD-Daniel is the next Arm's reference design subsystem. The first four patches consolidate the code in SgiPkg in preparation for adding s

[edk2-devel] [edk2-platforms][PATCH v3 2/9] Platform/ARM/SgiPkg: move the GIC

Move the ACPI helper macros defines related to GIC structure, distributor, redistributor and ITS to SgiAcpiHeader.h as these are common across ARM SGI/RD platforms. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc | 68 +-

[edk2-devel] [edk2-platforms][PATCH v3 7/9] Platform/ARM/SgiPkg: add ACPI tables

RD-Daniel Config-XLR is a platform in which four identical chips are connected via a high speed CCIX link. Add Madt and Dsdt tables for the same. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgXlr/Dsdt.asl | 125 +++

[edk2-devel] [edk2-platforms][PATCH v3 9/9] Maintainers.txt: Update Arm platform

From: Thomas Abraham Update the reviewers list for Arm platforms. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Aditya Angadi --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index a19a64fc42d0..475f7d530b85 100

[edk2-devel] [edk2-platforms][PATCH v3 5/9] Platform/ARM/SgiPkg: add ACPI tables

Add Madt and Dsdt ACPI tables for RD-Daniel Config-M platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl | 118 + Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgM/Madt.aslc | 134

[edk2-devel] [edk2-platforms][PATCH v3 8/9] Platform/ARM/Sgi: add initial support

For RD-Daniel Config-XLR, use multichip mode information from the SGI platform descriptor HOB to pick the correct ACPI table to be installed. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 + Platform/ARM/Sg

[edk2-devel] [edk2-platforms][PATCH v3 6/9] Platform/ARM/Sgi: add initial support

Add information in the SGI platform descriptor HOB to pick the correct ACPI table to install for RD-Daniel Config-M Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++ Platform/ARM/SgiPkg/Drivers/PlatformDxe/Pl

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

Ray, Zhichao, On 02/27/20 12:02, Maciej Rabeda wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032 > > 'ping' command's receive flow utilizes a single Rx token which it > attempts to reuse before recycling the previously received packet. > This causes a situation where under ICMP tr

Re: [edk2-devel] [PATCH v1] NetworkPkg/Ip6Dxe: Improve Neightbor Discovery message validation (CVE-2019-14559)

Jiaxin, Siyuan, On 03/02/20 13:38, Maciej Rabeda wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2174 > > Problem has been identified with Ip6ProcessRouterAdvertise() when > Router Advertise packet contains options with malicious/invalid > 'Length' field. This can lead to platform en

[edk2-devel] [PATCH v2 1/2] ArmPkg/ArmMmuLib AARCH64: use helpers to determine table entry types

Given how the meaning of the attribute bits for page table entry types is slightly awkward, and changes between levels, add some helpers to abstract from this. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 40 +---

[edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

Currently, depending on the size of the region being (re)mapped, the page table manipulation code may replace a table entry with a block entry, even if the existing table entry uses different mapping attributes to describe different parts of the region it covers. This is undesirable, and instead, w

[edk2-devel] [PATCH v2 0/2] ArmPkg/ArmMmuLib AARCH64: correctness fix

The new ArmMmuLib code is easier to reason about, so that is what I did: currently, when we create mappings that cover existing table entries, we may end up overwriting those with block entries without taking the mapping attributes of the original table entries into account. So let's fix this. I h

Re: [edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

On Wed, Mar 25, 2020 at 12:38:46 +0100, Ard Biesheuvel wrote: > Currently, depending on the size of the region being (re)mapped, the > page table manipulation code may replace a table entry with a block entry, > even if the existing table entry uses different mapping attributes to > describe differ

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, March 25, 2020 5:20 AM > To: Samer El-Haj-Mahmoud > Cc: devel@edk2.groups.io; Samer El-Haj-Mahmoud > ; Leif Lindholm > Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] > Platform/RaspberryPi/RPi4: Enable HTTP Boot > > (

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO (extended) - Wed, 03/25/2020 11:00pm to Thu, 03/26/2020 12:00am #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO (extended) *When:* Wednesday, 25 March 2020, 11:00pm to Thursday, 26 March 2020, 12:00am (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/971006237 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758392 ) *Organizer:* Ray

Re: [edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

On Wed, 25 Mar 2020 at 13:38, Leif Lindholm wrote: > > On Wed, Mar 25, 2020 at 12:38:46 +0100, Ard Biesheuvel wrote: > > Currently, depending on the size of the region being (re)mapped, the > > page table manipulation code may replace a table entry with a block entry, > > even if the existing tabl

Re: [edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

Hi Ard, I tried to verify the patch just now and now I am seeing data abort with a translation fault at 0th level. Also, if this helps, it is caused by in FreePageTablesRecursive function when it tries to access the address pointed to by TranslationTable. Thanks Ashish

[edk2-devel] TianoCore Design Meeting - APAC/NAMO (extended) - Wed, 03/25/2020 #cal-notice

"TianoCore Design Meeting - APAC/NAMO (extended)" When: Wednesday, 25 March 2020 11:00pm to Thursday, 26 March 2020 12:00am (GMT+08:00) Asia/Chongqing Where: https://zoom.com.cn/j/971006237 Organizer: ray...@intel.com Description: # TOPIC * Discuss RISC-V edk2 port (Abner Chan

[edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

Enable HTTP Boot (with and without TLS) on RPi3 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Pl

[edk2-devel] Join from phone number if you have trouble joining through Zoom APP

All, If you want to join the Zoom meeting now but fail from Zoom APP, you could call the phone number shown in the agenda to join the meeting. Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56298): https://edk2.groups.io/g/d

Re: [edk2-devel] [RFCv2] code-first process for UEFI-forum specifications

On 03/23/20 20:05, Leif Lindholm wrote: > Changes to v2 of this proposal: > - Feedback from Laszlo[a] and Mike[b] incorporated. > - I opted to view Mike's responses to Laszlo's questions as > accepted, as no follow-up was made. > > Feedback from Felix[c] *not* incorporated, as while I agree

[edk2-devel] [PATCH v3 3/3] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

Currently, depending on the size of the region being (re)mapped, the page table manipulation code may replace a table entry with a block entry, even if the existing table entry uses different mapping attributes to describe different parts of the region it covers. This is undesirable, and instead, w

[edk2-devel] [PATCH v3 2/3] ArmPkg/ArmMmuLib AARCH64: use helpers to determine table entry types

Given how the meaning of the attribute bits for page table entry types is slightly awkward, and changes between levels, add some helpers to abstract from this. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 40 +---

[edk2-devel] [PATCH v3 0/3] ArmPkg/ArmMmuLib AARCH64: correctness fix

The new ArmMmuLib code is easier to reason about, so that is what I did: currently, when we create mappings that cover existing table entries, we may end up overwriting those with block entries without taking the mapping attributes of the original table entries into account. So let's fix this. I h

[edk2-devel] [PATCH v3 1/3] ArmPkg/ArmMmuLib AARCH64: limit recursion when freeing page tables

FreePageTablesRecursive () traverses the page table tree depth first to free all pages that it finds, without taking into account the level at which it is operating. Since TT_TYPE_TABLE_ENTRY aliases TT_TYPE_BLOCK_ENTRY_LEVEL3, we cannot distinguish table entries from block entries unless we take

Re: [edk2-devel] [PATCH v3 3/3] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

Reviewed-by: Ashish Singhal Tested-by: Ashish Singhal From: Ard Biesheuvel Sent: Wednesday, March 25, 2020 9:29 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Ashish Singhal Subject: [PATCH v3 3/3] ArmPkg/ArmMmuLib AARCH64: p

Re: [edk2-devel] [PATCH v3 1/3] ArmPkg/ArmMmuLib AARCH64: limit recursion when freeing page tables

Reviewed-by: Ashish Singhal Tested-by: Ashish Singhal From: Ard Biesheuvel Sent: Wednesday, March 25, 2020 9:29 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Ashish Singhal Subject: [PATCH v3 1/3] ArmPkg/ArmMmuLib AARCH64: li

Re: [edk2-devel] [PATCH v3 2/3] ArmPkg/ArmMmuLib AARCH64: use helpers to determine table entry types

Reviewed-by: Ashish Singhal Tested-by: Ashish Singhal From: Ard Biesheuvel Sent: Wednesday, March 25, 2020 9:29 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Ashish Singhal Subject: [PATCH v3 2/3] ArmPkg/ArmMmuLib AARCH64: u

Re: [edk2-devel] [PATCH v3 0/3] ArmPkg/ArmMmuLib AARCH64: correctness fix

Patch set version 3 looks good to me. I have reviewed and tested the changes locally. Reviewed-by: Ashish Singhal Tested-by: Ashish Singhal Thanks Ashish From: Ard Biesheuvel Sent: Wednesday, March 25, 2020 9:29 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel

[edk2-devel] [PATCH v2 01/17] OvmfPkg/PvScsiDxe: Create empty driver

In preparation for support booting from PvScsi devices, create a basic scaffolding for a driver. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/OvmfPkgIa32.dsc | 8 OvmfPkg/OvmfPkgIa32.fdf | 3 +++ OvmfPkg/OvmfPkgIa32X64.

[edk2-devel] [PATCH v2 13/17] OvmfPkg/PvScsiDxe: Setup requests and completions rings

These rings are shared memory buffers between host and device in which a cyclic buffer is managed to send request descriptors from host to device and receive completion descriptors from device to host. Note that because device may be constrained by IOMMU or guest may be run under AMD SEV, we make

[edk2-devel] [PATCH v2 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit

This commit doesn't change semantics. It is done as a preparation for future commits which will modify PCI attributes. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 54 +- OvmfPkg/PvScsiDxe/

[edk2-devel] [PATCH v2 08/17] OvmfPkg/PvScsiDxe: Open PciIo protocol for later use

This will give us an exclusive access to the PciIo of this device after it was started and until it will be stopped. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Reviewed-by: Laszlo Ersek Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 29 - Ov

[edk2-devel] [PATCH v2 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

The following commits will complete the implementation of device initialization. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/OvmfPkg/P

[edk2-devel] [PATCH v2 04/17] OvmfPkg/PvScsiDxe: Probe PCI devices and look for PvScsi

PvScsiControllerSupported() is called on handles passed in by the ConnectController() boot service and if the handle is the PVSCSI controller, the function would return success. A success return value will attach our driver to the device. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Re

[edk2-devel] [PATCH v2 02/17] OvmfPkg/PvScsiDxe: Install DriverBinding protocol

In order to probe and connect to the PvScsi device we need this protocol. Currently it does nothing. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Reviewed-by: Laszlo Ersek Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 66 - OvmfPkg/P

[edk2-devel] [PATCH v2 10/17] OvmfPkg/PvScsiDxe: Enable MMIO-Space & Bus-Mastering in PCI attributes

Enable MMIO-Space & Bus-Mastering PCI attributes when device is started. Note that original PCI attributes are restored when device is stopped. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 12 +++- 1 file changed, 11

[edk2-devel] [PATCH v2 07/17] OvmfPkg/PvScsiDxe: Translate Target & LUN to/from DevicePath

Implement EXT_SCSI_PASS_THRU.BuildDevicePath() and EXT_SCSI_PASS_THRU.GetTargetLun(). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Reviewed-by: Laszlo Ersek Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 61 -- 1 file changed, 59 inser

[edk2-devel] [PATCH v2 05/17] OvmfPkg/PvScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

Support dynamic insertion and removal of the protocol. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Reviewed-by: Laszlo Ersek Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 209 +++- OvmfPkg/PvScsiDxe/PvScsi.h | 29 + OvmfPkg/Pv

[edk2-devel] [PATCH v2 11/17] OvmfPkg/PvScsiDxe: Define device interface structures and constants

These definitions will be used by the following commits to complete the implementation of PVSCSI device driver. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/Include/IndustryStandard/PvScsi.h | 165 ++ 1 file changed, 165 inser

[edk2-devel] [PATCH v2 03/17] OvmfPkg/PvScsiDxe: Report name of driver

Install Component Name protocols to have a nice display name for the driver in places such as UEFI shell. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Reviewed-by: Laszlo Ersek Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 59 -- 1 fi

[edk2-devel] [PATCH v2 15/17] OvmfPkg/PvScsiDxe: Support sending SCSI request and receive response

Implement EXT_SCSI_PASS_THRU.PassThru(). Machines should be able to boot after this commit. Tested with Ubuntu 16.04 guest. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/OvmfPkg.dec | 6 + OvmfPkg/PvScsiDxe/PvScsi.c | 442 +

[edk2-devel] [PATCH v2 06/17] OvmfPkg/PvScsiDxe: Report the number of targets and LUNs

Implement EXT_SCSI_PASS_THRU.GetNextTarget() and EXT_SCSI_PASS_THRU.GetNextTargetLun(). ScsiBusDxe scans all MaxTarget * MaxLun possible devices. This can take unnecessarily long for large number of targets. To deal with this, VirtioScsiDxe has defined PCDs to limit the MaxTarget & MaxLun to desir

[edk2-devel] [PATCH v2 14/17] OvmfPkg/PvScsiDxe: Introduce DMA communication buffer

In case device is constrained by IOMMU or guest is running under AMD SEV, input/output buffers provided to device (DataBuffer and SenseData) needs to be explicitly mapped to device by PciIo->Map(). To avoid the overhead of mapping/unmapping the DataBuffer and SenseData to the device for every SCSI

[edk2-devel] [PATCH v2 16/17] OvmfPkg/PvScsiDxe: Reset device on ExitBootServices()

This causes the device to forget about the request/completion rings. We allocated said rings in EfiBootServicesData type memory, and code executing after ExitBootServices() is permitted to overwrite it. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Reviewed-by: Laszlo Ersek Signed-off-

[edk2-devel] [PATCH v2 00/17] OvmfPkg: Support booting from VMware PVSCSI controller

Hi, This series adds driver support for VMware PVSCSI controller. This controller is supported by VMware and QEMU. This work is part of the more general agenda of enhancing OVMF boot device support to have feature parity with SeaBIOS (Which supports booting from VMware PVSCSI). I pushed a copy o

[edk2-devel] [PATCH v2 17/17] OvmfPkg/PvScsiDxe: Enable device 64-bit DMA addresses

Enable PCI dual-address cycle attribute to signal device supports 64-bit DMA addresses. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 Signed-off-by: Liran Alon --- OvmfPkg/PvScsiDxe/PvScsi.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/OvmfPkg/PvScsiDxe

Re: [edk2-devel] [PATCH 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

On 03/25/20 02:11, Liran Alon wrote: > > On 24/03/2020 18:00, Laszlo Ersek wrote: >> On 03/16/20 16:01, Liran Alon wrote: >>> +STATIC >>> +EFI_STATUS >>> +PvScsiWriteCmdDesc ( >>> + IN CONST PVSCSI_DEV *Dev, >>> + IN UINT32 Cmd, >>> + IN VOID *Desc, >>> + IN UINTN

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

On 03/25/20 02:24, Wu, Hao A wrote: >> -Original Message- >> From: Ni, Ray >> Sent: Wednesday, March 25, 2020 8:46 AM >> To: Kinney, Michael D; Zeng, Star; Wu, Hao A; devel@edk2.groups.io >> Cc: Dong, Eric; Laszlo Ersek; Brian J . Johnson >> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/M

Re: [edk2-devel] [PATCH 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

On 25/03/2020 18:31, Laszlo Ersek wrote: On 03/25/20 02:11, Liran Alon wrote: On 24/03/2020 18:00, Laszlo Ersek wrote: On 03/16/20 16:01, Liran Alon wrote: +STATIC +EFI_STATUS +PvScsiWriteCmdDesc ( + IN CONST PVSCSI_DEV *Dev, + IN UINT32 Cmd, + IN VOID *Desc, +

Re: [edk2-devel] Questions about UEFI MAT / PcdPropertiesTableEnable

On Wed, 25 Mar 2020 at 17:55, Laszlo Ersek wrote: > > On 03/25/20 06:17, Ni, Ray wrote: > >> > >> The properties table should not be used. It has been superseded by the > >> memory attributes table, per spec. > >> > >> In edk2, the properties table is controlled by the PCD, regardless of the > >

Re: [edk2-devel] [PATCH 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

On 25/03/2020 18:40, Liran Alon wrote: On 25/03/2020 18:31, Laszlo Ersek wrote: On 03/25/20 02:11, Liran Alon wrote: To avoid further style comments, what is the coding convention in EDK2 to align the "PVSCSI_CMD_DESC_SETUP_RINGS Cmd;" var properly? The best I can recommend off-hand is: un

Re: [EXTERNAL] Re: [edk2-devel] Adding Bhyve support into upstream EDK2

Should it though? It seems like it should go the opposite way. ArmVirt->Ovmf and ArmVirt->Bhyve. Which one is the more core package? By naming it would *seem* that ArmVirt is more core, but maybe I’m wrong. - Bret From: Laszlo Ersek via Groups.Io Sent: Tuesda

Re: [edk2-devel] [PATCH 0/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

On Tue, 17 Mar 2020 at 11:26, Christopher J Zurcher wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 > > This patch adds support for building the native instruction algorithms for > IA32 and X64 versions of OpensslLib. The process_files.pl script was modified > to parse the .asm

Re: [edk2-devel][PATCH v2 1/1] Platform/RPi/ConfigDxe: Improve CPU Frequency configuration

On Wed, 11 Mar 2020 at 00:31, Pete Batard wrote: > > Improve the CPU frequency settings of the platforms by: > - Adding a "Default" option that sets the frequency to the > official default for each model/submodel. > - Adding a "Low" option, that sets the frequency to a fixed > PCD, custom to e

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

On 3/24/20 6:04 PM, Laszlo Ersek wrote: Umm... :) This is way too large, I think. Oh, it definitely is! I've still got a couple of days of deduplication work to go I think: I've already removed lots of packages from under BhyvePkg that it can just use from OvmfPkg. Thanks, I wasn't sure i

Re: [edk2-devel] [PATCH v2 2/2] Revert "NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval"

On 03/25/20 03:59, Michael Kubacki wrote: > From: Michael Kubacki > > This reverts commit 6896efdec2709e530b23c688cf0f31706709a0c5. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 > > GetVariable() now returns attributes when it fails with > EFI_BUFFER_TOO_SMALL. Therefore, commit 6

Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: add dummy assignment to work around GCC

On 03/25/20 10:12, Ard Biesheuvel wrote: > GCC 4.8 or 4.9 may throw the following error when building OVMF: > > Edk2/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c: > In function ‘QemuLoadKernelImage’: > Edk2/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c:416:30: >

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformPeiLib: add dummy assignment to work around older GCC

On 03/25/20 10:33, Ard Biesheuvel wrote: > Older GCC (<= 4.9) fail to infer that Parent is never used unless it > has been assigned before, and may throw an error like > > /work/git/edk2/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c: > In function ‘PlatformPeim’: > /work/git/edk2/Ar

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

On 03/25/20 06:07, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2627 > > The commit will introduce a static PCD to specify the periodic interval > for checking the AP status when MP services StartupAllAPs() and > StartupThisAP() are being executed in a non-blocking manner.

Re: [edk2-devel] [PATCH v3 0/3] ArmPkg/ArmMmuLib AARCH64: correctness fix

On 03/25/20 16:29, Ard Biesheuvel wrote: > The new ArmMmuLib code is easier to reason about, so that is what I did: > currently, when we create mappings that cover existing table entries, we > may end up overwriting those with block entries without taking the mapping > attributes of the original ta

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 2/2] Revert "NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval"

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Laszlo Ersek via Groups.Io Sent: Wednesday, March 25, 2020 12:05:28 PM To: devel@edk2.groups.io ; michael.kuba...@outlook.com Cc: Siyuan Fu ; Maciej Rabeda ; Jiaxin Wu Subject: [EXTE

[edk2-devel] [PATCH] OvmfPkg: Add bhyve support into AcpiTimerLib

--- OvmfPkg/Include/OvmfPlatforms.h| 7 +++ OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c| 3 +++ OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.c | 4 OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c | 3 +++ 4 files changed, 17 insertions(+) diff --git a/O

[edk2-devel] [PATCH v2 (add signed-off-by)] OvmfPkg: Add bhyve support into AcpiTimerLib

Signed-off-by: Rebecca Cran --- OvmfPkg/Include/OvmfPlatforms.h| 7 +++ OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c| 3 +++ OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.c | 4 OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c | 3 +++ 4 files changed, 17

Re: [edk2-devel] [PATCH] OvmfPkg: Add bhyve support into AcpiTimerLib

On 3/25/20 2:05 PM, Rebecca Cran wrote: --- OvmfPkg/Include/OvmfPlatforms.h| 7 +++ OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c| 3 +++ OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.c | 4 OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c | 3 +++ 4

Re: [EXTERNAL] Re: [edk2-devel] Questions about UEFI MAT / PcdPropertiesTableEnable

Agreed. Let’s please do what’s needed to put dropping this table on the roadmap. - Bret From: devel@edk2.groups.io on behalf of Ard Biesheuvel via Groups.Io Sent: Wednesday, March 25, 2020 10:00:39 AM To: Laszlo Ersek Cc: Ni, Ray ; devel@edk2.groups.io ; tige

Re: [edk2-devel] EDK II Python development process specification -draft

Thanks for all feedback received so far. As the review and feedback period is over, moving forward to fix the bugs and announce first official release of EDK II Python Development Process specification. Thank you all. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [PATCH v1] NetworkPkg/Ip6Dxe: Improve Neightbor Discovery message validation (CVE-2019-14559)

Maciej/Laszlo, Sorry I missed this patch. It looks good with me. Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: 2020年3月25日 19:36 > To: Wu, Jiaxin ; Fu, Siyuan > Cc: devel@edk2.groups.io; maciej.rab...@linux.intel.com > Subjec

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, March 26, 2020 3:24 AM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Dong, Eric; Ni, Ray; Kinney, Michael D; Zeng, Star; Brian J . Johnson > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH 0/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Wednesday, March 25, 2020 11:40 > To: Zurcher, Christopher J > Cc: edk2-devel-groups-io ; Wang, Jian J > ; Lu, XiaoyuX ; Eugene Cohen > > Subject: Re: [edk2-devel] [PATCH 0/1] CryptoPkg/OpensslLib: Add

Re: [edk2-devel] [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl

Hi Dandan, We can just halt this patch for now, we are looking for the alternative. Thanks Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, March 16, 2020 10:17 AM > To: Bi, Dandan ; devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

HI Christopher Thanks for the contribution. I think it is good enhancement. Do you have any data show what performance improvement we can get? Did the system boot faster with the this? Which feature ? UEFI Secure Boot? TCG Measured Boot? HTTPS boot? Comment for the code: 1) I am not sure if we n

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

Some more comment: 3) Do you consider to enable RNG instruction as well? 4) I saw you added some code for AVX instruction, such as YMM register. Have you validated that code, to make sure it can work correctly in current environment? > -Original Message- > From: devel@edk2.groups.io

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

The specific performance improvement depends on the operation; the OS provisioning I mentioned in the [Patch 0/1] thread removed the hashing as a bottleneck and improved the overall operation speed over 4x (saving 2.5 minutes of flashing time), but a direct SHA256 benchmark on the particular sil

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

Thanks. Comment inline: > -Original Message- > From: Zurcher, Christopher J > Sent: Thursday, March 26, 2020 10:44 AM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Ard Biesheuvel ; david.harr...@hp.com; Kinney, > Michael D > Subject: RE: [edk2-devel] [PATC

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

The ping command implementation would go into the ip4/ip6 protocol. But I am not familiar with the network part. Jiaxin/Siyuan, Can you help to review this patch? Thanks, Zhichao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, March 25, 2020 7:34

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

> -Original Message- > From: Yao, Jiewen > Sent: Wednesday, March 25, 2020 20:05 > To: Zurcher, Christopher J ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Ard Biesheuvel ; david.harr...@hp.com; Kinney, > Michael D > Subject: RE: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslL

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

There is an old shell based test application. It is removed from edk2-repo, and it should be in edk2-test repo in the future. Before the latter is ready, you can find the archive at https://github.com/jyao1/edk2/tree/edk2-cryptest/CryptoTestPkg/Cryptest But I am not sure if it covers the latest

  1   2   >