Re: [edk2-devel] [PATCH v1 2/7] MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Sean Brogan

Re: [edk2-devel] [PATCH v1 3/7] MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Sean Brogan

Re: [edk2-devel] [PATCH v1 4/7] MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Sean Brogan

Re: [edk2-devel] [PATCH v1 1/7] MdePkg/BaseLib: Add linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Kinney, Michael D ;

[edk2-devel] [PATCH v3] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Gu

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Sean, I think it meet the original code logic more closely. According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer. I have reviewed the

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

Hi Laszlo, According to your advice, i post new change. Can you help review the series again? Hi Jian, Chao, Jiewen, Please help review the series. Thanks, guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Thursday, April 16,

Re: [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, April 7, 2020 2:34 AM > To: devel@edk2.groups.io > Cc: Kun Qin ; Wang, Jian J > ; Yao, Jiewen ; Zhang, > Chao B > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Kinney, Sean, Bret, Could you help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 31, 2020 2:50 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

Hi Kinney, Sean, Bret, Could you help review the change? Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 31, 2020 11:06 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan

Re: [edk2-devel] [PATCH v1 2/2] SecurityPkg Tcg: Use SW SMI IO port PCD in Tpm.asl

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, April 7, 2020 2:34 AM > To: devel@edk2.groups.io > Cc: Kun Qin ; Wang, Jian J > ; Yao, Jiewen ; Zhang, > Chao B > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

Hi Jiewen, Jiang, Chao, Could you help review the change. Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Wednesday, April 1, 2020 9:11 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Zha

Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

Hi Ray, Chaganty, Could you please help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 24, 2020 2:37 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > &

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Remove FrameworkHandle parameter

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2612 Remove the FrameworkHandle parameter from the SaveFrameworkState interface in UnitTestLib Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- MdePkg/Include

[edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609 SavedState is not sticky, copied pointer update will not change source pointer Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

Summarize current status: Problem Statement: Openssl require _fltused to be defined as a constant anywhere floating point is used. It may use float out of edk2 tree and need _fltused, for example, Microsoft’s OnScreenKeyboard and UiToolKit. Current Proposal as below: Proposal 1: Add FltUsed.c

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

age- > From: Laszlo Ersek > Sent: Monday, April 20, 2020 7:39 PM > To: devel@edk2.groups.io; Jiang, Guomin > Subject: Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as > OPTIONAL > > On 04/16/20 09:33, Guomin Jiang wrote: > > File paramter should be optiona

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

es. > > Thanks, > guomin > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of > Guomin > > Jiang > > Sent: Thursday, April 16, 2020 3:34 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH v2 0/6] Mark

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

Hi Michael, Sean, Bret, Please help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, April 14, 2020 9:33 AM > To: devel@edk2.groups.io > Cc: kuqin ; Kinney, Michael D > ; Sean Bro

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Qin, Refer https://github.com/guominjia/edk2/commit/eed5154853f6522e6150b9cff16d24e0c88ad3cc Best Regards guomin From: Kun Qin Sent: Friday, April 10, 2020 3:18 PM To: Jiang, Guomin ; Sean Brogan ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib:

[edk2-devel] [PATCH v2 1/6] SecurityPkg/TPM: measure UEFI images without associated device paths again

). Therefore rejecting (File==NULL) at the top of the function is invalid. Fixes: 4b026f0d5af36faf3a3629a3ad49c51b5b3be12f Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Guomin Jiang --- .../DxeTpm2MeasureBootLib.c | 20

[edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

File paramter should be optional according to the descritpion. Guomin Jiang (6): SecurityPkg/TPM: measure UEFI images without associated device paths again SecurityPkg/DxeImageAuth: Mark the File parameter as option SecurityPkg/DxeImageVerificationLib: Mark the File parameter

[edk2-devel] [PATCH v2 4/6] MdeModulePkg/SecurityManagementLib: Mark the File parameter as OPTIONAL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the File description, the File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Include/Library/SecurityManagementLib.h| 2

[edk2-devel] [PATCH v2 5/6] MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the description, the File is optional and can be NULL Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c | 2 +- 1 file changed

[edk2-devel] [PATCH v2 2/6] SecurityPkg/DxeImageAuth: Mark the File parameter as option

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the File description, The File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang --- .../DxeImageAuthenticationStatusLib.c | 2 +- 1 file

[edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File parameter as OPTIONAL.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the description, the File is OPTIONAL and can be NULL. Signed-off-by: Guomin Jiang Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/Include/Protocol/Security2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2-devel] [PATCH v2 3/6] SecurityPkg/DxeImageVerificationLib: Mark the File parameter as OPTIONAL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the File description, the File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +- 1 file

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for VS2019 tool chains.

; Ni, Ray > Subject: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for > VS2019 tool chains. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2604 > > The link flags for VS2019 is absent and result the build fail. > > Cc: Jordan Justen > Cc: Andrew F

[edk2-devel] [PATCH v3] MdeModulePkg/SdDxe: Check the Token to avoid null pointer

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286 Token pointer may be NULL, it should be checked before use it. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Guomin Jiang --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 9 - 1 file changed, 8 insertions(+), 1 deletion

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SdDxe: Potential NULL pointer on Token

Hi Ray, Hao Could you please help review this changes. Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Wednesday, March 4, 2020 5:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wu, Hao A > ; Ni, Ray > Subject:

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

Add commets in your original message > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Yau > Sent: Friday, March 20, 2020 11:42 AM > To: devel@edk2.groups.io > Cc: Yau, KaiX > Subject: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR >

[edk2-devel] [PATCH v2] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

be off-by one than size of array, so when check array, the max index should less than size of array. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c| 12 ++-- 1 file changed, 6 insertions

[edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

be off-by one than size of array, so when check array, the max index should less than size of array. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c| 12 ++-- 1 file changed, 6 insertions

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

ret Barkelew Signed-off-by: Guomin Jiang --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c index b136992

[edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2608 According to logic and the practice, it is need to allocate ascii length by 2 for unicode string. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- .../UnitTestPersistenceLibSimpleFileSystem.c

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

gt; > Cc: Wang, Jian J ; Lu, XiaoyuX > ; Yao, Jiewen ; Sean Brogan > ; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > On 03/30/20 11:02, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 10:52, Guo

Re: [edk2-devel] [PATCH v3 2/3] MdeModulePkg VariablePei: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Monday, March 30, 2020 12:19 PM > To: michael.kuba...@outlook.com; devel@edk2.groups.io > Cc: Bret Barkelew ; Gao, Liming >

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

There is a spell error in the comments of VariableServiceGetVariable() in Variable.c. - @return EFI_BUFFER_TO_SMALL DataSize is too small for the result. + @return EFI_BUFFER_TOO_SMALLDataSize is too small for the result. Need create new bugs for it or fix in this comment directly? >

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

It is ok, I have no others confusion. Reviewed-by: Guomin Jiang > -Original Message- > From: Michael Kubacki [mailto:michael.kuba...@outlook.com] > Sent: Wednesday, April 1, 2020 1:12 AM > To: Jiang, Guomin ; devel@edk2.groups.io; Wang, > Jian J > Cc: Bret Bark

[edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

for 4b026f0d5af36faf3a3629a3ad49c51b5b3be12f. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Guomin Jiang --- .../DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 14 +++--- .../DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c| 14 +++--- 2 files changed, 14 insertions

[edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

the build. To solve this problem, the FltUsedLib was created that is one spot that the global static can exist. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Guomin Jiang --- CryptoPkg/CryptoPkg.dsc | 2 ++ .../Library/BaseCryptLib/BaseCryptLib.inf | 1 + .../Library

[edk2-devel] [PATCH v2] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Gu

Re: [edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

Hi Jian, Hao, Could you please help review this change? Thanks From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of GuoMinJ Sent: Thursday, March 26, 2020 2:11 PM To: devel@edk2.groups.io; newexplor...@gmail.com; GuoMinJ via Groups.Io Cc: Wang, Jian J ; Wu, Hao A Subject: Re:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

Hi Pankaj, I know your consideration. My consideration is that we provide an interface, it should be better for user, it not, the user won't use it and if no nobody use it, why provide it? In other word, the effort for copying the SerialPortLib and the effort for implementing

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

It is a good idea, I have a question: 1. When can detect the jumper signal or register? 2. If the jumper use GPIO, SerialUartClockLib will depend on GpioLib? 3. If the register is inside SIO, how to dispose the dependence? If it is too complex to implement the SerialUartClockLib, the project

Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid

Hi Jian, Hao, Could you please help review the change. Thanks Original message From: "GuoMinJ via Groups.Io" mailto:newexplorerj=gmail@groups.io>> Date: Fri, Feb 21, 2020, 6:10 PM To: devel@edk2.groups.io Cc: GuoMinJ

[edk2-devel] [PATCH v6] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Guomin Jiang Reviewe

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

an know the image size impact. > > Thanks > Liming > > -Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Guomin > > Jiang > > Sent: Thursday, April 23, 2020 12:04 PM > > To: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael > > D ;

[edk2-devel] [PATCH v2] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2694 When the USB fail and then Reset Device, it should rebuild description. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 1 file changed, 12 insertions

Re: [edk2-devel] [PATCH v1 3/9] MdeModulePkg: Define the VariablePolicyHelperLib

Add comment inline. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Saturday, April 11, 2020 2:38 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [edk2-devel] [PATCH v1 3/9] MdeModulePkg: Define the >

[edk2-devel] [PATCH v4] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Gu

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

; > To: devel@edk2.groups.io > > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray > > > Subject: [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description > > > table after Reset Device > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2694 &

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

Saturday, April 25, 2020 9:36 AM > > > > > To: devel@edk2.groups.io > > > > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray > > > > > Subject: [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the > description > > > > > table after Reset Dev

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

Hi Ard, it explain the reason at https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk1237?view=vs-2019. It can use ```MSFT:*_*_*_DLINK_FLAGS = /include:_fltused``` to resolve the error, but it is complex. Best Regards Guomin > -Original Message- >

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

ups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, April 14, 2020 3:01 PM > To: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D > ; ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

MSFT > > > > [Sources.Ia32] > >Ia32/WriteTr.nasm > > diff --git a/MdePkg/Library/BaseLib/FltUsed.c > > b/MdePkg/Library/BaseLib/FltUsed.c > > new file mode 100644 > > index 00..c065594266 > > --- /dev/null > > +++ b/MdePkg/Library/B

Re: [edk2-devel] [PATCH v1 2/9] MdeModulePkg: Define the VariablePolicyLib

It is better that pay more attention to code style, for example Replace NewTable = AllocatePool( NewSize ); With space NewTable = AllocatePool (NewSize); Refer https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C for simple principle and

[edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Add _fltused to feed MSVC compiler

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 Out of edk2 may need _fltused symbol such as mu_plus OnScreenKeyboard and UiToolKit. those driver will define the symbol to feed MSVC, but it will conflict with CryptoPkg. so move the symbol to BaseLib. Signed-off-by: Guomin Jiang Cc

[edk2-devel] [PATCH v2 2/2] CryptoPkg/IntrinsicLib: Remove _fltused to avoid duplication

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 Out of edk2 may need _fltused symbol such as mu_plus OnScreenKeyboard and UiToolKit. those driver will define the symbol to feed MSVC, but it will conflict with CryptoPkg. so move the symbol to BaseLib. Signed-off-by: Guomin Jiang Cc

[edk2-devel] [PATCH v2 0/2] Define the unique _fltused in BaseLib

Out of edk2 may need _fltused and may confict with edk2, define the unique to provide the _fltused and expect to avoid build error result by missing _fltused symbol Guomin Jiang (2): MdePkg/BaseLib: Add _fltused to feed MSVC compiler CryptoPkg/IntrinsicLib: Remove _fltused to avoid

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: On reset rebuild descriptor table

Hi Jeremy, You can refer https://edk2.groups.io/g/devel/message/58125 for discussion about this solution. Two issue I found: 1. Memory leakage may occur if doing so and I am investigating it. 2. It test pass with OVMF but fail in real platform, and I am figuring out the flow. Best Regards

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

, Jian J; Ni, Ray > > > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: > > > Rebuild > > > > > the > > > > > > description table after Reset Device > > > > > > > > > > > > &

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: On reset rebuild descriptor table

Hi Jeremy, Let move the discussion into https://edk2.groups.io/g/devel/message/58125, and I will add history in that message. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeremy > Linton > Sent: Tuesday, April 28, 2020 8:44 AM > To: Jiang, Guomin ;

[edk2-devel] [PATCH v5] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Gu

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

> >>>>>> Sent: Sunday, April 26, 2020 1:12 PM > >>>>>> To: devel@edk2.groups.io; Wu, Hao A ; Jiang, > >>>>> Guomin > >>>>>> > >>>>>> Cc: Wang, Jian J ; Ni, Ray > >>>>>> > >>

[edk2-devel] [PATCH v3 0/2] Define the unique _fltused in BaseLib

Out of edk2 may need _fltused and may confict with edk2, define the unique to provide the _fltused and expect to avoid build error result by missing _fltused symbol Guomin Jiang (2): MdePkg/BaseLib: Add _fltused to feed MSVC compiler CryptoPkg/IntrinsicLib: Remove _fltused to avoid

[edk2-devel] [PATCH v3 2/2] CryptoPkg/IntrinsicLib: Remove _fltused to avoid duplication

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 Out of edk2 may need _fltused symbol such as mu_plus OnScreenKeyboard and UiToolKit. those driver will define the symbol to feed MSVC, but it will conflict with CryptoPkg. so move the symbol to BaseLib. Signed-off-by: Guomin Jiang Cc

[edk2-devel] [PATCH v3 1/2] MdePkg/BaseLib: Add _fltused to feed MSVC compiler

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 Out of edk2 may need _fltused symbol such as mu_plus OnScreenKeyboard and UiToolKit. those driver will define the symbol to feed MSVC, but it will conflict with CryptoPkg. so move the symbol to BaseLib. Signed-off-by: Guomin Jiang Cc

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

during labor holiday and will back after May 5, please know it. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, April 28, 2020 11:22 AM > To: devel@edk2.groups.io; jeremy.lin...@arm.com; Wu, Hao A > > Cc: Wang, Jian J ; Ni

[edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2694 When the USB fail and then Reset Device, it should rebuild description. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference

I can't search the patch in master, anyone can pull the patch if it haven't been pull. Best Regards guomin From: devel@edk2.groups.io On Behalf Of Guomin Jiang Sent: Monday, March 23, 2020 4:13 PM To: Kun Qin ; devel@edk2.groups.io; Kinney, Michael D ; Xu, Wei6 Cc: Gao, Liming Subject: Re

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

> Hello Guomin, > > Could you help to add a brief summary of the relationship between the > proposed fix and the issue reported in the above BZ tracker? It would be > helpful for clarifying the purpose of the commit. Thanks. I will add the brief summary in next version patch. > > On

Re: [edk2-devel] [PATCH 00/18] Remove All UGA Support

iang, Guomin > > Subject: Re: [edk2-devel] [PATCH 00/18] Remove All UGA Support > > On 5/8/20 12:09 PM, Laszlo Ersek wrote: > > Hello Guomin, > > > > On 05/08/20 10:38, Guomin Jiang wrote: > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 > >

Re: [edk2-devel] [PATCH V4 02/11] CryptoPkg/BaseCrpytLib: Retire MD4 algorithm

Add commit inline. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Tuesday, May 12, 2020 2:27 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > ; Fu, Siyuan ; Kinney, Michael > D ; Yao, Jiewen ; > Philippe Mathieu-Daude > Subject:

Re: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

Add some comments. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Thursday, May 14, 2020 3:53 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D ; > fel...@ami.com; oleks...@ami.com > Subject: [edk2-devel] [PATCH

[edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2605 I think it is necessary that check the buffer size before ReadFile, it will inform the caller that they should provide more buffer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/Win/Host

Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference

Hi Kun, It is clear and i have no confusion. Reviewed-by: Guomin Jiang Thanks guomin From: Kun Qin [mailto:kun@microsoft.com] Sent: Monday, March 23, 2020 3:40 PM To: Jiang, Guomin ; devel@edk2.groups.io; Kinney, Michael D ; Xu, Wei6 Cc: Gao, Liming Subject: RE: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData

Hi Michael, Liming, Could you help review the patch. Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 1:58 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Kinney, Michael D > ; Gao, Liming >

Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference

Hi Xuwei, QinKun, Have you indeed encounter this issue or just think it is potential issue. I think below code will always initialize the mFmpImageInfoBuf[] and make sure it is valid. Line 585 - mFmpImageInfoBuf[Index] = AllocateZeroPool (ImageInfoSize); If the second GetImageInfo() is

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Check Suite pointer before use.

Hi Michael, Sean, Bret, Could you review the patch? Thanks > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, March 12, 2020 2:02 PM > To: devel@edk2.groups.io; newexplor...@gmail.com > Cc: Kinney, Michael D ;

Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments

Hi Ray, Rangasai, Could you help review the patch. Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Monday, March 9, 2020 9:21 AM > To: devel@edk2.groups.io; newexplor...@gmail.com > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status.

tatus. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2605 > > > > I think it is necessary that check the buffer size before ReadFile, it > > will inform the caller that they should provide more buffer. > > > > Cc: Jordan Justen > >

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index may be used.

Hi Michael, Sean, Bret, Could help review the patch? Thanks > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Wednesday, March 4, 2020 3:59 PM > To: devel@edk2.groups.io; newexplor...@gmail.com > Subject: Re:

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang

[edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe

[edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2587 SmmAccessLib.h and ConfigBlockLib.h is the primary header file in IntelSiliconPkg. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 8 1 file changed, 8

[edk2-devel] [PATCH v4] MdePkg/UnitTestBaseLib: Add check for pointer BinData

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531 AllocatePool may fail and BinData may be invalid, check it before use. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Guomin Jiang --- MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 4 +++- 1 file changed, 3 insertions

[edk2-devel] [PATCH 06/18] MdeModulePkg/GraphicsConsoleDxe: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in GraphicsConsoleDxe, remove comment about UGA in HiiDatabaseDxe. Cc: Dandan Bi Cc: Eric Dong Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../GraphicsConsoleDxe/GraphicsConsole.c

[edk2-devel] [PATCH 08/18] OvmfPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in OvmfPkg. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Guomin Jiang --- OvmfPkg/OvmfPkgIa32.dsc| 1 - OvmfPkg/OvmfPkgIa32X64.dsc | 1 - OvmfPkg/OvmfPkgX64.dsc

[edk2-devel] [PATCH 10/18] ArmVirtPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in ArmVirtPkg Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Guomin Jiang --- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - 2 files changed

[edk2-devel] [PATCH 00/18] Remove All UGA Support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 UGA is replaced by GOP and remove all related code. GuoMinJ (18): BaseTools: Remove All UGA Support UefiPayloadPkg: Remove All UGA Support ShellPkg: Remove All UGA Support MdeModulePkg: Remove All UGA Support

[edk2-devel] [PATCH 11/18] MdePkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in MdePkg. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Guomin Jiang --- MdePkg/Include/Protocol/UgaDraw.h| 160 --- MdePkg/Include/Protocol/UgaIo.h | 191

[edk2-devel] [PATCH 18/18] MdeModulePkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove the PcdConOutGopSupport definition. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Guomin Jiang --- MdeModulePkg/MdeModulePkg.dec | 7 --- MdeModulePkg/MdeModulePkg.uni | 6 -- 2 files changed, 13 deletions

[edk2-devel] [PATCH 17/18] ArmVirtPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove PcdConOutGopSupport, it is unnecessary any more. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Guomin Jiang --- ArmVirtPkg/ArmVirtQemu.dsc | 4 ArmVirtPkg/ArmVirtQemuKernel.dsc

[edk2-devel] [PATCH 15/18] OvmfPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Delete PcdConOutGopSupport, it is unnecessary any more. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Guomin Jiang --- OvmfPkg/OvmfPkgIa32.dsc| 1 - OvmfPkg/OvmfPkgIa32X64.dsc | 1 - OvmfPkg

[edk2-devel] [PATCH 01/18] BaseTools: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA support in BaseTools package. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Guomin Jiang --- .../Source/C/Include/Protocol/HiiFramework.h | 51 -- BaseTools/Source/C/Include/Protocol/UgaDraw.h | 161

[edk2-devel] [PATCH 03/18] ShellPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove All UGA Support in ShellPkg. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Guomin Jiang --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 -- ShellPkg/Library/UefiHandleParsingLib

[edk2-devel] [PATCH 16/18] UefiPayloadPkg: Remove All UGA Support

From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove PcdConOutGopSupport, it is unnecessary any more. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Signed-off-by: Guomin Jiang --- .../Library/PlatformBootManagerLib/PlatformBootManager.h| 2

  1   2   3   4   >