Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-21 Thread Xing, Eric via groups.io
Chang, Abner > Cc: Xing, Eric ; devel@edk2.groups.io; Zhai, MingXin > (Duke) ; Lendacky, Thomas > ; Yao, Ken ; Roth, > Michael ; Attar, AbdulLateef (Abdul Lateef) > ; Ard Biesheuvel > ; Gerd Hoffmann ; Min > Xu ; Leif Lindholm > Subject: Re: [edk2-devel] [PATCH 1/2] Platfo

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2024 at 15:00, Chang, Abner wrote: > > [AMD Official Use Only - General] > > I guess my RB misled contributors thought the patch is good to merge. > However, I was thinking Eric's team should give the final RB after the > validation as they are the maintainers for the subordinate

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Chang, Abner via groups.io
; Lendacky, Thomas ; Chang, Abner > ; Yao, Ken ; Roth, Michael > ; Attar, AbdulLateef (Abdul Lateef) > ; Ard Biesheuvel ; > Gerd Hoffmann ; Min Xu ; Leif > Lindholm > Subject: RE: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to > required DSC files > > [AMD Offic

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Xing, Eric via groups.io
bdulLateef (Abdul Lateef) > ; Ard Biesheuvel > ; Gerd Hoffmann ; Min > Xu ; Leif Lindholm > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to > required DSC files > > Caution: This message originated from an External Source. Use proper > caution when op

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2024 at 11:06, Xing, Eric wrote: > > [AMD Official Use Only - General] > > Hi Ard, > > This checkin causes VanGoghBoard build fail now. Would you help revert it? > I will merge PATCH to VanGoghBoard after the code review process done and > code changes are verified pass on real

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Xing, Eric via groups.io
Leif Lindholm > > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to > required DSC files > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Fri, 19 Apr 2024

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2024 at 10:10, Xing, Eric via groups.io wrote: > > [AMD Official Use Only - General] > > > Thanks Duke. > > > > Hi Thomas, > > > > PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off > EDK2_202208. Please hold on this PATCH check in. > > Apologies, but I

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Xing, Eric via groups.io
[AMD Official Use Only - General] Thanks Duke. Hi Thomas, PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off EDK2_202208. Please hold on this PATCH check in. Added my comments below. Thanks, Eric > -Original Message- > From: Zhai, MingXin

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Zhai, MingXin (Duke) via groups.io
[AMD Official Use Only - General] Hi Thomas, Yes, I agree with your opinion, edk2-platforms should be able to build against the latest edk2 repo. That is why we plan to update VanGoghBoard to support latest EDK2, In fact we are doing QA testing. I think every change on VanGoghBoard need

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-17 Thread Xing, Eric via groups.io
[AMD Official Use Only - General] Thanks Thomas and Abner. Reviewed-by: For up-stream, please let us verify it first: @Zhai, MingXin (Duke), Duke, please help verify this change on Chachani Board and feedback. Thanks, Eric > -Original Message- > From: Chang, Abner > Sent: Thursday,

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-17 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Thanks > -Original Message- > From: Lendacky, Thomas > Sent: Monday, April 15, 2024 11:01 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Roth, Michael ; Min Xu > ; Leif Lindholm ; Michael D > Kinney ; Chang, Abner