Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-21 Thread Xing, Eric via groups.io 
[AMD Official Use Only - General]

Hi Ard,

Please let me merge VangoGh board code next time after we finished the review 
process and build/verification test since I am maintainer and responsible for 
Vangogh Board platform code.

I will discuss it inside AMD to how to resolve current 
Platform/AMD/VanGoghBoard platform code build fail issue and reduce customer 
impact.
I will also discuss with Abner and other AMD reviewers to make a solution we 
want to move on.


Thanks,
Eric

> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, April 19, 2024 10:12 PM
> To: Chang, Abner 
> Cc: Xing, Eric ; devel@edk2.groups.io; Zhai, MingXin
> (Duke) ; Lendacky, Thomas
> ; Yao, Ken ; Roth,
> Michael ; Attar, AbdulLateef (Abdul Lateef)
> ; Ard Biesheuvel
> ; Gerd Hoffmann ; Min
> Xu ; Leif Lindholm 
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 19 Apr 2024 at 15:00, Chang, Abner  wrote:
> >
> > [AMD Official Use Only - General]
> >
> > I guess my RB misled contributors thought the patch is good to merge.
> However, I was thinking Eric's team should give the final RB after the
> validation as they are the maintainers for the subordinate VanGoghBoard
> platform. Suppose the impacted packages should be built successfully with
> the patches applied, as this is considered the base requirement of the code
> change. Nevertheless, the special build sauce for VanGoghBoard may be not
> easy for contributors to verify the build.
> >
> > Eric, I have few suggestions for this failure, for the short term, you can
> commit another change to remove this change, as the build failure has
> impacts on our customer support. You can decide to recover this or not
> depends on your business requirement.
>
> Keeping edk2-platforms synced with edk2 is already complicated enough.
> So I object to changes to retain compatibility with downstream forks of EDK2.
> Surely, you are not telling your customers to use EDK202208 with whatever
> the top-of-tree of edk2-platforms is at any given moment?
>
> In any case, if upstream edk2 is important to you, please fix the current
> situation in edk2 first. If it is not important to you, I don't see a reason 
> to
> revert anything, and you can fix it in your downstream.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118055): https://edk2.groups.io/g/devel/message/118055
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Ard Biesheuvel 
On Fri, 19 Apr 2024 at 15:00, Chang, Abner  wrote:
>
> [AMD Official Use Only - General]
>
> I guess my RB misled contributors thought the patch is good to merge. 
> However, I was thinking Eric's team should give the final RB after the 
> validation as they are the maintainers for the subordinate VanGoghBoard 
> platform. Suppose the impacted packages should be built successfully with the 
> patches applied, as this is considered the base requirement of the code 
> change. Nevertheless, the special build sauce for VanGoghBoard may be not 
> easy for contributors to verify the build.
>
> Eric, I have few suggestions for this failure, for the short term, you can 
> commit another change to remove this change, as the build failure has impacts 
> on our customer support. You can decide to recover this or not depends on 
> your business requirement.

Keeping edk2-platforms synced with edk2 is already complicated enough.
So I object to changes to retain compatibility with downstream forks
of EDK2. Surely, you are not telling your customers to use EDK202208
with whatever the top-of-tree of edk2-platforms is at any given
moment?

In any case, if upstream edk2 is important to you, please fix the
current situation in edk2 first. If it is not important to you, I
don't see a reason to revert anything, and you can fix it in your
downstream.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118029): https://edk2.groups.io/g/devel/message/118029
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Chang, Abner via groups.io 
[AMD Official Use Only - General]

I guess my RB misled contributors thought the patch is good to merge. However, 
I was thinking Eric's team should give the final RB after the validation as 
they are the maintainers for the subordinate VanGoghBoard platform. Suppose the 
impacted packages should be built successfully with the patches applied, as 
this is considered the base requirement of the code change. Nevertheless, the 
special build sauce for VanGoghBoard may be not easy for contributors to verify 
the build.

Eric, I have few suggestions for this failure, for the short term, you can 
commit another change to remove this change, as the build failure has impacts 
on our customer support. You can decide to recover this or not depends on your 
business requirement.
For the long term, besides of code base upgrade, we could consider to revise 
VanGoghBoard to use native edk2 build script. Maybe we can leverage prebuild 
mechanism to cover the platform specific build requirements.

Thanks
Abner


> -Original Message-
> From: Xing, Eric 
> Sent: Friday, April 19, 2024 7:32 PM
> To: Ard Biesheuvel 
> Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) ;
> Lendacky, Thomas ; Chang, Abner
> ; Yao, Ken ; Roth, Michael
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Ard Biesheuvel ;
> Gerd Hoffmann ; Min Xu ; Leif
> Lindholm 
> Subject: RE: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> [AMD Official Use Only - General]
>
> Hi Ard,
>
> Agree with you, reverting code looks not a good way now. We will think about
> new method to resolve this issue. Just need a bit more time and I will hold on
> checking in code to VanGoghBoard before it.
> Thanks again for your suggestion and help us improve code in VanGoghBoard.
>
> Thanks,
> Eric
>
>
> > -Original Message-
> > From: Ard Biesheuvel 
> > Sent: Friday, April 19, 2024 5:25 PM
> > To: Xing, Eric 
> > Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) ;
> > Lendacky, Thomas ; Chang, Abner
> > ; Yao, Ken ; Roth, Michael
> > ; Attar, AbdulLateef (Abdul Lateef)
> > ; Ard Biesheuvel
> > ; Gerd Hoffmann ; Min
> > Xu ; Leif Lindholm 
> > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> > required DSC files
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > On Fri, 19 Apr 2024 at 11:06, Xing, Eric  wrote:
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Hi Ard,
> > >
> > > This checkin causes VanGoghBoard build fail now. Would you help revert it?
> > > I will merge PATCH to VanGoghBoard after the code review process done
> > and code changes are verified pass on real board.
> > >
> >
> > Please provide a solution instead that makes upstream edk2 work with
> > upstream edk2-platforms.
> >
> > For downstream builds, you can combine the old EDK2_202208 with an older
> > checkout of edk2-platforms, right?



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118028): https://edk2.groups.io/g/devel/message/118028
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Xing, Eric via groups.io 
[AMD Official Use Only - General]

Hi Ard,

Agree with you, reverting code looks not a good way now. We will think about 
new method to resolve this issue. Just need a bit more time and I will hold on 
checking in code to VanGoghBoard before it.
Thanks again for your suggestion and help us improve code in VanGoghBoard.

Thanks,
Eric


> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, April 19, 2024 5:25 PM
> To: Xing, Eric 
> Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) ;
> Lendacky, Thomas ; Chang, Abner
> ; Yao, Ken ; Roth, Michael
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Ard Biesheuvel
> ; Gerd Hoffmann ; Min
> Xu ; Leif Lindholm 
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 19 Apr 2024 at 11:06, Xing, Eric  wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Ard,
> >
> > This checkin causes VanGoghBoard build fail now. Would you help revert it?
> > I will merge PATCH to VanGoghBoard after the code review process done
> and code changes are verified pass on real board.
> >
>
> Please provide a solution instead that makes upstream edk2 work with
> upstream edk2-platforms.
>
> For downstream builds, you can combine the old EDK2_202208 with an older
> checkout of edk2-platforms, right?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118019): https://edk2.groups.io/g/devel/message/118019
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Ard Biesheuvel 
On Fri, 19 Apr 2024 at 11:06, Xing, Eric  wrote:
>
> [AMD Official Use Only - General]
>
> Hi Ard,
>
> This checkin causes VanGoghBoard build fail now. Would you help revert it?
> I will merge PATCH to VanGoghBoard after the code review process done and 
> code changes are verified pass on real board.
>

Please provide a solution instead that makes upstream edk2 work with
upstream edk2-platforms.

For downstream builds, you can combine the old EDK2_202208 with an
older checkout of edk2-platforms, right?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118015): https://edk2.groups.io/g/devel/message/118015
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Xing, Eric via groups.io 
[AMD Official Use Only - General]

Hi Ard,

This checkin causes VanGoghBoard build fail now. Would you help revert it?
I will merge PATCH to VanGoghBoard after the code review process done and code 
changes are verified pass on real board.

Thanks,
Eric

> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, April 19, 2024 4:27 PM
> To: devel@edk2.groups.io; Xing, Eric 
> Cc: Zhai, MingXin (Duke) ; Lendacky, Thomas
> ; Chang, Abner ;
> Yao, Ken ; Roth, Michael ;
> Attar, AbdulLateef (Abdul Lateef) ; Ard
> Biesheuvel ; Gerd Hoffmann
> ; Min Xu ; Leif Lindholm
> 
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 19 Apr 2024 at 10:10, Xing, Eric via groups.io
>  wrote:
> >
> > [AMD Official Use Only - General]
> >
> >
> > Thanks Duke.
> >
> >
> >
> > Hi Thomas,
> >
> >
> >
> > PATCH1/2 still cannot be checked in because today’s VanGoghBoard is
> based off EDK2_202208. Please hold on this PATCH check in.
> >
> >
>
> Apologies, but I already merged this patch two days ago.
>
> edk2-platforms should build in combination with edk2. If your platform has
> other dependencies that are not in edk2, edk2-platforms or edk2-non-osi,
> please host and maintain the platform elsewhere.
>
> I also noticed that
> Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh requires that the
> various repo checkouts are inside the workspace, but the BaseTools don't
> actually require this. Personally, I use
>
> $HOME/edk2-workspace for the builds
>
> $HOME/edk2
> $HOME/edk2-platforms
> $HOME/edk2-non-osi
>
> for the checkouts, which keeps things separate, and allow me to wipe the
> workspace entirely without touching the repos.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118014): https://edk2.groups.io/g/devel/message/118014
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Ard Biesheuvel 
On Fri, 19 Apr 2024 at 10:10, Xing, Eric via groups.io
 wrote:
>
> [AMD Official Use Only - General]
>
>
> Thanks Duke.
>
>
>
> Hi Thomas,
>
>
>
> PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off 
> EDK2_202208. Please hold on this PATCH check in.
>
>

Apologies, but I already merged this patch two days ago.

edk2-platforms should build in combination with edk2. If your platform
has other dependencies that are not in edk2, edk2-platforms or
edk2-non-osi, please host and maintain the platform elsewhere.

I also noticed that
Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh requires that the
various repo checkouts are inside the workspace, but the BaseTools
don't actually require this. Personally, I use

$HOME/edk2-workspace for the builds

$HOME/edk2
$HOME/edk2-platforms
$HOME/edk2-non-osi

for the checkouts, which keeps things separate, and allow me to wipe
the workspace entirely without touching the repos.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118010): https://edk2.groups.io/g/devel/message/118010
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Xing, Eric via groups.io 
[AMD Official Use Only - General]


Thanks Duke.



Hi Thomas,



PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off 
EDK2_202208. Please hold on this PATCH check in.



Added my comments below.



Thanks,

Eric



> -Original Message-

> From: Zhai, MingXin (Duke) 

> Sent: Friday, April 19, 2024 3:06 PM

> To: Lendacky, Thomas ; Xing, Eric

> ; Chang, Abner ; Yao, Ken

> ; devel@edk2.groups.io

> Cc: Roth, Michael ; Attar, AbdulLateef (Abdul

> Lateef) ; Ard Biesheuvel

> ; Gerd Hoffmann ; Min

> Xu ; Leif Lindholm ; Leif

> Lindholm 

> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC

> files

>

> [AMD Official Use Only - General]

>

> Hi Thomas,

>

> Yes, I agree with your opinion,  edk2-platforms should be able to build

> against the latest edk2 repo. That is why we plan to update VanGoghBoard to

> support latest EDK2, In fact we are doing QA testing.

[Xing, Eric] It is incorrect for edk2-platforms board code. We will not verify 
edk2-platform build test with latest edk2. See my comments below.

> I think every change on VanGoghBoard need ensure system can works

> properly. But if I apply this patch and use the latest EDK2 version to build, 
> it

> will encounter error because it requires other code changes(Such as including

> new libraries).

> So my point is, Let me upload VanGoghBoard related changes after passing

> full QA testing.

>

>

> Thanks!

>

> -Original Message-

> From: Lendacky, Thomas 
> mailto:thomas.lenda...@amd.com>>

> Sent: Friday, April 19, 2024 12:03 AM

> To: Zhai, MingXin (Duke) mailto:duke.z...@amd.com>>; Xing, 
> Eric

> mailto:eric.x...@amd.com>>; Chang, Abner 
> mailto:abner.ch...@amd.com>>; Yao, Ken

> mailto:ken@amd.com>>

> Cc: Roth, Michael mailto:michael.r...@amd.com>>; Attar, 
> AbdulLateef (Abdul

> Lateef) mailto:abdullateef.at...@amd.com>>

> Subject: Re: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC

> files

>

> On 4/18/24 05:02, Zhai, MingXin (Duke) wrote:

> > [AMD Official Use Only - General]

> >

> > Hi Thomas,

> >

> > this patch looks like for newer EDK2 codebase, but VanGoghBoard is based

> on EDK2_202208 now, and will encounter build issues if this patch is applied.

> > We have plans to update the EDK2 codebase to EDK2_202402. So I thought

> > it would be better to add this change when we update the EDK2 code

> > base

>

> I thought the latest edk2-platforms repo was supposed to be able to build

> against the latest edk2 repo.

[Xing, Eric] No. It will easily impact edk2-platforms BIOS if we pull in the 
latest edk2 repo. So, edk2-platforms will pull in a stable edk2 tag instead of 
latest edk2 repo.

>If your VanGoghBoard is based on a particular

> edk2 tag, then you should probably have a tag in edk2-platforms so that you

> can have a version of the edk2-platform code that works with a version of

> the edk2 code, no?

[Xing, Eric] I don’t think we will create tag for VanGoghBoard. Instead, we 
will have user guide/readme to let user know which EDK2 tag is supported in 
current board code.

The board code owner can decide when to update edk2 kernel and which Tage. I 
think it is the same for ALL board code, not only VanGoghBoard.

>

> Why is this a private email? This discussion should be on the list so that the

> maintainer(s) can decide what to do based on the discussion.

>

> Thanks,

> Tom

>

> >

> >

> > Thanks!

> >

> > -Original Message-

> > From: Xing, Eric mailto:eric.x...@amd.com>>

> > Sent: Thursday, April 18, 2024 9:54 AM

> > To: Chang, Abner mailto:abner.ch...@amd.com>>; 
> > Lendacky, Thomas

> > mailto:thomas.lenda...@amd.com>>; 
> > devel@edk2.groups.io; Zhai, MingXin

> (Duke)

> > mailto:duke.z...@amd.com>>; Yao, Ken 
> > mailto:ken@amd.com>>

> > Cc: Ard Biesheuvel 
> > mailto:ardb+tianoc...@kernel.org>>; Gerd Hoffmann

> > mailto:kra...@redhat.com>>; Roth, Michael 
> > mailto:michael.r...@amd.com>>; Min Xu

> > mailto:min.m...@intel.com>>; Leif Lindholm 
> > mailto:quic_llind...@quicinc.com>>;

> > Michael D Kinney 
> > mailto:michael.d.kin...@intel.com>>; Attar, 
> > AbdulLateef

> > (Abdul Lateef) mailto:abdullateef.at...@amd.com>>

> > Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC

> > files

> >

> > [AMD Official Use Only - General]

> >

> > Thanks Thomas and Abner.

> > Reviewed-by: mailto:eric.x...@amd.com>>

> >

> > For up-stream, please let us verify it first:

> > @Zhai, MingXin (Duke), Duke, please help verify this change on Chachani

> Board and feedback.

> >

> > Thanks,

> > Eric

> >

> >> -Original Message-

> >> From: Chang, Abner mailto:abner.ch...@amd.com>>

> >> Sent: Thursday, April 18, 2024 8:59 AM

> >> To: Lendacky, Thomas 
> >> mailto:thomas.lenda...@amd.com>>;

> devel@edk2.groups.io

> >> Cc: Ard Biesheuvel 
> >> mailto:ardb+tianoc...@kernel.org>>; Gerd 
> >> Hoffmann

> >>

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-19 Thread Zhai, MingXin (Duke) via groups.io 
[AMD Official Use Only - General]

Hi Thomas,

Yes, I agree with your opinion,  edk2-platforms should be able to build against 
the latest edk2 repo. That is why we plan to update VanGoghBoard to support 
latest EDK2, In fact we are doing QA testing.
I think every change on VanGoghBoard need ensure system can works properly. But 
if I apply this patch and use the latest EDK2 version to build, it will 
encounter error because it requires other code changes(Such as including new 
libraries).
So my point is, Let me upload VanGoghBoard related changes after passing full 
QA testing.


Thanks!

-Original Message-
From: Lendacky, Thomas 
Sent: Friday, April 19, 2024 12:03 AM
To: Zhai, MingXin (Duke) ; Xing, Eric ; 
Chang, Abner ; Yao, Ken 
Cc: Roth, Michael ; Attar, AbdulLateef (Abdul Lateef) 

Subject: Re: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

On 4/18/24 05:02, Zhai, MingXin (Duke) wrote:
> [AMD Official Use Only - General]
>
> Hi Thomas,
>
> this patch looks like for newer EDK2 codebase, but VanGoghBoard is based on 
> EDK2_202208 now, and will encounter build issues if this patch is applied.
> We have plans to update the EDK2 codebase to EDK2_202402. So I thought
> it would be better to add this change when we update the EDK2 code
> base

I thought the latest edk2-platforms repo was supposed to be able to build 
against the latest edk2 repo. If your VanGoghBoard is based on a particular 
edk2 tag, then you should probably have a tag in edk2-platforms so that you can 
have a version of the edk2-platform code that works with a version of the edk2 
code, no?

Why is this a private email? This discussion should be on the list so that the 
maintainer(s) can decide what to do based on the discussion.

Thanks,
Tom

>
>
> Thanks!
>
> -Original Message-
> From: Xing, Eric 
> Sent: Thursday, April 18, 2024 9:54 AM
> To: Chang, Abner ; Lendacky, Thomas
> ; devel@edk2.groups.io; Zhai, MingXin (Duke)
> ; Yao, Ken 
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Roth, Michael ; Min Xu
> ; Leif Lindholm ;
> Michael D Kinney ; Attar, AbdulLateef
> (Abdul Lateef) 
> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
> files
>
> [AMD Official Use Only - General]
>
> Thanks Thomas and Abner.
> Reviewed-by: 
>
> For up-stream, please let us verify it first:
> @Zhai, MingXin (Duke), Duke, please help verify this change on Chachani Board 
> and feedback.
>
> Thanks,
> Eric
>
>> -Original Message-
>> From: Chang, Abner 
>> Sent: Thursday, April 18, 2024 8:59 AM
>> To: Lendacky, Thomas ; devel@edk2.groups.io
>> Cc: Ard Biesheuvel ; Gerd Hoffmann
>> ; Roth, Michael ; Min Xu
>> ; Leif Lindholm ;
>> Michael D Kinney ; Attar, AbdulLateef
>> (Abdul
>> Lateef) ; Xing, Eric 
>> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
>> files
>>
>> [AMD Official Use Only - General]
>>
>> Reviewed-by: 
>>
>> Thanks
>>
>>> -Original Message-
>>> From: Lendacky, Thomas 
>>> Sent: Monday, April 15, 2024 11:01 PM
>>> To: devel@edk2.groups.io
>>> Cc: Ard Biesheuvel ; Gerd Hoffmann
>>> ; Roth, Michael ; Min Xu
>>> ; Leif Lindholm ;
>>> Michael D Kinney ; Chang, Abner
>>> ; Attar, AbdulLateef (Abdul Lateef)
>>> ; Xing, Eric 
>>> Subject: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
>>> files
>>>
>>> Any DSC file that uses the UefiCpuPkg MpInitLib library now requires
>>> the AmdSvsmLib library. Update the DSC files to include the
>>> AmdSvsmLib NULL library implementation. Also, fix the specification
>>> of VmgExitLib as it was renamed to CcExitLib.
>>>
>>> Cc: Abner Chang 
>>> Cc: Abdul Lateef Attar 
>>> Cc: Eric Xing 
>>> Signed-off-by: Tom Lendacky 
>>> ---
>>>   Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
>>> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
>>> index 20f06dd851..e478e0b0c2 100644
>>> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
>>> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
>>> @@ -371,7 +371,8 @@
>>>
>>>   [LibraryClasses.common]
>>>
>>> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilte
>>> RegisterFilterLib|rL
>>> RegisterFilterLib|ibNull.inf
>>> -  VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
>>> +  CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf
>>> +  AmdSvsmLib|UefiCpuPkg/Library/AmdSvsmLibNull/AmdSvsmLibNull.inf
>>>
>>>   [PcdsFixedAtBuild]
>>>
>> gEfiAmdAgesaPkgTokenSpaceGuid.PcdFchOemBeforePciRestoreSwSmi|0xEA
>>> --
>>> 2.43.2
>>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118007): https://edk2.groups.io/g/devel/message/118007
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-17 Thread Xing, Eric via groups.io 
[AMD Official Use Only - General]

Thanks Thomas and Abner.
Reviewed-by: 

For up-stream, please let us verify it first:
@Zhai, MingXin (Duke), Duke, please help verify this change on Chachani Board 
and feedback.

Thanks,
Eric

> -Original Message-
> From: Chang, Abner 
> Sent: Thursday, April 18, 2024 8:59 AM
> To: Lendacky, Thomas ;
> devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Roth, Michael ; Min Xu
> ; Leif Lindholm ;
> Michael D Kinney ; Attar, AbdulLateef (Abdul
> Lateef) ; Xing, Eric 
> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
> files
>
> [AMD Official Use Only - General]
>
> Reviewed-by: 
>
> Thanks
>
> > -Original Message-
> > From: Lendacky, Thomas 
> > Sent: Monday, April 15, 2024 11:01 PM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel ; Gerd Hoffmann
> > ; Roth, Michael ; Min Xu
> > ; Leif Lindholm ;
> > Michael D Kinney ; Chang, Abner
> > ; Attar, AbdulLateef (Abdul Lateef)
> > ; Xing, Eric 
> > Subject: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
> > files
> >
> > Any DSC file that uses the UefiCpuPkg MpInitLib library now requires
> > the AmdSvsmLib library. Update the DSC files to include the AmdSvsmLib
> > NULL library implementation. Also, fix the specification of VmgExitLib
> > as it was renamed to CcExitLib.
> >
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Cc: Eric Xing 
> > Signed-off-by: Tom Lendacky 
> > ---
> >  Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > index 20f06dd851..e478e0b0c2 100644
> > --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > @@ -371,7 +371,8 @@
> >
> >  [LibraryClasses.common]
> >
> > RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterL
> > RegisterFilterLib|ibNull.inf
> > -  VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
> > +  CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf
> > +  AmdSvsmLib|UefiCpuPkg/Library/AmdSvsmLibNull/AmdSvsmLibNull.inf
> >
> >  [PcdsFixedAtBuild]
> >
> gEfiAmdAgesaPkgTokenSpaceGuid.PcdFchOemBeforePciRestoreSwSmi|0xEA
> > --
> > 2.43.2
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117941): https://edk2.groups.io/g/devel/message/117941
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

2024-04-17 Thread Chang, Abner via groups.io 
[AMD Official Use Only - General]

Reviewed-by: 

Thanks

> -Original Message-
> From: Lendacky, Thomas 
> Sent: Monday, April 15, 2024 11:01 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Roth, Michael ; Min Xu
> ; Leif Lindholm ; Michael D
> Kinney ; Chang, Abner
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Xing, Eric 
> Subject: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files
>
> Any DSC file that uses the UefiCpuPkg MpInitLib library now requires the
> AmdSvsmLib library. Update the DSC files to include the AmdSvsmLib NULL
> library implementation. Also, fix the specification of VmgExitLib as it
> was renamed to CcExitLib.
>
> Cc: Abner Chang 
> Cc: Abdul Lateef Attar 
> Cc: Eric Xing 
> Signed-off-by: Tom Lendacky 
> ---
>  Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> index 20f06dd851..e478e0b0c2 100644
> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> @@ -371,7 +371,8 @@
>
>  [LibraryClasses.common]
>
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
> -  VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
> +  CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf
> +  AmdSvsmLib|UefiCpuPkg/Library/AmdSvsmLibNull/AmdSvsmLibNull.inf
>
>  [PcdsFixedAtBuild]
>gEfiAmdAgesaPkgTokenSpaceGuid.PcdFchOemBeforePciRestoreSwSmi|0xEA
> --
> 2.43.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117939): https://edk2.groups.io/g/devel/message/117939
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-