Re: CheckRequire: in spec?

2018-02-14 Thread Rex Dieter
Marian Csontos wrote:

> I wonder, when there is a %check in spec, and the testsuite requires
> more packages than BuildRequires, is there a way to have them installed
> only if check is running?
> 
> Or shall I just throw them in as BuildRequire`s?

use BuildRequires

If these extra deps could cause complications (say, for bootstrapping), you 
can make them conditional (e.g. only used if %{bootstrap} macro is not 
defined)

-- rex
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: CheckRequire: in spec?

2018-02-14 Thread Tomasz Kłoczko
On 14 February 2018 at 08:56, Igor Gnatenko <
ignatenkobr...@fedoraproject.org> wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On Wed, 2018-02-14 at 09:39 +0100, Marian Csontos wrote:
> > I wonder, when there is a %check in spec, and the testsuite requires
> > more packages than BuildRequires, is there a way to have them installed
> > only if check is running?
>
> This has been brought up few time... There is nothing like that. The
> consensus,
> IIRC, was to use %bcond_without check and have
> %if %{with check}
> BuildRequires: ...
> %endif
>
> same for %check section itself. I think someone wanted to implement this
> generally in RPM, but this didn't happen.
>

Using such constructions is not compliant with --nocheck rpmbuild command
line option.
When I've proposed here CheckRequire few months ago on this list original
intention was to use those additional dependency when rpmbuild is not
executed with --nocheck option.

kloczek
PS. Igor may I ask you disable use PGP signs in public emails? or at least
switch to use PGP signature as MIME attachment? Please ..
I can understand that using PGP is OK or is sometimes necessary when
someone who receives your emails needs to be sure that it is your emails.
-- 
Tomasz Kłoczko | LinkedIn: *http://lnkd.in/FXPWxH *
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: CheckRequire: in spec?

2018-02-14 Thread Vascom
%check run only on build stage so you can use just BuildRequire for it.

ср, 14 февр. 2018 г. в 11:47, Marian Csontos :

> I wonder, when there is a %check in spec, and the testsuite requires
> more packages than BuildRequires, is there a way to have them installed
> only if check is running?
>
> Or shall I just throw them in as BuildRequire`s?
>
> -- Martian
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: CheckRequire: in spec?

2018-02-14 Thread Igor Gnatenko
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On Wed, 2018-02-14 at 09:39 +0100, Marian Csontos wrote:
> I wonder, when there is a %check in spec, and the testsuite requires 
> more packages than BuildRequires, is there a way to have them installed 
> only if check is running?

This has been brought up few time... There is nothing like that. The consensus,
IIRC, was to use %bcond_without check and have
%if %{with check}
BuildRequires: ...
%endif

same for %check section itself. I think someone wanted to implement this
generally in RPM, but this didn't happen.

> Or shall I just throw them in as BuildRequire`s?

Yes.
- -- 
- -Igor Gnatenko
-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlqD+cEACgkQaVcUvRu8
X0zwmA//XPNf9ZitR5HU0azJJxifIv982/ZiDhEZh/newKtni2FMNE4Q53n734yT
rx+pyYsaR2stbASR4DrOUTq/6MjEkCFhLs5Dm+bRi1TC34t6QD8/VHh6qu2KAWqM
OPEUE85rEGW8E3glv4aZCNll6TBlJcok2XvnP0LgfcNtQLhvc/GLzGMjtkze2t+H
B3iWXj/g10WhCGQ6TV7xxCdlBoDEkusLWHGyxpD/mOKdN7JW9Tkplmz5kJirOmf5
+yMQhG6O3lzfL3bXw8JMJ2FocSYL+rD8agbu59xSE2QMGx0zwWjzvh5M6+ji7UPF
UQUf9JhHrf42SRYDbP11P2u3k6Y9IwioPqa+BUfqJEMO9cEM8yk0OIoPPuUjLCKt
3TAqmd6tYgp4K3wMvrc3tofFccPnLdYIHWsLHuiVKIV3qZn19d3acK/kL66bULk2
laG2hFaDD9/DLoEoome/FnqIpW25Czmpr24aotaF0wskCVSmC9PCsfqw2KJk4ugZ
tVAu9IDkCOIL7qzx/Eg6AH2AQa/BN2L1B6kt1i8DLmkdO9Oer5ZK0Uc+9MR8Mxvd
zpNr15kJzuyytqxcQsrbrYX4nci2iacBIWPJZEYYyU2Uw/PbiAhizY8VA2WO7Xd8
zjqo8M2CaFzQlZtxXsv6XDg5AEXCMA/pI/YR7+vlIkM6PMDMuOc=
=1auY
-END PGP SIGNATURE-
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


CheckRequire: in spec?

2018-02-14 Thread Marian Csontos
I wonder, when there is a %check in spec, and the testsuite requires 
more packages than BuildRequires, is there a way to have them installed 
only if check is running?


Or shall I just throw them in as BuildRequire`s?

-- Martian
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org