Re: HEADS UP: Rebasing to Readline-7.0 in rawhide

2017-01-14 Thread Igor Gnatenko
On Sat, 2017-01-14 at 17:17 +0100, Pavel Raiskup wrote:
> On Friday, January 13, 2017 6:33:49 PM CET Igor Gnatenko wrote:
> > On Fri, 2017-01-13 at 10:30 -0500, Siteshwar Vashisht wrote:
> > > Hello,
> > > 
> > > Readline-7.0 was released few months ago and I have rebased it in
> > > rawhide to version 7.0. I have created a compatibility package
> > > compat-readline6 to avoid breaking any existing applications.
> > > 
> > > Update to readline-7.0 caused a build failure with gdb that was
> > > fixed
> > > by this commit [1].
> > 
> > I've rebuilt yesterday ~199 packages to link against new soname,
> 
> Was that complete list?  I miss the build for PostgreSQL e.g.
Macaulay2
afpfs-ng
augeas
bes
folks
freeradius
ghc-readline
glusterfs-coreutils
gnomint
guile
insight
ipmitool
kawa
ktechlab
libgda
libldm
libwvstreams
malaga
maxima
nmh
ocaml-omake
opendbx
perl-Term-ReadLine-Gnu
physfs
piklab
postgresql
python26
root
shigofumi
socat
sqlcipher
tcl-tclreadline
telegram-cli
torque
v8-314
xmlrpc-c

This are the packages in koji which are still linking to
libreadline.so.6.

Full list of packages I've rebuilt is more complicated and much wider
(just use datagrapper to find my commits to git).

P.S. I probably missed some of packages to rebuild...
> 
> Pavel
> 
> > however some of them (~38) failed by various reasons:
> > airtsp: #1307310 NEW- Denis Arnaud - airtsp: FTBFS in
> > rawhide
> > augeas: still building
> > bacula: #1412924 NEW- Simone Caronni - bacula: FTBFS in
> > Fedora
> > Rawhide
> > bes: maintainer reported upstream
> > dropwatch: #1412926 MODIFIED   - Neil Horman - dropwatch: FTBFS in
> > Fedora Rawhide on ppc64/ppc64le
> > folks: #1412927 NEW- Brian Pepple - folks: FTBFS in Fedora
> > Rawhide
> > freeradius: #1385588 POST   - Nikolai Kondrashov - freeradius-
> > 3.0.11-3.fc26 FTBFS: dereferencing pointer to incomplete type 'SSL
> > {aka
> > struct ssl_st}'
> > gnomint: #1412929 NEW- Adam Huffman - gnomint is not
> > buildable
> > from master (rawhide) branch
> > guile: #1412931 NEW- Miroslav Lichvar - guile: FTBFS in
> > Fedora
> > Rawhide
> > insight: #1409768 NEW- Patrick Monnerat - insight FTBFS in
> > rawhide
> > ipmitool: no bugs/investigation
> > kawa: #1307678 NEW- Mosaab Alzoubi - kawa: FTBFS in rawhide
> > ktechlab: #1307703 NEW- Kiara Navarro - ktechlab: FTBFS in
> > rawhide
> > libgda: no bugs/investigation 
> > libldm: no bugs/investigation 
> > libwvstreams: no bugs/investigation
> > Macaulay2: no bugs/investigation
> > malaga: no bugs/investigation 
> > maxima: still building
> > nmh: no bugs/investigation
> > opendbx: no bugs/investigation
> > physfs: no bugs/investigation 
> > piklab: #1307864 NEW- Kiara Navarro - piklab: FTBFS in
> > rawhide
> > root: still building
> > shigofumi: no bugs/investigation
> > socat: #1404290 NEW- Paul Wouters - socat build failure on
> > rawhide (fc26)
> > tcl: no bugs/investigation
> > telegram-cli: #1412932 NEW- Antonio Trande - telegram-cli:
> > FTBFS in Fedora Rawhide
> > torque: no bugs/investigation 
> > v8: #1389477 NEW- Tom "spot" Callaway - FTBFS in
> > crankshaft/lithium-allocator
> > > 
> > > I am providing abidiff report for the changes between readline-
> > > 6.3
> > > and readline-7.0 :
> > > 
> > > ELF SONAME changed
> > > Functions changes summary: 2 Removed, 2 Changed (1 filtered out),
> > > 17
> > > Added functions
> > > Variables changes summary: 0 Removed, 1 Changed, 15 Added
> > > variables
> > >  
> > > SONAME changed from 'libreadline.so.6' to 'libreadline.so.7'
> > >  
> > > 2 Removed functions:
> > >  
> > >   'function void _rl_audit_tty(char*)'{_rl_audit_tty}
> > >   'function void replace_history_data(int, histdata_t*,
> > > histdata_t*)'{replace_history_data}
> > >  
> > > 17 Added functions:
> > >  
> > >   'function void _hs_append_history_line(int, const
> > > char*)'{_hs_append_history_line}
> > >   'function void _hs_replace_history_data(int, histdata_t*,
> > > histdata_t*)'{_hs_replace_history_data}
> > >   'function int _rl_find_prev_mbchar_internal(char*, int,
> > > int)'{_rl_find_prev_mbchar_internal}
> > >   'function int
> > > _rl_isearch_cleanup(int)'{_rl_isearch_cleanup}
> > >   'function int
> > > _rl_nsearch_cleanup(int)'{_rl_nsearch_cleanup}
> > >   'function bool
> > > _rl_print_prefix_color()'{_rl_print_prefix_color}
> > >   'function void _rl_ttyflush()'{_rl_ttyflush}
> > >   'function int
> > > _rl_vi_domove_motion_cleanup(int)'{_rl_vi_domove_motion_clean
> > > up}
> > >   'function int
> > > _rl_vi_motion_command(int)'{_rl_vi_motion_command}
> > >   'function int rl_bracketed_paste_begin(int,
> > > int)'{rl_bracketed_paste_begin}
> > >   'function void
> > > rl_callback_sigcleanup()'{rl_callback_sigcleanup}
> > >   'function int
> > > rl_clear_visible_line()'{rl_clear_visible_line}
> > >   'function int rl_pending_signal()'{rl_pending_signal}
> > > 

Re: HEADS UP: Rebasing to Readline-7.0 in rawhide

2017-01-14 Thread Pavel Raiskup
On Friday, January 13, 2017 6:33:49 PM CET Igor Gnatenko wrote:
> On Fri, 2017-01-13 at 10:30 -0500, Siteshwar Vashisht wrote:
> > Hello,
> > 
> > Readline-7.0 was released few months ago and I have rebased it in
> > rawhide to version 7.0. I have created a compatibility package
> > compat-readline6 to avoid breaking any existing applications.
> > 
> > Update to readline-7.0 caused a build failure with gdb that was fixed
> > by this commit [1].
> 
> I've rebuilt yesterday ~199 packages to link against new soname,

Was that complete list?  I miss the build for PostgreSQL e.g.

Pavel

> however some of them (~38) failed by various reasons:
> airtsp: #1307310 NEW- Denis Arnaud - airtsp: FTBFS in rawhide
> augeas: still building
> bacula: #1412924 NEW- Simone Caronni - bacula: FTBFS in Fedora
> Rawhide
> bes: maintainer reported upstream
> dropwatch: #1412926 MODIFIED   - Neil Horman - dropwatch: FTBFS in
> Fedora Rawhide on ppc64/ppc64le
> folks: #1412927 NEW- Brian Pepple - folks: FTBFS in Fedora
> Rawhide
> freeradius: #1385588 POST   - Nikolai Kondrashov - freeradius-
> 3.0.11-3.fc26 FTBFS: dereferencing pointer to incomplete type 'SSL {aka
> struct ssl_st}'
> gnomint: #1412929 NEW- Adam Huffman - gnomint is not buildable
> from master (rawhide) branch
> guile: #1412931 NEW- Miroslav Lichvar - guile: FTBFS in Fedora
> Rawhide
> insight: #1409768 NEW- Patrick Monnerat - insight FTBFS in
> rawhide
> ipmitool: no bugs/investigation
> kawa: #1307678 NEW- Mosaab Alzoubi - kawa: FTBFS in rawhide
> ktechlab: #1307703 NEW- Kiara Navarro - ktechlab: FTBFS in
> rawhide
> libgda: no bugs/investigation 
> libldm: no bugs/investigation 
> libwvstreams: no bugs/investigation
> Macaulay2: no bugs/investigation
> malaga: no bugs/investigation 
> maxima: still building
> nmh: no bugs/investigation
> opendbx: no bugs/investigation
> physfs: no bugs/investigation 
> piklab: #1307864 NEW- Kiara Navarro - piklab: FTBFS in rawhide
> root: still building
> shigofumi: no bugs/investigation
> socat: #1404290 NEW- Paul Wouters - socat build failure on
> rawhide (fc26)
> tcl: no bugs/investigation
> telegram-cli: #1412932 NEW- Antonio Trande - telegram-cli:
> FTBFS in Fedora Rawhide
> torque: no bugs/investigation 
> v8: #1389477 NEW- Tom "spot" Callaway - FTBFS in
> crankshaft/lithium-allocator
> > 
> > I am providing abidiff report for the changes between readline-6.3
> > and readline-7.0 :
> > 
> > ELF SONAME changed
> > Functions changes summary: 2 Removed, 2 Changed (1 filtered out), 17
> > Added functions
> > Variables changes summary: 0 Removed, 1 Changed, 15 Added variables
> >  
> > SONAME changed from 'libreadline.so.6' to 'libreadline.so.7'
> >  
> > 2 Removed functions:
> >  
> >   'function void _rl_audit_tty(char*)'{_rl_audit_tty}
> >   'function void replace_history_data(int, histdata_t*,
> > histdata_t*)'{replace_history_data}
> >  
> > 17 Added functions:
> >  
> >   'function void _hs_append_history_line(int, const
> > char*)'{_hs_append_history_line}
> >   'function void _hs_replace_history_data(int, histdata_t*,
> > histdata_t*)'{_hs_replace_history_data}
> >   'function int _rl_find_prev_mbchar_internal(char*, int,
> > int)'{_rl_find_prev_mbchar_internal}
> >   'function int _rl_isearch_cleanup(int)'{_rl_isearch_cleanup}
> >   'function int _rl_nsearch_cleanup(int)'{_rl_nsearch_cleanup}
> >   'function bool
> > _rl_print_prefix_color()'{_rl_print_prefix_color}
> >   'function void _rl_ttyflush()'{_rl_ttyflush}
> >   'function int
> > _rl_vi_domove_motion_cleanup(int)'{_rl_vi_domove_motion_cleanup}
> >   'function int
> > _rl_vi_motion_command(int)'{_rl_vi_motion_command}
> >   'function int rl_bracketed_paste_begin(int,
> > int)'{rl_bracketed_paste_begin}
> >   'function void
> > rl_callback_sigcleanup()'{rl_callback_sigcleanup}
> >   'function int rl_clear_visible_line()'{rl_clear_visible_line}
> >   'function int rl_pending_signal()'{rl_pending_signal}
> >   'function void
> > rl_redraw_prompt_last_line()'{rl_redraw_prompt_last_line}
> >   'function int rl_tty_set_echoing(int)'{rl_tty_set_echoing}
> >   'function int rl_vi_unix_word_rubout(int,
> > int)'{rl_vi_unix_word_rubout}
> >   'function int rl_vi_yank_pop(int, int)'{rl_vi_yank_pop}
> >  
> > 2 functions with some indirect sub-type change:
> >  
> >   [C]'function bool _rl_print_color_indicator(char*)' at
> > colors.c:123:1 has some indirect sub-type changes:
> > parameter 1 of type 'char*' changed:
> >   in pointed to type 'char':
> > entity changed from 'char' to 'const char'
> >  
> >   [C]'function int rl_restore_state(readline_state*)' at
> > readline.c:1405:1 has some indirect sub-type changes:
> > parameter 1 of type 'readline_state*' has sub-type changes:
> >   in pointed to type 'struct readline_state' at readline.h:894:1:
> > type size chan

Re: HEADS UP: Rebasing to Readline-7.0 in rawhide

2017-01-13 Thread Igor Gnatenko
On Fri, 2017-01-13 at 10:30 -0500, Siteshwar Vashisht wrote:
> Hello,
> 
> Readline-7.0 was released few months ago and I have rebased it in
> rawhide to version 7.0. I have created a compatibility package
> compat-readline6 to avoid breaking any existing applications.
> 
> Update to readline-7.0 caused a build failure with gdb that was fixed
> by this commit [1].

I've rebuilt yesterday ~199 packages to link against new soname,
however some of them (~38) failed by various reasons:
airtsp: #1307310 NEW- Denis Arnaud - airtsp: FTBFS in rawhide
augeas: still building
bacula: #1412924 NEW- Simone Caronni - bacula: FTBFS in Fedora
Rawhide
bes: maintainer reported upstream
dropwatch: #1412926 MODIFIED   - Neil Horman - dropwatch: FTBFS in
Fedora Rawhide on ppc64/ppc64le
folks: #1412927 NEW- Brian Pepple - folks: FTBFS in Fedora
Rawhide
freeradius: #1385588 POST   - Nikolai Kondrashov - freeradius-
3.0.11-3.fc26 FTBFS: dereferencing pointer to incomplete type 'SSL {aka
struct ssl_st}'
gnomint: #1412929 NEW- Adam Huffman - gnomint is not buildable
from master (rawhide) branch
guile: #1412931 NEW- Miroslav Lichvar - guile: FTBFS in Fedora
Rawhide
insight: #1409768 NEW- Patrick Monnerat - insight FTBFS in
rawhide
ipmitool: no bugs/investigation
kawa: #1307678 NEW- Mosaab Alzoubi - kawa: FTBFS in rawhide
ktechlab: #1307703 NEW- Kiara Navarro - ktechlab: FTBFS in
rawhide
libgda: no bugs/investigation 
libldm: no bugs/investigation 
libwvstreams: no bugs/investigation
Macaulay2: no bugs/investigation
malaga: no bugs/investigation 
maxima: still building
nmh: no bugs/investigation
opendbx: no bugs/investigation
physfs: no bugs/investigation 
piklab: #1307864 NEW- Kiara Navarro - piklab: FTBFS in rawhide
root: still building
shigofumi: no bugs/investigation
socat: #1404290 NEW- Paul Wouters - socat build failure on
rawhide (fc26)
tcl: no bugs/investigation
telegram-cli: #1412932 NEW- Antonio Trande - telegram-cli:
FTBFS in Fedora Rawhide
torque: no bugs/investigation 
v8: #1389477 NEW- Tom "spot" Callaway - FTBFS in
crankshaft/lithium-allocator
> 
> I am providing abidiff report for the changes between readline-6.3
> and readline-7.0 :
> 
> ELF SONAME changed
> Functions changes summary: 2 Removed, 2 Changed (1 filtered out), 17
> Added functions
> Variables changes summary: 0 Removed, 1 Changed, 15 Added variables
>  
> SONAME changed from 'libreadline.so.6' to 'libreadline.so.7'
>  
> 2 Removed functions:
>  
>   'function void _rl_audit_tty(char*)'{_rl_audit_tty}
>   'function void replace_history_data(int, histdata_t*,
> histdata_t*)'{replace_history_data}
>  
> 17 Added functions:
>  
>   'function void _hs_append_history_line(int, const
> char*)'{_hs_append_history_line}
>   'function void _hs_replace_history_data(int, histdata_t*,
> histdata_t*)'{_hs_replace_history_data}
>   'function int _rl_find_prev_mbchar_internal(char*, int,
> int)'{_rl_find_prev_mbchar_internal}
>   'function int _rl_isearch_cleanup(int)'{_rl_isearch_cleanup}
>   'function int _rl_nsearch_cleanup(int)'{_rl_nsearch_cleanup}
>   'function bool
> _rl_print_prefix_color()'{_rl_print_prefix_color}
>   'function void _rl_ttyflush()'{_rl_ttyflush}
>   'function int
> _rl_vi_domove_motion_cleanup(int)'{_rl_vi_domove_motion_cleanup}
>   'function int
> _rl_vi_motion_command(int)'{_rl_vi_motion_command}
>   'function int rl_bracketed_paste_begin(int,
> int)'{rl_bracketed_paste_begin}
>   'function void
> rl_callback_sigcleanup()'{rl_callback_sigcleanup}
>   'function int rl_clear_visible_line()'{rl_clear_visible_line}
>   'function int rl_pending_signal()'{rl_pending_signal}
>   'function void
> rl_redraw_prompt_last_line()'{rl_redraw_prompt_last_line}
>   'function int rl_tty_set_echoing(int)'{rl_tty_set_echoing}
>   'function int rl_vi_unix_word_rubout(int,
> int)'{rl_vi_unix_word_rubout}
>   'function int rl_vi_yank_pop(int, int)'{rl_vi_yank_pop}
>  
> 2 functions with some indirect sub-type change:
>  
>   [C]'function bool _rl_print_color_indicator(char*)' at
> colors.c:123:1 has some indirect sub-type changes:
> parameter 1 of type 'char*' changed:
>   in pointed to type 'char':
> entity changed from 'char' to 'const char'
>  
>   [C]'function int rl_restore_state(readline_state*)' at
> readline.c:1405:1 has some indirect sub-type changes:
> parameter 1 of type 'readline_state*' has sub-type changes:
>   in pointed to type 'struct readline_state' at readline.h:894:1:
> type size changed from 1536 to 1792 bits
> 2 data member insertions:
>   'char* readline_state::kseq', at offset 576 (in bits) at
> readline.h:913:1
>   'char* readline_state::wordbreakchars', at offset 1216 (in
> bits) at readline.h:932:1
> 13 data member changes:
>  'int readline_state::buflen' offset changed from 192 to 96
> (in bit

HEADS UP: Rebasing to Readline-7.0 in rawhide

2017-01-13 Thread Siteshwar Vashisht
Hello,

Readline-7.0 was released few months ago and I have rebased it in rawhide to 
version 7.0. I have created a compatibility package compat-readline6 to avoid 
breaking any existing applications.

Update to readline-7.0 caused a build failure with gdb that was fixed by this 
commit [1].

I am providing abidiff report for the changes between readline-6.3 and 
readline-7.0 :

ELF SONAME changed
Functions changes summary: 2 Removed, 2 Changed (1 filtered out), 17 Added 
functions
Variables changes summary: 0 Removed, 1 Changed, 15 Added variables
 
SONAME changed from 'libreadline.so.6' to 'libreadline.so.7'
 
2 Removed functions:
 
  'function void _rl_audit_tty(char*)'{_rl_audit_tty}
  'function void replace_history_data(int, histdata_t*, histdata_t*)'
{replace_history_data}
 
17 Added functions:
 
  'function void _hs_append_history_line(int, const char*)'
{_hs_append_history_line}
  'function void _hs_replace_history_data(int, histdata_t*, histdata_t*)'
{_hs_replace_history_data}
  'function int _rl_find_prev_mbchar_internal(char*, int, int)'
{_rl_find_prev_mbchar_internal}
  'function int _rl_isearch_cleanup(int)'{_rl_isearch_cleanup}
  'function int _rl_nsearch_cleanup(int)'{_rl_nsearch_cleanup}
  'function bool _rl_print_prefix_color()'{_rl_print_prefix_color}
  'function void _rl_ttyflush()'{_rl_ttyflush}
  'function int _rl_vi_domove_motion_cleanup(int)'
{_rl_vi_domove_motion_cleanup}
  'function int _rl_vi_motion_command(int)'{_rl_vi_motion_command}
  'function int rl_bracketed_paste_begin(int, int)'
{rl_bracketed_paste_begin}
  'function void rl_callback_sigcleanup()'{rl_callback_sigcleanup}
  'function int rl_clear_visible_line()'{rl_clear_visible_line}
  'function int rl_pending_signal()'{rl_pending_signal}
  'function void rl_redraw_prompt_last_line()'{rl_redraw_prompt_last_line}
  'function int rl_tty_set_echoing(int)'{rl_tty_set_echoing}
  'function int rl_vi_unix_word_rubout(int, int)'{rl_vi_unix_word_rubout}
  'function int rl_vi_yank_pop(int, int)'{rl_vi_yank_pop}
 
2 functions with some indirect sub-type change:
 
  [C]'function bool _rl_print_color_indicator(char*)' at colors.c:123:1 has 
some indirect sub-type changes:
parameter 1 of type 'char*' changed:
  in pointed to type 'char':
entity changed from 'char' to 'const char'
 
  [C]'function int rl_restore_state(readline_state*)' at readline.c:1405:1 has 
some indirect sub-type changes:
parameter 1 of type 'readline_state*' has sub-type changes:
  in pointed to type 'struct readline_state' at readline.h:894:1:
type size changed from 1536 to 1792 bits
2 data member insertions:
  'char* readline_state::kseq', at offset 576 (in bits) at 
readline.h:913:1
  'char* readline_state::wordbreakchars', at offset 1216 (in bits) at 
readline.h:932:1
13 data member changes:
 'int readline_state::buflen' offset changed from 192 to 96 (in bits)
 'UNDO_LIST* readline_state::ul' offset changed from 256 to 192 (in 
bits)
 'char* readline_state::prompt' offset changed from 320 to 256 (in bits)
 'int readline_state::rlstate' offset changed from 384 to 320 (in bits)
 'int readline_state::done' offset changed from 416 to 352 (in bits)
 'Keymap readline_state::kmap' offset changed from 448 to 384 (in bits)
 'int readline_state::insmode' offset changed from 576 to 512 (in bits)
 'int readline_state::edmode' offset changed from 608 to 544 (in bits)
 'int readline_state::pendingin' offset changed from 832 to 672 (in 
bits)
 'char* readline_state::macro' offset changed from 896 to 832 (in bits)
 'int readline_state::catchsigs' offset changed from 960 to 896 (in 
bits)
 'int readline_state::catchsigwinch' offset changed from 992 to 928 (in 
bits)
 'char readline_state::reserved[64]' offset changed from 1024 to 1280 
(in bits)
 
 
 
15 Added variables:
 
  'int _rl_colored_completion_prefix'{_rl_colored_completion_prefix}
  'char* _rl_emacs_mode_str'{_rl_emacs_mode_str}
  'int _rl_emacs_modestr_len'{_rl_emacs_modestr_len}
  'int _rl_enable_bracketed_paste'{_rl_enable_bracketed_paste}
  'int _rl_optimize_typeahead'{_rl_optimize_typeahead}
  'char* _rl_vi_cmd_mode_str'{_rl_vi_cmd_mode_str}
  'int _rl_vi_cmd_modestr_len'{_rl_vi_cmd_modestr_len}
  'char* _rl_vi_ins_mode_str'{_rl_vi_ins_mode_str}
  'int _rl_vi_ins_modestr_len'{_rl_vi_ins_modestr_len}
  'int _rl_vi_redoing'{_rl_vi_redoing}
  'int history_file_version'{history_file_version}
  'int history_lines_read_from_file'{history_lines_read_from_file}
  'int history_lines_written_to_file'{history_lines_written_to_file}
  'int history_multiline_entries'{history_multiline_entries}
  'int rl_persistent_signal_handlers'{rl_persistent_signal_handlers}
 
1 Changed variable:
 
  [C]'int rl_readline_state' was changed to